Re: [FFmpeg-devel] what AVCodecID to use for copying full vanc data between .mxf and .mcc

2025-07-08 Thread Jacob Lifshay
On Tue, Jul 8, 2025 at 5:08 PM Devin Heitmueller wrote: > I took a quick look at your branch. So this is a good start, IMHO... thanks! > Note that I took a look at the MCC demuxer last year, and it's got a > bunch of issues where the parsing makes a bunch of assumptions (e.g. > doesn't filter o

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec: add NETINT Quadra HW decoders & encoders

2025-07-08 Thread Desmond Liu
Hi Ronald, thanks for your response. > We previously had a similar debate regarding realmedia (search for "Codec > wrapper for librv11 and RMHD muxer/demuxer"). I couldn't find much in the way of debate when I searched for this except for a patch submission in Jan 2018. Was this debate in #ffmpeg

Re: [FFmpeg-devel] [PATCH] avfilter/vf_frei0r: fix time not being passed in seconds

2025-07-08 Thread Michael Niedermayer
Hi Stefan On Sun, Jul 06, 2025 at 08:57:57AM +0200, Stefan Breunig via ffmpeg-devel wrote: > Date: Sun, 6 Jul 2025 08:57:57 +0200 > From: Stefan Breunig > To: ffmpeg-devel@ffmpeg.org > Subject: [PATCH] avfilter/vf_frei0r: fix time not being passed in seconds > > The frei0r API expects the time

Re: [FFmpeg-devel] what AVCodecID to use for copying full vanc data between .mxf and .mcc

2025-07-08 Thread Devin Heitmueller
Hi Jake, On Tue, Jul 8, 2025 at 12:12 AM Jacob Lifshay wrote: > > I'm currently writing a .mcc muxer, it currently translates from eia-608/708 > to full vanc packets before outputting a .mcc file: > https://github.com/programmerjake/FFmpeg/tree/add-mcc-mux I took a quick look at your branch.

Re: [FFmpeg-devel] [PATCH 0/1] Fix tmix on discontinuities

2025-07-08 Thread Michael Niedermayer
Hi Ignacy On Sun, Jul 06, 2025 at 08:30:09PM +0200, Ignacy Gawędzki wrote: > A simple example of the bug: > > ffplay -f lavfi color=c=gray -vf 'tmix=enable=gt(t\,1)' > > After one second, the color is wrong (green in my case), not the > expected gray. > > It seems it is due to the fact that p

[FFmpeg-devel] [PATCH] avformat/demux: avoid unconditional ID3v2 tag consumption

2025-07-08 Thread Nil Fons Miret via ffmpeg-devel
--- Begin Message --- I have found a few instances of rawvideo files that coincidentally start with a header matching the ID3v2 header format, and ffmpeg consumes the header before demuxing, causing a decoding error. This happens even if "-f rawvideo" is specified. This patch limits the formats fo

Re: [FFmpeg-devel] [RFC PATCH] avformat: remove HLS protocol

2025-07-08 Thread Marton Balint
On Tue, 8 Jul 2025, Martin Storsjö wrote: On Tue, 8 Jul 2025, Marvin Scholz wrote: The use of this protocol was already discouraged and warned about for years with the recommendation to use the HLS demuxer instead. --- doc/protocols.texi | 20 --- libavformat/Makefile| 2 - l

Re: [FFmpeg-devel] [RFC PATCH] avformat: remove HLS protocol

2025-07-08 Thread Martin Storsjö
On Tue, 8 Jul 2025, Marvin Scholz wrote: The use of this protocol was already discouraged and warned about for years with the recommendation to use the HLS demuxer instead. --- doc/protocols.texi | 20 --- libavformat/Makefile| 2 - libavformat/hlsproto.c | 318 ---

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec: add NETINT Quadra HW decoders & encoders

2025-07-08 Thread Marton Balint
On Tue, 8 Jul 2025, Ronald S. Bultje wrote: Hi, On Mon, Jul 7, 2025 at 9:00 PM Desmond Liu wrote: * As far as I know, these cards/units are not available to the general public at all. The cards are available to the general public. See https://netint.com/contact-us and send a message t

[FFmpeg-devel] [PATCH] Optimised alf_classify function 8/10/12bit of vvc codec for aarch64

2025-07-08 Thread Georgii Zagoruiko
--- libavcodec/aarch64/vvc/alf.S | 278 ++ libavcodec/aarch64/vvc/alf_template.c | 87 libavcodec/aarch64/vvc/dsp_init.c | 6 + 3 files changed, 371 insertions(+) diff --git a/libavcodec/aarch64/vvc/alf.S b/libavcodec/aarch64/vvc/alf.S index 8801b3

Re: [FFmpeg-devel] [PATCH] Playout to DeckLink will wait for all buffered frames before stopping.

2025-07-08 Thread Marton Balint
On Tue, 8 Jul 2025, Devin Heitmueller wrote: On Tue, Jul 8, 2025 at 1:08 PM Marvin Scholz wrote: What about a drain_timeout option? This could then solve all the mentioned cases. We could have it default to something like 1000ms, and for your use-case you could set it to 0, to not drain at a

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec: add NETINT Quadra HW decoders & encoders

2025-07-08 Thread Kieran Kunhya via ffmpeg-devel
--- Begin Message --- On Tue, 8 Jul 2025, 02:00 Desmond Liu, wrote: > * As far as I know, these cards/units are not available to the general > public at all. > > The cards are available to the general public. See > https://netint.com/contact-us and send a message to sa...@netint.com >

Re: [FFmpeg-devel] [PATCHv2] avcodec/adpcm: squelch uninitialized variable warnings

2025-07-08 Thread Marvin Scholz
On 8 Jul 2025, at 10:49, Peter Ross wrote: > Fixes CID1655273 and CID1655274. > --- > v2: Use the new av_unreachable() macro > > libavcodec/adpcm.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > index 92ab248f3d..83ef7c780a 100644 > --- a/

[FFmpeg-devel] [RFC PATCH] avformat: remove HLS protocol

2025-07-08 Thread Marvin Scholz
The use of this protocol was already discouraged and warned about for years with the recommendation to use the HLS demuxer instead. --- doc/protocols.texi | 20 --- libavformat/Makefile| 2 - libavformat/hlsproto.c | 318 libavformat/protocols.

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Marvin Scholz
On 8 Jul 2025, at 20:33, Nicolas George wrote: > Marvin Scholz (HE12025-07-08): >> That's already possible with `-tls_verify 0` > > Then the commit message inadequately explains what the patch does. > Please clarify. Sure, I will add a more verbose message. However note that verification was a

[FFmpeg-devel] [PATCH v3 3/3] avformat/tls_openssl: load default verify locations

2025-07-08 Thread Marvin Scholz
When no explicit CAs file is set, load the default locations, else there is no way for verification to succeed. This matches the behavior of other TLS backends. --- libavformat/tls_openssl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_open

[FFmpeg-devel] [PATCH v3 2/3] avformat/tls_openssl: verify setting hostname for SNI

2025-07-08 Thread Marvin Scholz
--- libavformat/tls_openssl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 7f10d80f9e..248d1eedf9 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -927,7 +927,11 @@ static int tls_open(

[FFmpeg-devel] [PATCH v3 1/3] avformat/tls_openssl: add hostname for verification

2025-07-08 Thread Marvin Scholz
From: Daniel N Pettersson When verification is enabled (using -tls_verify 1) now the hostname will be verified properly too, while before only other aspects of the certificate were checked. Co-Authored-By: Marvin Scholz --- libavformat/tls_openssl.c | 12 +--- 1 file changed, 9 inserti

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Nicolas George
Marvin Scholz (HE12025-07-08): > Sure, I will add a more verbose message. Thanks. > How could that work though? Warn for every tls use > in ffmpeg unless the user explicitly specifies > -tls_verify 1 or -tls_verify 0? > I think a lot of people would complain about that? Warn each time verificati

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Nicolas George
Marvin Scholz (HE12025-07-08): > That's already possible with `-tls_verify 0` Then the commit message inadequately explains what the patch does. Please clarify. > (which is actually the default, arguably shouldn't be IMHO but > thats a different topic) A transition period where only a warning is

Re: [FFmpeg-devel] [PATCH 2/3] avformat/tls_openssl: verify setting hostname for SNI

2025-07-08 Thread Nicolas George
Marvin Scholz (HE12025-07-08): > We should probably eventually change most of the other ones to that > as well, as right now nearly all are AVERROR(EIO) even if its not an > IO error at all. You are certainly right. A lot of this code predates the addition of AVERROR_EXTERNAL. Regards, -- Nic

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: fix leak of options dict on error

2025-07-08 Thread Kieran Kunhya via ffmpeg-devel
--- Begin Message --- On Tue, 8 Jul 2025, 19:15 Marvin Scholz, wrote: > Fix CID 1655306 > --- > libavformat/rtsp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index 8d360b375f..0810c56a8b 100644 > --- a/libavformat/rtsp.c > +++ b/libavfor

[FFmpeg-devel] [PATCH v2 2/3] avformat/tls_openssl: verify setting hostname for SNI

2025-07-08 Thread Marvin Scholz
--- libavformat/tls_openssl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 7f10d80f9e..248d1eedf9 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -927,7 +927,11 @@ static int tls_open(

[FFmpeg-devel] [PATCH v2 3/3] avformat/tls_openssl: load default verify locations

2025-07-08 Thread Marvin Scholz
When no explicit CAs file is set, load the default locations, else there is no way for verification to succeed. This matches the behavior of other TLS backends. --- libavformat/tls_openssl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_open

[FFmpeg-devel] [PATCH v2 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Marvin Scholz
From: Daniel N Pettersson Co-Authored-By: Marvin Scholz --- libavformat/tls_openssl.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index a0fa3285d5..7f10d80f9e 100644 --- a/libavformat/tls_openssl.c +++ b/

Re: [FFmpeg-devel] [PATCH 2/3] avformat/tls_openssl: verify setting hostname for SNI

2025-07-08 Thread Marvin Scholz
On 8 Jul 2025, at 20:16, Nicolas George wrote: > Marvin Scholz (HE12025-07-08): >> --- >> libavformat/tls_openssl.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c >> index 7614caf089..e65914f11a 100644 >> --

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Marvin Scholz
On 8 Jul 2025, at 20:21, Nicolas George wrote: > Marvin Scholz (HE12025-07-08): >> Can you clarify? That's already possible with `-tls_verify 0` (which is actually the default, arguably shouldn't be IMHO but thats a different topic) > > wget(1): > >--no-check-certificate >D

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Nicolas George
Marvin Scholz (HE12025-07-08): > Can you clarify? wget(1): --no-check-certificate Don't check the server certificate against the available certificate authorities. Also don't require the URL host name to match the common name presented by the certific

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Marvin Scholz
On 8 Jul 2025, at 20:16, Nicolas George wrote: > Marvin Scholz (HE12025-07-08): >> From: Daniel N Pettersson >> >> Co-Authored-By: Marvin Scholz >> --- >> libavformat/tls_openssl.c | 9 - >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/tls_openssl.c b

Re: [FFmpeg-devel] [PATCH 2/3] avformat/tls_openssl: verify setting hostname for SNI

2025-07-08 Thread Nicolas George
Marvin Scholz (HE12025-07-08): > --- > libavformat/tls_openssl.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > index 7614caf089..e65914f11a 100644 > --- a/libavformat/tls_openssl.c > +++ b/libavformat/tls_open

Re: [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Nicolas George
Marvin Scholz (HE12025-07-08): > From: Daniel N Pettersson > > Co-Authored-By: Marvin Scholz > --- > libavformat/tls_openssl.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > index a0fa3285d5..7614caf089 1

[FFmpeg-devel] [PATCH] avformat/rtsp: fix leak of options dict on error

2025-07-08 Thread Marvin Scholz
Fix CID 1655306 --- libavformat/rtsp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 8d360b375f..0810c56a8b 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1847,6 +1847,7 @@ redirect: /* GET requests */ if (ffurl

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Fix MV-HEVC encoding display SEI handling

2025-07-08 Thread Timo Rothenpieler
looks good to me, will apply ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/3] avformat/tls_openssl: verify setting hostname for SNI

2025-07-08 Thread Marvin Scholz
--- libavformat/tls_openssl.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 7614caf089..e65914f11a 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -928,7 +928,11 @@ static int tls_open(

[FFmpeg-devel] [PATCH 3/3] avformat/tls_openssl: load default verify locations

2025-07-08 Thread Marvin Scholz
When no explicit CAs file is set, load the default locations, else there is no way for verification to succeed. This matches the behavior of other TLS backends. --- libavformat/tls_openssl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_open

[FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification

2025-07-08 Thread Marvin Scholz
From: Daniel N Pettersson Co-Authored-By: Marvin Scholz --- libavformat/tls_openssl.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index a0fa3285d5..7614caf089 100644 --- a/libavformat/tls_openssl.c +++ b/libav

[FFmpeg-devel] [PATCH] fftools/ffmpeg_demux: don't flag timestamps as unreliable if they are generated

2025-07-08 Thread James Almer
Regardless of the source being an AVFMT_NOTIMESTAMPS format, if the timestamps are generated like when using the use_wallclock_as_timestamps demuxer option, then they are reliable. Fixes ticket #11268 Signed-off-by: James Almer --- fftools/ffmpeg_demux.c | 11 ++- 1 file changed, 10 i

Re: [FFmpeg-devel] [PATCH] Playout to DeckLink will wait for all buffered frames before stopping.

2025-07-08 Thread Devin Heitmueller
On Tue, Jul 8, 2025 at 1:08 PM Marvin Scholz wrote: > What about a drain_timeout option? This could then solve all the > mentioned cases. We could have it default to something like 1000ms, > and for your use-case you could set it to 0, to not drain at all? I have no objection to that approach. D

Re: [FFmpeg-devel] [PATCH] Playout to DeckLink will wait for all buffered frames before stopping.

2025-07-08 Thread Marvin Scholz
On 8 Jul 2025, at 18:22, Devin Heitmueller wrote: > Hi Marvin, > > On Tue, Jul 8, 2025 at 11:19 AM Marvin Scholz > wrote: >> I think even if a frame is schedule "far" in the future, if I want them >> all played out then it should probably still wait, no? As what is considered >> "far" is a matt

Re: [FFmpeg-devel] [PATCH] Playout to DeckLink will wait for all buffered frames before stopping.

2025-07-08 Thread Devin Heitmueller
Hi Marvin, On Tue, Jul 8, 2025 at 11:19 AM Marvin Scholz wrote: > I think even if a frame is schedule "far" in the future, if I want them > all played out then it should probably still wait, no? As what is considered > "far" is a matter of interpretation… That probably depends. If the clock get

Re: [FFmpeg-devel] [PATCH] Playout to DeckLink will wait for all buffered frames before stopping.

2025-07-08 Thread Marvin Scholz
On 8 Jul 2025, at 16:54, Devin Heitmueller wrote: > Hi Matt, > > Thanks for your contribution. Comments inline. > > On Mon, Jul 7, 2025 at 9:40 PM Matt via ffmpeg-devel > wrote: >> diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp >> index cb8f91730e..5751f27de8 100644 >

[FFmpeg-devel] [PATCH 3/3] avformat/rtsp: check copy_tls_opts_dict

2025-07-08 Thread Marvin Scholz
Properly check av_dict_set return values and propagate them to the caller so they can be handled. --- libavformat/rtsp.c | 43 +-- 1 file changed, 33 insertions(+), 10 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index c6203a07de..519fe

[FFmpeg-devel] [PATCH 2/3] avformat/rtsp: use av_unreachable

2025-07-08 Thread Marvin Scholz
--- libavformat/rtsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 6201f09136..c6203a07de 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -2001,7 +2001,7 @@ redirect: if (CONFIG_RTSP_MUXER) err =

[FFmpeg-devel] [PATCH 1/3] avformat/rtsp: fix misleading indentation

2025-07-08 Thread Marvin Scholz
--- libavformat/rtsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 8d360b375f..6201f09136 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -602,8 +602,8 @@ static void sdp_parse_line(AVFormatContext *s, SDPParseS

Re: [FFmpeg-devel] [PATCH] Playout to DeckLink will wait for all buffered frames before stopping.

2025-07-08 Thread Devin Heitmueller
Hi Matt, Thanks for your contribution. Comments inline. On Mon, Jul 7, 2025 at 9:40 PM Matt via ffmpeg-devel wrote: > diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp > index cb8f91730e..5751f27de8 100644 > --- a/libavdevice/decklink_enc.cpp > +++ b/libavdevice/decklink_

[FFmpeg-devel] [PATCH] avcodec/nvenc: Fix MV-HEVC encoding display SEI handling

2025-07-08 Thread Diego Felix de Souza via ffmpeg-devel
--- Begin Message --- From: Diego de Souza Remove redundant display_sei_sent flag for 3D reference display info handling in MV-HEVC encoding. The display SEI must be sent for every frame in the multi-view sequence. Signed-off-by: Diego de Souza --- libavcodec/nvenc.c | 4 +--- libavcodec/nvenc

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec: add NETINT Quadra HW decoders & encoders

2025-07-08 Thread Ronald S. Bultje
Hi, On Mon, Jul 7, 2025 at 9:00 PM Desmond Liu wrote: > * As far as I know, these cards/units are not available to the general > public at all. > > The cards are available to the general public. See > https://netint.com/contact-us and send a message to sa...@netint.com >

Re: [FFmpeg-devel] [PATCH v2 3/3] avfilter/scale_cuda: Add support for 4:2:2 chroma subsampling

2025-07-08 Thread Diego de Souza via ffmpeg-devel
--- Begin Message --- Hi Andreas, Do you mean something like this? struct format_entry { enum AVPixelFormat format; char name[16]; }; static const struct format_entry supported_formats[] = { {AV_PIX_FMT_YUV420P, "planar8"}, {AV_PIX_FMT_YUV422P, "planar8"}, {AV_PIX_FMT_YUV44

Re: [FFmpeg-devel] [PATCH] doc/scaler.texi: add missing gamma option

2025-07-08 Thread Gyan Doshi
On 2025-07-08 06:45 am, Desmond Liu wrote: Add missing 'gamma correct scaling' option to documentation. Signed-off-by: Desmond Liu --- doc/scaler.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/scaler.texi b/doc/scaler.texi index eb045de6b7..a9ed10e34e 100644 --- a/doc/sca

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: squelch uninitialized variable warnings

2025-07-08 Thread Peter Ross
On Mon, Jul 07, 2025 at 12:41:34PM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > Fixes CID1655273 and CID1655274. > > --- > > libavcodec/adpcm.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > > index 92ab248f3d..527384b86d 10064

[FFmpeg-devel] [PATCHv2] avcodec/adpcm: squelch uninitialized variable warnings

2025-07-08 Thread Peter Ross
Fixes CID1655273 and CID1655274. --- v2: Use the new av_unreachable() macro libavcodec/adpcm.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 92ab248f3d..83ef7c780a 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -877,6 +877,8 @@