Re: [FFmpeg-devel] [PATCH v2 07/13] avfilter/x86/f_ebur128: add x86 AVX implementation

2025-06-13 Thread James Almer
On 6/13/2025 1:37 PM, Niklas Haas wrote: From: Niklas Haas Processes two channels in parallel, using 128-bit XMM registers. In theory, we could go up to YMM registers to process 4 channels, but this is not a gain except for relatively high channel counts (e.g. 7.1), and also complicates the sa

Re: [FFmpeg-devel] [PATCH v2 07/13] avfilter/x86/f_ebur128: add x86 AVX implementation

2025-06-13 Thread Michael Niedermayer
Hi Niklas On Fri, Jun 13, 2025 at 06:37:50PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Processes two channels in parallel, using 128-bit XMM registers. > > In theory, we could go up to YMM registers to process 4 channels, but this is > not a gain except for relatively high channel count

Re: [FFmpeg-devel] [PATCH] configure: fix Microsoft tools detection

2025-06-13 Thread Kacper Michajlow
On Sat, 14 Jun 2025 at 03:03, Kacper Michajłow wrote: > > LLVM tools print installation path upon execution. If one uses LLVM > tools bundled with Microsoft Visual Studio installation, they would be > incorrectly detected as Microsoft's ones. > > Microsoft tools can have localized names, so a more

[FFmpeg-devel] [PATCH] configure: fix Microsoft tools detection

2025-06-13 Thread Kacper Michajłow
LLVM tools print installation path upon execution. If one uses LLVM tools bundled with Microsoft Visual Studio installation, they would be incorrectly detected as Microsoft's ones. Microsoft tools can have localized names, so a more specific string check is not feasible, but luckily we can test if

[FFmpeg-devel] [PATCH v2 6/6] avformat/segment: Indent and whitespace fixes

2025-06-13 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/segment.c | 48 +-- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index ec084483d4..57ea54b00a 100644 --- a/libavformat/segment.c +++

[FFmpeg-devel] [PATCH v2 5/6] avformat/segment: Fix typo

2025-06-13 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index daff385c2c..ec084483d4 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -20,7 +20,7 @@ /

[FFmpeg-devel] [PATCH v2 4/6] avformat/segment: Don't allow negative segment duration

2025-06-13 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 1e99acdddb..daff385c2c 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -1090,7 +1090,7 @@

[FFmpeg-devel] [PATCH v2 3/6] avformat/segment: Remove non-negative constraint from segment_time_delta

2025-06-13 Thread softworkz
From: softworkz Use case is to keep early content out of the first segment when not starting from zero. Signed-off-by: softworkz --- libavformat/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index e8b1582e7d..1e99acd

[FFmpeg-devel] [PATCH v2 2/6] avformat/segment: Add segment_limit option

2025-06-13 Thread softworkz
From: softworkz Example use case: Existing segments 0-30 and 70-99, 31-69 need to be created. This option allows to stop precisely after 69. Otherwise it would start overwriting segment 70 before stopping via 'q' or break signal. Signed-off-by: softworkz --- doc/muxers.texi | 7 +++

[FFmpeg-devel] [PATCH v2 1/6] avformat/segment: Add segment_write_temp option

2025-06-13 Thread softworkz
From: softworkz Allows to write segments as temp files (.tmp) which are renamed on completion. Signed-off-by: softworkz --- doc/muxers.texi | 5 + libavformat/segment.c | 29 ++--- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/doc/muxers.tex

[FFmpeg-devel] [PATCH v2 0/6] avformat/segment: Various segment muxer improvements

2025-06-13 Thread ffmpegagent
Includes * Two new options * segment_write_temp Allows to write segments as temp files (.tmp) which are renamed on completion * segment_limit Stop after n segments have been written * some minor changes (option contraints and formatting fixes) Versions V2 == * merg

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Fix path handling for Windows

2025-06-13 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Freitag, 13. Juni 2025 23:36 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Fix path > handling for Windows > > > > On Fri, 1

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: Fix path handling for Windows

2025-06-13 Thread softworkz
From: softworkz Signed-off-by: softworkz --- avformat/hlsenc: Some HLS improvements Includes only a single patch now: * Fix path handling on Windows Versions V2 == * Fix path handling for Windows; * Keep using a

Re: [FFmpeg-devel] [PATCH 03/10] avformat/segment: Log more detailed information about written segments

2025-06-13 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Freitag, 13. Juni 2025 22:45 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 03/10] avformat/segment: Log > more detailed information about written seg

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Fix path handling for Windows

2025-06-13 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Freitag, 13. Juni 2025 23:36 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Fix path > handling for Windows > > > > On Fri, 1

Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Log information about segments written

2025-06-13 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Freitag, 13. Juni 2025 23:03 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Log > information about segments written > > > >

Re: [FFmpeg-devel] [PATCH 05/10] doc/muxers: Add documentation for segment_limit option

2025-06-13 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Samstag, 14. Juni 2025 00:00 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 05/10] doc/muxers: Add > documentation for segment_limit option > > > >

Re: [FFmpeg-devel] [PATCH 01/10] avformat/segment: Add segment_write_temp option

2025-06-13 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Samstag, 14. Juni 2025 00:07 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 01/10] avformat/segment: Add > segment_write_temp option > > > > On Fri

Re: [FFmpeg-devel] [PATCH 01/10] avformat/segment: Add segment_write_temp option

2025-06-13 Thread Marton Balint
On Fri, 13 Jun 2025, softworkz . wrote: Hi Marton, -Original Message- From: ffmpeg-devel On Behalf Of Marton Balint Sent: Freitag, 13. Juni 2025 22:38 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 01/10] avformat/segment: Add segment_write_temp

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mpegts: update stream info when PMT ES stream_type changes"

2025-06-13 Thread Pavel Koshevoy
On Fri, Jun 13, 2025 at 2:46 PM Michael Niedermayer wrote: > On Mon, Jun 09, 2025 at 02:25:51PM +0200, Michael Niedermayer wrote: > > This fixes mixing up contexts, use of uninitialized data and crashes. > > More specifically: > > > > ==1001752== Conditional jump or move depends on uninitialised

Re: [FFmpeg-devel] [PATCH 05/10] doc/muxers: Add documentation for segment_limit option

2025-06-13 Thread Marton Balint
On Fri, 13 Jun 2025, softworkz . wrote: -Original Message- From: ffmpeg-devel On Behalf Of Marton Balint Sent: Freitag, 13. Juni 2025 22:26 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 05/10] doc/muxers: Add documentation for segment_limit opti

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mpegts: update stream info when PMT ES stream_type changes"

2025-06-13 Thread Pavel Koshevoy
On Fri, Jun 13, 2025 at 2:46 PM Michael Niedermayer wrote: > On Mon, Jun 09, 2025 at 02:25:51PM +0200, Michael Niedermayer wrote: > > This fixes mixing up contexts, use of uninitialized data and crashes. > > More specifically: > > > > ==1001752== Conditional jump or move depends on uninitialised

Re: [FFmpeg-devel] [PATCH 01/10] avformat/segment: Add segment_write_temp option

2025-06-13 Thread softworkz .
Hi Marton, > -Original Message- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Freitag, 13. Juni 2025 22:38 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 01/10] avformat/segment: Add > segment_write_temp option > > >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Fix path handling for Windows

2025-06-13 Thread Marton Balint
On Fri, 13 Jun 2025, softworkz wrote: From: softworkz Can you give an example where the path handling is wrong and where this patch fixes it? Is there a trac ticket? Signed-off-by: softworkz --- libavformat/hlsenc.c | 43 --- 1 file changed, 28

Re: [FFmpeg-devel] [PATCH 05/10] doc/muxers: Add documentation for segment_limit option

2025-06-13 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marton Balint > Sent: Freitag, 13. Juni 2025 22:26 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 05/10] doc/muxers: Add > documentation for segment_limit option > > > >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Log information about segments written

2025-06-13 Thread Marton Balint
On Fri, 13 Jun 2025, softworkz wrote: From: softworkz Signed-off-by: softworkz --- libavformat/hlsenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index a93d35ab75..a3e523a5df 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlse

Re: [FFmpeg-devel] [PATCH] avcodec/h264: fixed qp table attach for h264

2025-06-13 Thread Michael Niedermayer
On Fri, Jun 13, 2025 at 02:37:53PM +0200, Timothee wrote: > Hello, > > Here is a patch where I fixed the attach of per-macroblock qp tables for > H.264. It was implemented for MPEG2 so I have only extended it. > > I tested the functionality with the codecview filter using the following > command:

Re: [FFmpeg-devel] [PATCH 03/10] avformat/segment: Log more detailed information about written segments

2025-06-13 Thread Marton Balint
On Fri, 13 Jun 2025, softworkz wrote: From: softworkz Also moves point of log writing to after rename of temp files and changes log level to INFO. The completion of a segment is important enough to justify logging at INFO level. Signed-off-by: softworkz --- libavformat/segment.c | 10

Re: [FFmpeg-devel] [PATCH] Revert "avformat/mpegts: update stream info when PMT ES stream_type changes"

2025-06-13 Thread Michael Niedermayer
On Mon, Jun 09, 2025 at 02:25:51PM +0200, Michael Niedermayer wrote: > This fixes mixing up contexts, use of uninitialized data and crashes. > More specifically: > > ==1001752== Conditional jump or move depends on uninitialised value(s) > ==1001752==at 0xA9ED82: avpriv_h264_has_num_reorder_fra

Re: [FFmpeg-devel] [PATCH 01/10] avformat/segment: Add segment_write_temp option

2025-06-13 Thread Marton Balint
On Fri, 13 Jun 2025, softworkz wrote: From: softworkz Allows to write segments as temp files (.tmp) which are renamed on completion. Signed-off-by: softworkz --- libavformat/segment.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/libavf

Re: [FFmpeg-devel] [PATCH 05/10] doc/muxers: Add documentation for segment_limit option

2025-06-13 Thread Marton Balint
On Fri, 13 Jun 2025, softworkz wrote: From: softworkz Signed-off-by: softworkz --- doc/muxers.texi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 6d5c17b4cc..1cca8da1fb 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -3510,6 +3510,13

[FFmpeg-devel] [PATCH] h264dsp: h264_luma_dc_dequant_idct: constify input

2025-06-13 Thread Tristan Matthews
--- libavcodec/h264dsp.h | 2 +- libavcodec/h264idct.h| 2 +- libavcodec/h264idct_template.c | 2 +- libavcodec/loongarch/h264dsp_loongarch.h | 2 +- libavcodec/loongarch/h264idct.S | 2 +- libavcodec/mips/h264dsp_mips.h | 2 +-

Re: [FFmpeg-devel] [PATCH] configure: add celp_math component

2025-06-13 Thread Michael Niedermayer
On Tue, Jun 10, 2025 at 08:01:51AM +1000, Peter Ross wrote: > libavcodec/tests/celp_math depends on libavcodec/celp_math.o > > This fixes fate when configuring with --disable-everything > --- > configure | 13 - > libavcodec/Makefile | 17 + > tes

[FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Fix path handling for Windows

2025-06-13 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/hlsenc.c | 43 --- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index f81385d0b4..ba1e74e999 100644 --- a/libavformat/hlsenc.c +++ b/li

[FFmpeg-devel] [PATCH 2/3] avformat/hlsenc: Log InitFileComplete message

2025-06-13 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/hlsenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index a3e523a5df..f81385d0b4 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2467,6 +2467,9 @@ static int hls_ini

[FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Log information about segments written

2025-06-13 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavformat/hlsenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index a93d35ab75..a3e523a5df 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2703,6 +2703,12 @@ static int hls

[FFmpeg-devel] [PATCH 0/3] avformat/hlsenc: Some HLS improvements

2025-06-13 Thread ffmpegagent
Includes: * Segment and init file completion logging * Fix path handling on Windows softworkz (3): avformat/hlsenc: Log information about segments written avformat/hlsenc: Log InitFileComplete message avformat/hlsenc: Fix path handling for Windows libavformat/hlsenc.c | 52 +

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Nicolas George
Tomas Härdin (HE12025-06-13): > 3) remove edit list hacks from all demuxers, especially mov.c That would mean that applications that currently show files with edit lists correctly or almost correctly thanks to these hacks would no longer do so. If you manage to get something clean working, these

[FFmpeg-devel] [PATCH v2 01/13] avfilter/f_ebur128: use transformed direct form II

2025-06-13 Thread Niklas Haas
From: Niklas Haas Instead of direct form I. See af_biquads.c for math. Also eliminate an unnecessary indirection. --- libavfilter/f_ebur128.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index 768f062bac..173a4

[FFmpeg-devel] [PATCH v2 02/13] avfilter/f_ebur128: simplify sample cache array

2025-06-13 Thread Niklas Haas
From: Niklas Haas We don't need an X sample cache anymore, and we also can simplify the access macro slightly. --- libavfilter/f_ebur128.c | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index 1

[FFmpeg-devel] [PATCH v2 11/13] avfilter/f_ebur128: move variable declarations to usage site

2025-06-13 Thread Niklas Haas
From: Niklas Haas This is actually allowed by non-ancient versions of C. --- libavfilter/f_ebur128.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index 4051b1ea95..1fb7129271 100644 --- a/libavfilter/f_eb

[FFmpeg-devel] [PATCH v2 08/13] avfilter/f_ebur128: remove pointless macro

2025-06-13 Thread Niklas Haas
From: Niklas Haas This macro is not shortening the code nor aiding readability. --- libavfilter/f_ebur128.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index 2d94cefce7..2e1eedd855 100644 --- a/l

[FFmpeg-devel] [PATCH v2 09/13] avfilter/f_ebur128: move true peak calculation out of main loop

2025-06-13 Thread Niklas Haas
From: Niklas Haas Easier to read, less convoluted, and ~30% faster. Most importantly, this avoids repeating the redundant recalculation of the true peak on every single sample, by moving the FIND_PEAK() loop out of the main loop. (Note that FIND_PEAK() does not depend on the current sample index

[FFmpeg-devel] [PATCH v2 07/13] avfilter/x86/f_ebur128: add x86 AVX implementation

2025-06-13 Thread Niklas Haas
From: Niklas Haas Processes two channels in parallel, using 128-bit XMM registers. In theory, we could go up to YMM registers to process 4 channels, but this is not a gain except for relatively high channel counts (e.g. 7.1), and also complicates the sample load/store operations considerably. I

[FFmpeg-devel] [PATCH v2 06/13] avfilter/f_ebur128: split off C implementation to separate function

2025-06-13 Thread Niklas Haas
From: Niklas Haas I decided to separate out the peak measurement loop to avoid bloating the signature, and since it's only conditionally used. --- libavfilter/f_ebur128.c | 83 - libavfilter/f_ebur128.h | 3 ++ 2 files changed, 52 insertions(+), 34 deleti

[FFmpeg-devel] [PATCH v2 13/13] avfilter/x86/f_ebur128: implement AVX true peak calculation

2025-06-13 Thread Niklas Haas
From: Niklas Haas Stereo only, for simplicity. Slightly faster than the C code. --- libavfilter/f_ebur128.c | 8 +++- libavfilter/f_ebur128.h | 2 +- libavfilter/x86/f_ebur128.asm| 25 + libavfilter/x86/f_ebur128_init.c | 9 +++-- 4 files

[FFmpeg-devel] [PATCH v2 12/13] avfilter/f_ebur128: move true peak calculation to DSP function

2025-06-13 Thread Niklas Haas
From: Niklas Haas --- libavfilter/f_ebur128.c | 43 ++--- libavfilter/f_ebur128.h | 4 2 files changed, 31 insertions(+), 16 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c index 1fb7129271..0adc89c823 100644 --- a/libavfilte

[FFmpeg-devel] [PATCH v2 05/13] avfilter/f_ebur128: move weights and cache to EBUR128DSPContext

2025-06-13 Thread Niklas Haas
From: Niklas Haas --- libavfilter/f_ebur128.c | 53 + libavfilter/f_ebur128.h | 35 +++ 2 files changed, 57 insertions(+), 31 deletions(-) create mode 100644 libavfilter/f_ebur128.h diff --git a/libavfilter/f_ebur128.c b/libavfilt

[FFmpeg-devel] [PATCH v2 10/13] avfilter/f_ebur128: lift sample peak calculation out of main loop

2025-06-13 Thread Niklas Haas
From: Niklas Haas This is substantially faster (~55%) than the transposed loop, and also avoids an unnecessary macro. --- libavfilter/f_ebur128.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_e

[FFmpeg-devel] [PATCH v2 04/13] avfilter/f_ebur128: use a single packed array for the integrator cache

2025-06-13 Thread Niklas Haas
From: Niklas Haas Instead of having a planar array for each channel, use a single packed array. This will help processing multiple channels in parallel, as we can directly load all channels' data in a single load instruction. Also improves memory locality of data, as the loop order is: for (sam

[FFmpeg-devel] [PATCH v2 03/13] avfilter/f_ebur128: use structs for biquad weights

2025-06-13 Thread Niklas Haas
From: Niklas Haas Simplifies the code a bit. In particular, the copy to the stack is marginally faster. --- libavfilter/f_ebur128.c | 52 +++-- 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c in

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Michael Niedermayer
Hi Tomas On Fri, Jun 13, 2025 at 04:53:14PM +0200, Tomas Härdin wrote: [...] > > > I haven't sketched out any API yet, but it would probably closely > > > mirror how elst works in MOV. Care should be taken that MXF > > > operational > > > pattern 3a can also fit into this API. Possibly even OP3c.

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Michael Niedermayer
Hi On Fri, Jun 13, 2025 at 04:53:14PM +0200, Tomas Härdin wrote: > fre 2025-06-13 klockan 16:21 +0200 skrev Michael Niedermayer: > > > 3) remove edit list hacks from all demuxers, especially mov.c > > > > +1 (with ABI +2 bump) > > I'm not sure why a (major?) bump would be necessary. Are removal

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Tomas Härdin
> Derek did this in 2018: > > https://ffmpeg.org/pipermail/ffmpeg-devel/2018-March/227437.html Interesting. I didn't think to use side data for it. Putting the edit lists in AVStream seems wrong. They belong to AVFormatContext. Else we can't support ganged or alternate packages in MXF (OP1b, OP1c

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Gyan Doshi
On 2025-06-13 08:23 pm, Tomas Härdin wrote: For now I'll probably dummy out elst support and the associated tests just to make progress on segmented indexes. Does `-ignore_editlist true`   not work for your use-case? Regards, Gyan ___ ffmpeg-devel

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Tomas Härdin
fre 2025-06-13 klockan 16:21 +0200 skrev Michael Niedermayer: > > 3) remove edit list hacks from all demuxers, especially mov.c > > +1 (with ABI +2 bump) I'm not sure why a (major?) bump would be necessary. Are removal of options a major bump, not a minor one? Either way, we could make the option

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Derek Buitenhuis
On 6/13/2025 3:34 PM, Tomas Härdin wrote: > Interesting. I didn't think to use side data for it. Putting the edit > lists in AVStream seems wrong. They belong to AVFormatContext. Else we > can't support ganged or alternate packages in MXF (OP1b, OP1c, OP2b, > OP2c, OP3b, OP3c), nor could we support

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Gyan Doshi
On 2025-06-13 04:25 pm, Tomas Härdin wrote: The present level of edit list support could be reimplemented by just fiddling with the -ss and -t options. That is, the ffmpeg CLI could automatically derive -ss and -t from the edit list extracted by lavf. In mov.c, edit lists are per-track and ca

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Michael Niedermayer
Hi Tomas On Fri, Jun 13, 2025 at 12:55:56PM +0200, Tomas Härdin wrote: > Hi > > In my fiddling with fragmented indexes in mov.c I ran cross > mov_fix_index(), which has been in the codebase since September 2016. > The intent of this function is to implement limited support for edit > lists (elst)

Re: [FFmpeg-devel] [PATCH 1/7] avutil: add an API to handle 3D Reference Displays Information

2025-06-13 Thread Timo Rothenpieler
On 10/06/2025 00:09, Andreas Rheinhardt wrote: James Almer: On 6/9/2025 5:59 PM, Timo Rothenpieler wrote: On 08.06.2025 17:45, James Almer wrote: On 6/8/2025 11:29 AM, Andreas Rheinhardt wrote: Timo Rothenpieler: From: James Almer I don't like that you add another allocator for this; inst

Re: [FFmpeg-devel] [PATCH 2/2] checkasm: h264dsp: test luma_dc_dequant

2025-06-13 Thread Martin Storsjö
On Fri, 13 Jun 2025, Tristan Matthews wrote: --- tests/checkasm/h264dsp.c | 37 + 1 file changed, 37 insertions(+) Both patches LGTM, thank you! // Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

[FFmpeg-devel] [PATCH 2/2] checkasm: h264dsp: test luma_dc_dequant

2025-06-13 Thread Tristan Matthews
--- tests/checkasm/h264dsp.c | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c index d1228ed985..f5f9650224 100644 --- a/tests/checkasm/h264dsp.c +++ b/tests/checkasm/h264dsp.c @@ -22,6 +22,7 @@ #include

[FFmpeg-devel] [PATCH 1/2] checkasm: add checkasm_check_dctcoef

2025-06-13 Thread Tristan Matthews
This is useful for tests that compare dctcoefs which will be either 2 bytes or 4 bytes, depending on bitdepth. --- tests/checkasm/checkasm.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h index 146bfdec35..e829942d58 100644 --

[FFmpeg-devel] [PATCH] configure: Make MSVC version grabbing more robust

2025-06-13 Thread Martin Storsjö
When running plain "cl", to get the MSVC version, it prints the version header on stderr, while the usage instructions are printed on stdout. Usually, the version on stderr gets flushed first, so "head -n1" gets the line it expects, but some times (in particular when running MSVC wrapped in wine),

Re: [FFmpeg-devel] [PATCH 03/10] avformat/segment: Log more detailed information about written segments

2025-06-13 Thread softworkz .
Hi Derek, > -Original Message- > From: ffmpeg-devel On Behalf Of > Derek Buitenhuis > Sent: Freitag, 13. Juni 2025 15:43 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 03/10] avformat/segment: Log > more detailed information about written segments > > On 6/13/2025 6:5

Re: [FFmpeg-devel] [PATCH 03/10] avformat/segment: Log more detailed information about written segments

2025-06-13 Thread Derek Buitenhuis
On 6/13/2025 6:54 AM, softworkz wrote: > av_log(s, AV_LOG_INFO, "SegmentComplete=%s:%d Index=%d Start=%f End=%f > Duration=%f offset_pts=%s start_pts=%s Frames=%d filename=%s\n", Should be VERBOSE, not INFO. - Derek ___ ffmpeg-devel mailing list ff

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Derek Buitenhuis
On 6/13/2025 1:51 PM, Kieran Kunhya via ffmpeg-devel wrote: > Derek did this in 2018: > > https://ffmpeg.org/pipermail/ffmpeg-devel/2018-March/227437.html elenril had some good comments, others were so bad I never sent a v2 because every time I looked at the replies I was demotivated by their sev

Re: [FFmpeg-devel] [PATCH] checkasm: h264dsp: test luma_dc_dequant

2025-06-13 Thread Martin Storsjö
On Fri, 13 Jun 2025, Tristan Matthews wrote: On Fri, Jun 13, 2025 at 2:08 AM Martin Storsjö wrote: On Fri, 13 Jun 2025, Tristan Matthews wrote: Good catch, also I realized that the output buffers were too small, will be fixed in the next version. Why was that too small? If we write (and c

Re: [FFmpeg-devel] [PATCH] checkasm: h264dsp: test luma_dc_dequant

2025-06-13 Thread Tristan Matthews
On Fri, Jun 13, 2025 at 2:08 AM Martin Storsjö wrote: > > On Fri, 13 Jun 2025, Tristan Matthews wrote: > > > On Thu, Jun 12, 2025 at 4:14 PM Martin Storsjö wrote: > >> > >> On Thu, 12 Jun 2025, Tristan Matthews wrote: > >> > >>> --- > >>> tests/checkasm/h264dsp.c | 37

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-13 Thread Marcos Del Sol
Tomas Härdin: > tis 2025-06-10 klockan 11:42 + skrev Marcos Del Sol: > > WebVTT is supposed to be an extensible format. > > The syntax says otherwise. Why the W3C feels the need to specify a > particular imperative algorithm for parsing I cannot know, but this is > not how RFCs are authored. It

Re: [FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Kieran Kunhya via ffmpeg-devel
--- Begin Message --- On Fri, 13 Jun 2025, 12:56 Tomas Härdin, wrote: > Hi > > In my fiddling with fragmented indexes in mov.c I ran cross > mov_fix_index(), which has been in the codebase since September 2016. > The intent of this function is to implement limited support for edit > lists (elst).

[FFmpeg-devel] [PATCH] avcodec/h264: fixed qp table attach for h264

2025-06-13 Thread Timothee
Hello, Here is a patch where I fixed the attach of per-macroblock qp tables for H.264. It was implemented for MPEG2 so I have only extended it. I tested the functionality with the codecview filter using the following command: `./ffmpeg -export_side_data 4 -i input.mp4 -vf codecview=qp=1 outp

[FFmpeg-devel] [PATCH 2/2] doc/encoders: Document mediacodec wrapper

2025-06-13 Thread Zhao Zhili
From: Zhao Zhili --- doc/encoders.texi | 69 +++ 1 file changed, 69 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index f6f6c096ec..5595e57038 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -3342,6 +3342,75 @@ fastest.

[FFmpeg-devel] [PATCH 1/2] avcodec/mediacodecenc: Fix typo in VP9 option description

2025-06-13 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/mediacodecenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c index c201fc3365..507c48df9c 100644 --- a/libavcodec/mediacodecenc.c +++ b/libavcodec/mediacodecenc.c @@ -1352,7 +1352,7 @@

[FFmpeg-devel] [PATCH v2] avcodec/apv_encoder: Updated APV encoder to set the encoder output to OAPV_CFG_VAL_AU_BS_FMT_NONE format (the only AU without bitstream format)

2025-06-13 Thread Dawid Kozinski
Signed-off-by: Dawid Kozinski --- libavcodec/liboapvenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/liboapvenc.c b/libavcodec/liboapvenc.c index 0c95489bc9..fa849c1dcc 100644 --- a/libavcodec/liboapvenc.c +++ b/libavcodec/liboapvenc.c @@ -306,6 +306,14 @@ static av_co

Re: [FFmpeg-devel] [PATCH 1/2] lavf/webvttenc: avio_flush() output

2025-06-13 Thread Tomas Härdin
tis 2025-06-10 klockan 00:17 +0200 skrev Andreas Rheinhardt: > Tomas Härdin: > > Hi > > > > These two patches are a bit of a warmup for another pass at > > streamable > > subtitles. FATE passes. > > > > /Tomas > > > Users who want this should set the generic flush_packets options > appropriately

Re: [FFmpeg-devel] [PATCH] avcodec/itut35: always check the provider code and country code together

2025-06-13 Thread Maryla Ustarroz via ffmpeg-devel
--- Begin Message --- On Thu, Jun 12, 2025 at 6:48 PM Devin Heitmueller wrote: > > On Thu, Jun 12, 2025 at 12:27 PM Maryla Ustarroz-Calonge via > ffmpeg-devel wrote: > > -- Forwarded message -- > > From: Maryla Ustarroz-Calonge > > To: ffmpeg-devel@ffmpeg.org > > Cc: > > Bcc: > >

[FFmpeg-devel] [FATE PATCH] Properly list test errors when there are no failed tests

2025-06-13 Thread Martin Storsjö
If there were failures while running tests, e.g. if failing to compile checkasm or any other of the test programs, there are no failed tests per se, and the number of succeessful tests is equal to the total number of tests. For these cases, check the job status code instead of declaring them as a

[FFmpeg-devel] [RFC] Moving edit list handling out of demuxers

2025-06-13 Thread Tomas Härdin
Hi In my fiddling with fragmented indexes in mov.c I ran cross mov_fix_index(), which has been in the codebase since September 2016. The intent of this function is to implement limited support for edit lists (elst). More rudely one could say it implements half-assed support for edit lists. Besides

[FFmpeg-devel] [PATCH v3 3/3] avformat/whip: reindent whip options

2025-06-13 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Signed-off-by: Jack Lau --- libavformat/whip.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index 84c2092e5e..6a33966472 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1898,13

[FFmpeg-devel] [PATCH v3 2/3] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 candidates

2025-06-13 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- mark this ignore_ipv6 flag could ignore any ipv6 ICE candidate, preventing “No route to host” errors on devices without IPv6 connectivity. Signed-off-by: Jack Lau --- libavformat/whip.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/whip.c b/

[FFmpeg-devel] [PATCH v3 1/3] avformat/whip: replace AV_OPT_FLAG_DECODING_PARAM to ENCODING

2025-06-13 Thread Jack Lau via ffmpeg-devel
--- Begin Message --- Signed-off-by: Jack Lau --- libavformat/whip.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index 710f24fc5a..a6827d3478 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1885,13 +1885,13

Re: [FFmpeg-devel] [PATCH v5] gcc: Don't disable '-ftree-vectorize' if gcc version higher than 13.

2025-06-13 Thread Martin Storsjö
On Fri, 13 Jun 2025, Jiawei wrote: This patch modifies the FFmpeg build system to allow GCC to use the `-ftree-vectorize` flag when the compiler version is 13 or newer. Enabling this flag can improve performance through better loop analysis and auto-vectorization (SIMD) opportunities in modern G

Re: [FFmpeg-devel] [PATCH] avutil: Fix linking x86 asm constants with Clang in MSVC mode

2025-06-13 Thread Martin Storsjö
On Thu, 12 Jun 2025, Martin Storsjö wrote: This fixes building with Clang in MSVC mode, for x86, which was broken in 6e49b8699657b808b7dc80033f2c3f2d0e029fa3 (in Nov 2024); previously it failed with undefined symbols for the constants defined with DECLARE_ASM_CONST, accessed via inline assembly.

Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-13 Thread Steven Liu
Jack Lau 于2025年6月13日周五 13:07写道: > > > > > On Jun 8, 2025, at 08:25, Jack Lau via ffmpeg-devel > > wrote: > > > > api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem > > > > In higher versions (openssl 1.0.2 and higher), > > the function signature is BIO *BIO_new_mem_buf(const void *buf, int l

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 candidates

2025-06-13 Thread Steven Liu
Jack Lau via ffmpeg-devel 于2025年6月13日周五 13:05写道: > > > > > -- Forwarded message -- > From: Jack Lau > To: ffmpeg-devel@ffmpeg.org > Cc: Jack Lau > Bcc: > Date: Fri, 13 Jun 2025 13:03:35 +0800 > Subject: [PATCH v2 1/2] avformat/whip: add whip_flags ignore_ipv6 to skip > IPv6 cand

Re: [FFmpeg-devel] ebur128 bounty

2025-06-13 Thread Guillaume Khayat
Hi Niklas, Vey nice. I’m seeing 22% improvement already. I’ll reach out privately to get us started on the paperwork. Best, SPECTRE Guillaume KHAYAT / Technical Director (T) +33 (0)1 43 87 12 34 Paris — 39, rue de Rome 75008 Paris, France Asia — Prosperity Tower, Room 1501, 39 Queen’s Road

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix editlist with hybrid_fragmented

2025-06-13 Thread Martin Storsjö
On Fri, 13 Jun 2025, Zhao Zhili wrote: From: Zhao Zhili The segment_duration must not be set to zero when writing the moov atom for the second time. This is related to edit lists in standard MP4 files. --- libavformat/movenc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libaom: Add tests for HDR10+ metadata support

2025-06-13 Thread Maryla Ustarroz via ffmpeg-devel
--- Begin Message --- On Thu, Jun 5, 2025 at 9:27 AM Andreas Rheinhardt wrote: > > Maryla Ustarroz via ffmpeg-devel: > > On Fri, May 30, 2025 at 2:52 PM Andreas Rheinhardt > > wrote: > >> > >> Maryla Ustarroz-Calonge via ffmpeg-devel: > >>> The new fate sample av1/metadata_hdr10_plus.ivf used in