[FFmpeg-devel] [PATCH] avformat/tls_openssl: fix warnings when openssl is lower version

2025-06-06 Thread Jack Lau via ffmpeg-devel
In higher versions (like openssl 1.1.1 and higher), the function signature is BIO *BIO_new_mem_buf(const void *buf, int len), so passing a const string doesn't cause an warnings. However, in lower versions of OpenSSL, the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len), which le

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times

2025-06-06 Thread Michael Niedermayer
On Sat, Jun 07, 2025 at 12:21:43AM +0100, Kieran Kunhya via ffmpeg-devel wrote: > On Sat, 7 Jun 2025, 00:12 Michael Niedermayer, > wrote: > > > Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe > > as FFMIN() is a macro and avio_size() is thus evaluated multiple > > times >

Re: [FFmpeg-devel] [PATCH v11 0/3] avutil/log: Add log flag to control printing of memory addresses

2025-06-06 Thread softworkz .
From: Kieran Kunhya Sent: Samstag, 7. Juni 2025 01:24 To: FFmpeg development discussions and patches Cc: softworkz Subject: Re: [FFmpeg-devel] [PATCH v11 0/3] avutil/log: Add log flag to control printing of memory addresses #define LIBAVUTIL_VERSION_MAJOR 60 --#define LIBAVUTIL_

Re: [FFmpeg-devel] [PATCH v11 0/3] avutil/log: Add log flag to control printing of memory addresses

2025-06-06 Thread Kieran Kunhya via ffmpeg-devel
> > > #define LIBAVUTIL_VERSION_MAJOR 60 > --#define LIBAVUTIL_VERSION_MINOR 1 > -+#define LIBAVUTIL_VERSION_MINOR 2 > +-#define LIBAVUTIL_VERSION_MINOR 3 > ++#define LIBAVUTIL_VERSION_MINOR 4 >#define LIBAVUTIL_VERSION_MICRO Are you seriously expecting

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times

2025-06-06 Thread Kieran Kunhya via ffmpeg-devel
On Sat, 7 Jun 2025, 00:12 Michael Niedermayer, wrote: > Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe > as FFMIN() is a macro and avio_size() is thus evaluated multiple > times > > CC: Justin Ruggles > Signed-off-by: Michael Niedermayer > --- > libavformat/dhav.c | 7

[FFmpeg-devel] [PATCH] avformat/dhav: Do not evaluate avio_size() multiple times

2025-06-06 Thread Michael Niedermayer
Code like FFMIN(MAX_DURATION_BUFFER_SIZE, avio_size(s->pb)) is not safe as FFMIN() is a macro and avio_size() is thus evaluated multiple times CC: Justin Ruggles Signed-off-by: Michael Niedermayer --- libavformat/dhav.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself for graph printing

2025-06-06 Thread Michael Niedermayer
Hi softworkz On Thu, Jun 05, 2025 at 03:44:13PM +, softworkz . wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Michael > > Niedermayer > > Sent: Dienstag, 27. Mai 2025 13:26 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PA

Re: [FFmpeg-devel] [PATCH] rtpdec: Fix RTP timestamp wraparound in Producer Reference Time

2025-06-06 Thread Michael Niedermayer
On Fri, Jun 06, 2025 at 10:54:14AM +0200, Clément Péron wrote: > The rtp_set_prft() function incorrectly calculates the timestamp delta > when RTP timestamps wrap around the 32-bit boundary. The current code: > > delta_timestamp = (int64_t)timestamp - (int64_t)s->last_rtcp_timestamp; > > trea

Re: [FFmpeg-devel] [PATCH v2 1/4] tools/target_dec_fuzzer: move things to suppress Wdeclaration-after-statement

2025-06-06 Thread Michael Niedermayer
Hi Kacper On Fri, Jun 06, 2025 at 07:20:32PM +0200, Kacper Michajłow wrote: > To avoid spam in log, each fuzzer is built separately so it's amplified > a lot. > > Signed-off-by: Kacper Michajłow > --- > tools/target_dec_fuzzer.c | 31 ++- > 1 file changed, 18 inserti

[FFmpeg-devel] [PATCH v11 2/3] fftools: add mem log flag for printing memory addresses

2025-06-06 Thread softworkz
From: softworkz This commit adds the mem log flag. When specifying this flag at the command line, context prefixes will be printed with memory addresses like in earlier ffmpeg versions. Example with mem flag: [hevc @ 018e72a89cc0] . without (new behavior): [hevc] . Signed-off-by:

[FFmpeg-devel] [PATCH v11 0/3] avutil/log: Add log flag to control printing of memory addresses

2025-06-06 Thread ffmpegagent
--and disable by default in fftools. The benefits are: * Smaller log file sizes * Makes log files better readable * Allows comparing and viewing log file diffs without almost every line being different due to those addresses Before == [hevc @ 018e72a89cc0] nal_unit_type: [hevc @ 0

[FFmpeg-devel] [PATCH v11 3/3] doc/fftools-common-opts: document mem log flag

2025-06-06 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/fftools-common-opts.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index f6d452c40e..5d66af6b02 100644 --- a/doc/fftools-common-opts.texi +++ b/doc/fftools-common-opts.texi @

[FFmpeg-devel] [PATCH v11 1/3] avutil/log: Add log flag AV_LOG_PRINT_MEMADDRESS and hide addresses by default

2025-06-06 Thread softworkz
From: softworkz Memory addresses are no longer printed by default. With this flag set, memory addresses are included like in earlier versions. Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavutil/log.c | 6 -- libavutil/log.h | 5 + libavutil/version.h | 2 +- 4

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-06 Thread Marcos Del Sol Vives
El 6 de junio de 2025 21:43:58 CEST, "Tomas Härdin" escribió: > >Sounds like the demuxer correctly rejected some broken files > The WebVTT standard does not call for a fatal error unless the magic header does not match. The current implementation is not only non-compliant with the standard, b

[FFmpeg-devel] [PATCH] configure: rename POSIX ioctl check

2025-06-06 Thread Leo Izen
Commit 00b64fca55a3a009c9d0e391c85f4fd3291e5d12 introduced configure detection for HAVE_POSIX_IOCTL but unfortunately this conflicts with v4l-utils version 1.30, which itself checks for #ifdef HAVE_POSIX_IOCTL in a public header and erroneously determines it to be true because we define this to be

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing

2025-06-06 Thread Tomas Härdin
tis 2025-05-27 klockan 10:40 + skrev Marcos Del Sol via ffmpeg- devel: > A note on this change: I found some .vtt files while using yt-dlp > that follow > a draft version of the WebVTT standard (probably > https://www.w3.org/2013/07/webvtt.html) that use "Region:" for > regions instead > of "RE

Re: [FFmpeg-devel] [FEATURE PROPOSAL] Extracting codec-level data to binary files

2025-06-06 Thread Tomas Härdin
ons 2025-05-21 klockan 15:34 +0200 skrev Timothée: > Hello, > > I am interested in expanding ffmpeg's capabilities to extract > low-level data from video codecs. Specifically, I'd like to implement > functionality that would allow exporting frame data, macroblock > information, quantization tables

[FFmpeg-devel] [PATCH v2 4/4] tools/target_dem_fuzzer: remove unused fuzz_tag

2025-06-06 Thread Kacper Michajłow
Signed-off-by: Kacper Michajłow --- tools/target_dem_fuzzer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index 19bc1f09c1..e169438ceb 100644 --- a/tools/target_dem_fuzzer.c +++ b/tools/target_dem_fuzzer.c @@ -98,10 +98,7 @@ static i

[FFmpeg-devel] [PATCH v2 3/4] tools/target_dem_fuzzer: make fuzz data pointer constant

2025-06-06 Thread Kacper Michajłow
Mostly to avoid warnings. Signed-off-by: Kacper Michajłow --- tools/target_dem_fuzzer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index 8e96fad7f8..19bc1f09c1 100644 --- a/tools/target_dem_fuzzer.c +++ b/tools/target

[FFmpeg-devel] [PATCH v2 2/4] tools/target_dec_fuzzer: suppress Wunused-function

2025-06-06 Thread Kacper Michajłow
Signed-off-by: Kacper Michajłow --- tools/target_dec_fuzzer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 7afb23619e..6950d134d9 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@ -72,6 +72,8 @@ static v

[FFmpeg-devel] [PATCH v2 1/4] tools/target_dec_fuzzer: move things to suppress Wdeclaration-after-statement

2025-06-06 Thread Kacper Michajłow
To avoid spam in log, each fuzzer is built separately so it's amplified a lot. Signed-off-by: Kacper Michajłow --- tools/target_dec_fuzzer.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c

[FFmpeg-devel] [PATCH v2 0/4] Minor fixes and for fuzzing targets

2025-06-06 Thread Kacper Michajłow
Minor fixes and for fuzzing targets. Mostly motivated to reduce spam in the build log. v2 only for rebase only. Kacper Michajłow (4): tools/target_dec_fuzzer: move things to suppress Wdeclaration-after-statement tools/target_dec_fuzzer: suppress Wunused-function tools/target_dem_fuzzer:

Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up

2025-06-06 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Freitag, 6. Juni 2025 16:33 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up > > Michael Niedermayer (HE12025-06-04): > > Is

Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up

2025-06-06 Thread Devin Heitmueller
On Fri, Jun 6, 2025 at 10:32 AM Nicolas George wrote: > The fact that he prefers spending hours writing verbal diarrhea to this > mailing-list over spending minutes testing what I pointed him to test > tells you all you need to know about his attitude. Respectfully, you just spent six paragraphs

Re: [FFmpeg-devel] [RFC] Subtitle Filtering Ramp-Up

2025-06-06 Thread Nicolas George
Michael Niedermayer (HE12025-06-04): > Is it possible to create 3 testcases that one can just copy and paste to the > command line to see these 3 problems ? Absolutely. I made sure to give all the necessary information all in one place. Turning my words into command lines is a very easy task. Now

[FFmpeg-devel] [PATCH] avformat/dhav: Add missed free for end_buffer

2025-06-06 Thread Derek Buitenhuis
Accidentally left out of 36ec9217e6dca3432304c9d76078d9618247eb0f. Found-by: Kacper Michajłow Signed-off-by: Derek Buitenhuis --- libavformat/dhav.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/dhav.c b/libavformat/dhav.c index d9db775802..5a83a8aea9 100644 --- a/libavform

Re: [FFmpeg-devel] [PATCH] tests/fate/mov: Add bitexact for fate-mov-mp4-frag-flush

2025-06-06 Thread Michael Niedermayer
On Fri, Jun 06, 2025 at 12:52:33PM +0800, Zhao Zhili wrote: > > > > On Jun 6, 2025, at 10:35, Michael Niedermayer > > wrote: > > > > On Fri, Jun 06, 2025 at 03:40:33AM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: > >>> Signed-off-by: Michael Niedermayer > >>> --- > >>> tests/fat

Re: [FFmpeg-devel] [PATCH 1/3] amfenc: Update the min version to 1.4.36.0 for AMF SDK.

2025-06-06 Thread Dmitrii Ovchinnikov
> > > AMF doesn't always require the latest version, however, since the library is under active development, I periodically update it before integrating newly added features. Without updating the header version, some defines (such as names of new parameters) are unavailable. For the user, everythin

Re: [FFmpeg-devel] [PATCH 1/3] amfenc: Update the min version to 1.4.36.0 for AMF SDK.

2025-06-06 Thread Zhao Zhili
> On May 30, 2025, at 21:58, Dmitrii Ovchinnikov > wrote: > > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index a1f483f02c..b9de840ec2 100755 > --- a/configure > +++ b/configure > @@ -7476,7 +7476,7 @@ fi > > enabled amf &&

Re: [FFmpeg-devel] [PATCH] avformat/format: make experimental flag works for muxer

2025-06-06 Thread Zhao Zhili
> On Jun 6, 2025, at 18:00, Kieran Kunhya via ffmpeg-devel > wrote: > > On Fri, 6 Jun 2025, 10:51 Michael Niedermayer, > wrote: > >> On Fri, Jun 06, 2025 at 12:06:34AM +0800, Zhao Zhili wrote: >>> From: Zhao Zhili >>> >>> --- >>> libavformat/avformat.h | 3 +-- >>> libavformat/format.c |

Re: [FFmpeg-devel] [PATCH] avcodec/d3d12va_encode: fix l0 reference count limit

2025-06-06 Thread Tong Wu
Araz Iusubov: > From: ffmpeg-devel On Behalf Of Araz > Iusubov > Sent: Wednesday, June 4, 2025 4:37 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Araz Iusubov > Subject: [FFmpeg-devel] [PATCH] avcodec/d3d12va_encode: fix l0 reference > count limit > > Prevents potential null pointer dereference when qu

Re: [FFmpeg-devel] [PATCH] avformat/format: make experimental flag works for muxer

2025-06-06 Thread Kieran Kunhya via ffmpeg-devel
On Fri, 6 Jun 2025, 10:51 Michael Niedermayer, wrote: > On Fri, Jun 06, 2025 at 12:06:34AM +0800, Zhao Zhili wrote: > > From: Zhao Zhili > > > > --- > > libavformat/avformat.h | 3 +-- > > libavformat/format.c | 2 ++ > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/l

Re: [FFmpeg-devel] [PATCH] avformat/format: make experimental flag works for muxer

2025-06-06 Thread Michael Niedermayer
On Fri, Jun 06, 2025 at 12:06:34AM +0800, Zhao Zhili wrote: > From: Zhao Zhili > > --- > libavformat/avformat.h | 3 +-- > libavformat/format.c | 2 ++ > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index 2034d2aecc..6edcf

[FFmpeg-devel] [PATCH v6] libavcodec/riscv: add RVV optimized idct_32x32_8 for HEVC

2025-06-06 Thread daichengrong
From: daichengrong On Banana PI F3: hevc_idct_32x32_8_c:119249.5 ( 1.00x) hevc_idct_32x32_8_rvv_i64: 13352.5 ( 8.93x) hevc_idct_32x32_8_rvv_i64: 13830.1 ( 8.66x) (transpose16_4x4_2 segment

Re: [FFmpeg-devel] [PATCH] swscale/aarch64/output: Implement neon assembly for yuv2nv12cX_c()

2025-06-06 Thread Harshitha Sarangu Suresh
Apologies sent older version of the patch. Here is the proper version that passed all the tests. >From 4ca5eae1e7164f78296719f19aef97239e5b046a Mon Sep 17 00:00:00 2001 From: Harshitha Suresh Date: Mon, 19 May 2025 22:37:20 +0530 Subject: [PATCH] v2ff-swscale/aarch64/output: Implement neon asse

Re: [FFmpeg-devel] [PATCH] rtpdec: Fix RTP timestamp wraparound in Producer Reference Time

2025-06-06 Thread Clément Péron
On Fri, 6 Jun 2025 at 10:54, Clément Péron wrote: > > The rtp_set_prft() function incorrectly calculates the timestamp delta > when RTP timestamps wrap around the 32-bit boundary. The current code: > > delta_timestamp = (int64_t)timestamp - (int64_t)s->last_rtcp_timestamp; > > treats both time

[FFmpeg-devel] [PATCH] rtpdec: Fix RTP timestamp wraparound in Producer Reference Time

2025-06-06 Thread Clément Péron
The rtp_set_prft() function incorrectly calculates the timestamp delta when RTP timestamps wrap around the 32-bit boundary. The current code: delta_timestamp = (int64_t)timestamp - (int64_t)s->last_rtcp_timestamp; treats both timestamps as large positive values, causing wraparound to produce

Re: [FFmpeg-devel] [PATCH v3] avformat/dhav: fix backward scanning for get_duration and optimize seeking

2025-06-06 Thread Kacper Michajlow
On Wed, 21 May 2025 at 15:23, Derek Buitenhuis wrote: > > From: Justin Ruggles > > The backwards scanning done for incomplete final packets should not > assume a specific alignment at the end of the file. Truncated files > result in hundreds of thousands of seeks if the final packet does not > fa

Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix build error when openssl version < 3

2025-06-06 Thread Martin Storsjö
On Fri, 6 Jun 2025, Jack Lau via ffmpeg-devel wrote: add the missing data structure pkey in the tls_context properly set this pkey and free it Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) LGTM,

[FFmpeg-devel] [PATCH] swscale/aarch64/output: Implement neon assembly for yuv2planeX_10_c_template()

2025-06-06 Thread Logaprakash Ramajayam
Checked FATE tests and gha-aarch64 git workflow. >From 34cdef26eaebcf98916e9881b3a04f4f698f09c6 Mon Sep 17 00:00:00 2001 From: Logaprakash Ramajayam Date: Thu, 5 Jun 2025 01:33:39 -0700 Subject: [PATCH] swscale/aarch64/output: Implement neon assembly for yuv2planeX_10_c_template() --- libswscal

Re: [FFmpeg-devel] [PATCH] avformat/tls_openssl: fix build error when openssl version < 3

2025-06-06 Thread Jack Lau
> On Jun 5, 2025, at 19:20, Martin Storsjö wrote: > > On Thu, 5 Jun 2025, Jack Lau wrote: > >>> On Jun 5, 2025, at 15:02, Martin Storsjö wrote: >>> On Thu, 5 Jun 2025, Jack Lau via ffmpeg-devel wrote: fix the missing data structure pkey in the tls_context Signed-off-by: Jack Lau >>

[FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix build error when openssl version < 3

2025-06-06 Thread Jack Lau via ffmpeg-devel
add the missing data structure pkey in the tls_context properly set this pkey and free it Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_open

Re: [FFmpeg-devel] [PATCH] swscale/aarch64/output: Implement neon assembly for yuv2nv12cX_c()

2025-06-06 Thread Martin Storsjö
On Fri, 6 Jun 2025, Harshitha Sarangu Suresh wrote: Changed indentation, checked for FATE tests and gha-aarch64 git workflow. Everything passed. I doubt that everything passed; this doesn't even compile. See below: @@ -275,7 +291,10 @@ av_cold void ff_sws_init_swscale_aarch64(SwsInternal *c)