Re: [FFmpeg-devel] [PATCH v10 06/15] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:17 +, softworkz wrote: > From: softworkz > > This allows future addition of options without > changes to the signature of avtext_context_open(). > > Reviewed-by: Stefano Sabatini > Signed-off-by: softworkz > --- > fftools/ffprobe.c | 13

[FFmpeg-devel] [PATCH v12 14/15] fftools/graphprint: Add execution graph printing

2025-05-07 Thread softworkz
From: softworkz The key benefits are: - Different to other graph printing methods, this is outputting: - all graphs with runtime state (including auto-inserted filters) - each graph with its inputs and outputs - all filters with their in- and output pads - all connections between all

[FFmpeg-devel] [PATCH v12 15/15] fftools/graphprint: Now, make it a Killer-Feature!

2025-05-07 Thread softworkz
From: softworkz remember this: -sg <= means Show Graph Signed-off-by: softworkz --- doc/ffmpeg.texi | 4 + fftools/Makefile | 1 + fftools/ffmpeg.c | 2 +- fftools/ffmpeg.h | 1 + fftools/ffmpeg_filter.c | 2 +- fftools/ffmpeg_o

[FFmpeg-devel] [PATCH v12 12/15] fftools/resources: Add resource manager files with build-time compression

2025-05-07 Thread softworkz
From: softworkz Compression requires zlib to be available, otherwise resources will be included uncompressed - in either case via BIN2C. It can also be disabled via ./configure --disable-resource-compression Size figures: graph.css 7752 graph.css.min 6655 (css is always minified)

[FFmpeg-devel] [PATCH v12 13/15] fftools/ffmpeg_mux: Make ms_from_ost() inline

2025-05-07 Thread softworkz
From: softworkz Signed-off-by: softworkz --- fftools/ffmpeg_mux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux.h b/fftools/ffmpeg_mux.h index f41f2c18fa..4ca8ab73a4 100644 --- a/fftools/ffmpeg_mux.h +++ b/fftools/ffmpeg_mux.h @@ -123,7 +123,7 @@ typedef

[FFmpeg-devel] [PATCH v12 11/15] avfilter/avfilter: Add avfilter_link_get_hw_frames_ctx()

2025-05-07 Thread softworkz
From: softworkz Signed-off-by: softworkz --- doc/APIchanges | 3 +++ libavfilter/avfilter.c | 9 + libavfilter/avfilter.h | 12 3 files changed, 24 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index 75d66f87f3..d0869561f3 100644 --- a/doc/APIchanges

[FFmpeg-devel] [PATCH v12 10/15] fftools/ffmpeg_filter: Move some declaration to new header file

2025-05-07 Thread softworkz
From: softworkz to allow filtergraph printing to access the information. Signed-off-by: softworkz --- fftools/ffmpeg_filter.c | 190 +--- fftools/ffmpeg_filter.h | 234 2 files changed, 235 insertions(+), 189 deletions(-) cr

[FFmpeg-devel] [PATCH v12 09/15] fftools/textformat: Add flags param to function avtext_print_integer()

2025-05-07 Thread softworkz
From: softworkz Make this function work analog to avtext_print_string() which already has a flags parameter. Signed-off-by: softworkz --- fftools/ffprobe.c | 2 +- fftools/textformat/avtextformat.c | 24 ++-- fftools/textformat/avtextformat.h | 2 +- 3 fil

[FFmpeg-devel] [PATCH v12 07/15] fftools/textformat: Introduce common header and deduplicate code

2025-05-07 Thread softworkz
From: softworkz Also change writer_printf signature in AVTextWriter to use va_list, so that it can be called by the new function writer_printf() in tf_internal.h. Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextwriters.h | 2 +- fftools/textformat/tf_compa

[FFmpeg-devel] [PATCH v12 08/15] fftools/tf_internal: Use av_default_item_name

2025-05-07 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/tf_internal.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fftools/textformat/tf_internal.h b/fftools/textformat/tf_internal.h index 362a4cbc38..484886b7a7 100644 --- a/fft

[FFmpeg-devel] [PATCH v12 06/15] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-05-07 Thread softworkz
From: softworkz This allows future addition of options without changes to the signature of avtext_context_open(). Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/ffprobe.c | 13 + fftools/textformat/avtextformat.c | 18 ++ fftools

[FFmpeg-devel] [PATCH v12 05/15] fftools/avtextformat: Re-use BPrint in loop

2025-05-07 Thread softworkz
From: softworkz Instead of initializing a new BPrint in case of UTF decode error, re-use the same BPrint struct and just clear it for each iteration. Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 23 ++- 1 file changed, 14 i

[FFmpeg-devel] [PATCH v12 04/15] fftools/textformat: Rename name param to key for API consistency

2025-05-07 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 14 +++--- fftools/textformat/avtextformat.h | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/fftools/textformat/avtextformat.c b/fftools/textfor

[FFmpeg-devel] [PATCH v12 03/15] fftools/textformat: Remove unused print_rational() pointer from AVTextFormatter

2025-05-07 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextformat.h | 1 - fftools/textformat/avtextwriters.h | 5 - 2 files changed, 6 deletions(-) diff --git a/fftools/textformat/avtextformat.h b/fftools/textformat/avtextformat.h index 86feb9d0

[FFmpeg-devel] [PATCH v12 01/15] fftools/textformat: Apply formatting and whitespace changes

2025-05-07 Thread softworkz
From: softworkz Reviewed-by: Stefano Sabatini Signed-off-by: softworkz --- fftools/textformat/avtextformat.c | 88 +++--- fftools/textformat/avtextformat.h | 20 +++ fftools/textformat/avtextwriters.h | 11 ++-- fftools/textformat/tf_compact.c| 87

[FFmpeg-devel] [PATCH v12 02/15] fftools/textformat: Apply quality improvements

2025-05-07 Thread softworkz
From: softworkz Perform multiple improvements to increase code robustness. In particular: - favor unsigned counters for loops - add missing checks - avoid possible leaks - move variable declarations to inner scopes when feasible - provide explicit type-casting when needed Signed-off-by: softwork

[FFmpeg-devel] [PATCH v12 00/15] Execution Graph Printing

2025-05-07 Thread ffmpegagent
Shortest cover letter for my longest-running FFmpeg patchset: * Apply * Build * Add the "-sg" switch to any FFmpeg command line * Press 'q' when you don't want to wait SG = Show Graph Documentation and examples can be found here: https://github.com/softworkz/ffmpeg_output_apis/wiki Versio

Re: [FFmpeg-devel] [PATCH v10 06/15] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-05-07 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Donnerstag, 8. Mai 2025 02:06 > To: FFmpeg development discussions and patches > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH v10 06/15] fftools/textformat: Introduce > AVTextFormatOptions for avtext_context_open() > > On da

Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting and whitespace changes

2025-05-07 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Donnerstag, 8. Mai 2025 02:14 > To: softworkz . > Cc: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting > and whitespace changes > > On date Wednesday 2025-05-

Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting and whitespace changes

2025-05-07 Thread Stefano Sabatini
On date Wednesday 2025-05-07 23:59:39 +, softworkz . wrote: > > > > -Original Message- > > From: Stefano Sabatini > > Sent: Donnerstag, 8. Mai 2025 01:45 > > To: FFmpeg development discussions and patches > > Cc: softworkz > > Subject: Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/t

Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting and whitespace changes

2025-05-07 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Donnerstag, 8. Mai 2025 01:45 > To: FFmpeg development discussions and patches > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting > and whitespace changes > > On date Sunday 2025-05-04 0

Re: [FFmpeg-devel] [PATCH v10 05/15] fftools/avtextformat: Re-use BPrint in loop

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:16 +, softworkz wrote: > From: softworkz > > Instead of initializing a new BPrint in each iteration of > the loop, a new BPrint in case of UTF decode error > re-use the same BPrint struct and just clear it > for each iteration. > > Signed-off-by: softworkz

Re: [FFmpeg-devel] [PATCH v10 03/15] fftools/textformat: Remove unused print_rational() pointer from AVTextFormatter

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:14 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.h | 1 - > fftools/textformat/avtextwriters.h | 5 - > 2 files changed, 6 deletions(-) > > diff --git a/fftools/textformat/avtextformat.h > b/

Re: [FFmpeg-devel] [PATCH v10 04/15] fftools/textformat: Rename name param to key for API consistency

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:15 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.c | 14 +++--- > fftools/textformat/avtextformat.h | 6 +++--- > 2 files changed, 10 insertions(+), 10 deletions(-) LGTM. _

Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting and whitespace changes

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:12 +, softworkz wrote: > From: softworkz [...] nit: use verb-object form in topic line - as in "apply formatting and whitespace changes" - for consistency and easier human readers processing. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-05-07 Thread Stefano Sabatini
On date Saturday 2025-05-03 08:55:42 +, softworkz . wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of softworkz > > . > > Sent: Dienstag, 29. April 2025 01:24 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFo

Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting and whitespace changes

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:12 +, softworkz wrote: > From: softworkz > > Reviewed-by: Stefano Sabatini > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.c | 92 +++--- > fftools/textformat/avtextformat.h | 20 +++ > fftools/textformat/avte

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-05-07 Thread softworkz .
> -Original Message- > From: Stefano Sabatini > Sent: Donnerstag, 8. Mai 2025 01:31 > To: softworkz . > Cc: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface > > On date Saturday 2025-05-03 08:55:42 +, softworkz .

Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros

2025-05-07 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Michael > Niedermayer > Sent: Donnerstag, 8. Mai 2025 01:22 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable > and av_assume() macros > > On Wed, May

Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros

2025-05-07 Thread Michael Niedermayer
On Wed, May 07, 2025 at 07:14:04PM +, softworkz . wrote: [...] > > > > As long as there's no migration to a better way, why not try out making > > PRs > > > to https://github.com/ffstaging/FFmpeg? > > > > > > I doubt "ffstaging" is affiliated with the project in any capacity. > > > > Hi James,

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-05-07 Thread Stefano Sabatini
On date Monday 2025-05-05 16:32:08 +0200, Nicolas George wrote: > Stefano Sabatini (HE12025-05-04): > > I don't understand this claim. There is a root, and each section can > > have several subsections, so it is a tree in my view, although we set > > a maximum depth. Where am I wrong? > > Are we

Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros

2025-05-07 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of softworkz . > Sent: Mittwoch, 7. Mai 2025 20:54 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable > and av_assume() macros > > > > > -Original Me

Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros

2025-05-07 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of James Almer > Sent: Mittwoch, 7. Mai 2025 20:30 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable > and av_assume() macros > > On 5/7/2025 2:57 PM, softworkz . wrote: > >

Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros

2025-05-07 Thread James Almer
On 5/7/2025 2:57 PM, softworkz . wrote: -Original Message- From: ffmpeg-devel On Behalf Of Andreas Rheinhardt Sent: Mittwoch, 7. Mai 2025 13:59 To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() mac

Re: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros

2025-05-07 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: Mittwoch, 7. Mai 2025 13:59 > To: FFmpeg development discussions and patches > Subject: [FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and > av_assume() macros > > Patches attached. >

Re: [FFmpeg-devel] [PATCH 01/11] avcodec/vulkan_encode_h264: Fix memleak on error

2025-05-07 Thread Lynne
On 06/05/2025 01:37, Andreas Rheinhardt wrote: Patches attached. - Andreas Vulkan patches LGTM. OpenPGP_0xA2FEA5F03F034464.asc Description: OpenPGP public key OpenPGP_signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH 0/4] [Please Ignore] ci_test

2025-05-07 Thread softworkz .
> -Original Message- > From: Kieran Kunhya > Sent: Mittwoch, 7. Mai 2025 16:16 > To: FFmpeg development discussions and patches > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH 0/4] [Please Ignore] ci_test > > On Wed, May 7, 2025 at 4:24 AM ffmpegagent wrote: > > > > This is for

Re: [FFmpeg-devel] [PATCH 0/4] [Please Ignore] ci_test

2025-05-07 Thread Kieran Kunhya via ffmpeg-devel
On Wed, May 7, 2025 at 4:24 AM ffmpegagent wrote: > > This is for testing Patchwork CI builds, not for merging. > > softworkz (4): > ci_test: Fail configure > ci_test: Fail build > ci_test: Fail fate > ci_test: All good > > > > base-commit: 2b6303762fc0850b3bd841ebd234c336271f657c > Publis

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: Query the correct format

2025-05-07 Thread Lynne
On 05/05/2025 21:37, Link Mauve wrote: In the call to vkGetPhysicalDeviceImageFormatProperties2(), we were previously requesting the properties of the first fallback format (e.g. VK_FORMAT_R8_UNORM for VK_FORMAT_G8_B8R8_2PLANE_420_UNORM) instead of the actual format in use. We don’t do anything

[FFmpeg-devel] [PATCH 1/2] Revert "fftools/textformat/avtextformat: Make close functions return void"

2025-05-07 Thread Marton Balint
This reverts commit 7684243fbe6e84fecb4a039195d5fda8a006a2a4 and a888975a3c25760027cd59932f5c1ad04368db8b. --- fftools/ffprobe.c | 14 +++--- fftools/textformat/avtextformat.c | 12 fftools/textformat/avtextformat.h | 2 +- fftools/textformat/avtextwriters.

[FFmpeg-devel] [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros

2025-05-07 Thread Andreas Rheinhardt
Patches attached. - Andreas From dd62fb6eeb9a5bc9a870430a93c6de1aca4be1d6 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 3 Oct 2021 14:03:25 +0200 Subject: [PATCH 01/21] avutil/avassert: Add av_unreachable and av_assume() macros Useful to let the compiler and static analyzers know

Re: [FFmpeg-devel] [PATCH 0/2] FFmpeg Source plugin experiment

2025-05-07 Thread Michael Niedermayer
On Tue, May 06, 2025 at 01:06:40AM +0200, Michael Niedermayer wrote: > This patch set will remove libpostproc from FFmpeg > resulting in a master branch like: > https://github.com/michaelni/FFmpeg/tree/experiment-sourceplugin-master > > matching this, libpostproc can trivially become a source plu

Re: [FFmpeg-devel] [PATCH v4 5/6] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-05-07 Thread Michael Niedermayer
On Tue, May 06, 2025 at 09:19:31AM -0500, Romain Beauxis wrote: > --- > libavformat/oggparsevorbis.c | 11 +-- > tests/ref/fate/ogg-vorbis-chained-meta.txt | 3 --- > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/libavformat/oggparsevorbis.c b/libavforma

[FFmpeg-devel] [PATCH 2/2] fftools/textformat: correctly propagate uninit error codes

2025-05-07 Thread Marton Balint
This allows catching IO errors occuring at file close. Signed-off-by: Marton Balint --- fftools/textformat/avtextformat.c | 4 ++-- fftools/textformat/avtextformat.h | 2 +- fftools/textformat/avtextwriters.h | 2 +- fftools/textformat/tw_avio.c | 6 -- 4 files changed, 8 insertions(

Re: [FFmpeg-devel] Patch for Phantom .cine files

2025-05-07 Thread Michael Niedermayer
On Tue, May 06, 2025 at 03:08:37PM +0200, Max Rudolph via ffmpeg-devel wrote: > Hello, > I'm offering a patch to add support for additional CFA types when reading > phantom cine files. This was necessary to get ffmpeg to debayer the cine > files produced by my newer Phantom C321. > > > > Max Rud

Re: [FFmpeg-devel] [PATCH v5] Mark C globals with small code model

2025-05-07 Thread Rémi Denis-Courmont
Hi, This looks like a kludge to me. If static variables are too far away, then the assembler code that refers to them needs to be fixed, and that's all that there is to it. You can't just magically make the data and the code closer, especially if FFmpeg is compiled as a static library (a very

[FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Add direct map quirk for Intel i965 driver

2025-05-07 Thread David Rosca
vaGetImage is currently used for all maps when read access is required because vaDeriveImage is supposed to be very slow on old Intel HW with i965 driver. However, this is not the case with modern drivers and vaDeriveImage is faster also for reading. Add a new quirk for i965 driver that will keep

[FFmpeg-devel] [PATCH v3] libavcodec/riscv:add RVV optimized idct_32x32_8 for HEVC:

2025-05-07 Thread daichengrong
From: daichengrong On Banana PI F3: hevc_idct_32x32_8_c:118833.7 ( 1.00x) hevc_idct_32x32_8_rvv_i64: 28718.3 ( 4.14x) Changes in v3: remove the slides in transposition and spill values from vector registers to sta

Re: [FFmpeg-devel] [PATCH] avfilter/vf_setparams: Fix chroma_location being cleared

2025-05-07 Thread Tobias Rapp
On 02/05/2025 22:08, Michael Niedermayer wrote: On Wed, Apr 30, 2025 at 02:56:58PM +0200, Tobias Rapp wrote: On 30/04/2025 14:09, Tobias Rapp wrote: Fix chroma_location being cleared by setrange and setfield filters. This was forgotten in 201f1cba150d44de6fedfeee4e8647170ed5fbca. Signed-off-

Re: [FFmpeg-devel] [PATCH v2 0/3] avcodec/sanm: Fixes for "StarWars - Making Magic"

2025-05-07 Thread Manuel Lauss
Hi, If there are no objections, I will commit this with whitespace fixes in 2-3 days. I see no regressions with existing sanm video support. Manuel On Tue, May 6, 2025 at 5:41 PM Manuel Lauss wrote: > > This patchset extends the SANM codec handler to support video of > the 1996 CD-ROM Title "S