Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-04-29 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of softworkz . > Sent: Dienstag, 29. April 2025 20:07 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface > > > > > -Original Message- > > From: ffmpeg-d

[FFmpeg-devel] [PATCH v4] avformat/hls: Return error code when read key file failed

2025-04-29 Thread Zhao Zhili
From: Zhao Zhili --- libavformat/hls.c | 47 ++- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 6623c80309..5cddf4b5c0 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1331,6 +1331,

Re: [FFmpeg-devel] [PATCH v2 2/2] ogg/{vorbis, flac, opus}: Remove header packets from subsequent ogg streams from the demuxer output.

2025-04-29 Thread Romain Beauxis
Le mar. 29 avr. 2025 à 19:17, Michael Niedermayer a écrit : > > Hi Romain > > On Tue, Apr 29, 2025 at 05:42:22PM -0500, Romain Beauxis wrote: > > Le mar. 29 avr. 2025 à 16:35, Michael Niedermayer > > a écrit : > > > > > > Hi > > > > > > On Mon, Apr 28, 2025 at 06:31:36PM -0500, Romain Beauxis wro

[FFmpeg-devel] [PATCH] avcodec: add APV encoder using liboapv

2025-04-29 Thread James Almer
From: Dawid Kozinski Co-authored-by: James Almer Signed-off-by: James Almer --- Touched up Dawid's patch to fix several issues. The most important one being the image rescaling code that's out of place in an encoder. liboapv does not seem to properly support 12bit content yet (Which is why the

Re: [FFmpeg-devel] [PATCH v2 2/2] ogg/{vorbis, flac, opus}: Remove header packets from subsequent ogg streams from the demuxer output.

2025-04-29 Thread Michael Niedermayer
Hi Romain On Tue, Apr 29, 2025 at 05:42:22PM -0500, Romain Beauxis wrote: > Le mar. 29 avr. 2025 à 16:35, Michael Niedermayer > a écrit : > > > > Hi > > > > On Mon, Apr 28, 2025 at 06:31:36PM -0500, Romain Beauxis wrote: > > > --- > > > libavformat/oggdec.c | 26 ++-

[FFmpeg-devel] [PATCH 2/2] avformat/hls: Fix flash1.bogulus.cfd support

2025-04-29 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/hls.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 34a36f68f1f..1025ccd2f58 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -760,8 +760,11 @@ static int test_seg

[FFmpeg-devel] [PATCH 1/2] avformat/hls: Split allowed_segment_extensions off allowed_extensions

2025-04-29 Thread Michael Niedermayer
This allows the user to set only the one that is needed to ALL or a specific "wrong" extension like html Signed-off-by: Michael Niedermayer --- libavformat/hls.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 84a

Re: [FFmpeg-devel] [PATCH v2 2/2] ogg/{vorbis, flac, opus}: Remove header packets from subsequent ogg streams from the demuxer output.

2025-04-29 Thread Romain Beauxis
Le mar. 29 avr. 2025 à 16:35, Michael Niedermayer a écrit : > > Hi > > On Mon, Apr 28, 2025 at 06:31:36PM -0500, Romain Beauxis wrote: > > --- > > libavformat/oggdec.c | 26 ++-- > > libavformat/oggdec.h | 6 + > > libavformat/oggpa

Re: [FFmpeg-devel] [PATCH 0/4] avformat/hls: Some extension fixes that need testing

2025-04-29 Thread Michael Niedermayer
Hi On Sun, Apr 06, 2025 at 01:16:27PM +0200, Michael Niedermayer wrote: > Hi all > > This patchset adds all the extensions i found on trac and its links to > allowed_extensions for hls. > There was one testcase only so most of this is untested. It may be > needed to add the extensions also to de

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fix Youtube AAC

2025-04-29 Thread Michael Niedermayer
On Sun, Apr 06, 2025 at 06:52:05PM +0200, Michael Niedermayer wrote: > Fixes: Ticket11435 > Fixes: yt-dlp -f 234+270 https://www.youtube.com/live/l8PMl7tUDIE > > Signed-off-by: Michael Niedermayer > --- > libavformat/hls.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) will apply [.

Re: [FFmpeg-devel] [PATCH v3] avcodec: Fix fate-checkasm-hevc_pel failed on LA.

2025-04-29 Thread Michael Niedermayer
Hi On Tue, Apr 29, 2025 at 04:13:59PM +0800, 陈昊 wrote: > > > > > -原始邮件- > > 发件人: "Shiyou Yin" > > 发送时间:2025-04-18 09:37:08 (星期五) > > 收件人: ffmpeg-devel@ffmpeg.org > > 主题: [FFmpeg-devel] [PATCH v3] avcodec: Fix fate-checkasm-hevc_pel failed on > > LA. > > > > Some loop counters were in

Re: [FFmpeg-devel] [PATCH v2 2/2] ogg/{vorbis, flac, opus}: Remove header packets from subsequent ogg streams from the demuxer output.

2025-04-29 Thread Michael Niedermayer
Hi On Mon, Apr 28, 2025 at 06:31:36PM -0500, Romain Beauxis wrote: > --- > libavformat/oggdec.c | 26 ++-- > libavformat/oggdec.h | 6 + > libavformat/oggparseflac.c | 28 -- > libavformat/oggpars

[FFmpeg-devel] SW's Patchsets Heads-Up

2025-04-29 Thread softworkz .
Hello everybody, here's a list of patches that I'm intending to apply by the end of the week (Fr/Sa) unless there would any more comments: avformat/dump: Change precision of stream start offsets GitHub:https://github.com/ffstaging/FFmpeg/pull/72 Patchwork: (seems broken today) avutil/o

Re: [FFmpeg-devel] [PATCH v2 1/2] tests: Add stream dump test API util, use it to dump stream data for chained ogg/{vorbis, opus, flac} streams.

2025-04-29 Thread Michael Niedermayer
Hi Romain On Mon, Apr 28, 2025 at 06:31:35PM -0500, Romain Beauxis wrote: > --- > tests/Makefile | 4 + > tests/api/Makefile | 2 +- > tests/api/api-dump-stream-meta-test.c | 182 + > tests/fate/ogg-flac.mak

[FFmpeg-devel] [PATCH v3] avformat/dump: Stream start offsets: change precision and label

2025-04-29 Thread softworkz
From: softworkz - Change precision to 6 digits to align with other printed times - Change label to just "Start" - Add 's' unit to format 'start' value for consistency Signed-off-by: softworkz --- avformat/dump: Change precision of stream start offsets Changing this to 6 digits to a

Re: [FFmpeg-devel] [PATCH v8 14/15] fftools/graphprint: Add execution graph printing

2025-04-29 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Michael > Niedermayer > Sent: Dienstag, 29. April 2025 21:35 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v8 14/15] fftools/graphprint: Add execution > graph printing > > Hi softworkz > >

[FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-04-29 Thread Russell Greene
Previously, it was assumed that `drmFormatModifierPlaneCount` was one for all modifiers when exporting, which is not always the case, in particular for AMD GPUs and maybe others. Fetch the number of memory planes and fill the structs appropriately in this situation. The encoded stream is still ba

Re: [FFmpeg-devel] [PATCH v8 13/15] fftools/ffmpeg_mux: Make ms_from_ost() inline

2025-04-29 Thread Michael Niedermayer
On Tue, Apr 29, 2025 at 01:00:02AM +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/ffmpeg_mux.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No human

[FFmpeg-devel] [PATCH] avcodec/cbs_apv: don't return an error when reading empty buffers

2025-04-29 Thread James Almer
The output will be a fragment with zero units, which is a lot more user friendly than making them think something went wrong, as it already happens with cbs_av1. Signed-off-by: James Almer --- libavcodec/cbs_apv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs

Re: [FFmpeg-devel] [PATCH v8 14/15] fftools/graphprint: Add execution graph printing

2025-04-29 Thread Michael Niedermayer
Hi softworkz On Tue, Apr 29, 2025 at 01:00:03AM +, softworkz wrote: > From: softworkz > > The key benefits are: > > - Different to other graph printing methods, this is outputting: > - all graphs with runtime state > (including auto-inserted filters) > - each graph with its inputs a

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lut3d_opencl Initial support for OpenCL implementation of vf_lut3d.

2025-04-29 Thread Michael Niedermayer
On Mon, Apr 28, 2025 at 01:37:27PM +0300, Jan Studený via ffmpeg-devel wrote: > --- > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/opencl/lut3d.cl | 177 ++ > libavfilter/opencl_source.h | 2 + > libavfilter/vf_lut3d_opencl.c | 444

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-04-29 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Nicolas > George > Sent: Dienstag, 29. April 2025 10:31 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface > > Stefano Sabatini (HE12025-04-27): > > Elaboratin

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Detect subpic overlaps at CTU level

2025-04-29 Thread Nuo Mi
Hi Frank, Thank you for the detail. On Mon, Apr 28, 2025 at 10:35 PM Frank Plowman wrote: > On 28/04/2025 14:33, Nuo Mi wrote: > > Hi Frank, > > Thank you for the v2. > > Could we remove all asserts? > > Asserts can cause the application to crash at runtime. > > Hi, > > I think av_assert2s are t

Re: [FFmpeg-devel] [PATCH 11/17] swscale/x86: add SIMD backend

2025-04-29 Thread Michael Niedermayer
On Sat, Apr 26, 2025 at 07:41:15PM +0200, Niklas Haas wrote: > From: Niklas Haas > > This covers most 8-bit and 16-bit ops, and some 32-bit ops. It also covers all > floating point operations. While this is not yet 100% coverage, it's good > enough for the vast majority of formats out there. > >

Re: [FFmpeg-devel] [PATCH v3] avformat/hls: Return error code when read key file failed

2025-04-29 Thread Zhao Zhili
> On Apr 29, 2025, at 20:15, Andreas Rheinhardt > wrote: > > Zhao Zhili: >> From: Zhao Zhili >> >> --- >> libavformat/hls.c | 47 ++- >> 1 file changed, 34 insertions(+), 13 deletions(-) >> >> diff --git a/libavformat/hls.c b/libavformat/hls.c >>

Re: [FFmpeg-devel] [PATCH v3] avformat/hls: Return error code when read key file failed

2025-04-29 Thread Andreas Rheinhardt
Zhao Zhili: > From: Zhao Zhili > > --- > libavformat/hls.c | 47 ++- > 1 file changed, 34 insertions(+), 13 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 6623c80309..fe908a563b 100644 > --- a/libavformat/hls.c > +++ b/lib

Re: [FFmpeg-devel] [PATCH v3] avformat/hls: Return error code when read key file failed

2025-04-29 Thread Steven Liu
Zhao Zhili 于2025年4月29日 周二17:30写道: > From: Zhao Zhili > > --- > libavformat/hls.c | 47 ++- > 1 file changed, 34 insertions(+), 13 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 6623c80309..fe908a563b 100644 > --- a/libavfor

[FFmpeg-devel] [PATCH v3] avformat/hls: Return error code when read key file failed

2025-04-29 Thread Zhao Zhili
From: Zhao Zhili --- libavformat/hls.c | 47 ++- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 6623c80309..fe908a563b 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1331,6 +1331,

[FFmpeg-devel] [PATCH] avutil/hwcontext_dxva2: fix dst width/ height is 0 in av_hwframe_map()

2025-04-29 Thread Stalkyr
libavutil/hwcontext_dxva2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/hwcontext_dxva2.c b/libavutil/hwcontext_dxva2.c index f697690e19..1f9506aed6 100644 --- a/libavutil/hwcontext_dxva2.c +++ b/libavutil/hwcontext_dxva2.c @@ -334,6 +334,9 @@ static int dxva2_map_frame(AVHWFram

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-04-29 Thread Nicolas George
Stefano Sabatini (HE12025-04-27): > Elaborating on this. ffprobe/textformat is based on a notion of > hierarchical tree-like data No, this is not true. FFprobe and all its supporting code is based on one level of hierarchy. Just one level, not a real hierarchical structure. > Considering this, th

Re: [FFmpeg-devel] [PATCH v3] avcodec: Fix fate-checkasm-hevc_pel failed on LA.

2025-04-29 Thread 陈昊
> -原始邮件- > 发件人: "Shiyou Yin" > 发送时间:2025-04-18 09:37:08 (星期五) > 收件人: ffmpeg-devel@ffmpeg.org > 主题: [FFmpeg-devel] [PATCH v3] avcodec: Fix fate-checkasm-hevc_pel failed on > LA. > > Some loop counters were initialized incorrectly. > This patch enhances the handling of loop iterations a

Re: [FFmpeg-devel] [PATCH] aarch64/h26x: Add put_hevc_pel_bi_w_pixels

2025-04-29 Thread Zhao Zhili
> On Apr 25, 2025, at 16:29, Martin Storsjö wrote: > > On Wed, 23 Apr 2025, Zhao Zhili wrote: > >> From: Zhao Zhili >> >> On rpi5 (A76): >> >> put_hevc_pel_bi_w_pixels4_8_c: 90.0 ( 1.00x) >> put_hevc_pel_bi_w_pixels4_8_neon: 34.1 ( 2.64x) >> pu

[FFmpeg-devel] [PATCH 2/2] ffv1enc_vulkan: support 2-plane YUV formats

2025-04-29 Thread Lynne
This adds support for NV12 and P010. More will be added later. --- libavcodec/ffv1enc.c| 2 ++ libavcodec/ffv1enc_vulkan.c | 8 ++-- libavcodec/vulkan/ffv1_enc.comp | 21 ++--- 3 files changed, 22 insertions(+), 9 deletions(-) diff --git a/libavcodec/ffv1enc.

[FFmpeg-devel] [PATCH 1/2] hwcontext_vulkan: support AV_PIX_FMT_GBRP

2025-04-29 Thread Lynne
Support was partially added previously in vulkan.c, but now it's fully supported. --- libavutil/hwcontext_vulkan.c | 1 + libavutil/vulkan.c | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index ade023

Re: [FFmpeg-devel] [PATCH] aarch64/h26x: optimize sao_band_filter

2025-04-29 Thread Martin Storsjö
On Tue, 29 Apr 2025, Zhao Zhili wrote: On Apr 25, 2025, at 16:25, Martin Storsjö wrote: On Tue, 15 Apr 2025, Zhao Zhili wrote: +tbx v3.8b, {v16.16b-v17.16b}, v3.8b Is there any specific reason for preferring tbx over tbl here? (I know the existing code used tbx.) With

Re: [FFmpeg-devel] [PATCH] aarch64/h26x: optimize sao_band_filter

2025-04-29 Thread Zhao Zhili
> On Apr 25, 2025, at 16:25, Martin Storsjö wrote: > > On Tue, 15 Apr 2025, Zhao Zhili wrote: > >> From: Zhao Zhili >> >> int8_t[] is enough for offset_table of 8 bit streams. >> >> On rpi5: >>Before After >> hevc_sao_band_8_8_c: 252.3 ( 1.

[FFmpeg-devel] [PATCH] configure: Enable -fno-common for Darwin targets, avoid linker warnings

2025-04-29 Thread Martin Storsjö
Since GCC 10 and llvm.org Clang 11, -fno-common is the default. However Apple's Xcode Clang hasn't followed suit yet, and still defaults to -fcommon. Compiling with -fcommon causes uninitialized global variables to be treated as "common" (which allows multiple object files to have similar definiti