[FFmpeg-devel] [PATCH] doc/encoders: Move FFV1 encoder to video encoder section

2025-03-30 Thread Andreas Rheinhardt
Patch attached. - Andreas From 771b85f1bb55df28b7ab2a5c48a9470aa07e017b Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 31 Mar 2025 08:38:02 +0200 Subject: [PATCH] doc/encoders: Move FFV1 encoder to video encoder section It is not an audio encoder. Signed-off-by: Andreas Rheinhardt

[FFmpeg-devel] [PATCH 4/6] vulkan_decode: add a generic start_frame function

2025-03-30 Thread Lynne
--- libavcodec/vulkan_decode.c | 38 ++ libavcodec/vulkan_decode.h | 6 ++ 2 files changed, 40 insertions(+), 4 deletions(-) diff --git a/libavcodec/vulkan_decode.c b/libavcodec/vulkan_decode.c index 058efe3037..893f8fca3d 100644 --- a/libavcodec/vulkan_de

[FFmpeg-devel] [PATCH 6/6] vulkan_hevc: make all temporary structs temporary

2025-03-30 Thread Lynne
--- libavcodec/vulkan_hevc.c | 291 --- 1 file changed, 150 insertions(+), 141 deletions(-) diff --git a/libavcodec/vulkan_hevc.c b/libavcodec/vulkan_hevc.c index e83f8346a0..baf8b0c3fd 100644 --- a/libavcodec/vulkan_hevc.c +++ b/libavcodec/vulkan_hevc.c @@ -11

[FFmpeg-devel] [PATCH 5/6] vulkan_h264: make all temporary structs temporary

2025-03-30 Thread Lynne
This commit moves all temporary structs used for decoding out of the common picture header and onto stack. --- libavcodec/vulkan_decode.c | 1 + libavcodec/vulkan_decode.h | 3 + libavcodec/vulkan_h264.c | 322 +++-- 3 files changed, 168 insertions(+), 158 del

[FFmpeg-devel] [PATCH 3/6] vulkan_decode: move temporary Vulkan structs into each codec

2025-03-30 Thread Lynne
Required for next refactor. --- libavcodec/vulkan_av1.c| 30 +- libavcodec/vulkan_decode.c | 20 ++-- libavcodec/vulkan_decode.h | 13 + libavcodec/vulkan_h264.c | 32 ++-- libavcodec/vulkan_hevc.c | 28 +++

[FFmpeg-devel] [PATCH 1/6] vulkan_decode: generalize handling of slice offsets/nb

2025-03-30 Thread Lynne
This allows for the upcoming refactor. --- libavcodec/vulkan_av1.c| 6 +++--- libavcodec/vulkan_decode.c | 23 ++- libavcodec/vulkan_decode.h | 5 +++-- libavcodec/vulkan_ffv1.c | 22 -- libavcodec/vulkan_h264.c | 9 +++-- libavcodec/vulkan_he

[FFmpeg-devel] [PATCH 2/6] vulkan_decode: only create sequence params in end_frame

2025-03-30 Thread Lynne
We tried to create sequence params in both start_frame and end_frame. This was redundant. Just always create them in end_frame. --- libavcodec/vulkan_av1.c | 8 libavcodec/vulkan_h264.c | 9 - libavcodec/vulkan_hevc.c | 9 - 3 files changed, 26 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Use CBR filler data consistently across codecs

2025-03-30 Thread Cameron Gutman
On Sun, Mar 30, 2025 at 10:46 AM Zhao Zhili wrote: > > > > > On Mar 30, 2025, at 23:33, Kieran Kunhya via ffmpeg-devel > > wrote: > > > > On Sun, Mar 30, 2025 at 12:04 AM Cameron Gutman > > wrote: > >> > >> Previously, AV1 used filler data with CBR by default while

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: Add -remap_optimizer option

2025-03-30 Thread Michael Niedermayer
On Fri, Mar 28, 2025 at 12:41:51PM +0100, Michael Niedermayer wrote: > This allows tuning how much effort (time) the encoder spends on > optimizing the remap table > > Signed-off-by: Michael Niedermayer > --- > doc/encoders.texi| 4 > libavcodec/ffv1.h| 2 +- > libavcodec/ffv1enc.

Re: [FFmpeg-devel] [PATCH v2] w32pthreads: add support for setting thread name

2025-03-30 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of Jan > Ekström > Sent: Montag, 31. März 2025 00:05 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v2] w32pthreads: add support for > setting thread name > > On Tue, Mar 4, 2025 at 5:14 PM Kacpe

Re: [FFmpeg-devel] [PATCH] avfilter: Proof of Concept: enable out-of-tree filters

2025-03-30 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Michael Niedermayer > Sent: Sonntag, 30. März 2025 23:27 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Proof of Concept: enable > out-of-tree filters > > Hi > > On Sun, Mar 30,

Re: [FFmpeg-devel] [PATCH v2] w32pthreads: add support for setting thread name

2025-03-30 Thread Jan Ekström
On Tue, Mar 4, 2025 at 5:14 PM Kacper Michajłow wrote: > > Signed-off-by: Kacper Michajłow > --- > compat/w32pthreads.h | 30 ++ > libavutil/thread.h | 2 ++ > 2 files changed, 32 insertions(+) > > diff --git a/compat/w32pthreads.h b/compat/w32pthreads.h > index fd

Re: [FFmpeg-devel] [PATCH] avfilter: Proof of Concept: enable out-of-tree filters

2025-03-30 Thread Michael Niedermayer
Hi On Sun, Mar 30, 2025 at 12:51:46AM +, softworkz . wrote: [...] > When the branch to merge has the same baseline with only the additional > commits on top it works fine of course. That's equivalent to the patchsets on > the ML needing to be created against the master branch. > It also work

[FFmpeg-devel] [PATCH 1/2] avcodec/ffv1enc: replace 3 double precision log2() by 1 single precision log2()

2025-03-30 Thread Michael Niedermayer
This makes the remap finding heuristic much faster Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index a09b31218db..2a188ade776 100644 --- a/libavcodec/

Re: [FFmpeg-devel] [PATCH] configure: Allow mixing declarations and statements

2025-03-30 Thread softworkz .
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Sonntag, 30. März 2025 17:37 > To: FFmpeg development discussions and patches > Subject: [FFmpeg-devel] [PATCH] configure: Allow mixing declarations and > statements > > Patch attached. > > - Andreas

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ffv1enc: Eliminate copy_state

2025-03-30 Thread Michael Niedermayer
On Fri, Mar 28, 2025 at 09:45:41AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1enc.c | 77 ++-- > 1 file changed, 25 insertions(+), 52 deletions(-) will apply patchset [...] -- Michael GnuPG fingerpr

Re: [FFmpeg-devel] [PATCH] configure: Allow mixing declarations and statements

2025-03-30 Thread Marvin Scholz
On 30 Mar 2025, at 17:37, Andreas Rheinhardt wrote: > Patch attached. > Yes please, +1 to this. > - Andreas > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link ab

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Use CBR filler data consistently across codecs

2025-03-30 Thread Cameron Gutman
On Sun, Mar 30, 2025 at 11:41 AM Timo Rothenpieler wrote: > > On 30.03.2025 17:33, Kieran Kunhya wrote: > > On Sun, Mar 30, 2025 at 12:04 AM Cameron Gutman > > wrote: > >> > >> Previously, AV1 used filler data with CBR by default while H.264 > >> and HEVC did not. Make this consistent by using f

Re: [FFmpeg-devel] [PATCH] avformat/rtpenc: Fix declaration-after-statement warning

2025-03-30 Thread Michael Niedermayer
On Sun, Mar 30, 2025 at 12:09:10PM +0200, Andreas Rheinhardt wrote: > Patch attached. Will apply it tonight unless there are objections > together with the other declaration-after-statement and unused-variable > patch. > Btw: I see no value in adhering to this ancient C90 rule. Can't we just > dro

[FFmpeg-devel] [PATCH 2/2] avcodec/ffv1enc: replace the remaining log2() by magic

2025-03-30 Thread Michael Niedermayer
big secret, reading a float as the corresponding integer is a good approximation of log2() for numbers not too close to 1.0. At the same time it maintains strict monotonicity this reduces run time from 19sec to 17sec for the slowest of my testcases (with default remap_optimizer 3) Compression is

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Use CBR filler data consistently across codecs

2025-03-30 Thread Timo Rothenpieler
On 30.03.2025 17:33, Kieran Kunhya wrote: On Sun, Mar 30, 2025 at 12:04 AM Cameron Gutman wrote: Previously, AV1 used filler data with CBR by default while H.264 and HEVC did not. Make this consistent by using filler data in CBR mode across all codecs. Since there are valid reasons to use CBR

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Use CBR filler data consistently across codecs

2025-03-30 Thread Zhao Zhili
> On Mar 30, 2025, at 23:33, Kieran Kunhya via ffmpeg-devel > wrote: > > On Sun, Mar 30, 2025 at 12:04 AM Cameron Gutman > wrote: >> >> Previously, AV1 used filler data with CBR by default while H.264 >> and HEVC did not. Make this consistent by using filler dat

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Use CBR filler data consistently across codecs

2025-03-30 Thread Kieran Kunhya via ffmpeg-devel
On Sun, Mar 30, 2025 at 12:04 AM Cameron Gutman wrote: > > Previously, AV1 used filler data with CBR by default while H.264 > and HEVC did not. Make this consistent by using filler data in > CBR mode across all codecs. > > Since there are valid reasons to use CBR with or without filler, > also add

[FFmpeg-devel] [PATCH] configure: Allow mixing declarations and statements

2025-03-30 Thread Andreas Rheinhardt
Patch attached. - Andreas From b2a09f78b72d6c54115166297a95d0fc093eac00 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 30 Mar 2025 17:26:05 +0200 Subject: [PATCH] configure: Allow mixing declarations and statements This C90 rule forces us to use a too big scope and should therefore

[FFmpeg-devel] [PATCH] avutil/tests/channel_layout: Improve enum range check

2025-03-30 Thread Andreas Rheinhardt
Patch attached. - Andreas From 052f9bba9924335ce03cd1bef0d54cd0a37e6dc5 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 30 Mar 2025 16:23:51 +0200 Subject: [PATCH] avutil/tests/channel_layout: Improve enum range check Both GCC and Clang use unsigned as underlying type of an enum wit

[FFmpeg-devel] [PATCH] avformat/rtpenc: Check dimensions during init

2025-03-30 Thread Andreas Rheinhardt
Obsoletes my earlier patch to fix the Wdeclaration-after-statement warning. - Andreas From 46e1284d95407f1b757f23aedf59fb9332f48913 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 30 Mar 2025 12:06:13 +0200 Subject: [PATCH] avformat/rtpenc: Check dimensions during init Also fixes a

Re: [FFmpeg-devel] [PATCH v2] configure: add option to select use of response files

2025-03-30 Thread Gyan Doshi
On 2025-03-29 10:42 am, Gyan Doshi wrote: On 2025-03-26 07:38 pm, Gyan Doshi wrote: --- v2:     *switched state and make var name to response_files     *changed option to standard action-optname format Plan to push tomorrow. Pushed as 64087171f67bab220c4d3001eb6b074cf488284c Regards, Gy

[FFmpeg-devel] [PATCH] avcodec/sbcdsp_data: Make data static

2025-03-30 Thread Andreas Rheinhardt
Patch attached - Andreas From 2e5b748fbd635aecb7a586679bedd6372acd79fd Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Fri, 7 Oct 2022 12:52:25 +0200 Subject: [PATCH] avcodec/sbcdsp_data: Make data static This data is only used by sbcdsp.c, so delete sbcdsp_data.h, make a header out of s

Re: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: add option to skip padding OBUs

2025-03-30 Thread Cameron Gutman
On Sat, Mar 29, 2025 at 4:02 PM Timo Rothenpieler wrote: > > On 29.03.2025 21:58, Cameron Gutman wrote: > > Some scenarios (such as game streaming or videoconferencing) may use CBR > > to strictly cap the maximum encoded bitrate, but they don't mind the > > bitrate falling below the target if the

[FFmpeg-devel] [PATCH 1/2] avcodec/ac3dec: Read spx flags at once, not one bit at a, time

2025-03-30 Thread Andreas Rheinhardt
Patches attached. - Andreas From d45f52c848de42ef40b0593330724de13324d921 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 30 Mar 2025 13:40:58 +0200 Subject: [PATCH 1/2] avcodec/ac3dec: Read spx flags at once, not one bit at a time Doing so gets rid of a stupid GCC -Wstringop-overf

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild: compose linker response files in a loop

2025-03-30 Thread Ramiro Polla
On Sun, Mar 30, 2025 at 8:53 AM Gyan Doshi wrote: > On 2025-03-30 11:57 am, Andreas Rheinhardt wrote: > > Gyan Doshi: > >> On 2025-03-29 11:52 pm, Martin Storsjö wrote: > >>> On Sat, 29 Mar 2025, Gyan Doshi wrote: > >>> > > Did you not try to use GNU make's flie function? > I just benched

[FFmpeg-devel] [PATCH] avcodec/dct: Make declarations and definitions match

2025-03-30 Thread Andreas Rheinhardt
Patch attached. - Andreas From 8a513c26c03983c7fcfd36a59a01c120e6abe0d1 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 30 Mar 2025 12:49:07 +0200 Subject: [PATCH] avcodec/dct: Make declarations and definitions match GCC considers declarations using a parameter of pointer type (or e

Re: [FFmpeg-devel] [PATCH] fftools/resorces: Add resource_manager with build-time compression

2025-03-30 Thread Michael Niedermayer
On Sat, Mar 29, 2025 at 05:27:10AM +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > [RFC] fftools/resorces: Add resource_manager with build-time compression > > Hello everybody, > > this is a resource manager implementation which I've done for

Re: [FFmpeg-devel] [PATCH v5] libavcodec/dvbsubenc.c: add a disable_2bpp option to work around some decoders.

2025-03-30 Thread Ronan Waide
> On 8 Mar 2025, at 08:02, Ronan Waide wrote: > > > >> On 2 Mar 2025, at 20:38, Soft Works >> wrote: >> >> >> >>> -Original Message- >>> From: ffmpeg-devel On Behalf Of Ronan >>> Waide >>> Sent: Sonntag, 2. März 2025 18:24 >>> To: ffmpeg-devel@ffmpeg.org >>> Cc: Ronan Waide >>>

[FFmpeg-devel] [PATCH] avformat/rtpenc: Fix declaration-after-statement warning

2025-03-30 Thread Andreas Rheinhardt
Patch attached. Will apply it tonight unless there are objections together with the other declaration-after-statement and unused-variable patch. Btw: I see no value in adhering to this ancient C90 rule. Can't we just drop it? - Andreas From f8405e877a434ca0b390b5d7f43599cde00a7974 Mon Sep 17 00:00

[FFmpeg-devel] [PATCH] avcodec/nvenc: Use CBR filler data consistently across codecs

2025-03-30 Thread Cameron Gutman
Previously, AV1 used filler data with CBR by default while H.264 and HEVC did not. Make this consistent by using filler data in CBR mode across all codecs. Since there are valid reasons to use CBR with or without filler, also add a cbr_padding option to allow users to opt out. Signed-off-by: Came

Re: [FFmpeg-devel] [PATCH v2] avcodec/nvenc: add option to skip padding OBUs

2025-03-30 Thread Cameron Gutman
On Sat, Mar 29, 2025 at 4:42 PM Timo Rothenpieler wrote: > > On 29.03.2025 22:37, Cameron Gutman wrote: > > On Sat, Mar 29, 2025 at 4:26 PM Timo Rothenpieler > > wrote: > >> > >> On 29.03.2025 22:17, Cameron Gutman wrote: > >>> On Sat, Mar 29, 2025 at 4:02 PM Timo Rothenpieler > >>> wrote: > >