Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Always use slot 0 with 1 l0 ref

2025-03-03 Thread David Rosca
On Tue, Mar 4, 2025 at 2:55 AM Wang, Fei W wrote: > > On Mon, 2025-03-03 at 14:47 +0100, David Rosca wrote: > > On Wed, Jan 15, 2025 at 10:41 PM David Rosca > > wrote: > > > > > > Don't need to alternate when only one reference is used. > > > Fixes fail after bf9f921ef7 ("avcodec/hw_base_encode:

Re: [FFmpeg-devel] FFmpeg Community Committee – Updates & Next Steps

2025-03-03 Thread Michael Niedermayer
Hi jb On Thu, Feb 27, 2025 at 12:11:39AM +0100, Jean-Baptiste Kempf wrote: > On Wed, 26 Feb 2025, at 02:51, Michael Niedermayer wrote: > > 1. I agree we need discussions, transparency and maybe IRC or some other > >audio/video form of commuication can be tried. Such discussion should be > >

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Always use slot 0 with 1 l0 ref

2025-03-03 Thread Wang, Fei W
On Mon, 2025-03-03 at 14:47 +0100, David Rosca wrote: > On Wed, Jan 15, 2025 at 10:41 PM David Rosca > wrote: > > > > Don't need to alternate when only one reference is used. > > Fixes fail after bf9f921ef7 ("avcodec/hw_base_encode: restrict size > > of next_prev") > > due to AV1 writer complaini

Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures

2025-03-03 Thread Nil Fons Miret via ffmpeg-devel
From what I can see, that one time it is called with constants in qrencode.c will never fail. I can remove that check, but I am a bit worried it will make it brittle if the internals of ff_draw_init* change later on, e.g. to introduce more failure modes. In fact, I ran across this issue while upgra

Re: [FFmpeg-devel] [PATCH 01/30] avcodec/mpegvideo_enc: Don't set qscale_table value

2025-03-03 Thread Andreas Rheinhardt
Ramiro Polla: > On Tue, Mar 4, 2025 at 12:37 AM Andreas Rheinhardt > wrote: >> Ramiro Polla: >>> On Mon, Mar 3, 2025 at 2:12 PM Andreas Rheinhardt >>> wrote: Andreas Rheinhardt: > Patches attached; the first few were already sent last year [1], but I > have refrained from pushin

Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures

2025-03-03 Thread Michael Niedermayer
On Mon, Mar 03, 2025 at 05:05:58PM -0800, Nil Fons Miret via ffmpeg-devel wrote: > From what I can see, that one time it is called with constants in > qrencode.c will never fail. I can remove that check, but I am a bit > worried it will make it brittle if the internals of ff_draw_init* > change lat

Re: [FFmpeg-devel] [PATCH v5 1/2] avformat/riffdec: change declaration of ff_get_wav_header()

2025-03-03 Thread Michael Niedermayer
On Mon, Feb 03, 2025 at 09:54:57AM +0530, Viraaj Raulgaonkar wrote: > Change the type of logctx from void* to AVFormatContext*. This is in > preparation for the next commit. > --- > libavformat/riff.h| 2 +- > libavformat/riffdec.c | 14 +++--- > 2 files changed, 8 insertions(+), 8 de

Re: [FFmpeg-devel] [PATCH 01/30] avcodec/mpegvideo_enc: Don't set qscale_table value

2025-03-03 Thread Ramiro Polla
On Tue, Mar 4, 2025 at 12:37 AM Andreas Rheinhardt wrote: > Ramiro Polla: > > On Mon, Mar 3, 2025 at 2:12 PM Andreas Rheinhardt > > wrote: > >> > >> Andreas Rheinhardt: > >>> Patches attached; the first few were already sent last year [1], but I > >>> have refrained from pushing them because Mich

Re: [FFmpeg-devel] [PATCH 01/30] avcodec/mpegvideo_enc: Don't set qscale_table value

2025-03-03 Thread Andreas Rheinhardt
Ramiro Polla: > Hi Andreas, > > On Mon, Mar 3, 2025 at 2:12 PM Andreas Rheinhardt > wrote: >> >> Andreas Rheinhardt: >>> Patches attached; the first few were already sent last year [1], but I >>> have refrained from pushing them because Michael seems to have trouble >>> testing them due to a conf

Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures

2025-03-03 Thread Michael Niedermayer
On Thu, Feb 20, 2025 at 10:31:57PM -0500, Nil Fons Miret via ffmpeg-devel wrote: > The return value of ff_draw_init and ff_draw_init2 are not checked in > most usages. However, if they return an error, they don't get to the > point where they set the attributes of the FFDrawContext. These > functio

[FFmpeg-devel] Request for help with decoding an mpeg2ts stream into a Unity app

2025-03-03 Thread Hanuma Teja Maddali
Hello, We're looking for someone who can help with creating a Unity package for decoding streaming video into Unity with minimal lag. From some googling, we've found a good set of ffmpeg and ffplay arguments to stream an mpeg2-ts udp stream with low latency on a windows desktop. ffplay -hwaccel cu

Re: [FFmpeg-devel] [PATCH] doc/filters: Add CUDA Video Filters section for CUDA-based and CUDA+NPP based filters.

2025-03-03 Thread Michael Niedermayer
Hi Danil On Sun, Mar 02, 2025 at 11:31:54AM +, Danil Iashchenko wrote: > --- > doc/filters.texi | 1353 -- > 1 file changed, 713 insertions(+), 640 deletions(-) make doc/ffmpeg-filters.html HTMLdoc/ffmpeg-filters.html *** Undefined node `CUDA N

Re: [FFmpeg-devel] [PATCH 01/30] avcodec/mpegvideo_enc: Don't set qscale_table value

2025-03-03 Thread Ramiro Polla
Hi Andreas, On Mon, Mar 3, 2025 at 2:12 PM Andreas Rheinhardt wrote: > > Andreas Rheinhardt: > > Patches attached; the first few were already sent last year [1], but I > > have refrained from pushing them because Michael seems to have trouble > > testing them due to a conflict [2] that existed by

[FFmpeg-devel] [PATCH v2] avcodec/aarch64/vvc: Optimize NEON version of vvc_dmvr

2025-03-03 Thread Krzysztof Pyrkosz via ffmpeg-devel
This patch replaces blocks of instructions performing rounding and widening shifts with one-liners achieving the same result. Before and after on A78 dmvr_8_12x20_neon: 86.2 ( 6.90x) dmvr_8_20x12_neon: 94.8 ( 5.93x) dmvr_8_2

[FFmpeg-devel] [PATCH v2] avcodec/aarch64/vvc: Optimize vvc_avg{8, 10, 12}

2025-03-03 Thread Krzysztof Pyrkosz via ffmpeg-devel
This patch replaces integer widening with halving addition, and multi-step "emulated" rounding shift with a single asm instruction doing exactly that. Benchmarks before and after: A78 avg_8_64x64_neon: 2686.2 ( 6.12x) avg_8_128x128_neon:

[FFmpeg-devel] [PATCH v2] swscale/aarch64: dotprod implementation of rgba32_to_Y

2025-03-03 Thread Krzysztof Pyrkosz via ffmpeg-devel
The idea is to split the 16 bit coefficients into lower and upper half, invoke udot for the lower half, shift by 8, and follow by udot for the upper half. Benchmark on A78: bgra_to_y_128_c: 682.0 ( 1.00x) bgra_to_y_128_neon:

[FFmpeg-devel] [PATCH v3] Mark C globals with small code model

2025-03-03 Thread Pranav Kant via ffmpeg-devel
By default, all globals in C/C++ compiled by clang are allocated in non-large data sections. See [1] for background on code models. For PIC (Position independent code), this is fine as long as binary is small but as binary size increases, users maybe want to use medium/large code models (-mcmodel=m

Re: [FFmpeg-devel] [PATCH] vulkan: take refs of frames using the regular buffer ref path

2025-03-03 Thread Lynne
On 02/03/2025 00:02, Lynne wrote: This simplifies the code, reduces allocations, and critically, does not store references of frames, along with references to hw_frames_ctx. The issue was that storing refs to frames while transferring stored refs to hw_frames_ctx of frames, and so created a circu

Re: [FFmpeg-devel] [PATCH v2] avcodec/libwebpenc_anim: support setting the duration of the last frame

2025-03-03 Thread James Zern via ffmpeg-devel
Hi, On Fri, Feb 28, 2025 at 1:47 AM wangyaqiang via ffmpeg-devel wrote: > > From: Wang Yaqiang > > Signed-off-by: Wang Yaqiang > --- > libavcodec/libwebpenc_animencoder.c | 17 +++-- > libavcodec/libwebpenc_common.c | 2 ++ > libavcodec/libwebpenc_common.h | 1 + > 3 fi

Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures

2025-03-03 Thread Nil Fons Miret via ffmpeg-devel
Hi, any feedback on this? Thank you On Thu, Feb 20, 2025 at 7:31 PM Nil Fons Miret wrote: > > The return value of ff_draw_init and ff_draw_init2 are not checked in > most usages. However, if they return an error, they don't get to the > point where they set the attributes of the FFDrawContext. Th

Re: [FFmpeg-devel] [PATCH] swscale/x86/rgb2rgb: optimize AVX2 version of uyvytoyuv422

2025-03-03 Thread Shreesh Adiga
On Thu, Feb 20, 2025 at 6:51 PM Shreesh Adiga <16567adigashre...@gmail.com> wrote: > > Currently the AVX2 version of uyvytoyuv422 in the SIMD loop does the > following: > 4 vinsertq to have interleaving of the vector lanes during load from memory. > 4 vperm2i128 inside 4 RSHIFT_COPY calls to achie

Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-03 Thread Devin Heitmueller
On Mon, Mar 3, 2025 at 7:25 AM Tomas Härdin wrote: > > Looking at CTA-708 at the moment and noticed this. In the future we > might want to make it possible for the user to set the country code. > This patch makes finding usage of the US country code easier I've got no objection to moving a consta

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_av1: Always use slot 0 with 1 l0 ref

2025-03-03 Thread David Rosca
On Wed, Jan 15, 2025 at 10:41 PM David Rosca wrote: > > Don't need to alternate when only one reference is used. > Fixes fail after bf9f921ef7 ("avcodec/hw_base_encode: restrict size of > next_prev") > due to AV1 writer complaining about incorrect ref_order_hint value. Ping. > --- > libavcodec

Re: [FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-03 Thread Andreas Rheinhardt
Tomas Härdin: > #include "libavutil/mem.h" > #include "atsc_a53.h" > +#include "itut35.h" > #include "get_bits.h" > Proper alphabetical ordering please. Here and in the other files. - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] [PATCH 01/30] avcodec/mpegvideo_enc: Don't set qscale_table value

2025-03-03 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Patches attached; the first few were already sent last year [1], but I > have refrained from pushing them because Michael seems to have trouble > testing them due to a conflict [2] that existed by the time he tried to > test it. > > - Andreas > > [1]: https://ffmpeg.org/pipe

[FFmpeg-devel] [PATCH] lavc: Replace 181 magic number with ITU_T_T35_COUNTRY_CODE_US

2025-03-03 Thread Tomas Härdin
Looking at CTA-708 at the moment and noticed this. In the future we might want to make it possible for the user to set the country code. This patch makes finding usage of the US country code easier Running FATE at the moment, but I don't expected it to fail from this kind of change. /Tomas From 4

Re: [FFmpeg-devel] [PATCH] avfilter/dnn_detect: fail on filter if mandatory anchor option is missing

2025-03-03 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Chen, > Wenbin > Sent: Thursday, February 27, 2025 10:41 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avfilter/dnn_detect: fail on filter if > mandatory anchor option i

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/dnn: do not manually parse anchors filter option

2025-03-03 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Chen, > Wenbin > Sent: Thursday, February 27, 2025 10:39 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avfilter/dnn: do not manually parse > anchors filter option >