[FFmpeg-devel] [PATCH v5 3/3] avcodec/hevc: Add alpha layer support

2025-02-09 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevcdec.c | 72 ++- libavcodec/hevc/hevcdec.h | 2 ++ libavcodec/hevc/refs.c| 11 +- 3 files changed, 83 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec

[FFmpeg-devel] [PATCH v5 1/3] avcodec/hevc: Rewrite scalability_mask_flag parse in decode_vps_ext

2025-02-09 Thread Zhao Zhili
From: Zhao Zhili Remove a for loop and make it easy to extend to support other types of scalability. Move ScalabilityMask to hevc header file so it can be used in hevc decoder. Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevc.h | 7 +++ libavcodec/hevc/ps.c | 33 +++---

[FFmpeg-devel] [PATCH v5 2/3] avcodec/hevc/ps: Add basic HEVC_SCALABILITY_AUXILIARY support

2025-02-09 Thread Zhao Zhili
From: Zhao Zhili Only implementing what's needed for HEVC with alpha. Signed-off-by: Zhao Zhili --- libavcodec/hevc/hevc.h | 5 ++ libavcodec/hevc/ps.c | 125 + libavcodec/hevc/ps.h | 1 + 3 files changed, 95 insertions(+), 36 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau
> On Feb 10, 2025, at 11:08, Marth64 wrote: > > I don't think its fair to shoot this down, its a simple but valid tidy up > work. > I find typos and such when browsing code distracting and readability > important down the road. > Not everyone's first language is English and grammar correction

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Marth64
I don't think its fair to shoot this down, its a simple but valid tidy up work. I find typos and such when browsing code distracting and readability important down the road. Not everyone's first language is English and grammar correction may not come instinctively. Thank you for the contribution J

Re: [FFmpeg-devel] Captions SCC

2025-02-09 Thread Devlist Archive
I believe I have sorted out the embed/extract issues I encountered into a formatting issue with the .scc file and lack of eia-608 codec for embedding captions. It is possible this might be a result of an oversight regarding drop frame or non drop frame time codes with some part of the chain that h

Re: [FFmpeg-devel] [PATCH] aacenc: move to libavcodec/aac/

2025-02-09 Thread Michael Niedermayer
Hi Lynne On Sat, Feb 08, 2025 at 06:32:12AM +0100, Lynne wrote: [...] > index 70b1dca274..489fa9f67a 100644 > --- a/libavcodec/aac/Makefile > +++ b/libavcodec/aac/Makefile > @@ -1,6 +1,8 @@ > clean:: > $(RM) $(CLEANSUFFIXES:%=libavcodec/aac/%) > > +OBJS-$(CONFIG_AAC_ENCODER)

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec: add AV_CODEC_ID_IVTV_VBI

2025-02-09 Thread Marth64
Pushed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: fix seeking on multi-angle discs

2025-02-09 Thread Marth64
Will push soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau
> On Feb 10, 2025, at 09:36, Soft Works > wrote: > > > >> -Original Message- >> From: ffmpeg-devel > > On Behalf Of >> Jack Lau >> Sent: Monday, February 10, 2025 2:13 AM >> To: FFmpeg development discussions and patches > de...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Jack Lau > Sent: Monday, February 10, 2025 2:13 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is > an extra space in the original comment

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau
Hi, Thanks for your reply. I'm trying to fix some issues with hls. I happened to see this typo. Since I saw in the ffmpeg documentation that cosmetic changes should be kept in separate patches, so i submitted it first. Thank you for your advice, I will try my best to submit more important pat

Re: [FFmpeg-devel] [PATCH v2 5/6] avcodec/hevc/sei: dynamically allocate 3D Reference Displays Information SEI messages

2025-02-09 Thread James Almer
On 2/9/2025 9:53 PM, Michael Niedermayer wrote: Hi On Wed, Feb 05, 2025 at 11:50:17PM -0300, James Almer wrote: Considerably reduces the size of HEVCSEI. Signed-off-by: James Almer --- Fixed segfaults. libavcodec/hevc/hevcdec.c | 10 +- libavcodec/hevc/refs.c| 4 ++-- libavc

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Jack Lau via ffmpeg-devel > Sent: Monday, February 10, 2025 1:34 AM > To: ffmpeg-devel@ffmpeg.org > Cc: Jack Lau > Subject: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an > extra space in the original comment > > ---

Re: [FFmpeg-devel] [PATCH v2 5/6] avcodec/hevc/sei: dynamically allocate 3D Reference Displays Information SEI messages

2025-02-09 Thread Michael Niedermayer
Hi On Wed, Feb 05, 2025 at 11:50:17PM -0300, James Almer wrote: > Considerably reduces the size of HEVCSEI. > > Signed-off-by: James Almer > --- > Fixed segfaults. > > libavcodec/hevc/hevcdec.c | 10 +- > libavcodec/hevc/refs.c| 4 ++-- > libavcodec/hevc/sei.c | 6 +- > l

[FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau via ffmpeg-devel
--- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3bdc1bc848..c2130bb883 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1993,7 +1993,7 @@ static int hls_read_header(AVFormatContext *s) return r

Re: [FFmpeg-devel] [PATCH] avformat/unix: Set is_streamed to true

2025-02-09 Thread Michael Niedermayer
Hi Efrain On Wed, Feb 05, 2025 at 07:25:23PM -0600, Efrain Torres wrote: > Currently when a Unix Domain Socket is used as input there is a loss of data > when data is consumed from the stream. Setting is_streamed to true fixes > this, since the unix domain socket is now treated like a consumable s

Re: [FFmpeg-devel] [PATCH v2 2/2] random_seed: Improve behaviour with small timer increments with high precision timers

2025-02-09 Thread Michael Niedermayer
Hi Martin On Fri, Feb 07, 2025 at 12:04:53AM +0200, Martin Storsjö wrote: > On Thu, 6 Feb 2025, Michael Niedermayer wrote: > > > On Thu, Feb 06, 2025 at 02:38:48PM +0200, Martin Storsjö wrote: > > > On Thu, 6 Feb 2025, Michael Niedermayer wrote: > > > > > > > > +// If the timer resol

Re: [FFmpeg-devel] Captions SCC

2025-02-09 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marth64 > Sent: Sunday, February 9, 2025 9:23 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > On Sun, Feb 9, 2025 at 2:14 PM Soft Works > wrote: > > Numpad ali

Re: [FFmpeg-devel] Captions SCC

2025-02-09 Thread Marth64
On Sun, Feb 9, 2025 at 2:14 PM Soft Works wrote: > Numpad alignment 7, LeftMargin=x VertMargin=y Yeah, that could work. I forgot about margins. I'll play around with it. Thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/m

Re: [FFmpeg-devel] Captions SCC

2025-02-09 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Marth64 > Sent: Sunday, February 9, 2025 8:38 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > Partial reply: > FFmpeg's CC decoder is actually pretty decent fo

Re: [FFmpeg-devel] Captions SCC

2025-02-09 Thread Marth64
Partial reply: FFmpeg's CC decoder is actually pretty decent for pop-on CC but produces non-compliant ASS that needs postprocessing. ASS can cover and render the pop-ons quite well, but the fundamental limitation with representing EIA608 with ASS is that ASS does not allow arbitrary positioning AN

Re: [FFmpeg-devel] Captions SCC

2025-02-09 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Devlist Archive > Sent: Sunday, February 9, 2025 6:42 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Captions SCC > > > > > Not to start an argument, but WebVTT is kind of a te

Re: [FFmpeg-devel] Captions SCC

2025-02-09 Thread Tom Vaughan
I suspect WebVTT became the modern CC format because... - It is natively supported by the HLS and DASH specifications - https://developer.apple.com/documentation/http-live-streaming/hls-authoring-specification-for-apple-devices - https://reference.dashif.org/dash.js/latest/samples

Re: [FFmpeg-devel] Captions SCC

2025-02-09 Thread Devlist Archive
> > Not to start an argument, but WebVTT is kind of a terrible format. > It's a lowest common denominator and loses most formatting information > available even in 608 (which is now more than 40 years old). Stuff > like rollup captions for live programming, color (to distinguish > speakers) and ca

Re: [FFmpeg-devel] lavfi: fix undefined ff_vk_shader_print if vulkan filters are disabled

2025-02-09 Thread Wang Bin
Lynne 于2025年1月16日周四 16:19写道: > >> On 16/01/2025 15:24, Wang Bin wrote: >> > >> > >> > ___ >> > ffmpeg-devel mailing list >> > ffmpeg-devel@ffmpeg.org >> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> > >> > To unsubscribe, visit link above, or ema

[FFmpeg-devel] [PATCH 1/2] lavc/vvc: Fix slice map construction for small subpics

2025-02-09 Thread Frank Plowman
In the case pps_subpic_less_than_one_tile_slice is called, the subpicture is smaller than the tile and so there are multiple subpictures in the tile. Of course, then, not all the subpictures can start in the top-left corner as the code before the patch does. Patch fixes this, so each subpicture s

[FFmpeg-devel] [PATCH 2/2] lavc/vvc: Ensure subpictures don't overlap

2025-02-09 Thread Frank Plowman
This is essentially a re-implementation of https://patchwork.ffmpeg.org/project/ffmpeg/patch/20241005223955.54158-1-p...@frankplowman.com/ That patch was not applied last time. Instead we opted to identify issues which could be caused by invalid subpicture layouts and remedy those issues where th

Re: [FFmpeg-devel] Captions SCC

2025-02-09 Thread Devin Heitmueller
On Sat, Feb 8, 2025 at 10:39 PM Tom Vaughan wrote: > > I'm excited to see this discussion. There are many leading video distributors > (streaming services, etc.) that would love to see solid support in FFMPEG for > closed captions. No promises, but my sense is that additional money can be > rai

[FFmpeg-devel] [PATCH] tools: Add binaries to .gitignore

2025-02-09 Thread Frank Plowman
Signed-off-by: Frank Plowman --- tools/.gitignore | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/.gitignore b/tools/.gitignore index 7c45896923..f017fa2343 100644 --- a/tools/.gitignore +++ b/tools/.gitignore @@ -3,6 +3,7 @@ /bisect.need /crypto_bench /cws2fws +/enc_reco

[FFmpeg-devel] [PATCH v2] avfilter/scale*: add option reset_sar

2025-02-09 Thread Gyan Doshi
For anamorphic videos, enabling this option leads to adjustment of output dimensions to obtain square pixels when the user requests proportional scaling through either of the w/h expressions or force_original_aspect_ratio. Output SAR is always reset to 1. Option added to scale, scale_cuda, scale_