Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-01-31 Thread Zhao Zhili
> On Feb 1, 2025, at 08:49, Michael Niedermayer wrote: > > Hi James > > On Fri, Jan 31, 2025 at 12:44:50PM -0300, James Almer wrote: >> On 1/31/2025 11:58 AM, Nicolas George wrote: >>> Niklas Haas (12025-01-30): > [...] >>> On the other hand, I believe this whole plan is a bad idea. >> Yes, it

Re: [FFmpeg-devel] [PATCH] avdevice/alsa_dec: add a ch_layout option

2025-01-31 Thread James Almer
On 1/31/2025 11:01 PM, Michael Niedermayer wrote: On Fri, Jan 31, 2025 at 10:45:13PM -0300, James Almer wrote: On 1/31/2025 10:43 PM, Michael Niedermayer wrote: On Tue, Jan 28, 2025 at 09:57:57AM -0300, James Almer wrote: Missed in ffc4fd3cc2ccb2cadb71f19849842b18ca1281c6, which after e7817355

Re: [FFmpeg-devel] [PATCH] avformat: add DAT (Digital Audio Tape) demuxer

2025-01-31 Thread Michael Niedermayer
Hi Jerome On Wed, Jan 29, 2025 at 06:02:57PM +0100, Jerome Martinez wrote: > Le 25/01/2025 à 01:46, Michael Niedermayer a écrit : > > [...] > > this passes tests. > > > > but if you want, you could instead of testing "extra metadata (not needed > > for decoding)" > > test more than 1 packet > >

Re: [FFmpeg-devel] [PATCH] avdevice/alsa_dec: add a ch_layout option

2025-01-31 Thread Michael Niedermayer
On Fri, Jan 31, 2025 at 10:45:13PM -0300, James Almer wrote: > On 1/31/2025 10:43 PM, Michael Niedermayer wrote: > > On Tue, Jan 28, 2025 at 09:57:57AM -0300, James Almer wrote: > > > Missed in ffc4fd3cc2ccb2cadb71f19849842b18ca1281c6, which after > > > e78173557da898f18a78241cc3525b76694164b5 brok

Re: [FFmpeg-devel] [PATCH] avdevice/alsa_dec: add a ch_layout option

2025-01-31 Thread James Almer
On 1/31/2025 10:43 PM, Michael Niedermayer wrote: On Tue, Jan 28, 2025 at 09:57:57AM -0300, James Almer wrote: Missed in ffc4fd3cc2ccb2cadb71f19849842b18ca1281c6, which after e78173557da898f18a78241cc3525b76694164b5 broke setting channel count. Should fix ticket #11434. Signed-off-by: James Al

Re: [FFmpeg-devel] [PATCH] avdevice/alsa_dec: add a ch_layout option

2025-01-31 Thread Michael Niedermayer
On Tue, Jan 28, 2025 at 09:57:57AM -0300, James Almer wrote: > Missed in ffc4fd3cc2ccb2cadb71f19849842b18ca1281c6, which after > e78173557da898f18a78241cc3525b76694164b5 broke setting channel count. > > Should fix ticket #11434. > > Signed-off-by: James Almer > --- > libavdevice/alsa.h

[FFmpeg-devel] [PATCH] avformat/mov: fix parsing lhvc boxes with no NALU arrays

2025-01-31 Thread James Almer
Return if the box is empty at the point the arrays should start. Signed-off-by: James Almer --- libavformat/mov.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2c8be51063..05afda4169 100644 --- a/libavformat/mov.c +++ b

Re: [FFmpeg-devel] [PATCH] fix pad artifacting

2025-01-31 Thread Michael Niedermayer
Hi On Sat, Feb 01, 2025 at 12:18:08AM +, Ben Lu via ffmpeg-devel wrote: > When using pad with eval=frame with variable frame sizes, we get > significant artifacting. This is due to incorrect frame sizes, resulting in > invalid frames. Made changes to use the output width and height for frame >

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-01-31 Thread Michael Niedermayer
Hi James On Fri, Jan 31, 2025 at 12:44:50PM -0300, James Almer wrote: > On 1/31/2025 11:58 AM, Nicolas George wrote: > > Niklas Haas (12025-01-30): [...] > > On the other hand, I believe this whole plan is a bad idea. > Yes, it is a bad idea. We have had the current system in place for about > fiv

[FFmpeg-devel] [PATCH] fix pad artifacting

2025-01-31 Thread Ben Lu via ffmpeg-devel
When using pad with eval=frame with variable frame sizes, we get significant artifacting. This is due to incorrect frame sizes, resulting in invalid frames. Made changes to use the output width and height for frame sizes when using eval=frame, with if statement guards to make sure the normal usage

[FFmpeg-devel] [PATCH 1/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-01-31 Thread Michael Niedermayer
Maybe fixes: 11435 Signed-off-by: Michael Niedermayer --- libavformat/hls.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index d2787ade46b..e8b7cf40068 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -754,6 +754,10 @@ static int test_seg

Re: [FFmpeg-devel] [PATCH] avcodec/h263dec: Check against previous dimensions instead of coded

2025-01-31 Thread Michael Niedermayer
On Thu, Jan 30, 2025 at 09:15:23AM +0100, Kacper Michajlow wrote: > On Thu, 30 Jan 2025 at 02:57, Michael Niedermayer > wrote: > > > > Fixes: out of array access > > Fixes: crash-a41ef3db699013f669b076f02f36942925f5a98c > > > > Found-by: Kacper Michajlow > > Signed-off-by: Michael Niedermayer >

[FFmpeg-devel] [PATCH 2/2] libavformat/hls: Be more restrictive on mpegts extensions

2025-01-31 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/hls.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index e8b7cf40068..8eae64b787e 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -758,8 +758,10 @@ static int test_segme

[FFmpeg-devel] [PATCH] swscale/aarch64/output.S: refactor ff_yuv2plane1_8_neon

2025-01-31 Thread Krzysztof Pyrkosz via ffmpeg-devel
The benchmarks (before vs after) were gathered using ./tests/checkasm/checkasm --test=sw_scale --bench --runs=6 | grep yuv2yuv1 A78 before: yuv2yuv1_0_512_accurate_c:2039.5 ( 1.00x) yuv2yuv1_0_512_accurate_neon: 385.5 ( 5.29x) yuv2yuv1_0_512_ap

[FFmpeg-devel] [PATCH v2 6/6] avcodec/hevc/hevcdec: export 3D Reference Displays side data

2025-01-31 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc/hevcdec.c | 57 ++- 1 file changed, 56 insertions(+), 1 deletion(-) Now actually filling the correct side data array. diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c index 7d3e844945..db97d9b0a

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-01-31 Thread James Almer
On 1/31/2025 11:58 AM, Nicolas George wrote: Niklas Haas (12025-01-30): This should be time-gated to count only commits in the recent, say, 3 years (to match the current GA cycle). Counting purely historical commits seems odd. On the other hand, we should give more weight to the opinion of peo

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-01-31 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Friday, January 31, 2025 4:45 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Democratization work in progress draft v2 > > > Past involvement, including long-past involvement, is not only > pas

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-01-31 Thread Nicolas George
Niklas Haas (12025-01-30): > This should be time-gated to count only commits in the recent, say, 3 > years (to match the current GA cycle). Counting purely historical > commits seems odd. On the other hand, we should give more weight to the opinion of people who have been around for many years and

Re: [FFmpeg-devel] Democratization work in progress draft v2

2025-01-31 Thread Nicolas George
Michael Niedermayer (12025-01-30): > If instead of a hypothetical case, you use real cases > like for example any successfull company (not just on the stock market > but that too) If we compare ffmpeg to a company (a dangerous comparison, as the goals of FFmpeg are quite different, but let us roll

[FFmpeg-devel] [PATCH 6/6] avcodec/hevc/hevcdec: export 3D Reference Displays side data

2025-01-31 Thread James Almer
Signed-off-by: James Almer --- libavcodec/hevc/hevcdec.c | 37 + 1 file changed, 37 insertions(+) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c index 7d3e844945..91119fbc58 100644 --- a/libavcodec/hevc/hevcdec.c +++ b/libavcodec/hevc/hevcd

[FFmpeg-devel] [PATCH 2/6] avutil/frame: add a 3D Reference Displays Information side data type

2025-01-31 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 1 + libavutil/frame.h | 11 +++ 2 files changed, 12 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 992115e04f..d1566298ae 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -59,6 +59,7 @@ static const AVS

[FFmpeg-devel] [PATCH 5/6] avfilter/vf_showinfo: add support for 3D Reference Displays Information side data

2025-01-31 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 12 1 file changed, 12 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 8109ca7fce..c706d00c96 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -38,6 +38,7 @@ #

[FFmpeg-devel] [PATCH 4/6] avformat/dump: add support for 3D Reference Displays Information side data

2025-01-31 Thread James Almer
Signed-off-by: James Almer --- libavformat/dump.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 3d37623a41..f19ee584b1 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -37,6 +37,7 @@ #include "libavutil/replaygain.h"

[FFmpeg-devel] [PATCH 3/6] avcodec/packet: add a 3D Reference Displays Information side data type

2025-01-31 Thread James Almer
Signed-off-by: James Almer --- libavcodec/avcodec.c | 1 + libavcodec/packet.c | 1 + libavcodec/packet.h | 11 +++ 3 files changed, 13 insertions(+) diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c index e7e2c09222..fe19d99a84 100644 --- a/libavcodec/avcodec.c +++ b/libavcod

[FFmpeg-devel] [PATCH 1/6] avutil: add an API to handle 3D Reference Displays Information

2025-01-31 Thread James Almer
As defined in section G.14.3.2.3 of ITU-T H.265, it's required for proper signaling of MV-HEVC. Signed-off-by: James Almer --- libavutil/Makefile | 2 + libavutil/tdrdi.c | 35 libavutil/tdrdi.h | 129 + 3 files changed, 166 insertio

Re: [FFmpeg-devel] [PATCH 8/9] avcodec/nvenc: use encoder level options for qmin/qmax

2025-01-31 Thread Timo Rothenpieler
On 31/01/2025 07:16, Zhao Zhili wrote: On Jan 31, 2025, at 03:40, Timo Rothenpieler wrote: AV1 uses a vastly different range than what the global options permit, and also for the other codecs the range of the global options is at least misaligned. It ’s simpler to update qmin upper thresho

[FFmpeg-devel] [PATCH] avfilter/scale*: add option reset_sar

2025-01-31 Thread Gyan Doshi
For anamorphic videos, enabling this option leads to adjustment of output dimensions to obtain square pixels when the user requests proportional scaling through either of the w/h expressions or force_original_aspect_ratio. Output SAR is always reset to 1. Option added to scale, scale_cuda, scale_

Re: [FFmpeg-devel] GSoC 2025

2025-01-31 Thread James Almer
On 1/30/2025 6:20 PM, Koushik Dutta wrote: Why gitlab and not GitHub? If the intent is on making contribution from new developers easier, I think the workflow should be where the majority of developers are actively participating. The point is having full control of it, and not host the main repo

Re: [FFmpeg-devel] [PATCH v3] avformat/riffdec: warn on invalid sample rate

2025-01-31 Thread Marton Balint
On Fri, 31 Jan 2025, Viraaj Raulgaonkar wrote: On Fri, Jan 31, 2025 at 4:49 AM Marton Balint wrote: On Thu, 30 Jan 2025, Viraaj Raulgaonkar wrote: > If std_strict_compliance < FF_COMPLIANCE_STRICT, then warn the user of > the invalid sample rate instead of returning an error. This allows