Re: [FFmpeg-devel] Democratization

2025-01-28 Thread Zhao Zhili
> On Jan 29, 2025, at 02:21, Michael Niedermayer wrote: > > Hi Marth64 > > while this wasnt a reply to me, some comments from me > > On Sun, Jan 26, 2025 at 04:01:17PM -0600, Marth64 wrote: >> Hi, >> >> That is what I am imagining when I mean have a meeting, suggesting >> that maybe we shoul

Re: [FFmpeg-devel] [PATCH] ffmpeg_demux: don't print input error for AVERROR_EXIT

2025-01-28 Thread Gyan Doshi
On 2025-01-27 10:48 am, Gyan Doshi wrote: This error code is for expected exits, like after listing options for a device. Plan to push tomorrow. Regards, Gyan --- fftools/ffmpeg_demux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_demux.c b/f

Re: [FFmpeg-devel] [PATCH] avcodec/speexdec: limit max frame_size

2025-01-28 Thread slbtty
Still not 100% certain about the reason, but this works for both #11054 and #11078. The max value of s->mode is 2 which means ultra wide band? --- libavcodec/speexdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/speexdec.c b/libavcodec/speexdec.c index d25

Re: [FFmpeg-devel] [PATCH] avcodec/speexdec: limit max frame_size

2025-01-28 Thread slbtty
Correction: this fix the sample from #11054 but not #11078. Still trying to figure out why. > On Jan 28, 2025, at 8:21 PM, shenleban tongying > wrote: > > The max frame_size for speex format is 32000 Hz * 20 ms / 1000 ms = 640 > > close #11054 and #11078 > > Signed-off-by: shenleban tongyin

[FFmpeg-devel] [PATCH] avcodec/speexdec: limit max frame_size

2025-01-28 Thread shenleban tongying
The max frame_size for speex format is 32000 Hz * 20 ms / 1000 ms = 640 close #11054 and #11078 Signed-off-by: shenleban tongying --- libavcodec/speexdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/speexdec.c b/libavcodec/speexdec.c index d25823ef6e..555012a34

[FFmpeg-devel] [PATCH] avformat/mov: fix overflow in drift timestamp calculation

2025-01-28 Thread James Almer
Fixes: signed integer overflow: 7803923888585309955 - -3407677434275325337 cannot be represented in type 'int64_t' (aka 'long') Fixes: 377736723/clusterfuzz-testcase-minimized-media_pipeline_integration_fuzzer-5052449500889088 Signed-off-by: James Almer --- libavformat/mov.c | 2 +- 1 file cha

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-01-28 Thread Michael Niedermayer
Hi On Tue, Jan 28, 2025 at 10:12:30PM +0200, Jan Ekström wrote: > On Tue, Jan 28, 2025 at 4:24 PM Michael Niedermayer > wrote: > > > > Maybe fixes: 11435 > > > > Do I understand correctly that the root issue that's being attempted > to be fixed by the initial patch set is that unusual demuxers w

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-01-28 Thread Michael Niedermayer
Hi On Tue, Jan 28, 2025 at 10:12:30PM +0200, Jan Ekström wrote: > On Tue, Jan 28, 2025 at 4:24 PM Michael Niedermayer > wrote: > > > > Maybe fixes: 11435 > > > > Do I understand correctly that the root issue that's being attempted > to be fixed by the initial patch set is that unusual demuxers w

Re: [FFmpeg-devel] [PATCH] avformat/id3v2: add image/webp for WebP attached pictures

2025-01-28 Thread Jan Ekström
On Mon, Jan 27, 2025 at 9:56 PM Jan Ekström wrote: > > On Sat, Jan 25, 2025 at 9:38 PM Jan Ekström wrote: > > > > Found out to have been utilized via a user reporting an attached > > image not being available in a player utilizing avformat's demuxing > > capabilities. > > --- > > Asked around in

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-01-28 Thread Jan Ekström
On Tue, Jan 28, 2025 at 4:24 PM Michael Niedermayer wrote: > > Maybe fixes: 11435 > Do I understand correctly that the root issue that's being attempted to be fixed by the initial patch set is that unusual demuxers were possible to have been probed and opened through the HLS meta demuxer? In that

[FFmpeg-devel] [PATCH 1/2] doc/filters: Add CUDA Video Filters section for CUDA-based and CUDA+NPP based filters.

2025-01-28 Thread Danil Iashchenko
--- doc/filters.texi | 687 +++ 1 file changed, 687 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index a14c7e7e77..c4f312d2b8 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -26890,6 +26890,693 @@ value. @c man end VIDEO FIL

[FFmpeg-devel] [PATCH 2/2] doc/filters: Remove redundant *_cuda and *_npp filters since they are already in CUDA Video Filters section

2025-01-28 Thread Danil Iashchenko
--- doc/filters.texi | 630 +-- 1 file changed, 10 insertions(+), 620 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index c4f312d2b8..28be8920fd 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -8619,45 +8619,6 @@ Set planes to fi

Re: [FFmpeg-devel] Democratization

2025-01-28 Thread Michael Niedermayer
Hi Marth64 while this wasnt a reply to me, some comments from me On Sun, Jan 26, 2025 at 04:01:17PM -0600, Marth64 wrote: > Hi, > > That is what I am imagining when I mean have a meeting, suggesting > that maybe we should try a different communication medium that can be > facilitated more rapidl

Re: [FFmpeg-devel] [PATCH] tests/checkasm/sw_rgb: increase plane array buffers

2025-01-28 Thread epirat07
On 28 Jan 2025, at 18:43, James Almer wrote: > Fixes stack-buffer-overflow errors running under asan. > > Signed-off-by: James Almer > --- > tests/checkasm/sw_rgb.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/tests/checkasm/sw_rgb.c b/tests/checkas

[FFmpeg-devel] [PATCH] swscale/aarch64/rgb2rgb: Implemented NEON shuf routines

2025-01-28 Thread Krzysztof Pyrkosz via ffmpeg-devel
The key idea is to pass the pre-generated tables to the TBL instruction and churn through the data 16 bytes at a time. The remaining 4 elements are handled with a specialized block located at the end of the routine. The 3210 variant can be implemented using rev32, but surprisingly it is slower tha

Re: [FFmpeg-devel] [PATCH] rtmpproto: Avoid rare crashes in the fail: codepath in rtmp_open

2025-01-28 Thread Martin Storsjö
On Tue, 28 Jan 2025, Martin Storsjö wrote: On Thu, 23 Jan 2025, Martin Storsjö wrote: When running the cleanup in rtmp_close on failures in rtmp_open, we can in rare cases end up using rt->playpath, assuming that it is still set. The crash could happen if we hit the fail codepath in rtmp_open

Re: [FFmpeg-devel] [PATCH] configure: Improve the check for the rsync --contimeout option

2025-01-28 Thread Martin Storsjö
On Tue, 28 Jan 2025, epira...@gmail.com wrote: On 24 Jan 2025, at 22:40, Martin Storsjö wrote: Traditionally, macOS has shipped an old version of rsync that lacked support for this version, hence this check (added in a8b3f0c5cf548f654e30c981988bb71981a3f8d3). However, in macOS 15.x, they have

Re: [FFmpeg-devel] [PATCH] avutil/downmix_info: check for side data allocation success before zeroing it

2025-01-28 Thread epirat07
On 28 Jan 2025, at 18:49, James Almer wrote: > Fixes coverity #1641638. > > Signed-off-by: James Almer > --- > libavutil/downmix_info.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavutil/downmix_info.c b/libavutil/downmix_info.c > index feaee28493..7e6c3e854d

[FFmpeg-devel] [PATCH] avutil/downmix_info: check for side data allocation success before zeroing it

2025-01-28 Thread James Almer
Fixes coverity #1641638. Signed-off-by: James Almer --- libavutil/downmix_info.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/downmix_info.c b/libavutil/downmix_info.c index feaee28493..7e6c3e854d 100644 --- a/libavutil/downmix_info.c +++ b/libavutil/downmix_in

Re: [FFmpeg-devel] [PATCH] avutil/frame: check return value for cropping offsets

2025-01-28 Thread Leo Izen
On 1/21/25 7:34 AM, Leo Izen wrote: This function can return AVERROR_BUG in theory if something went wrong, but so can the caller, so we should propagate that error message upward in that case. Signed-off-by: Leo Izen --- libavutil/frame.c | 9 +++-- 1 file changed, 7 insertions(+), 2 de

[FFmpeg-devel] [PATCH] tests/checkasm/sw_rgb: increase plane array buffers

2025-01-28 Thread James Almer
Fixes stack-buffer-overflow errors running under asan. Signed-off-by: James Almer --- tests/checkasm/sw_rgb.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c index 5714bfaa1e..5808cd79e4 100644 --- a/tests/c

[FFmpeg-devel] [PATCH] libavformat/mov.c: fix seek issues for fragmented mp4 files

2025-01-28 Thread Srikanth Kiran Kotagiri
From: Srikanth Kiran Kotagiri For Fragmented MP4 files where the audio and video streams are written to seperate fragments, the -ss option will cause the file pointer to be set to the first available fragment. This is due to an interaction in search_frag_timestamp() function and get_frag_time(

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: fix seek issues for fragmented mp4 files

2025-01-28 Thread Srikanth Kotagiri
please ignore this patch. I will submit a corrected one. On Mon, Jan 27, 2025 at 5:20 PM Srikanth Kiran Kotagiri wrote: > > For Fragmented MP4 files where the audio and video streams are written to > seperate fragments, the -ss option will cause the file pointer to be set to > the first availab

Re: [FFmpeg-devel] [PATCH] configure: Improve the check for the rsync --contimeout option

2025-01-28 Thread epirat07
On 24 Jan 2025, at 22:40, Martin Storsjö wrote: > Traditionally, macOS has shipped an old version of rsync that lacked > support for this version, hence this check (added in > a8b3f0c5cf548f654e30c981988bb71981a3f8d3). > > However, in macOS 15.x, they have switched to providing rsync as a > differ

[FFmpeg-devel] [PATCH v3] swscale/x86/rgb2rgb: add AVX512ICL versions of shuffle_bytes

2025-01-28 Thread Shreesh Adiga
Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com> --- v3: Fix build failure on older nasm by replacing "kmovw k, tmpw" with "kmov k, tmpd" which matches "kmovw k, r32" syntax. v2: Tried to align operands and improve indentation for ASM routine. libswscale/x86/rgb2rgb.c | 21 ++

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: fix hls_time not respected

2025-01-28 Thread Ingo Oppermann
> On 28 Jan 2025, at 15:10, Michael Niedermayer wrote: > > On Mon, Jan 27, 2025 at 10:09:30AM +0100, Ingo Oppermann wrote: >> This fixes the criterion when to split the segments based on the >> elapsed time for the current segment instead of using the theoretical >> elapsed time since start bas

[FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-01-28 Thread Michael Niedermayer
Maybe fixes: 11435 Signed-off-by: Michael Niedermayer --- libavformat/hls.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index d2787ade46b..bdc3f5dbed5 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -754,6 +754,10 @@ static int test_seg

[FFmpeg-devel] [PATCH 1/2] avformat/hls: Print input format in error message

2025-01-28 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 93f6d1f1021..d2787ade46b 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -758,7 +758,7 @@ static int test_segment(AVFo

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: fix hls_time not respected

2025-01-28 Thread Michael Niedermayer
On Mon, Jan 27, 2025 at 10:09:30AM +0100, Ingo Oppermann wrote: > This fixes the criterion when to split the segments based on the > elapsed time for the current segment instead of using the theoretical > elapsed time since start based on hls_time and the number of written > segments. > > hls_time

Re: [FFmpeg-devel] [PATCH v2] swscale/x86/rgb2rgb: add AVX512ICL versions of shuffle_bytes

2025-01-28 Thread Michael Niedermayer
On Sun, Jan 26, 2025 at 11:59:20AM +0530, Shreesh Adiga wrote: > Signed-off-by: Shreesh Adiga <16567adigashre...@gmail.com> > --- > v2: Tried to align operands and improve indentation for ASM routine. > > libswscale/x86/rgb2rgb.c | 21 + > libswscale/x86/rgb_2_rgb.asm | 90 +++

[FFmpeg-devel] [PATCH] avdevice/alsa_dec: add a ch_layout option

2025-01-28 Thread James Almer
Missed in ffc4fd3cc2ccb2cadb71f19849842b18ca1281c6, which after e78173557da898f18a78241cc3525b76694164b5 broke setting channel count. Should fix ticket #11434. Signed-off-by: James Almer --- libavdevice/alsa.h | 4 libavdevice/alsa_dec.c | 24 +++- libavd

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Be more picky on extensions

2025-01-28 Thread Michael Niedermayer
On Tue, Jan 28, 2025 at 06:11:33AM +0100, Vittorio Giovara wrote: > On Sat, Jan 25, 2025 at 9:38 PM Michael Niedermayer > wrote: > > > On Thu, Jan 23, 2025 at 10:27:47PM +0100, Michael Niedermayer wrote: > > > On Wed, Jan 22, 2025 at 09:36:09PM +0100, Michael Niedermayer wrote: > > > > This block

Re: [FFmpeg-devel] [PATCH] avfilter/xpsnr: avoid division by zero

2025-01-28 Thread Gyan Doshi
On 2025-01-28 01:44 am, Jan Ekström wrote: On Mon, Jan 27, 2025 at 9:23 PM Marton Balint wrote: On Mon, 27 Jan 2025, Gyan Doshi wrote: The ref input may have its frame rate unset, which would then lead to SIGFPE. Related to #11428 --- libavfilter/vf_xpsnr.c | 3 ++- 1 file changed, 2 inse

Re: [FFmpeg-devel] [PATCH] rtmpproto: Avoid rare crashes in the fail: codepath in rtmp_open

2025-01-28 Thread Martin Storsjö
On Thu, 23 Jan 2025, Martin Storsjö wrote: When running the cleanup in rtmp_close on failures in rtmp_open, we can in rare cases end up using rt->playpath, assuming that it is still set. The crash could happen if we hit the fail codepath in rtmp_open while publishing (rt->is_input == 0) with rt

Re: [FFmpeg-devel] [PATCH] avcodec/aarch64/aacencdsp: NEON implementation

2025-01-28 Thread Martin Storsjö
On Mon, 27 Jan 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote: On Sun, Jan 26, 2025 at 01:29:38AM +0200, Martin Storsjö wrote: With the following diff: @@ -40,8 +41,8 @@ function ff_aac_quant_bands_neon, export=1 moviv5.4s, 0x80, lsl #24 .irp signed,1,0 \signed: -