Re: [FFmpeg-devel] [PATCH v2] avcodec/vvc: Add support for output_corrupt/showall flags

2025-01-18 Thread Nuo Mi
On Sun, Jan 19, 2025 at 12:40 AM Zhao Zhili < quinkblack-at-foxmail@ffmpeg.org> wrote: > > > > On Jan 18, 2025, at 23:30, Nuo Mi wrote: > > > > Hi Zhili, > > Thank you for v2, > > +1 > > > > Nit: The if statement is too long. Move it after generate_missing_ref and > > break it up to simplify

Re: [FFmpeg-devel] [PATCH] Fix the tail handling in R-V V sad

2025-01-18 Thread flow gg
ping 于2024年12月23日周一 23:02写道: > From: sunyuechi > > --- > libavcodec/riscv/h26x/asm.S| 36 +- > libavcodec/riscv/vvc/sad_rvv.S | 2 +- > 2 files changed, 19 insertions(+), 19 deletions(-) > > diff --git a/libavcodec/riscv/h26x/asm.S b/libavcodec/riscv/h26x/a

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/ffv1: NOT FOR GIT, experiment about float decorrelation

2025-01-18 Thread Michael Niedermayer
On Sat, Jan 18, 2025 at 05:33:19PM +0900, Lynne wrote: > On 18/01/2025 14:00, Michael Niedermayer wrote: > > This performs a tiny bit better than not using it but it is incompatible > > with the RCT which gives a bigger gain > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Nied

[FFmpeg-devel] [PATCH] avcodec/ffv1: NOT FOR GIT experiment seperately coding sign bits of float16

2025-01-18 Thread Michael Niedermayer
The float sign bits seem to take about 1% of space in the compressed bitstream. Storing it separately in a RC symbol each is worse --- libavcodec/ffv1.c | 1 + libavcodec/ffv1.h | 1 + libavcodec/ffv1enc_template.c | 24 3 files changed, 18 insert

[FFmpeg-devel] [PATCH 2/2] avcodec/ffv1: Store remap flag per slice

2025-01-18 Thread Michael Niedermayer
This allows switching it on conditionally and also for non float, it may improve compression for RGB data that was paletted or other synthetic images Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.h | 1 + libavcodec/ffv1dec.c | 8 ++

[FFmpeg-devel] [PATCH 1/2] avcodec/ffv1: flip half of float16 and Compactify floats

2025-01-18 Thread Michael Niedermayer
float16 (and more so float32) have many odd values half the values are negative, many are larger than "1.0" and many values are very close to 0. Storing the 16bits as is, looses compression because of the mixture of dense and sparse regions and also many completely unused ones. This simply remaps

[FFmpeg-devel] [PATCH 2/2] avcodec/ffv1: Compactify floats

2025-01-18 Thread Michael Niedermayer
float16 (and more so float32) have many odd values half the values are negative, many are larger than "1.0" and many values are very close to 0. Storing the 16bits as is, looses compression because of the mixture of dense and sparse regions and also many completely unused ones. This simply remaps

[FFmpeg-devel] [PATCH 1/2] avcodec/ffv1: flip half of float16

2025-01-18 Thread Michael Niedermayer
float16 is a sign bit followed by "positive is larger" exponent and mantisse that way the up direction changes between negative and positive numbers flipping the exponent and mantisse for positive numbers gives a compression gain of 0.5% for both RCT and noRCT modes using the ACES_OT_VWG_SampleFram

[FFmpeg-devel] [PATCH] Parse ogg/flac header again after processing a new chained ogg bitstream.

2025-01-18 Thread Romain Beauxis
This patch makes sure that ogg/flac headers are parsed again when encountering a new logic stream inside a chained ogg bistream[1]. This patches makes it possible to retrieve metadata in chained ogg/flac bitstreams. It is particularly important because ogg/flac is one of the only (if not the only

Re: [FFmpeg-devel] [PATCH v2] avcodec/vvc: Add support for output_corrupt/showall flags

2025-01-18 Thread Zhao Zhili
> On Jan 18, 2025, at 23:30, Nuo Mi wrote: > > Hi Zhili, > Thank you for v2, > +1 > > Nit: The if statement is too long. Move it after generate_missing_ref and > break it up to simplify the logic. Put the check before generate_missing_ref is meant to avoid allocate frame when it won’t be used

Re: [FFmpeg-devel] [PATCH v2] avcodec/vvc: Add support for output_corrupt/showall flags

2025-01-18 Thread Nuo Mi
Hi Zhili, Thank you for v2, +1 Nit: The if statement is too long. Move it after generate_missing_ref and break it up to simplify the logic. like: if (!ref) { ref = generate_missing_ref(s, fc, poc); if (!ref) return AVERROR(ENOMEM); } +if (ref->flags &

[FFmpeg-devel] [PATCH v3] avcodec/vvc: Add support for output_corrupt/showall flags

2025-01-18 Thread Zhao Zhili
From: Zhao Zhili --- v3: Use temporary variable to make the condition check more readable v2: Fix GDR stream libavcodec/vvc/refs.c | 20 +++- libavcodec/vvc/refs.h | 1 + 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/libavcodec/vvc/refs.c b/libavcodec/vvc/refs.c

Re: [FFmpeg-devel] [PATCH v3] lavc/vvc: Stop c->pix_fmt and s->pix_fmt diverging

2025-01-18 Thread Nuo Mi
On Sat, Jan 18, 2025 at 4:18 AM Frank Plowman wrote: > When the chroma format changes mid-sequence, c->pix_fmt and s->pix_fmt > can get out-of-sync. More specifically, > 1. export_frame_params is called. >c->pix_fmt and s->pix_fmt are both set to their new values. > 2. set_output_format is c

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashdec: Check whitelist

2025-01-18 Thread Steven Liu
Michael Niedermayer 于2025年1月18日周六 06:31写道: > > On Thu, Jan 16, 2025 at 04:39:49AM +0100, Michael Niedermayer wrote: > > Fixes: CVE-2023-6602, V. DASH Playlist SSRF > > > > Found-by: Harvey Phillips of Amazon Element55 (element55) > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/das

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/ffv1: NOT FOR GIT, experiment about float decorrelation

2025-01-18 Thread Lynne
On 18/01/2025 14:00, Michael Niedermayer wrote: This performs a tiny bit better than not using it but it is incompatible with the RCT which gives a bigger gain Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.h | 20 li