Re: [FFmpeg-devel] [PATCH] lavc/vvc: Fix pix_fmt change detection

2025-01-12 Thread Wang, Fei W
On Sun, 2025-01-12 at 11:45 +0800, Nuo Mi wrote: > > > On Sat, Jan 11, 2025 at 9:18 PM Frank Plowman > wrote: > > In some scenarios, the VVCContext.pix_fmt and the > > AVCodecContext.pix_fmt can get out-of-sync.  It is more robust here > > to check the AVCodecContext.pix_fmt, as we already do fo

Re: [FFmpeg-devel] [PATCH] swresample/rematrix: fix mixing of center channels

2025-01-12 Thread Michael Niedermayer
Hi James On Sun, Jan 12, 2025 at 06:52:55PM -0300, James Almer wrote: > On 1/12/2025 6:25 PM, Michael Niedermayer wrote: > > Hi > > > > On Sat, Jan 11, 2025 at 11:13:30AM -0300, James Almer wrote: > > > With this, the output from > > > > > > ffmpeg -i $fate-samples/ac3/monsters_inc_5.1_448_small

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_v360: Fix NULL pointer use

2025-01-12 Thread Michael Niedermayer
On Wed, Jan 08, 2025 at 05:13:37AM +0100, Michael Niedermayer wrote: > Fixes: applying zero offset to null pointer > partly Fixes: verysmall.flv > > Found-by: Elias Myllymäki > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_v360.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deleti

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo_enc: Check FLV1 resolution limits

2025-01-12 Thread Michael Niedermayer
Hi On Sun, Jan 12, 2025 at 12:31:53PM +0100, Alexander Strasser via ffmpeg-devel wrote: > On 2025-01-08 05:13 +0100, Michael Niedermayer wrote: > > Found-by: Elias Myllymäki > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/mpegvideo_enc.c | 6 ++ > > 1 file changed, 6 insertio

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix recent lavapipe regression

2025-01-12 Thread Lynne
On 07/01/2025 13:58, Lynne wrote: lavapipe indicates it supports external_semaphore_fd, but actually, it does not support exporting such? Ref: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12422 --- libavutil/hwcontext_vulkan.c | 25 - libavutil/vulkan_functions.h

Re: [FFmpeg-devel] [PATCH] swscale/cms, graph, lut3d: Use ff_-prefix, don't export, internal functions

2025-01-12 Thread Michael Niedermayer
Hi Niklas On Mon, Jan 13, 2025 at 01:11:31AM +0100, Niklas Haas wrote: > Series LGTM, though I did want to consider opening them up to the public at > some point in the future. +1 thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/ffv1enc: Fix handling of 32bit unsigned sambols

2025-01-12 Thread Michael Niedermayer
Hi Alexander On Sun, Jan 12, 2025 at 01:37:05PM +0100, Alexander Strasser via ffmpeg-devel wrote: > On 2025-01-10 05:06 +0100, Michael Niedermayer wrote: > > This may be needed for floats > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/ffv

Re: [FFmpeg-devel] [PATCH] [h264] Make slice header parse errors fatal under AV_EF_EXPLODE

2025-01-12 Thread Michael Niedermayer
Hi Marth64 On Wed, Jan 08, 2025 at 12:44:15AM -0600, Marth64 wrote: > It makes sense based on the surrounding code and AV_EF_EXPLODE use case. > Will let it sit for a few days for others to provide feedback. the patch looks correct to me too, only took a quick look though thx [...] -- Michael

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: perform sanity checks for heif before index building

2025-01-12 Thread Michael Niedermayer
On Thu, Jan 09, 2025 at 12:17:44AM +0100, Michael Niedermayer wrote: > Fixes: undefined NULL pointer use > Fixes: clusterfuzz-testcase-minimized-audio_decoder_fuzzer-6363211175493632 > > This performs equivalent sanity checks as are done in mov_read_trak() > before mov_build_index() > > Reported-

Re: [FFmpeg-devel] [PATCH v3] loongarch: fixes fate-checkasm-sw_rgb failure

2025-01-12 Thread Michael Niedermayer
On Wed, Jan 08, 2025 at 06:17:01PM +0800, yinshiyou...@loongson.cn wrote: > verified. LGTM. will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Avoid a single point of failure, be that a person or equipment. signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] swscale/cms, graph, lut3d: Use ff_-prefix, don't export, internal functions

2025-01-12 Thread Niklas Haas
Series LGTM, though I did want to consider opening them up to the public at some point in the future. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg

Re: [FFmpeg-devel] [PATCH] swresample/rematrix: fix mixing of center channels

2025-01-12 Thread James Almer
On 1/12/2025 6:25 PM, Michael Niedermayer wrote: Hi On Sat, Jan 11, 2025 at 11:13:30AM -0300, James Almer wrote: With this, the output from ffmpeg -i $fate-samples/ac3/monsters_inc_5.1_448_small.ac3 -af aresample,aformat=channel_layouts=mono -f s16le - matches the one from ffmpeg -downmix m

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/mpegvideo_enc: add checks for custom inter/intra/chroma matrices

2025-01-12 Thread Michael Niedermayer
On Sat, Jan 11, 2025 at 02:11:33PM +0100, Marton Balint wrote: > Make the checker functions available for all codecs. > > Signed-off-by: Marton Balint > --- > libavcodec/encode.c| 19 +++ > libavcodec/encode.h| 9 + > libavcodec/mpegvideo_enc.c | 8 +

[FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Remove audio_drift_threshold

2025-01-12 Thread Andreas Rheinhardt
Patch attachedFrom 1abad60fe2eba199845db35c92e27dbc4d35b93f Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 12 Jan 2025 20:40:31 +0100 Subject: [PATCH] fftools/ffmpeg_opt: Remove audio_drift_threshold Forgotten in 5a04aae82193d75b8f8814dc7e35f4cc84b1beba. Signed-off-by: Andreas Rhei

Re: [FFmpeg-devel] [PATCH] swresample/rematrix: fix mixing of center channels

2025-01-12 Thread Michael Niedermayer
Hi On Sat, Jan 11, 2025 at 11:13:30AM -0300, James Almer wrote: > With this, the output from > > ffmpeg -i $fate-samples/ac3/monsters_inc_5.1_448_small.ac3 -af > aresample,aformat=channel_layouts=mono -f s16le - > > matches the one from > > ffmpeg -downmix mono -i $fate-samples/ac3/monsters_in

[FFmpeg-devel] [PATCH] avutil/cpu: Disable ff_getauxval() on x86

2025-01-12 Thread Andreas Rheinhardt
Patch attachedFrom 4f36a9abe91637a63fa4d0c647361efd1d75c92d Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 12 Jan 2025 20:01:22 +0100 Subject: [PATCH] avutil/cpu: Disable ff_getauxval() on x86 Not used there. Signed-off-by: Andreas Rheinhardt --- libavutil/cpu.c | 2 ++ 1 file ch

[FFmpeg-devel] [PATCH 1/2] swscale/x86/swscale: Move some constants to rgb2rgb.c

2025-01-12 Thread Andreas Rheinhardt
Patches attachedFrom 0c6e52fee3a2d8335e2b31f180811f2c02a89603 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sun, 12 Jan 2025 19:43:12 +0100 Subject: [PATCH 1/2] swscale/x86/swscale: Move some constants to rgb2rgb.c ff_w and ff_bgr2(Y|UV)Offset are only used there (and only on x86-32

Re: [FFmpeg-devel] [PATCH 2/2] lavc/ac3dsp: fix R-V HAVE_RVV scope issue

2025-01-12 Thread Rémi Denis-Courmont
Le 8 janvier 2025 19:42:15 GMT+08:00, Jun Zhao a écrit : >From: Jun Zhao > >fix R-V HAVE_RVV scope issue > >Signed-off-by: Jun Zhao >--- > libavcodec/riscv/ac3dsp_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/libavcodec/riscv/ac3dsp_init.c b/libavcodec/riscv/ac3

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-12 Thread Andreas Rheinhardt
Peter Ross: > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_desc.c | 7 ++ > libavcodec/codec_id.h | 1 + > libavcodec/g728data.h | 70 + > libavcodec/g728dec.c| 213 > libavcodec/utils

Re: [FFmpeg-devel] [PATCH 1/2] ffbuild/bin2c: misc fix

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-08 19:42 +0800, Jun Zhao wrote: > From: Jun Zhao > > close the input file if open output fail > > Signed-off-by: Jun Zhao > --- > ffbuild/bin2c.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ffbuild/bin2c.c b/ffbuild/bin2c.c > index dfeedd7669..168b0c658

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/ffv1enc: Fix handling of 32bit unsigned sambols

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-10 05:06 +0100, Michael Niedermayer wrote: > This may be needed for floats > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/ffv1enc.c b/libavcodec/

Re: [FFmpeg-devel] [PATCH] swscale/cms, graph, lut3d: Use ff_-prefix, don't export, internal functions

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
Hi Andreas! On 2025-01-11 20:40 +0100, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > Patch attached > > Will apply this patch and my other patches tomorrow unless there are > objections. LGTM from my side (not maintaining any of the affected areas) I just reviewed them and partially tested

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo_enc: Check FLV1 resolution limits

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-08 05:13 +0100, Michael Niedermayer wrote: > Found-by: Elias Myllymäki > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo_enc.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c > index c5f20c2d855..09

Re: [FFmpeg-devel] [PATCH] avformat/mov: merge stts and ctts arrays into one

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-10 10:40 -0300, James Almer wrote: > On 1/10/2025 10:05 AM, James Almer wrote: > > On 1/7/2025 6:50 PM, Alexander Strasser via ffmpeg-devel wrote: > > > On 2025-01-07 10:55 -0300, James Almer wrote: > > > > Should reduce memory usage as well as remove code duplication. > > > > > > > > Si

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: int overflow in start_time_realtime

2025-01-12 Thread Alexander Strasser via ffmpeg-devel
On 2025-01-10 12:10 +0200, Martin Storsjö wrote: > On Wed, 8 Jan 2025, j...@jonb.org wrote: > > > From: Jonathan Baudanza > > > > This was previously adjusted by me in 6b3f9c2e92b. > > Unfortunately, I traded one integer overflow bug for > > another. > > > > Currently, NTP timestamps that exceed I