Re: [FFmpeg-devel] [PATCH] lavc/vvc: Check slice structure

2025-01-11 Thread Nuo Mi
Thank you, Frank, Applied with some minor changes. On Sat, Jan 11, 2025 at 5:31 AM Frank Plowman wrote: > The criteria for slice structure validity is similar to that of > subpicture structure validity that we saw not too long ago [1]. > The relationship between tiles and slices must satisfy the

Re: [FFmpeg-devel] [PATCH] avformat/matroska: add support for VVC streams

2025-01-11 Thread Nuo Mi
On Sat, Jan 11, 2025 at 11:49 PM James Almer wrote: > As defined in > https://github.com/ietf-wg-cellar/matroska-specification/blob/master/codec_specs.md#v_mpegiisovvc > > Signed-off-by: James Almer > --- > libavformat/matroska.c| 1 + > libavformat/matroskaenc.c | 10 -- > 2 files

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Fix pix_fmt change detection

2025-01-11 Thread Nuo Mi
On Sat, Jan 11, 2025 at 9:18 PM Frank Plowman wrote: > In some scenarios, the VVCContext.pix_fmt and the > AVCodecContext.pix_fmt can get out-of-sync. It is more robust here > to check the AVCodecContext.pix_fmt, as we already do for the width and > height, seeing as the AVCodecContext.pix_fmt i

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-11 Thread James Almer
On 1/11/2025 11:37 PM, Peter Ross wrote: --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 ++ libavcodec/codec_id.h | 1 + libavcodec/g728data.h | 70 + libavcodec/g728dec.c| 213 +

Re: [FFmpeg-devel] [PATCH] lavc/vvcdec: show frames info with ffprobe and other tools.

2025-01-11 Thread Nuo Mi
On Sun, Jan 12, 2025 at 6:24 AM James Almer wrote: > On 1/11/2025 3:40 AM, Nuo Mi wrote: > > Tested with: > > ``` > > wget > https://www.itu.int/wftp3/av-arch/jvet-site/bitstream_exchange/VVC/draft_conformance/draft6/CodingToolsSets_E_Tencent_1.zip > > unzip CodingToolsSets_E_Tencent_1.zip Coding

[FFmpeg-devel] [PATCH v2] lavc/vvc/refs: export keyframe and picture type in output frames

2025-01-11 Thread Nuo Mi
Tested with: ``` wget https://www.itu.int/wftp3/av-arch/jvet-site/bitstream_exchange/VVC/draft_conformance/draft6/CodingToolsSets_E_Tencent_1.zip unzip CodingToolsSets_E_Tencent_1.zip CodingToolsSets_E_Tencent_1.bit ffprobe -hide_banner CodingToolsSets_E_Tencent_1.bit -select_streams v -show_fra

[FFmpeg-devel] [PATCH 8/8] avformat/rtp: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
--- libavformat/rtp.c| 2 +- libavformat/rtpenc.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/rtp.c b/libavformat/rtp.c index 564489b613..5bde171cf4 100644 --- a/libavformat/rtp.c +++ b/libavformat/rtp.c @@ -53,7 +53,7 @@ static const struct { {13, "CN",

[FFmpeg-devel] [PATCH 7/8] avformat/aiff: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
--- libavformat/aiff.c| 1 + libavformat/aiffdec.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/libavformat/aiff.c b/libavformat/aiff.c index 1ceac69a70..907f7d8d28 100644 --- a/libavformat/aiff.c +++ b/libavformat/aiff.c @@ -40,6 +40,7 @@ const AVCodecTag ff_codec_aiff_tags[] = {

[FFmpeg-devel] [PATCH 6/8] avformat/riff: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
--- libavformat/riff.c| 2 ++ libavformat/riffenc.c | 1 + 2 files changed, 3 insertions(+) diff --git a/libavformat/riff.c b/libavformat/riff.c index 017a0658ef..151563e9f2 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -555,6 +555,7 @@ const AVCodecTag ff_codec_wav_tags[] = {

[FFmpeg-devel] [PATCH 5/8] avformat/g728dec: raw G.728 demuxer

2025-01-11 Thread Peter Ross
--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/g728dec.c| 58 3 files changed, 60 insertions(+) create mode 100644 libavformat/g728dec.c diff --git a/libavformat/Makefile b/libavformat/Makefile index 074efc118a..e6a9

[FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-11 Thread Peter Ross
--- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 ++ libavcodec/codec_id.h | 1 + libavcodec/g728data.h | 70 + libavcodec/g728dec.c| 213 libavcodec/utils.c | 1 + 7 files cha

[FFmpeg-devel] [PATCH 3/8] avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters

2025-01-11 Thread Peter Ross
--- libavcodec/aac/aacdec_dsp_template.c | 2 +- libavcodec/aacenc_tns.c | 2 +- libavcodec/lpc.c | 2 +- libavcodec/lpc_functions.h | 18 +- libavcodec/ra288.c | 2 +- 5 files changed, 17 insertions(+), 9 deletions(-

[FFmpeg-devel] [PATCH 2/8] avcodec/g728_template: make hist parameter constant

2025-01-11 Thread Peter Ross
--- libavcodec/g728_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/g728_template.c b/libavcodec/g728_template.c index 72eb5fde80..0c83b0dbdc 100644 --- a/libavcodec/g728_template.c +++ b/libavcodec/g728_template.c @@ -39,7 +39,7 @@ static void convolve(fl

[FFmpeg-devel] [PATCH 0/8] G.728 decoding

2025-01-11 Thread Peter Ross
Sample: https://pross.sdf.org/sandpit/CW5.g728 Peter Ross (8): avcodec/g728_template: do_hybrid_window() template avcodec/g728_template: make hist parameter constant avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters avcodec/g728dec: G.728 decoder

[FFmpeg-devel] [PATCH 1/8] avcodec/g728_template: do_hybrid_window() template

2025-01-11 Thread Peter Ross
intended for use by RealAudio 2.0 (28.8k) and G.728 decoders. --- libavcodec/g728_template.c | 65 ++ libavcodec/ra288.c | 50 ++--- 2 files changed, 68 insertions(+), 47 deletions(-) create mode 100644 libavcodec/g728_template.c

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/avfilter: Add FFFilter, hide internals of AVFilter

2025-01-11 Thread Andreas Rheinhardt
Michael Niedermayer: > On Thu, Jan 09, 2025 at 03:47:39AM +0100, Andreas Rheinhardt wrote: >> Patch attached > >> configure |6 >> libavfilter/aeval.c | 19 >> libavfilter/af_aap.c| 12 >> libavfilter/af_acontrast.c |

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/avfilter: Add FFFilter, hide internals of AVFilter

2025-01-11 Thread Michael Niedermayer
On Thu, Jan 09, 2025 at 03:47:39AM +0100, Andreas Rheinhardt wrote: > Patch attached > configure |6 > libavfilter/aeval.c | 19 > libavfilter/af_aap.c| 12 > libavfilter/af_acontrast.c |8 > libavfilter/af_acopy.c

Re: [FFmpeg-devel] [PATCH] lavc/vvcdec: show frames info with ffprobe and other tools.

2025-01-11 Thread James Almer
On 1/11/2025 3:40 AM, Nuo Mi wrote: Tested with: ``` wget https://www.itu.int/wftp3/av-arch/jvet-site/bitstream_exchange/VVC/draft_conformance/draft6/CodingToolsSets_E_Tencent_1.zip unzip CodingToolsSets_E_Tencent_1.zip CodingToolsSets_E_Tencent_1.bit ffprobe -hide_banner CodingToolsSets_E_Tenc

Re: [FFmpeg-devel] [PATCH] swscale/cms, graph, lut3d: Use ff_-prefix, don't export, internal functions

2025-01-11 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Patch attached > > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsub

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/mpegvideo_enc: add checks for custom inter/intra/chroma matrices

2025-01-11 Thread Marton Balint
On Sat, 11 Jan 2025, Andreas Rheinhardt wrote: Marton Balint: Make the checker functions available for all codecs. Signed-off-by: Marton Balint --- libavcodec/encode.c| 19 +++ libavcodec/encode.h| 9 + libavcodec/mpegvideo_enc.c | 8 3 f

[FFmpeg-devel] [PATCH] avformat/matroska: add support for VVC streams

2025-01-11 Thread James Almer
As defined in https://github.com/ietf-wg-cellar/matroska-specification/blob/master/codec_specs.md#v_mpegiisovvc Signed-off-by: James Almer --- libavformat/matroska.c| 1 + libavformat/matroskaenc.c | 10 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/libavformat/

Re: [FFmpeg-devel] [PATCH] avcodec/cuviddec: Fix missing HW_CONFIG_METHOD_HW_FRAMES_CTX flag

2025-01-11 Thread Timo Rothenpieler
On 18.12.2024 08:13, Zhao Zhili wrote: From: Zhao Zhili --- libavcodec/cuviddec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c index 3fae9c12eb..502bcc7fc2 100644 --- a/libavcodec/cuviddec.c +++ b/libavcodec/cuviddec.c @@ -1162,6 +1162,7 @

[FFmpeg-devel] [PATCH] swresample/rematrix: fix mixing of center channels

2025-01-11 Thread James Almer
With this, the output from ffmpeg -i $fate-samples/ac3/monsters_inc_5.1_448_small.ac3 -af aresample,aformat=channel_layouts=mono -f s16le - matches the one from ffmpeg -downmix mono -i $fate-samples/ac3/monsters_inc_5.1_448_small.ac3 -f s16le - When testing with tiny_psnr. Signed-off-by: Jam

[FFmpeg-devel] [PATCH] lavc/vvc: Fix pix_fmt change detection

2025-01-11 Thread Frank Plowman
In some scenarios, the VVCContext.pix_fmt and the AVCodecContext.pix_fmt can get out-of-sync. It is more robust here to check the AVCodecContext.pix_fmt, as we already do for the width and height, seeing as the AVCodecContext.pix_fmt is the value which actually ends up being used to determine the

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/mpegvideo_enc: add checks for custom inter/intra/chroma matrices

2025-01-11 Thread Andreas Rheinhardt
Marton Balint: > Make the checker functions available for all codecs. > > Signed-off-by: Marton Balint > --- > libavcodec/encode.c| 19 +++ > libavcodec/encode.h| 9 + > libavcodec/mpegvideo_enc.c | 8 > 3 files changed, 36 insertions(+) > > di

[FFmpeg-devel] [PATCH v2 1/3] avcodec/mpegvideo_enc: add checks for custom inter/intra/chroma matrices

2025-01-11 Thread Marton Balint
Make the checker functions available for all codecs. Signed-off-by: Marton Balint --- libavcodec/encode.c| 19 +++ libavcodec/encode.h| 9 + libavcodec/mpegvideo_enc.c | 8 3 files changed, 36 insertions(+) diff --git a/libavcodec/encode.c b/li

Re: [FFmpeg-devel] [PATCH 3/4] doc/faq: Document the plan ahead for Governance

2025-01-11 Thread Ronald S. Bultje
Hi Michael, On Fri, Jan 10, 2025 at 9:01 PM Michael Niedermayer wrote: > But i think a company which actually depends on a FFmpeg vote outcome > > will be able to connect the dots and be able to enumerate the options > to influcence said vote > > * do they have an employee with vote rights, iam

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/encode: add checks for custom inter/intra/chroma matrices

2025-01-11 Thread Marton Balint
On Thu, 9 Jan 2025, Michael Niedermayer wrote: Hi On Tue, Jan 07, 2025 at 12:08:39AM +0100, Marton Balint wrote: All elements should be within 1-255. --- libavcodec/encode.c | 16 1 file changed, 16 insertions(+) this breaks: ./ffmpeg -i lena.pnm -qscale 4 -intra_matrix

Re: [FFmpeg-devel] [PATCH v2] avutil/frame.h: improve documentation for AV_FRAME_FLAG_LOSSLESS

2025-01-11 Thread Marton Balint
On Fri, 10 Jan 2025, Leo Izen wrote: It should be more clear what this flag is indicating with a more verbose comment documenting it. Signed-off-by: Leo Izen Reviewed-by: Marton Balint Reviewed-by: Alexander Strasser Reviewed-by: Marth64 --- libavutil/frame.h | 6 +- 1 file changed, 5