[FFmpeg-devel] [PATCH 4/4] avformat/mlvdec: Check avio_read()

2024-12-24 Thread Michael Niedermayer
Fixes: use-of-uninitialized-value Fixes: 383170476/clusterfuzz-testcase-minimized-ffmpeg_dem_MLV_fuzzer-4696002884337664 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mlvdec.c | 6 -- 1

[FFmpeg-devel] [PATCH 3/4] avformat/mxfdec: Check llen addition for overflow

2024-12-24 Thread Michael Niedermayer
Fixes: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long' Fixes: 377971441/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-4966030696316928 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/4] doc/community: Add list of prohibited behaviors

2024-12-24 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/community.texi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/community.texi b/doc/community.texi index 97a49f15ede..0bc8893f0e8 100644 --- a/doc/community.texi +++ b/doc/community.texi @@ -179,4 +179,10 @@ instead and point them in the ri

[FFmpeg-devel] [PATCH 1/4] avcodec/aac/aacdec: Free channel layout

2024-12-24 Thread Michael Niedermayer
Fixes: 371445194/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-5981081124274176 Fixes: memleak Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec.c | 2 ++ 1 file c

Re: [FFmpeg-devel] [PATCH] ffmpeg_sched: return better error code

2024-12-24 Thread Gyan Doshi
On 2024-12-21 09:55 am, Gyan Doshi wrote: The existing code of 'No space left on device' leaves end users confused since the issue isn't of disk space. Plan to push tomorrow. Regards, Gyan --- fftools/ffmpeg_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ff

Re: [FFmpeg-devel] [PATCH v2 3/3] swscale/utils: lazily allocate XYZ tables on CONFIG_SMALL

2024-12-24 Thread Michael Niedermayer
On Mon, Dec 23, 2024 at 01:26:35PM +0100, Niklas Haas wrote: > From: Niklas Haas > > This has the downside of requiring these tables to be recomputed on every > init, but saves ~270 kB of static data. > > Signed-off-by: Niklas Haas > --- > libswscale/utils.c | 26 +- >

Re: [FFmpeg-devel] [PATCH v2 2/3] swscale/utils: add return code to fill_xyztables()

2024-12-24 Thread Michael Niedermayer
Hi On Mon, Dec 23, 2024 at 01:26:34PM +0100, Niklas Haas wrote: > From: Niklas Haas > > Needed for lazy allocation of XYZ tables. > > Signed-off-by: Niklas Haas > --- > libswscale/utils.c | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) ok [...] -- Michael

Re: [FFmpeg-devel] [PATCH v3] swscale/unscaled: add pal8 -> gbr(a)p special converter

2024-12-24 Thread Michael Niedermayer
Hi Niklas On Mon, Dec 23, 2024 at 12:55:19PM +0100, Niklas Haas wrote: > From: Niklas Haas > > Fixes: ticket #9520 > Signed-off-by: Niklas Haas > Sponsored-by: Sovereign Tech Fund > --- > libswscale/swscale.c | 8 > libswscale/swscale_unscaled.c | 81

Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/libjxl: add animated JPEG XL encoder

2024-12-24 Thread Leo Izen
On 12/24/24 5:23 PM, Marth64 wrote: Hi Leo, Code in v4 is clean and LGTM. Also, I tested today successfully and got a good visual result when playing back (though I had to use data muxer). ``` ffmpeg -i pizza.mkv -map 0:v -c:v libjxl_anim -f data test.jxl ``` Sorry for the back and forth on thi

Re: [FFmpeg-devel] [PATCH v2 1/3] swscale: use 16-bit intermediate precision for RGB/XYZ conversion

2024-12-24 Thread Michael Niedermayer
On Mon, Dec 23, 2024 at 01:26:33PM +0100, Niklas Haas wrote: > From: Niklas Haas > > The current logic uses 12-bit linear light math, which is woefully > insufficient > and leads to nasty postarization artifacts. This patch simply switches the > internal logic to 16-bit precision. > > This rais

Re: [FFmpeg-devel] Fwd: Your message to ffmpeg-devel awaits moderator approval

2024-12-24 Thread Steven Liu
Ronald S. Bultje 于2024年12月23日周一 21:24写道: > > Hi, > > On Mon, Dec 23, 2024 at 8:22 AM Nicolas George wrote: > > > Could you all stop ganging against Michael? It is reminiscent of the > > bullying he was subjected to in the months leading to the fork that > > convinced him to “resign” as project le

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: reformat and lowercase get_Fragment()

2024-12-24 Thread Marth64
Not a problem at all, this is not a critical change at all. Thank you very much and congratulations! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: reformat and lowercase get_Fragment()

2024-12-24 Thread Steven Liu
Marth64 于2024年12月25日 周三05:50写道: > Hi Steven, > > OK with me pushing this readability change? Sure, go ahead and push it. I'm really sorry for forgetting about this patch. I've been taking care of my newborn baby for the past few days and it must have slipped my mind. > > > Thank you > Thanks St

Re: [FFmpeg-devel] [PATCH] avformat/avformat.h: elaborate documentation for avformat_open_input() on error condition

2024-12-24 Thread Marth64
Hi, Pinging on an old patch (quoted below). Any objections? I checked and this still holds true. On Fri, Feb 9, 2024 at 4:08 PM Marth64 wrote: > > Signed-off-by: Marth64 > --- > libavformat/avformat.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/avf

Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/libjxl: add animated JPEG XL encoder

2024-12-24 Thread Marth64
Hi Leo, Code in v4 is clean and LGTM. Also, I tested today successfully and got a good visual result when playing back (though I had to use data muxer). ``` ffmpeg -i pizza.mkv -map 0:v -c:v libjxl_anim -f data test.jxl ``` Sorry for the back and forth on this last bit, but in libavcodec/version.

[FFmpeg-devel] [PATCH] avcodec/mpeg12dec: fix range for cc_format option

2024-12-24 Thread Marth64
After support was added for DVB 0502 Closed Caption coding, the cc_format option's range was never updated so user cannot select this coding as a forced formatting choice. Fix the range of the option by ending it with the new coding type. Signed-off-by: Marth64 --- libavcodec/mpeg12dec.c | 2 +-

Re: [FFmpeg-devel] [PATCH v2] libavcodec/mpeg12dec.c: append CC data to a53_buf_ref

2024-12-24 Thread Marth64
Hi, This makes sense to me still after much pondering. I would like to push next week if there are no objections. Thank you very much. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: reformat and lowercase get_Fragment()

2024-12-24 Thread Marth64
Hi Steven, OK with me pushing this readability change? Thank you ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subj

Re: [FFmpeg-devel] [PATCH v3 00/16] Implement enhanced rtmp/flv v2 spec

2024-12-24 Thread Timo Rothenpieler
I intend to push this series this year still, if no further review is done or requested. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: fix variable shadowing in cbs_av1_split_fragment()

2024-12-24 Thread Marth64
pushed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] Fix crash when trying to get a fragment time for a non-existing fragment

2024-12-24 Thread Marth64
Pushed as 7c9bde1d0d26ffa74b6791666c3a27c6d5d5019f ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: CC election

2024-12-24 Thread Marth64
> Btw, i also wanted to say, in case you fail to receive enough > support for a CC seat. Please ignore that and try to help anyway > the ffmpeg community is in need for your help, i think Thank you. I am not easily discouraged. At the end of the day, I care most about FFmpeg being a good program a

Re: [FFmpeg-devel] Fwd: Your message to ffmpeg-devel awaits moderator approval

2024-12-24 Thread compn
On Tue, 24 Dec 2024 06:24:40 +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-12-23 21:37:32) > > If i stand by and do nothing, THAT would be abusing of my power > > Behold, the favorite excuse of every tin-pot dictator ever. > > So boiling down your verbal vomit, I get > >

Re: [FFmpeg-devel] Fwd: Your message to ffmpeg-devel awaits moderator approval

2024-12-24 Thread Michael Niedermayer
Hi Anton On Tue, Dec 24, 2024 at 06:24:40AM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-12-23 21:37:32) > > If i stand by and do nothing, THAT would be abusing of my power > > Behold, the favorite excuse of every tin-pot dictator ever. > > So boiling down your verbal vomit, I

Re: [FFmpeg-devel] [PATCH] lavc/vvc_mc: reduce sequential dependency in R-V V sad

2024-12-24 Thread Nuo Mi
On Mon, Dec 23, 2024 at 11:18 PM flow gg wrote: > Hi, It looks like you submitted your review comments not long after the > patch was merged. > > Previously, regarding the VVC avg patch, you mentioned "LGTM for the RISC-V > side. No clue about the VVC side", > so I contacted Nuomi in the hope tha

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264: fix stride calculation in slice_table for multi-slice field video deblocking

2024-12-24 Thread Lingyi Kong
Hi Kieran, I am unsure how to keep two commits within the same series in Patchwork, so I have resubmitted a new version. The final version can be found at https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=13597. Best regards, Lingyi From: ffmpeg-devel on

[FFmpeg-devel] [PATCH v4] avcodec/h264: fix stride calculation in slice_table for multi-slice field video deblocking

2024-12-24 Thread Lingyi Kong
fix for https://trac.ffmpeg.org/ticket/11360 A new fate test case is added to validate the fix, the smaple file is located at https://trac.ffmpeg.org/attachment/ticket/11360/slice2_field_aurora4.264. Signed-off-by: Lingyi Kong --- libavcodec/h264_mb.c | 2 +- tests/fat

[FFmpeg-devel] [PATCH v2] avcodec/h264: fix stride calculation in slice_table for multi-slice field video deblocking

2024-12-24 Thread Lingyi Kong
add fate test case Signed-off-by: Lingyi Kong --- tests/fate/h264.mak | 2 + .../h264-conformance-slice2_field_aurora4 | 55 +++ 2 files changed, 57 insertions(+) create mode 100644 tests/ref/fate/h264-conformance-slice2_field_aurora4 diff --git a

[FFmpeg-devel] [PATCH v2] fix stride calculation in slice_table for multi-slice field video deblocking

2024-12-24 Thread Lingyi Kong
add fate test case Signed-off-by: Lingyi Kong --- tests/fate/h264.mak | 2 + .../h264-conformance-slice2_field_aurora4 | 55 +++ 2 files changed, 57 insertions(+) create mode 100644 tests/ref/fate/h264-conformance-slice2_field_aurora4 diff --git a

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264: fix stride calculation in slice_table for multi-slice field video deblocking

2024-12-24 Thread Lingyi Kong
Hi Kieran, Thank you for your feedback. I have already pushed the code related to the FATE test case, and the corresponding sample file is located at (https://trac.ffmpeg.org/attachment/ticket/11360/slice2_field_aurora4.264). I do not have the permissions to upload it to the FATE server. Could

[FFmpeg-devel] [PATCH v3] fix stride calculation in slice_table for multi-slice field video deblocking

2024-12-24 Thread Lingyi Kong
add fate test case Signed-off-by: Lingyi Kong --- tests/fate/h264.mak | 2 + .../h264-conformance-slice2_field_aurora4 | 55 +++ 2 files changed, 57 insertions(+) create mode 100644 tests/ref/fate/h264-conformance-slice2_field_aurora4 diff --git a

[FFmpeg-devel] [PATCH] avformat/wtvenc: do not output negative 'third timestamp' field

2024-12-24 Thread Peter Ross
Fixes ticket #3659. --- libavformat/wtvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/wtvenc.c b/libavformat/wtvenc.c index 02fe84573f..0c0ef05bbe 100644 --- a/libavformat/wtvenc.c +++ b/libavformat/wtvenc.c @@ -450,7 +450,7 @@ static void write_timestamp(AVF