Re: [FFmpeg-devel] [PATCH] libavcodec/mpegaudio_parser.c: differentiate MPEG audio dual mono

Quoting James Almer (2024-11-30 14:41:20) > with no speaker location implied Also, is it really the case that no speaker location is implied? I'd think mono (as opposed to just "1 channel") does carry the implication is is the center channel. -- Anton Khirnov

Re: [FFmpeg-devel] [PATCH] libavcodec/mpegaudio_parser.c: differentiate MPEG audio dual mono

Quoting Scott Theisen (2024-12-10 21:42:06) > On 12/9/24 02:31, Anton Khirnov wrote: > > Quoting Scott Theisen (2024-11-30 08:38:54) > >> On 11/25/24 00:42, Anton Khirnov wrote: > >>> Quoting Scott Theisen (2024-11-14 05:37:49) > @@ -85,7 +85,13 @@ static int mpegaudio_parse(AVCodecParserConte

[FFmpeg-devel] [PATCH 5/5] avformat/mov: dereference pointer after null check

Fixes: null pointer dereference Fixes: 383397479/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4776829338058752 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 3 ++- 1 file ch

[FFmpeg-devel] [PATCH 4/5] avcodec/utils: Fix block align overflow for ADPCM_IMA_WAV

Fixes: signed integer overflow: 529008646 * 8 cannot be represented in type 'int' Fixes: 383379145/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-6674045107503104 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nie

[FFmpeg-devel] [PATCH 3/5] avformat/matroskadec: Check pre_ns for overflow

Fixes: signed integer overflow: -3483479120376300096 - 7442323944145700864 cannot be represented in type 'long' Fixes: 383187489/clusterfuzz-testcase-minimized-ffmpeg_dem_WEBM_DASH_MANIFEST_fuzzer-4561470580391936 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/mast

[FFmpeg-devel] [PATCH 2/5] tools/target_dec_fuzzer: Adjust threshold for EACMV

Fixes: Timeout Fixes: 382988735/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EACMV_fuzzer-5278721465974784 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file cha

[FFmpeg-devel] [PATCH 1/5] tools/target_dec_fuzzer: Adjust threshold for SGA

Fixes: Timeout Fixes: 382804863/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SGA_fuzzer-5652795669151744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file chang

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

Hi, On Friday, December 6th, 2024 at 12:39 PM, Tristan Matthews via ffmpeg-devel wrote: > Hi (also apologies if my client mangles the inline version of the patch, it's > the first time I've tried to review an attached patch with it)... > > On Monday, December 2nd, 2024 at 9:57 AM, Chris Hodge

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Implement async_depth option

Looks good to me. If there are no comments, I’ll merge it in a few days. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wit

Re: [FFmpeg-devel] [PATCH v2] Use AVBufferPool in MOV

On Wed, 11 Dec 2024 14:56:23 +0100, Timo Rothenpieler wrote: > On 11/12/2024 10:10, Arnaud Masserann wrote: > > Hi, any feedback on this patch ? > > I do not appear to have received the mail you are replying to here https://ffmpeg.org//pipermail/ffmpeg-devel/2024-December/336971.html

Re: [FFmpeg-devel] [PATCH] Fix crash when trying to get a fragment time for a non-existing fragment

Hi Eugene, This makes sense to me. get_frag_stream_info() has a chance to return null but is unchecked here. It appears to be checked in all other scenarios in the file. get_frag_time() is always expected to return a timestamp and in undefined state will resort to returning AV_NOPTS_VALUE. So, we

Re: [FFmpeg-devel] [PATCH 0/2] Animated JPEG XL Encoder

Hi Leo, In libjxl_anim_encode_frame(): > +if (!ctx->prev) { > +ret = AVERROR(ENOMEM); > +goto end; > +} > +ret = ff_encode_get_frame(avctx, ctx->prev); > +if (ret == AVERROR(EAGAIN) || ret == AVERROR_EOF) > +goto end; > +

[FFmpeg-devel] [PATCH 2/2] avformat/riff: map 0069 twocc to ADPCM IMA XBOX decoder

--- Using AV_CODEC_ID_ADPCM_IMA_WAV for twocc 0x0069 causes subtle artefacts during playback. The correct decoder is AV_CODEC_ID_ADPCM_IMA_XBOX. Sample .wav and ref flac file: libavformat/riff.c | 2 +- tests/ref/fat

[FFmpeg-devel] [PATCH 1/2] avcodec: add ADPCM IMA XBOX decoder

From: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/adpcm.c | 41 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/utils.c | 6 ++ 6 files changed, 57 insertions

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/aac/aacdec_usac: Clean ics2->max_sfb when first SCE fails

Hi On Tue, Sep 03, 2024 at 07:20:50AM +0200, Lynne via ffmpeg-devel wrote: > On 01/08/2024 19:07, Michael Niedermayer wrote: > > On Thu, Aug 01, 2024 at 05:11:18PM +0200, Lynne via ffmpeg-devel wrote: > > > On 31/07/2024 21:54, Michael Niedermayer wrote: > > > > Fixes: out of array access > > > >

Re: [FFmpeg-devel] [PATCH 0/2] Animated JPEG XL Encoder

On 12/4/24 9:59 AM, Leo Izen wrote: > Changes since v1: > - modified fate tests to use jpegxl_anim codec ID, so > the fate tests don't fail after applying patch 2/2 > > Leo Izen (2): >avcodec/libjxlenc: add animated JPEG XL encoder >avformat/jpegxl_anim_dec: use new animated JPEG XL codec

Re: [FFmpeg-devel] [PATCH v2] avformat/mov: don't reallocate extradata when converting dvdsub palette

Planning to push in 2 days to resolve this. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v6] fftools/ffprobe: add analyze_frames option for CC and grain detection

Planning to push v6 in 2 days. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v3] fate: Add a target for listing failed tests

On Mon, 9 Dec 2024, Martin Storsjö wrote: If running tests with "make -j fate", the execution will stop after the first failing test. To get an overview of the whole test suite, one rather would run "make -k -j fate", which then again buries the results about what tests actually failed further u

Re: [FFmpeg-devel] [PATCH 1/3] lavf/mov: Always try to parse mfra if file contains moof boxes

ons 2024-12-11 klockan 15:24 +0100 skrev Tomas Härdin: > Hi > > This patchset addresses the issues Spotify has been having reading > fragmented MP4 over HTTP. The issue is that mov.c does hundreds of > seeks unless -use_mfra_for is set to something other than auto. > However, defaulting -use_mfra_

[FFmpeg-devel] [PATCH 2/3] lavf/mov: Always try to parse mfra

This one is perhaps a bit dubious, but on frags.mp4 it saves a seek. I have no strong feelings on this patch, it just struck me as far simpler to always read mfra I checked the ISO/IEC spec and mfra may be present in any file that is isom branded. Usually it is only present for fragmented files I

[FFmpeg-devel] [PATCH 3/3] lavf/mov: Parse and verify the whole mfro box

This saves a seek on files that don't have mfra but where the last 4 bytes happen to seeem valid It just struck me that we could tighten the bound on mfra_size, because it has to be at least 24 /Tomas From ccf83120683dcbcaba9191c058b820e516392b11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H

[FFmpeg-devel] [PATCH 3/5] lavc/packet: add API for an AVPacket-based AVContainerFifo

--- doc/APIchanges | 3 +++ libavcodec/packet.c | 33 + libavcodec/packet.h | 7 +++ libavcodec/version.h | 2 +- 4 files changed, 44 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 5d75b6077d..31b9ed175b 100644 --- a/

[FFmpeg-devel] [PATCH 2/5] lavc/container_fifo: move to lavu and make public

This can be useful in other places, e.g. it can replace objpool in fftools. The API is modified in the following nontrivial ways: * opaque pointers can be passed through to all user callbacks * read and write were previously separate callbacks in order to accomodate the caller wishing to write a

[FFmpeg-devel] [PATCH 5/5] fftools/sync_queue: switch from AVFifo+ObjPool to AVContainerFifo

Remove now-unused objpool. --- fftools/Makefile | 1 - fftools/objpool.c| 131 --- fftools/objpool.h| 37 fftools/sync_queue.c | 93 ++ 4 files changed, 29 insertions(+), 233 deletions(-) delete mode

[FFmpeg-devel] [PATCH 4/5] fftools/thread_queue: switch from AVFifo+ObjPool to AVContainerFifo

The queue needs to track each frame/packet's stream index, this is achieved by maintaining a parallel AVFifo instance for that purpose. This is simpler than implementing custom AVContainerFifo callbacks. --- fftools/ffmpeg_sched.c | 14 ++--- fftools/ffmpeg_utils.h | 10 -- fftools/thread_

Re: [FFmpeg-devel] [PATCH v2] Use AVBufferPool in MOV

On 11/12/2024 10:10, Arnaud Masserann wrote: Hi, any feedback on this patch ? I do not appear to have received the mail you are replying to here ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH v2 02/16] swscale/utils: add HDR metadata to SwsFormat

On Wed, 11 Dec 2024 01:35:25 +0100 Michael Niedermayer wrote: > Hi > > On Fri, Dec 06, 2024 at 03:32:01PM +0100, Niklas Haas wrote: > > From: Niklas Haas > > > > Only add the condensed values that we actually care about. Group them into > > a new struct to make it easier to discard or replace th

Re: [FFmpeg-devel] [PATCH v2 02/16] swscale/utils: add HDR metadata to SwsFormat

On Wed, 11 Dec 2024 01:35:25 +0100 Michael Niedermayer wrote: > Hi > > On Fri, Dec 06, 2024 at 03:32:01PM +0100, Niklas Haas wrote: > > From: Niklas Haas > > > > Only add the condensed values that we actually care about. Group them into > > a new struct to make it easier to discard or replace th

Re: [FFmpeg-devel] [PATCH v2] Use AVBufferPool in MOV

Hi, any feedback on this patch ? Thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] checkasm: Print benchmarks of C-only functions

On Wed, 23 Oct 2024, Martin Storsjö wrote: This corresponds to commit 9278a14cf406f8edb5052c42b83750112bf5b515 in dav1d. Omitting the C-only functions doesn't speed up benchmarking anyway (as those has to be benchmarked before we know if we have any corresponding assembly functions), and being

[FFmpeg-devel] [PATCH] swscale/slice: fix init of 32 bpc planes

From: Niklas Haas In input.c and output.c and many other places, swscale follows the rule of using 15-bit intermediate if output bpc is <= 8, and 19-bit (inside int32_t) intermediate otherwise. See e.g. the comments on hyScale() on swscale_internal.h. These are also the coefficients that yuv2gbrp