Re: [FFmpeg-devel] [PATCH 2/2] aarch64/vvc: Use faster clip operation

2024-12-09 Thread Martin Storsjö
On Tue, 10 Dec 2024, Zhao Zhili wrote: From: Zhao Zhili Replace sqxtn+smin+smax by sqxtun+umin. --- libavcodec/aarch64/vvc/inter.S | 41 +++--- 1 file changed, 18 insertions(+), 23 deletions(-) Both these patches look good to me, thanks! // Martin ___

Re: [FFmpeg-devel] [PATCH 1/2] aarch64/vvc: Fix clip in alf

2024-12-09 Thread Martin Storsjö
On Tue, 10 Dec 2024, Zhao Zhili wrote: From: Zhao Zhili Fix test failure: ./tests/checkasm/checkasm --test=vvc_alf 3607569773 --- libavcodec/aarch64/vvc/alf.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) After pushing (and after leaving it in git master for a little while), this

[FFmpeg-devel] [PATCH 2/2] aarch64/vvc: Use faster clip operation

2024-12-09 Thread Zhao Zhili
From: Zhao Zhili Replace sqxtn+smin+smax by sqxtun+umin. --- libavcodec/aarch64/vvc/inter.S | 41 +++--- 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/libavcodec/aarch64/vvc/inter.S b/libavcodec/aarch64/vvc/inter.S index b6b079b569..7a752019ee 100644

[FFmpeg-devel] [PATCH 1/2] aarch64/vvc: Fix clip in alf

2024-12-09 Thread Zhao Zhili
From: Zhao Zhili Fix test failure: ./tests/checkasm/checkasm --test=vvc_alf 3607569773 --- libavcodec/aarch64/vvc/alf.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/aarch64/vvc/alf.S b/libavcodec/aarch64/vvc/alf.S index c624093640..8801b3afb6 100644 --- a/li

Re: [FFmpeg-devel] [PATCH v2] checkasm: vvc: Use checkasm_check for printing failing output

2024-12-09 Thread Ronald S. Bultje
Hi, On Mon, Dec 9, 2024 at 5:02 PM Martin Storsjö wrote: > Share the checkasm_check_pixel macro from hevc_pel in checkasm.h, > to allow other tests to use the same. (To use it in other tests, > those tests need to have a similar setup for high bitdepth pixels, > with a local variable named "bit_

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: Add option to correct subtitles duration in webvtt subtitles

2024-12-09 Thread Vladimir Kharchevin
Hi Jan, Thanks for your respond. You’re right, it is really makes sense to process this behavior at the WebVTT muxer. Unfortunately WebVTT specs don’t foresee the feature like ’show until next’. So it would look like in the patch below. Thanks, Vladimir Signed-off-by: Vladimir Kharchevin ---

[FFmpeg-devel] [PATCH v2] checkasm: vvc: Use checkasm_check for printing failing output

2024-12-09 Thread Martin Storsjö
Share the checkasm_check_pixel macro from hevc_pel in checkasm.h, to allow other tests to use the same. (To use it in other tests, those tests need to have a similar setup for high bitdepth pixels, with a local variable named "bit_depth".) This simplifies the code for checking the output, and can

[FFmpeg-devel] [PATCH v3] fate: Add a target for listing failed tests

2024-12-09 Thread Martin Storsjö
If running tests with "make -j fate", the execution will stop after the first failing test. To get an overview of the whole test suite, one rather would run "make -k -j fate", which then again buries the results about what tests actually failed further up in the console log. Add a target so one ca

Re: [FFmpeg-devel] [PATCH] web: Add link to conferences page

2024-12-09 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-08 12:36 +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > src/template_head2 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/template_head2 b/src/template_head2 > index 0394ace..51da347 100644 > --- a/src/template_head2 > +++ b/src/template_he

Re: [FFmpeg-devel] [PATCH] avcodec/png{dec, enc}: update mDCV and cLLI chunk capitalization

2024-12-09 Thread Leo Izen
On 12/8/24 2:23 PM, Jan Ekström wrote: On Sun, Dec 1, 2024 at 4:21 PM Leo Izen wrote: The PNGv3 Specification Draft [1] has changed the capitalization of mDCV and cLLI chunks (formerly mDCv and cLLi). This patch updates FFmpeg to work with the new chunk names while retaining decode-side comp

[FFmpeg-devel] [PATCH] avutil/file: fix av_file_map file mapping on Windows

2024-12-09 Thread Kacper Michajłow
This makes the behavior of av_file_map() the same on Windows as it is on other platforms. The file is opened as read-only, but the mapping is copy-on-write, allowing the user to write to the memory pages returned by av_file_map(). This commit fixes libavutil\tests\file.c test, which would crash wh

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC election

2024-12-09 Thread Anton Khirnov
Hi all, the vote has been started (with a slight delay due to server issues). If you are in the GA (the tools/general_assembly.pl script lists your name), you should receive an email soon. If you do not, complain in this thread. -- Anton Khirnov ___ ffm

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: Add option to correct subtitles duration in webvtt subtitles

2024-12-09 Thread Jan Ekström
On Mon, Dec 9, 2024 at 1:24 PM Vladimir Kharchevin wrote: > > When importing text subtitles from libzvbi_teletext stream the duration of > subtitle > frames is -1 by default or fixed value per codec setting. > For hls webvtt stream it makes disappear time always 1193:02:47.295 for every > subtit

Re: [FFmpeg-devel] [PATCH] checkasm: vvc: Use checkasm_check for printing failing output

2024-12-09 Thread Martin Storsjö
On Mon, 9 Dec 2024, Ronald S. Bultje wrote: Hi, On Mon, Dec 9, 2024 at 9:17 AM Martin Storsjö wrote: On Mon, 9 Dec 2024, Ronald S. Bultje wrote: > Secondly, can we share checkasm_check_pixel in a more general location so > other codecs can use it too? Ideally, yes. But the problem is in t

Re: [FFmpeg-devel] [PATCH] checkasm: vvc: Use checkasm_check for printing failing output

2024-12-09 Thread Ronald S. Bultje
Hi, On Mon, Dec 9, 2024 at 9:17 AM Martin Storsjö wrote: > On Mon, 9 Dec 2024, Ronald S. Bultje wrote: > > > Secondly, can we share checkasm_check_pixel in a more general location so > > other codecs can use it too? > > Ideally, yes. > > But the problem is in the way multi-bitdepth codecs are ha

Re: [FFmpeg-devel] [PATCH] checkasm: vvc: Use checkasm_check for printing failing output

2024-12-09 Thread Martin Storsjö
On Mon, 9 Dec 2024, Ronald S. Bultje wrote: Secondly, can we share checkasm_check_pixel in a more general location so other codecs can use it too? Ideally, yes. But the problem is in the way multi-bitdepth codecs are handled in ffmpeg/checkasm, compared to how it is done in dav1d. In dav1d w

Re: [FFmpeg-devel] [PATCH] checkasm: vvc: Use checkasm_check for printing failing output

2024-12-09 Thread Ronald S. Bultje
Hello, On Mon, Dec 9, 2024 at 7:25 AM Martin Storsjö wrote: > This simplifies the code for checking the output, and can print > the failing output (including a map of matching/mismatching > elements) if checkasm is run with the -v/--verbose option. > First off: yay \o/ Secondly, can we share c

[FFmpeg-devel] [PATCH] checkasm: vvc: Use checkasm_check for printing failing output

2024-12-09 Thread Martin Storsjö
This simplifies the code for checking the output, and can print the failing output (including a map of matching/mismatching elements) if checkasm is run with the -v/--verbose option. This is similar to what was done for hevc_pel in 8ff4a4a4f4f73c5e276fa0cbe6cd5a148ebdd4ae. --- tests/checkasm/vvc_

[FFmpeg-devel] [PATCH] libavformat/hlsenc: Add option to correct subtitles duration in webvtt subtitles

2024-12-09 Thread Vladimir Kharchevin
When importing text subtitles from libzvbi_teletext stream the duration of subtitle frames is -1 by default or fixed value per codec setting. For hls webvtt stream it makes disappear time always 1193:02:47.295 for every subtitle. Suggested to add hls option fix_teletext_durations to fix this b