[FFmpeg-devel] [PATCH v2] libavformat/mpegts: demux DVB VBI data

2024-11-29 Thread Scott Theisen
DVB VBI data is defined in ETSI EN 301 775 and can include EBU teletext data as defined in ETSI EN 300 472. ETSI EN 300 468 defines teletext_descriptor, VBI_data_descriptor, and VBI_teletext_descriptor, which has the same definition as, but different use from, teletext_descriptor. --- libavcodec/

Re: [FFmpeg-devel] [PATCH] libavcodec/mpegaudio_parser.c: differentiate MPEG audio dual mono

2024-11-29 Thread Scott Theisen
On 11/25/24 00:42, Anton Khirnov wrote: Quoting Scott Theisen (2024-11-14 05:37:49) @@ -85,7 +85,13 @@ static int mpegaudio_parse(AVCodecParserContext *s1, if (s->header_count > header_threshold) { avctx->sample_rate= sr;

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ffv1enc: Add enum for qtable

2024-11-29 Thread Lynne via ffmpeg-devel
On 30/11/2024 04:33, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index c96c71b1096..742db549e5f 100644 --- a/libavcodec/ff

Re: [FFmpeg-devel] [PATCH 3/6] lavc/vvc: Store MIP information over entire CU area

2024-11-29 Thread Nuo Mi
On Fri, Nov 29, 2024 at 6:19 AM Frank Plowman wrote: > Previously, the code only stored the MIP mode and transpose flag in the > relevant tables at the top-left corner of the CU. This information ends > up being retrieved in ff_vvc_intra_pred_* not based on the CU position > but instead the tran

Re: [FFmpeg-devel] [PATCH 4/6] lavc/vvc: Fix scaling matrix DC coef derivation

2024-11-29 Thread Nuo Mi
Hi Frank, Thank you for the patch set; I will apply it except for this one On Fri, Nov 29, 2024 at 6:19 AM Frank Plowman wrote: > In 7.4.3.20 of H.266 (V3), there are two similarly-named variables: > scalingMatrixDcPred and ScalingMatrixDcRec. The old code set > ScalingMatrixDcRec, rather than

Re: [FFmpeg-devel] [PATCH 2/2] libavformat/mpegts: demux DVB VBI data

2024-11-29 Thread Scott Theisen
On 11/24/24 13:17, Marton Balint wrote: On Fri, 22 Nov 2024, Scott Theisen wrote: On 11/22/24 16:12, Marton Balint wrote:  On Fri, 15 Nov 2024, Scott Theisen wrote:  From: ulmus-scott  DVB VBI data is defined in ETSI EN 301 775 and can include EBU teletext  data  as defined in ETSI E

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Fix overflow in corrected_dts

2024-11-29 Thread James Almer
On 11/29/2024 11:20 PM, Michael Niedermayer wrote: This fix doesnt feel optimal, better fix is welcome Would you be ok with the C23 stdckdint.h compat header patch i sent two months ago being committed and used for this kind of overflow? I ask because the only con from using it is that backpor

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/rawenc: propagate the Producer Reference time

2024-11-29 Thread James Almer
On 11/1/2024 2:21 PM, Clément Péron wrote: The Producer Reference time contains the source time when the frame has been produced. This is usefull in the muxer so propagate it. Signed-off-by: Clément Péron --- libavcodec/rawenc.c | 12 1 file changed, 12 insertions(+) diff --git

[FFmpeg-devel] [PATCH 3/3] avformat/mov: Fix overflow in corrected_dts

2024-11-29 Thread Michael Niedermayer
This fix doesnt feel optimal, better fix is welcome Fixes: signed integer overflow: -9223091047224049440 + -281474976645120 cannot be represented in type 'long long' Fixes: 376128123/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4533016505942016 Found-by: continuous fuzzing process http

[FFmpeg-devel] [PATCH 2/3] tools/target_swr_fuzzer: do not use negative numbers of samples

2024-11-29 Thread Michael Niedermayer
Fixes: signed integer overflow: -277109688 * 8 cannot be represented in type 'int' Fixes: 376118159/clusterfuzz-testcase-minimized-ffmpeg_SWR_fuzzer-5884436320681984 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nieder

[FFmpeg-devel] [PATCH 1/3] avcodec/huffyuvdec: Initialize whole output for decode_gray_bitstream()

2024-11-29 Thread Michael Niedermayer
Fixes: use of uninitialized memory Fixes: 375286238/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-6352546854141952 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/huffyuvdec.c

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/cbs_h266: check subpicture slices number

2024-11-29 Thread Nuo Mi
On Fri, Nov 29, 2024 at 6:23 AM Frank Plowman wrote: > On 23/11/2024 09:32, Nuo Mi wrote: > > According to section 6.3.3, 'Spatial or component-wise partitionings,' > > Subpictures must cover the entire picture. > > Therefore, the total number of subpicture slices should equal the number > of pic

[FFmpeg-devel] [PATCH] avformat/mov: add support for pssh box

2024-11-29 Thread James Almer
From: Malek Assaad * Enable PSSH box writing to mov & moof. * Enable senc, saio & saiz writing to moof when writing fragments. Signed-off-by: James Almer --- libavformat/movenc.c | 48 ++-- libavformat/movenccenc.c | 5 +++-- libavformat/movenccenc.h |

Re: [FFmpeg-devel] [PATCH] avcodec/vc2enc: Initial vulkan VC2 encoder

2024-11-29 Thread Lynne via ffmpeg-devel
On 30/11/2024 05:09, IndecisiveTurtle wrote: Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths. Performance wise, encoding a 1080p 1-minute video is performed in about 2.5 minutes with the cpu encoder running on my Ryzen 5 4600H

Re: [FFmpeg-devel] When will the patch mentioned at the following URL be merged into its source code?

2024-11-29 Thread epirat07
On 30 Nov 2024, at 1:35, Bryan Kirk via ffmpeg-devel wrote: > *subject* > > https://ffmpeg.org/pipermail/ffmpeg-devel/2024-May/328600.html Hi, a later iteration of this is merged, with the movflags flag name of hybrid_fragmented, you can find it in the docs here: https://ffmpeg.org/ffmpeg-for

[FFmpeg-devel] When will the patch mentioned at the following URL be merged into its source code?

2024-11-29 Thread Bryan Kirk via ffmpeg-devel
*subject* https://ffmpeg.org/pipermail/ffmpeg-devel/2024-May/328600.html ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org w

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/cuvid: introduce a ringbuffer to reattach additional data

2024-11-29 Thread Timo Rothenpieler
On 29.11.2024 21:46, Clément Péron wrote: On Fri, 29 Nov 2024 at 20:06, Timo Rothenpieler wrote: On 01.11.2024 18:21, Clément Péron wrote: From: Troy Benson Cuvid data packet have specific format that don't contain any side data. In order to keep additional information and metadata, we need

Re: [FFmpeg-devel] libavformat/demux.c: MythTV added NULL checks

2024-11-29 Thread Scott Theisen
On 11/28/24 10:07, Anton Khirnov wrote: Quoting Scott Theisen (2024-11-14 06:52:05) I don't know if any of these are still necessary since I have reduced MythTV's modifications to FFmpeg and replaced all uses of internal functions. All of these look quite suspicious to me - the flow should neve

Re: [FFmpeg-devel] [PATCH v2 4/4] tests/fate/filter-audio: add aloop test

2024-11-29 Thread Marton Balint
On Tue, 5 Nov 2024, Anton Khirnov wrote: Quoting Marton Balint (2024-11-05 08:15:31) v2: use -filter_complex instead of -f lavfi to generate input Signed-off-by: Marton Balint --- tests/fate/filter-audio.mak | 3 +++ tests/ref/fate/filter-aloop | 45 +

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/asrc_sine: increase frequency accuracy

2024-11-29 Thread Marton Balint
On Thu, 28 Nov 2024, Nicolas George wrote: Marton Balint (12024-11-10): Previously the delta phase was fixed point fractional with 2^32 fractions, which caused inaccuracies in the output frequency, unless the input frequency*2^32 was divisable by the sample rate. This patch improves frequen

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/cuvid: introduce a ringbuffer to reattach additional data

2024-11-29 Thread Clément Péron
On Fri, 29 Nov 2024 at 20:06, Timo Rothenpieler wrote: > > On 01.11.2024 18:21, Clément Péron wrote: > > From: Troy Benson > > > > Cuvid data packet have specific format that don't contain any side data. > > In order to keep additional information and metadata, we need to implement > > a ring buf

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/rawenc: propagate the Producer Reference time

2024-11-29 Thread Clément Péron
Hi Michael, On Fri, 29 Nov 2024 at 20:22, Michael Niedermayer wrote: > > Hi > > On Fri, Nov 01, 2024 at 06:21:23PM +0100, Clément Péron wrote: > > The Producer Reference time contains the source time when the frame > > has been produced. This is usefull in the muxer so propagate it. > > > > Signe

[FFmpeg-devel] [PATCH] avcodec/vc2enc: Initial vulkan VC2 encoder

2024-11-29 Thread IndecisiveTurtle
Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths. Performance wise, encoding a 1080p 1-minute video is performed in about 2.5 minutes with the cpu encoder running on my Ryzen 5 4600H, while it takes about 30 seconds on my NVIDIA

[FFmpeg-devel] [PATCH 2/2] doc/encoders: very basic FFv1 documentation

2024-11-29 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/encoders.texi | 38 ++ 1 file changed, 38 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 0749417db4f..c0795fe5fd5 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -529,6 +529,44 @@ Sel

[FFmpeg-devel] [PATCH 1/2] avcodec/ffv1enc: Add enum for qtable

2024-11-29 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index c96c71b1096..742db549e5f 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.c @@ -41,6 +41,12 @@

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec/rawenc: propagate the Producer Reference time

2024-11-29 Thread Michael Niedermayer
Hi On Fri, Nov 01, 2024 at 06:21:23PM +0100, Clément Péron wrote: > The Producer Reference time contains the source time when the frame > has been produced. This is usefull in the muxer so propagate it. > > Signed-off-by: Clément Péron > --- > libavcodec/rawenc.c | 12 > 1 file cha

Re: [FFmpeg-devel] [PATCH v2 3/3] avcodec/cuvid: introduce a ringbuffer to reattach additional data

2024-11-29 Thread Timo Rothenpieler
On 01.11.2024 18:21, Clément Péron wrote: From: Troy Benson Cuvid data packet have specific format that don't contain any side data. In order to keep additional information and metadata, we need to implement a ring buffer and reattach side data to decoded frame. Signed-off-by: Troy Benson Sig

Re: [FFmpeg-devel] [PATCH v2 0/3] Propagate PRFT side data

2024-11-29 Thread Clément Péron
Hi Timo, Michael On Fri, 1 Nov 2024 at 18:39, Clément Péron wrote: > > Hi, > > This is in the continuity of the v1 that was sent in September. > > The idea is to be able to access the Producer Timestamp aka PRFT > of a RTSP stream in the encoder to be able to write it in the final > file. > > The

[FFmpeg-devel] [PATCH] avformat/iamf_parse: ambisonics mode > 1 will crash

2024-11-29 Thread Michael Niedermayer
ambisonics mode > 1 does not initialize any layer but layer 0 is unconditionally dereferenced Fixes: poc-2024-11 Fixes: null pointer dereference Found-by: 苏童 <220235...@seu.edu.cn> Signed-off-by: Michael Niedermayer --- libavformat/iamf_parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[FFmpeg-devel] Community

2024-11-29 Thread Michael Niedermayer
Hi all There are a few independant issues: * iam concerned about the rise of bitter hatred on the mailing list. * Whoever has the majority in the GA will by extension have the majority in the CC and the CC then may act with bias accordingly. * After over 3 weeks of attacks in some threads, an

Re: [FFmpeg-devel] [RFC] infrastructure documentation

2024-11-29 Thread Michael Niedermayer
Hi Anton On Thu, Nov 28, 2024 at 04:17:00PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-11-19 23:16:17) > > > > 3. who has what access (physical and remote/software). > > > > 4. Who owns avcodec.org? Who runs these DNS servers? Who has access? > > > > Who has contacts? > > > >

Re: [FFmpeg-devel] [PATCH 1/6] avutil/frame: add av_frame_remove_side_data_changed

2024-11-29 Thread James Almer
On 5/2/2024 7:11 AM, Niklas Haas wrote: On Fri, 26 Apr 2024 16:29:03 -0300 James Almer wrote: On 4/26/2024 9:27 AM, Niklas Haas wrote: From: Niklas Haas Many filters modify certain aspects of frame data, e.g. through resizing (vf_*scale* family), color volume mapping (vf_lut*, vf_tonemap*),

Re: [FFmpeg-devel] [PATCH 1/6] avutil/frame: add av_frame_remove_side_data_changed

2024-11-29 Thread Niklas Haas
On Thu, 02 May 2024 12:11:25 +0200 Niklas Haas wrote: > On Fri, 26 Apr 2024 16:29:03 -0300 James Almer wrote: > > On 4/26/2024 9:27 AM, Niklas Haas wrote: > > > From: Niklas Haas > > > > > > Many filters modify certain aspects of frame data, e.g. through resizing > > > (vf_*scale* family), color

Re: [FFmpeg-devel] [PATCH] avcodec/pthread_frame: rework assert

2024-11-29 Thread Thomas Guillem via ffmpeg-devel
Sorry for the spam. "avcodec: uninit hwaccel in case of software decoder" is a better version. On Fri, Nov 29, 2024, at 09:37, Thomas Guillem via ffmpeg-devel wrote: > This patch is an alternative to the patch "avcodec: add > avcodec_reset_hw_frames_parameters(): > > On Fri, Nov 29, 2024, at 09:

[FFmpeg-devel] [PATCH] avcodec: uninit hwaccel in case of software decoder

2024-11-29 Thread Thomas Guillem via ffmpeg-devel
avcodec_get_hw_frames_parameters(), called by the user from get_format, is allocating ctx->internal->hwaccel_priv_data. But the hardware decoding setup may fail on the user side and it may fallback to software decoding. In that case, ctx->internal->hwaccel_priv_data is still allocated but not used

Re: [FFmpeg-devel] [PATCH] avcodec: add avcodec_reset_hw_frames_parameters()

2024-11-29 Thread Thomas Guillem via ffmpeg-devel
Or you can check the alternative patch: "avcodec/pthread_frame: rework assert" On Thu, Nov 28, 2024, at 16:57, Thomas Guillem via ffmpeg-devel wrote: > usage example: > > AVBufferRef *hwframes_ref; > int ret = avcodec_get_hw_frames_parameters(ctx, hwdev_ref, hwfmt, >

Re: [FFmpeg-devel] [PATCH] avcodec/pthread_frame: rework assert

2024-11-29 Thread Thomas Guillem via ffmpeg-devel
This patch is an alternative to the patch "avcodec: add avcodec_reset_hw_frames_parameters(): On Fri, Nov 29, 2024, at 09:34, Thomas Guillem via ffmpeg-devel wrote: > avcodec_get_hw_frames_parameters(), called by the user from get_format, > is allocating ctx->internal->hwaccel_priv_data. But the

[FFmpeg-devel] [PATCH] avcodec/pthread_frame: rework assert

2024-11-29 Thread Thomas Guillem via ffmpeg-devel
avcodec_get_hw_frames_parameters(), called by the user from get_format, is allocating ctx->internal->hwaccel_priv_data. But the hardware decoding setup may fail on the user side and it may fallback to software decoding. In that case, ctx->internal->hwaccel_priv_data is still allocated but not used