[FFmpeg-devel] [PATCH v2 4/4] tests/fate/filter-audio: add aloop test

2024-11-04 Thread Marton Balint
v2: use -filter_complex instead of -f lavfi to generate input Signed-off-by: Marton Balint --- tests/fate/filter-audio.mak | 3 +++ tests/ref/fate/filter-aloop | 45 + 2 files changed, 48 insertions(+) create mode 100644 tests/ref/fate/filter-aloop diff --g

Re: [FFmpeg-devel] [PATCH 2/4] avfilter/f_loop: fix length of aloop leftover buffer

2024-11-04 Thread Marton Balint
On Mon, 4 Nov 2024, James Almer wrote: On 11/4/2024 5:30 PM, Marton Balint wrote: If the audio loop stops inside an audio frame, the leftover buffer contains the end of the frame, which is not looped. The length supposed to be the part which was not written to the loop buffer, so we nee

Re: [FFmpeg-devel] [PATCH] avformat/gifdec: There is an overflow int64_t receiving with int

2024-11-04 Thread Zhao Zhili
> On Nov 5, 2024, at 08:36, wzq via ffmpeg-devel > wrote: > > From: wzqzero <1918583...@qq.com> > > When converting a two-minute 3840 x 2160 video to a GIF file, > the viewing duration is shorter than the source duration when you use ffmpeg > -i, > which is due to data overflow, > which caus

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: clear window

2024-11-04 Thread James Almer
On 11/4/2024 11:23 PM, Michael Niedermayer wrote: Fixes: Use of uninitialised value of size 8 Odd, the only load op with dec->window appears to be 4 bytes. Fixes: 368725676/clusterfuzz-testcase-minimized-fuzzer_protocol_file-6022251122589696-cut Fixes: 42537758/clusterfuzz-testcase-minimize

Re: [FFmpeg-devel] [PATCH v2] libavutil/hwcontext_{d3d11va, dxva2}: Support Y212/XV36 pixel format

2024-11-04 Thread Wang, Fei W
On Mon, 2024-11-04 at 10:15 -0300, James Almer wrote: > On 11/4/2024 12:53 AM, fei.w.wang-at-intel@ffmpeg.org wrote: > > From: Fei Wang > > > > Use DXGI/D3DFMT 16bit pixel format to compatible with 12bit > > Y212/XV36 > > since there is no 12bit pixel defined in D3D11/D3D9. > > > > Fix cmdli

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: clear window

2024-11-04 Thread Michael Niedermayer
Fixes: Use of uninitialised value of size 8 Fixes: 368725676/clusterfuzz-testcase-minimized-fuzzer_protocol_file-6022251122589696-cut Fixes: 42537758/clusterfuzz-testcase-minimized-fuzzer_protocol_file-5818969469026304-cut Found-by: ossfuzz Reported-by: Kacper Michajlow Signed-off-by: Michael Ni

[FFmpeg-devel] [PATCH] avformat/gifdec: There is an overflow int64_t receiving with int

2024-11-04 Thread wzq via ffmpeg-devel
From: wzqzero <1918583...@qq.com> When converting a two-minute 3840 x 2160 video to a GIF file, the viewing duration is shorter than the source duration when you use ffmpeg -i, which is due to data overflow, which causes positive numbers to become negative after being assigned, causing the gif_ski

Re: [FFmpeg-devel] [RFC] Issue tarcker state for fate tests

2024-11-04 Thread Steven Liu
Michael Niedermayer 于2024年11月5日 周二04:34写道: > Hi all > > I think, in general most fixed issues (both bugs and features) > should have a test added to fate. > > To make that actually happen i suggest to introduce a state like > "fixed_and_fate_test" to trac > > That way we can track if a closed issu

Re: [FFmpeg-devel] [PATCH 2/4] avfilter/f_loop: fix length of aloop leftover buffer

2024-11-04 Thread James Almer
On 11/4/2024 5:30 PM, Marton Balint wrote: If the audio loop stops inside an audio frame, the leftover buffer contains the end of the frame, which is not looped. The length supposed to be the part which was not written to the loop buffer, so we need to drain exactly that number of bytes from the

[FFmpeg-devel] [PATCH 3/4] avfilter/f_loop: fix aloop activate logic

2024-11-04 Thread Marton Balint
The logic did not follow the documented behaviour and that caused skipping of some audio in the loop and in the leftover buffer. Example command line which should produce a smooth sine wave for the whole duration of the output: ffmpeg -f lavfi -i "sine=r=48000:f=480:d=4" -af "aloop=loop=4:start=

[FFmpeg-devel] [PATCH 4/4] tests/fate/filter-audio: add aloop test

2024-11-04 Thread Marton Balint
Signed-off-by: Marton Balint --- tests/fate/filter-audio.mak | 3 +++ tests/ref/fate/filter-aloop | 45 + 2 files changed, 48 insertions(+) create mode 100644 tests/ref/fate/filter-aloop diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak

[FFmpeg-devel] [PATCH 1/4] avfilter/asrc_sine: increase phase precision

2024-11-04 Thread Marton Balint
Signed-off-by: Marton Balint --- libavfilter/asrc_sine.c | 16 +- tests/ref/fate/copy-shortest1 | 58 ++--- tests/ref/fate/copy-shortest2 | 58 ++--- tests/ref/fate/filter-concat| 344 ++-- tests/ref/fate/filter-concat-vfr| 344 ++

[FFmpeg-devel] [PATCH 2/4] avfilter/f_loop: fix length of aloop leftover buffer

2024-11-04 Thread Marton Balint
If the audio loop stops inside an audio frame, the leftover buffer contains the end of the frame, which is not looped. The length supposed to be the part which was not written to the loop buffer, so we need to drain exactly that number of bytes from the leftover buffer. Signed-off-by: Marton Balin

[FFmpeg-devel] [RFC] Issue tarcker state for fate tests

2024-11-04 Thread Michael Niedermayer
Hi all I think, in general most fixed issues (both bugs and features) should have a test added to fate. To make that actually happen i suggest to introduce a state like "fixed_and_fate_test" to trac That way we can track if a closed issue has had a fate test added (using the existing "fixed" to

[FFmpeg-devel] [PATCH 3/3] swscale/swscale_unscaled: add unscaled x2rgb10le to packed RGB

2024-11-04 Thread James Almer
Signed-off-by: James Almer --- libswscale/rgb2rgb.c | 58 +++ libswscale/rgb2rgb.h | 9 ++ libswscale/swscale_unscaled.c | 30 ++ 3 files changed, 97 insertions(+) diff --git a/libswscale/rgb2rgb.c b/libswscale/rgb2rgb.c inde

Re: [FFmpeg-devel] [PATCH 1/5] avutil: add hwcontext_amf.

2024-11-04 Thread Mironov, Mikhail via ffmpeg-devel
[AMD Official Use Only - AMD Internal Distribution Only] > Why yet another crappy hardware API? There is a million of those. > Why yet another crappy special snowflake hardware decoder? We have more of > those than we want (which is 0). > > As Mark has also previously commented, the hwcontext impl

Re: [FFmpeg-devel] [PATCH] avcodec/ac3dec: fix build when eac3 decoder is disabled

2024-11-04 Thread Nicolas Gaullier
>Envoyé : dimanche 27 octobre 2024 01:01 >Objet : [PATCH] avcodec/ac3dec: fix build when eac3 decoder is disabled > > libavcodec/ac3dec_fixed.c | 3 +++ > libavcodec/ac3dec_float.c | 2 ++ > 2 files changed, 5 insertions(+) Ping ? Maybe I should detail a little bit more about the "actual" issue in

Re: [FFmpeg-devel] [PATCH] avformat/sapdec: check return value of avcodec_parameters_copy()

2024-11-04 Thread Marth64
Ping if anyone is familiar with this format, thanks On Sat, Oct 12, 2024 at 12:32 Marth64 wrote: > Written in the dominant style of the surrounding code block. > > Signed-off-by: Marth64 > --- > libavformat/sapdec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/li

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: set FF_CODEC_PROPERTY_CLOSED_CAPTIONS in mpeg_set_cc_format()

2024-11-04 Thread Marth64
Ping, thank you On Sun, Oct 13, 2024 at 06:33 Anton Khirnov wrote: > Quoting Marth64 (2024-10-12 20:04:50) > > When Closed Captions are discovered, this method is always invoked. > > Therefore, use it to set the property instead of repeating the statement. > > > > Signed-off-by: Marth64 > > ---

[FFmpeg-devel] [PATCH 1/2] avformat/mov: if pos has been reset, clear fragments and indexes and search for next root

2024-11-04 Thread vectronic
fixes https://trac.ffmpeg.org/ticket/7359 Signed-off-by: vectronic --- libavformat/mov.c | 39 --- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 8c3329b815..c994da0f5a 100644 --- a/libavformat/mov.c

[FFmpeg-devel] [PATCH 2/2] avformat/hls: improve comment

2024-11-04 Thread vectronic
Signed-off-by: vectronic --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 62473a15dd..045741c3b4 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2502,7 +2502,7 @@ static int hls_read_seek(AVFormatConte

[FFmpeg-devel] [PATCH 0/2] fix for seeking in HLS with FMP4 media

2024-11-04 Thread vectronic
I am again updating and resubmitting a patch which fixes the following ticket: https://trac.ffmpeg.org/ticket/7359 This fix has been tested and recommended by several people now and I have been using it in production successfully since I submitted it 6 years ago... The main patch in the series

[FFmpeg-devel] [PATCH 1/2] swscale/swscale_unscaled: add swscale/swscale_unscaled: add unscaled x2rgb10le to planar RGB

2024-11-04 Thread James Almer
Signed-off-by: James Almer --- Supersedes "swscale/swscale_unscaled: add swscale/swscale_unscaled: add unscaled x2rgb10le to gbrp10" libswscale/swscale_unscaled.c | 88 +++ tests/ref/pixfmt/gbrp10-x2bgr10le | 2 +- tests/ref/pixfmt/gbrp10-x2rgb10le | 2 +- 3 fi

Re: [FFmpeg-devel] [PATCH v2] libavutil/hwcontext_{d3d11va, dxva2}: Support Y212/XV36 pixel format

2024-11-04 Thread James Almer
On 11/4/2024 12:53 AM, fei.w.wang-at-intel@ffmpeg.org wrote: From: Fei Wang Use DXGI/D3DFMT 16bit pixel format to compatible with 12bit Y212/XV36 since there is no 12bit pixel defined in D3D11/D3D9. Fix cmdline on Windows: $ ffmpeg.exe -hwaccel qsv -init_hw_device qsv:hw,child_device_type