[FFmpeg-devel] [PATCH 1/7] avutil/pixfmt: add XV48 pixel format

2024-10-23 Thread James Almer
Much like XV30 and XV36 in d75c4693fef51e8f0a1b88798530f4c5147ea906, XV48 is added to support 16bit 4:4:4 as defined by Microsoft. Signed-off-by: James Almer --- libavutil/pixdesc.c | 25 + libavutil/pixfmt.h | 4 libavutil/tests/pixfmt_be

Re: [FFmpeg-devel] [PATCH v3 09/18] swscale/internal: use static_assert for enforcing offsets

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:18PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Instead of sprinkling av_assert0 into random init functions. > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/swscale_internal.h | 11 +++ > libswscale/utils.c

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/ffv1enc: Prevent generation of files with broken slices

2024-10-23 Thread Michael Niedermayer
On Fri, Oct 11, 2024 at 09:39:14AM +0200, Lynne via ffmpeg-devel wrote: > On 01/10/2024 22:31, Michael Niedermayer wrote: [...] > > +int i = width * (int64_t)(num_h_slices - 1) / num_h_slices; > > + > > +return width % mpw && (width - i) % mpw == 0; > > Would a check (if height < (subsampl

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffplay: constrain supported YUV color spaces

2024-10-23 Thread Michael Niedermayer
On Fri, Feb 09, 2024 at 08:14:46PM +, Niklas Haas wrote: > ffmpeg | branch: master | Niklas Haas | Mon Feb 5 19:28:04 > 2024 +0100| [c619d20906d039060efbeaa822daf8e949f3ef24] | committer: Niklas > Haas > > fftools/ffplay: constrain supported YUV color spaces > > SDL supports only these th

[FFmpeg-devel] [PATCH 2/3] avutil/hwcontext_vulkan: add support for AV_PIX_FMT_Y216

2024-10-23 Thread James Almer
Signed-off-by: James Almer --- libavutil/hwcontext_vulkan.c | 1 + libavutil/vulkan.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 35660c9750..ea33c815aa 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil/

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/vulkan_video: add mapping for AV_PIX_FMT_Y216

2024-10-23 Thread Lynne via ffmpeg-devel
On 24/10/2024 01:03, James Almer wrote: Signed-off-by: James Almer --- libavcodec/vulkan_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vulkan_video.c b/libavcodec/vulkan_video.c index a97d224d55..c58353246c 100644 --- a/libavcodec/vulkan_video.c +++

[FFmpeg-devel] [PATCH 3/3] avcodec/vulkan_video: add mapping for AV_PIX_FMT_Y216

2024-10-23 Thread James Almer
Signed-off-by: James Almer --- libavcodec/vulkan_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/vulkan_video.c b/libavcodec/vulkan_video.c index a97d224d55..c58353246c 100644 --- a/libavcodec/vulkan_video.c +++ b/libavcodec/vulkan_video.c @@ -83,11 +83,12

[FFmpeg-devel] [PATCH] avcodec/vc2enc: Initial vulkan VC2 encoder

2024-10-23 Thread IndecisiveTurtle
Implements a Vulkan based dirac encoder. Supports Haar and Legall wavelets and should work with all wavelet depths. Performance wise, encoding a 1080p 1-minute video is performed in about 2.5 minutes with the cpu encoder running on my Ryzen 5 4600H, while it takes about 30 seconds on my NVIDIA

[FFmpeg-devel] [PATCH 1/3] avcodec/vulkan_video: add proper maps for XV3{0, 6}

2024-10-23 Thread James Almer
Forgotten after fd8b0dcfed61ddf36b9523aa4ba1badc493b7707. Signed-off-by: James Almer --- libavcodec/vulkan_video.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/vulkan_video.c b/libavcodec/vulkan_video.c index 3a04d60d68..a97d224d55 100644 --- a/libavcodec/vu

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

2024-10-23 Thread Dale Curtis
Yes, please apply the dynamic version. Thanks! - dale On Wed, Oct 16, 2024 at 5:09 AM Lynne via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > On 16/10/2024 14:06, Niklas Haas wrote: > > On Mon, 14 Oct 2024 11:03:49 -0700 Dale Curtis > wrote: > >> Any issues remaining with this patch? Thanks

[FFmpeg-devel] [PATCH 6/7] libavutil/hwcontext_dxva2: use the XV48 pixel format

2024-10-23 Thread James Almer
Signed-off-by: James Almer --- libavutil/hwcontext_d3d11va.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c index ecf4207b3c..9d81effe5e 100644 --- a/libavutil/hwcontext_d3d11va.c +++ b/libavutil/hwcontext_d3d11va.

[FFmpeg-devel] [PATCH] avutil/hwcontext: Don't assume frames_uninit is reentrant

2024-10-23 Thread 徐浩宇
I have discovered that the vulnerability addressed by commit 3bb00c0 also affects the release/6.1 branch,but the fix has not yet been applied. Given that there were relevant commits to the release/6.1 branch just two

[FFmpeg-devel] [PATCH 1/1] Added support to get specific periods from the mpeg-dash demuxer instead of just the longest one.

2024-10-23 Thread Louis Letourneau
From: Louis Letourneau --- libavformat/dashdec.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index a1d274f2f0..345454e6b6 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -150,6 +150,7 @@ typede

[FFmpeg-devel] [PATCH 2/7] swscale/input: add XV48 input support

2024-10-23 Thread James Almer
Signed-off-by: James Almer --- libswscale/input.c | 40 libswscale/utils.c | 2 ++ 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/libswscale/input.c b/libswscale/input.c index 40629831db..5edf08106b 100644 --- a/libswscale/input.c +++ b/l

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

2024-10-23 Thread Niklas Haas
On Wed, 23 Oct 2024 10:34:31 -0700 Dale Curtis wrote: > Yes, please apply the dynamic version. Thanks! > > - dale > > On Wed, Oct 16, 2024 at 5:09 AM Lynne via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: Hi, could you please rebase the patch (or send me a branch link and I'll do it myself)?

Re: [FFmpeg-devel] [PATCH v3 04/18] swscale: add sws_free_context()

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:13PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Merely a convenience wrapper around sws_freeContext(). The name change is for > parity with the other sws_* functions. > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/swsc

Re: [FFmpeg-devel] [PATCH v3 10/18] swscale/x86: use dedicated int for self-modifying MMX dstW

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:19PM +0200, Niklas Haas wrote: > From: Niklas Haas > > I want to pull options out of SwsInternal, so we need to make this field > a dedicated int that gets updated as appropriate in ff_swscale(). > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas >

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/rangecoder: only perform renorm check/loop for callers that need it

2024-10-23 Thread Michael Niedermayer
On Wed, Oct 16, 2024 at 09:49:48PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/rangecoder.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Co

[FFmpeg-devel] [PATCH 4/7] avformat/riff: map Y416 fourcc to RAWVIDEO decoder

2024-10-23 Thread James Almer
As defined in https://learn.microsoft.com/en-us/windows/win32/medfound/10-bit-and-16-bit-yuv-video-formats#422-formats Signed-off-by: James Almer --- libavcodec/raw.c | 1 + libavformat/riff.c | 1 + tests/ref/fate/filter-pixdesc-xv48le | 2 +-

[FFmpeg-devel] [PATCH 7/7] libavutil/hwcontext_d3d11va: use the XV48 pixel format

2024-10-23 Thread James Almer
Signed-off-by: James Almer --- libavutil/hwcontext_dxva2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hwcontext_dxva2.c b/libavutil/hwcontext_dxva2.c index 0b76966ebf..acf7d4d798 100644 --- a/libavutil/hwcontext_dxva2.c +++ b/libavutil/hwcontext_dxva2.c @@ -94,7

[FFmpeg-devel] [PATCH 5/7] avfilter/vsrc_testsrc: add support for XV48

2024-10-23 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vsrc_testsrc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_testsrc.c index ce7ca90ae8..e3e076e878 100644 --- a/libavfilter/vsrc_testsrc.c +++ b/libavfilter/vsrc_testsrc.c @@ -1175,6

[FFmpeg-devel] [PATCH 3/7] swscale/output: add XV48 output support

2024-10-23 Thread James Almer
Signed-off-by: James Almer --- libswscale/output.c | 37 +++- libswscale/utils.c | 4 +-- tests/ref/fate/filter-pixdesc-xv48be | 1 + tests/ref/fate/filter-pixdesc-xv48le | 1 + tests/ref/fate/filter-pixfmts-copy | 2

[FFmpeg-devel] [PATCH] Added support to get specific periods from the mpeg-dash demuxer instead of just the longest one.

2024-10-23 Thread Louis Letourneau
From: Louis Letourneau --- libavformat/dashdec.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index a1d274f2f0..345454e6b6 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -150,6 +150,7 @@ typede

Re: [FFmpeg-devel] [PATCH v3 07/18] swscale: add sws_is_noop()

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:16PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Exactly what it says on the tin. > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/swscale.h | 6 ++ > libswscale/utils.c | 14 ++ > 2 files changed, 20 i

Re: [FFmpeg-devel] [PATCH v3 06/18] swscale: add new frame testing API

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:15PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Replacing the old sws_isSupported* API with a more consistent family > of functions that follows the same signature and naming convention, > including a placeholder for testing the color space parameters that > w

Re: [FFmpeg-devel] [PATCH v3 05/18] swscale/utils: add SwsFormat abstraction and helpers

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:14PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Groups together all relevant color metadata from an AVFrame. While we could > use AVFrame directly, keeping it a separate struct has three advantages: > > 1. Functions accepting an SwsFormat will definitely not

Re: [FFmpeg-devel] Add support for LJ92 compressed MLV files

2024-10-23 Thread South East
Thanks. I tried to run Fate tests locally, but they were broken for me, before and after my changes, with the same error (not the error you're reporting, something about fate-ffmpeg-spec-disposition). Is this something I need to look into? I don't have a tests/data dir (I assume you don't want t

[FFmpeg-devel] [PATCH 0/1] Support multi-period dash manifests

2024-10-23 Thread Louis Letourneau
From: Louis Letourneau Current dash demuxer only uses the longest period in a MPEG-DASH manifest. This patch allows the user to either use that mecanism (default) or pick the period they want to work with. Louis Letourneau (1): Added support to get specific periods from the mpeg-dash demuxer

Re: [FFmpeg-devel] [PATCH 3/6] swscale/output: add Y216LE output support

2024-10-23 Thread Michael Niedermayer
On Tue, Oct 22, 2024 at 09:48:44AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libswscale/output.c | 44 > libswscale/utils.c | 2 +- > tests/ref/fate/filter-pixdesc-y216le | 1 + > tests/ref/fate/filter-

Re: [FFmpeg-devel] [PATCH 2/6] swscale/input: add Y216LE input support

2024-10-23 Thread Michael Niedermayer
On Tue, Oct 22, 2024 at 09:48:43AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libswscale/input.c | 7 +++ > libswscale/utils.c | 1 + > 2 files changed, 8 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB There wil

Re: [FFmpeg-devel] Add support for LJ92 compressed MLV files

2024-10-23 Thread Michael Niedermayer
On Mon, Oct 21, 2024 at 07:44:47PM +0100, South East wrote: > ffmpeg has existing support for MLV raw video files; libavformat/mlvdec.c. > Since this was added, MLV has been extended to support LJ92 compressed > image data. These patches build on lossless DNG support in 7.2-dev to > enable handlin

Re: [FFmpeg-devel] [PATCH v12 5/9] libavcodec/dnxucdec: DNxUncompressed decoder

2024-10-23 Thread martin schitter
On 23.10.24 15:19, Marton Balint wrote: On Tue, 22 Oct 2024, Anton Khirnov wrote: Quoting Marton Balint (2024-10-22 20:35:52) I don't really want the MXF demuxer/muxer to do DNXUC parsing What parsing is there to do? You just compare against the codec tag. As far as I know, the codec tag

Re: [FFmpeg-devel] [PATCH v3 11/18] swscale: expose SwsContext publicly

2024-10-23 Thread Michael Niedermayer
On Sun, Oct 20, 2024 at 10:05:20PM +0200, Niklas Haas wrote: > From: Niklas Haas > > This commit does the ardous work of splitting the options out of SwsInternal. > To avoid having to change leaf functions too much in one commit, we simply > leave behind a pointer to the main context, and replace

Re: [FFmpeg-devel] [PATCH v12 5/9] libavcodec/dnxucdec: DNxUncompressed decoder

2024-10-23 Thread Marton Balint
On Tue, 22 Oct 2024, Anton Khirnov wrote: Quoting Marton Balint (2024-10-22 20:35:52) On Tue, 22 Oct 2024, Anton Khirnov wrote: Quoting Martin Schitter (2024-10-21 21:57:18) +static int pass_through(AVCodecContext *avctx, AVFrame *frame, const AVPacket *avpkt) +{ +/* there is no ne

Re: [FFmpeg-devel] [PATCH 1/1] Output .lrc with correct end time

2024-10-23 Thread Gu Song
I put the patch in the attachment of the email, please get it out of the attachment and try again. Michael Niedermayer 于2024年10月23日周三 19:24写道: > > On Wed, Oct 23, 2024 at 03:50:54PM +0800, Lu Renjia wrote: > [...] > > @@ -91,6 +101,8 @@ static int lrc_write_packet(AVFormatContext *s, > > AVPacket

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-23 Thread Michael Niedermayer
On Tue, Oct 22, 2024 at 04:22:06PM +0200, Lynne via ffmpeg-devel wrote: > On 16/10/2024 15:26, Michael Niedermayer wrote: > > This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression > > with rawlsb=4 > > > > Please test and comment > > > > This stores the LSB through non binary

[FFmpeg-devel] [PATCH] checkasm: Print benchmarks of C-only functions

2024-10-23 Thread Martin Storsjö
This corresponds to commit 9278a14cf406f8edb5052c42b83750112bf5b515 in dav1d. Omitting the C-only functions doesn't speed up benchmarking anyway (as those has to be benchmarked before we know if we have any corresponding assembly functions), and being able to benchmark those functions without corr

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: silently ignore APPx stubs

2024-10-23 Thread Michael Niedermayer
On Tue, Oct 22, 2024 at 11:25:58AM +0200, Ramiro Polla wrote: > On Mon, Oct 21, 2024 at 1:41 AM Michael Niedermayer > wrote: > > On Thu, Oct 17, 2024 at 01:00:12PM +0200, Ramiro Polla wrote: > > > Consider APPx fields that are too short to contain an id field (32-bit) > > > as stubs, and silently

Re: [FFmpeg-devel] GSoC Mentor Summit Reimbursement Request

2024-10-23 Thread Michael Niedermayer
On Thu, Oct 10, 2024 at 07:29:32PM +0100, Frank Plowman wrote: > Hello, > > I would like to request reimbursement for the following expenses > incurred attending the Google Summer of Code mentor summit. > > Description | Amount >

Re: [FFmpeg-devel] [PATCH 1/1] Output .lrc with correct end time

2024-10-23 Thread Michael Niedermayer
On Wed, Oct 23, 2024 at 03:50:54PM +0800, Lu Renjia wrote: [...] > @@ -91,6 +101,8 @@ static int lrc_write_packet(AVFormatContext *s, > AVPacket *pkt) > while(line) { patch corrupted by a linebreak: Applying: Output .lrc with correct end time error: corrupt patch at line 38 error: could

Re: [FFmpeg-devel] [PATCH v12 5/9] libavcodec/dnxucdec: DNxUncompressed decoder

2024-10-23 Thread martin schitter
On 23.10.24 09:12, Diederick C. Niehorster wrote: + This decoder for DNxUncompressed video data is mostly based on + reverse engineering of output generated by DaVinci Resolve 19 + but was later also checked against the SMPTE RDD 50 specification. + + Not all DNxUncompressed pixel format varia

[FFmpeg-devel] [PATCH 1/1] Output .lrc with correct end time

2024-10-23 Thread Lu Renjia
When input .sbv or .srt and output .lrc, line end time is incorrect as condition below: $ cat > input.sbv << EOF 0:00:00.000,0:00:03.000 Title 0:00:10.000,0:00:15.000 Line 1 EOF $ ffmpeg -i input.sbv out.lrc $ cat out.lrc [re:Lavf61.7.100] [ve:61.7.100] [00:00.00]Title [00:10.00]Line 1 'Title'

[FFmpeg-devel] [PATCH 0/1] Output .lrc with correct end time

2024-10-23 Thread Lu Renjia
Fix "Generate .lrc from .sbv or .srt have end time error on some lines" https://trac.ffmpeg.org/ticket/11253 gusong (1): Output .lrc with correct end time libavformat/lrcenc.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) -- 2.47.0 __

Re: [FFmpeg-devel] profile vs vprofile in 7.1?

2024-10-23 Thread Anton Khirnov
Quoting Andrew Randrianasulu (2024-10-23 03:34:06) > But then it turned out our vaapi/qsv profiles stopped working, anytime > there was "profile=high" line. > > Oh, dang. > > Looked around and found this thread on Narkive > > https://ffmpeg-user.ffmpeg.narkive.com/FRd15m7B/ffmpeg-1-0-null-0xcb47

Re: [FFmpeg-devel] GSoC Mentor Summit Reimbursement Request

2024-10-23 Thread Frank Plowman
Ping On 10/10/2024 19:29, Frank Plowman wrote: > Hello, > > I would like to request reimbursement for the following expenses > incurred attending the Google Summer of Code mentor summit. > > Description | Amount > ---

Re: [FFmpeg-devel] [PATCH v12 5/9] libavcodec/dnxucdec: DNxUncompressed decoder

2024-10-23 Thread Diederick C. Niehorster
On Wed, Oct 23, 2024 at 8:44 AM James Almer wrote: > > On 10/21/2024 4:57 PM, Martin Schitter wrote: > > --- > > libavcodec/Makefile| 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/dnxucdec.c | 338 + > > 3 files changed, 340 insertions(