[FFmpeg-devel] [PATCH] avutil/pixdesc: ensure the component being read or writen to is valid

2024-10-17 Thread James Almer
If depth is 0, then the component is invalid/unset. Signed-off-by: James Almer --- libavutil/pixdesc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index d73c3f0d58..4d61e32a1e 100644 --- a/libavutil/pixdesc.c +++ b/libavutil/pixdesc.c @@ -4

Re: [FFmpeg-devel] [PATCH 3/3] fate/vcodec: add a test for v410 pixel format raw video

2024-10-17 Thread James Almer
On 10/17/2024 7:47 PM, Sean McGovern wrote: Hi, On Mon, Oct 14, 2024 at 9:54 AM James Almer wrote: Signed-off-by: James Almer --- tests/fate/vcodec.mak | 6 ++ tests/ref/vsynth/vsynth1-v410 | 4 tests/ref/vsynth/vsynth2-v410 | 4 tests/ref/vsynth/vsynth

Re: [FFmpeg-devel] [PATCH 3/3] fate/vcodec: add a test for v410 pixel format raw video

2024-10-17 Thread Sean McGovern
Hi, On Mon, Oct 14, 2024 at 9:54 AM James Almer wrote: > > Signed-off-by: James Almer > --- > tests/fate/vcodec.mak | 6 ++ > tests/ref/vsynth/vsynth1-v410 | 4 > tests/ref/vsynth/vsynth2-v410 | 4 > tests/ref/vsynth/vsynth3-v410 | 4 > tests/ref/vsynt

Re: [FFmpeg-devel] [PATCH v2] doc/ffmpeg: improve -disposition, -stats, and -progress documentation

2024-10-17 Thread epirat07
On 17 Oct 2024, at 21:58, Soma Lucz wrote: > I’d like to reject the v1 version of this patch on Patchwork. What to do if > the Patchwork registration confirmation email didn’t arrive for more than 2 > days, so I cannot log in? (Password reset emails also don’t arrive.) I > checked the spam an

Re: [FFmpeg-devel] [PATCH] lavc/libx265: flag as experimental

2024-10-17 Thread BUCCIANTINI Francesco via ffmpeg-devel
No, I strongly disagree. Marking a vital encoder as libx265 that thousands of people rely on as "experimental" after more than 10 years since its inclusion doesn't make any sense and would make more harm than good. Besides, the experimental flag is supposed to be used to indicate that the imple

Re: [FFmpeg-devel] [RFC] AVFilter

2024-10-17 Thread Michael Niedermayer
On Thu, Oct 17, 2024 at 11:05:31AM +0200, Anton Khirnov wrote: > Quoting Niklas Haas (2024-10-16 14:30:47) > > On Tue, 15 Oct 2024 18:12:21 +0200 Michael Niedermayer > > wrote: > > > Hi all > > > > > > This is a quick RFC about peoples oppinions on AVFilter > > > > > > The question: Should anyone

[FFmpeg-devel] [PATCH v3 1/2] avutil/pixdesc: add alpha component information to pixfmts with reserved but undefined alpha bits

2024-10-17 Thread James Almer
This can be useful to simplify certain processes that need to know how many reserved bits there are and where they are placed, even if they are ultimately unused, as will be shown in the next commit. For any other case where the user simply looks at nb_components components, it will make no differe

Re: [FFmpeg-devel] [PATCH v2] doc/ffmpeg: improve -disposition, -stats, and -progress documentation

2024-10-17 Thread Soma Lucz
I’d like to reject the v1 version of this patch on Patchwork. What to do if the Patchwork registration confirmation email didn’t arrive for more than 2 days, so I cannot log in? (Password reset emails also don’t arrive.) I checked the spam and junk folders, etc. I tried to re-register, but I was

[FFmpeg-devel] [PATCH v2 1/2] avutil/pixdesc: add alpha component information to pixfmts with reserved but undefined alpha bits

2024-10-17 Thread James Almer
This can be useful to simplify certain processes that need to know how many reserved bits there are and where they are placed, even if they are ultimately unused, as will be shown in the next commit. For any other case where the user simply looks at nb_components components, it will make no differe

[FFmpeg-devel] [PATCH v2] doc/ffmpeg: improve -disposition, -stats, and -progress documentation

2024-10-17 Thread Soma Lucz
-disposition: Clarify the meaning of the default value, and how the '+' and '-' prefixes work. Add more examples. -stats: Clarify that it appears as an "info"-level log. -progress: Add info about the "progress" key's value being "continue" or "end". Add an example of logging to stdout. Signed-of

[FFmpeg-devel] [PATCH] avcodec/hw_base_encode: fix use after free on close

2024-10-17 Thread Marvin Scholz
The way the linked list of images was freed caused a use after free, by accessing pic->next after pic was already freed. Regression from 48a1a12968345bf673db1e1cbb5c64bd3529c50c Fix CID1633236 --- libavcodec/hw_base_encode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [RFC] AVFilter

2024-10-17 Thread Rémi Denis-Courmont
Le torstaina 17. lokakuuta 2024, 14.38.19 EEST Nicolas George a écrit : > Anton Khirnov (12024-10-17): > > Is that really any better than just adding your filter into your private > > fork of avfilter? > Are you asking if there is a benefit in the ability to ship a tiny > binary package with just

[FFmpeg-devel] [PATCH 2/2] avfilter/vsrc_testsrc: use the alpha component information for XV3{0, 6} and V30X

2024-10-17 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vsrc_testsrc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_testsrc.c index 6fd8c73757..ce7ca90ae8 100644 --- a/libavfilter/vsrc_testsrc.c +++ b/libavfilter/vsrc_testsrc.c @@ -11

[FFmpeg-devel] [PATCH 1/2] avutil/pixdesc: add alpha component information to pixfmts with reserved but undefined alpha bits

2024-10-17 Thread James Almer
This can be useful to simplify certain processes that need to know how many reserved bits there are and where they are placed, even if they are ultimately unused, as will be shown in the next commit. For any other case where the user simply looks at nb_components components, it will make no differe

Re: [FFmpeg-devel] [PATCH] lavc/libx265: flag as experimental

2024-10-17 Thread Zhao Zhili
> 在 2024年10月17日,下午10:01,James Almer 写道: > > On 10/17/2024 10:49 AM, Timo Rothenpieler wrote: >>> On 17/10/2024 11:22, Anton Khirnov wrote: >>> Quoting Anton Khirnov (2023-03-15 15:45:25) This encoder leaks and overreads, as can be seen e.g. by running an encode under valgrind with def

Re: [FFmpeg-devel] [PATCH] lavc/libx265: flag as experimental

2024-10-17 Thread James Almer
On 10/17/2024 10:49 AM, Timo Rothenpieler wrote: On 17/10/2024 11:22, Anton Khirnov wrote: Quoting Anton Khirnov (2023-03-15 15:45:25) This encoder leaks and overreads, as can be seen e.g. by running an encode under valgrind with default encoder parameters. This was known upstream since at leas

Re: [FFmpeg-devel] [PATCH] lavc/libx265: flag as experimental

2024-10-17 Thread Timo Rothenpieler
On 17/10/2024 11:22, Anton Khirnov wrote: Quoting Anton Khirnov (2023-03-15 15:45:25) This encoder leaks and overreads, as can be seen e.g. by running an encode under valgrind with default encoder parameters. This was known upstream since at least 2019 (e.g. bitbucket issue #482) but never fixed

Re: [FFmpeg-devel] [PATCH v2 02/19] swscale: rename SwsContext to SwsInternal

2024-10-17 Thread Niklas Haas
On Mon, 14 Oct 2024 20:58:31 +0200 Michael Niedermayer wrote: > On Mon, Oct 14, 2024 at 08:33:50PM +0200, Niklas Haas wrote: > > On Mon, 14 Oct 2024 19:49:21 +0200 Michael Niedermayer > > wrote: > > > On Mon, Oct 14, 2024 at 06:39:21PM +0200, Michael Niedermayer wrote: > > > > On Mon, Oct 14, 2

Re: [FFmpeg-devel] [PATCH 10/20] swscale/output: add VYU444 output support

2024-10-17 Thread James Almer
On 10/16/2024 8:17 PM, Michael Niedermayer wrote: On Wed, Oct 09, 2024 at 02:03:28PM -0300, James Almer wrote: On 10/8/2024 4:56 PM, Michael Niedermayer wrote: On Mon, Oct 07, 2024 at 09:29:45AM -0300, James Almer wrote: Signed-off-by: James Almer --- libswscale/output.c

Re: [FFmpeg-devel] [PATCH] Added support to enable VBV-End feature with x265 encode

2024-10-17 Thread Yaswanth Sastry
Hi Anton, Thank you for your feedback. Could you please clarify which specific development rules are being broken in this patch? I'm aiming to ensure that the implementation is aligned with best practices and any guidelines I may have missed. In this patch, I’ve added support for the VBV-End feat

Re: [FFmpeg-devel] [PATCH 00/16] swscale/range_convert: fix mpeg ranges in yuv range conversion for non-8-bit pixel formats

2024-10-17 Thread Ramiro Polla
On Fri, Sep 27, 2024 at 2:52 PM Ramiro Polla wrote: [...] > Ramiro Polla (16): > swscale/range_convert: call arch-specific init functions from main > init function > swscale/range_convert: drop redundant conditionals from arch-specific > init functions > swscale/range_convert: indent

Re: [FFmpeg-devel] [RFC] AVFilter

2024-10-17 Thread Nicolas George
Anton Khirnov (12024-10-17): > Is that really any better than just adding your filter into your private > fork of avfilter? Are you asking if there is a benefit in the ability to ship a tiny binary package with just “Depends: libavfilter (= 7:5.1.6-0+deb12u1) instead of a package of several megaoc

Re: [FFmpeg-devel] [PATCH] avformat/aeadec, avcodec/atrac1: Fix 8 and 4-channel ATRAC1 support

2024-10-17 Thread Ramiro Polla
On Sun, Sep 29, 2024 at 1:32 PM asivery via ffmpeg-devel wrote: > Pinging the patch. > I've merged the fate test case patch into the functionality one, and rebased > onto the current master. > Here are the two sample files required by the FATE test: > https://0x0.st/Xaw2.aea/boxboy333_house_music

Re: [FFmpeg-devel] [PATCH] tests/fate/filter-video: don't convert owdenoise test to mpeg range

2024-10-17 Thread Ramiro Polla
On Sun, Sep 29, 2024 at 5:38 PM Ramiro Polla wrote: > > --- > The new owdenoise-scenwin-jpeg.raw reference file is available at > https://0x0.st/XguT.raw > > tests/fate/filter-video.mak | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/fate/filter-video.mak b/tes

Re: [FFmpeg-devel] [PATCH] avdevice/dshow: fix unused variable warning

2024-10-17 Thread Ramiro Polla
On Mon, Sep 9, 2024 at 12:58 PM Ramiro Polla wrote: > > The acaps variable was used outside of the #if DSHOWDEBUG block with > a1c4929f, but it is no longer used outside of the block since f125c504. > --- > libavdevice/dshow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[FFmpeg-devel] [PATCH 2/2] avcodec/mjpegdec: silently ignore APPx stubs

2024-10-17 Thread Ramiro Polla
Consider APPx fields that are too short to contain an id field (32-bit) as stubs, and silently ignore them. This has been seen in the MJPEG output from some webcams (such as the Logitech C270 and C920) and the JPEG images embedded in DNG images from the Pentax K-1 camera. --- libavcodec/mjpegdec.

[FFmpeg-devel] [PATCH 1/2] avcodec/mjpegdec: fix skipping of bytes for unknown APPx markers

2024-10-17 Thread Ramiro Polla
The loop to skip the remaining bytes was off by one for all markers except for Adob. This patch uses post-decrement instead of pre-decrement in the while loop to make the len value easier to understand, and updates the len value to reflect this change for the Adob marker. --- libavcodec/mjpegdec.

Re: [FFmpeg-devel] (No Subject)

2024-10-17 Thread Ramiro Polla
Hi, On Thu, Oct 17, 2024 at 8:38 AM Cynthia via ffmpeg-devel wrote: > From d7863bab8e1028b6cfb3ce848e216e86ff00eca0 Mon Sep 17 00:00:00 2001 > From: cynthia2006 > Date: Tue, 28 May 2024 22:03:50 +0530 > Subject: [PATCH] lavc/mjpegdec: add option for ignorning malformed APPx > segments > X-Unsen

Re: [FFmpeg-devel] [PATCH] lavc/libx265: flag as experimental

2024-10-17 Thread Anton Khirnov
Quoting Anton Khirnov (2023-03-15 15:45:25) > This encoder leaks and overreads, as can be seen e.g. by running an > encode under valgrind with default encoder parameters. This was known > upstream since at least 2019 (e.g. bitbucket issue #482) but never fixed > until now. > > Since upstream does

Re: [FFmpeg-devel] [PATCH] Added support to enable VBV-End feature with x265 encode

2024-10-17 Thread Anton Khirnov
This breaks more development rules than there are lines changed, which is an impressive achievement. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link abov

Re: [FFmpeg-devel] [RFC] AVFilter

2024-10-17 Thread Anton Khirnov
Quoting Niklas Haas (2024-10-16 14:30:47) > On Tue, 15 Oct 2024 18:12:21 +0200 Michael Niedermayer > wrote: > > Hi all > > > > This is a quick RFC about peoples oppinions on AVFilter > > > > The question: Should anyone be able to write a filter (which > > other people can use) ? > > Or should onl

Re: [FFmpeg-devel] [PATCH] Added support to enable VBV-End feature with x265 encode

2024-10-17 Thread Yaswanth Sastry
Hi Michael, Here is the updated patch to support Vbv-end Feature,the API in the patch is expected to work with X265_BUILD >= 213 only. >From 64ce51509c74d7a4f9d86dd73662e561ab9c8845 Mon Sep 17 00:00:00 2001 From: yaswanthsastry Date: Thu, 17 Oct 2024 14:24:47 +0530 Subject: [PATCH] Added support