[FFmpeg-devel] (No Subject)

2024-10-16 Thread Cynthia via ffmpeg-devel
>From d7863bab8e1028b6cfb3ce848e216e86ff00eca0 Mon Sep 17 00:00:00 2001 From: cynthia2006 Date: Tue, 28 May 2024 22:03:50 +0530 Subject: [PATCH] lavc/mjpegdec: add option for ignorning malformed APPx segments X-Unsent: 1 To: ffmpeg-devel@ffmpeg.org A few cameras, namely Logitech C270 or similar

[FFmpeg-devel] [PATCH] avcodec/libopusenc: add support for mapping family 2

2024-10-16 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libopusenc.c | 55 +++-- 1 file changed, 42 insertions(+), 13 deletions(-) diff --git a/libavcodec/libopusenc.c b/libavcodec/libopusenc.c index 6b8b2cda0e..fcd0254be3 100644 --- a/libavcodec/libopusenc.c +++ b/libavcod

Re: [FFmpeg-devel] [PATCH] hw_base_encode: Free pictures on close

2024-10-16 Thread Cameron Gutman
On Wed, Oct 16, 2024 at 5:49 AM Lynne via ffmpeg-devel wrote: > > On 15/10/2024 17:51, Lynne via ffmpeg-devel wrote: > > On 15/10/2024 16:49, David Rosca wrote: > >> Fixes leaking recon surfaces with VAAPI. > >> --- > >> libavcodec/hw_base_encode.c | 5 + > >> 1 file changed, 5 insertions(+

Re: [FFmpeg-devel] nuv1 in avi

2024-10-16 Thread Michael Niedermayer
On Wed, Oct 16, 2024 at 12:39:14AM +0300, Andrew Randrianasulu wrote: > вс, 13 окт. 2024 г., 14:40 Anton Khirnov : > > > Quoting Andrew Randrianasulu (2024-10-08 14:03:13) > > > I was experimenting with mencoder > > > > > > > > > > > > what do you think? ;) > > > > why oh oh god why? > > > >

Re: [FFmpeg-devel] [PATCH 10/20] swscale/output: add VYU444 output support

2024-10-16 Thread Michael Niedermayer
On Wed, Oct 09, 2024 at 02:03:28PM -0300, James Almer wrote: > On 10/8/2024 4:56 PM, Michael Niedermayer wrote: > > On Mon, Oct 07, 2024 at 09:29:45AM -0300, James Almer wrote: > > > Signed-off-by: James Almer > > > --- > > > libswscale/output.c | 43

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
On Wed, Oct 16, 2024 at 10:53:37PM +0200, Michael Niedermayer wrote: > Hi Jerome > > On Wed, Oct 16, 2024 at 10:29:18PM +0200, Jerome Martinez wrote: > > Le 16/10/2024 à 21:51, Michael Niedermayer a écrit : > > > did you try qtable 1 ? strangely it performed better for the file i used > > > compr

Re: [FFmpeg-devel] [WIP] False positives on Coverity

2024-10-16 Thread Michael Niedermayer
On Mon, Aug 12, 2024 at 07:40:41PM +0200, Michael Niedermayer wrote: > On Thu, Jul 25, 2024 at 04:41:26PM +0200, Michael Niedermayer wrote: > > On Sat, Jul 13, 2024 at 01:20:23AM +0200, Michael Niedermayer wrote: > > > On Fri, Jul 12, 2024 at 01:55:42AM +0200, Michael Niedermayer wrote: > > > [...]

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
Hi Jerome On Wed, Oct 16, 2024 at 10:29:18PM +0200, Jerome Martinez wrote: > Le 16/10/2024 à 21:51, Michael Niedermayer a écrit : > > did you try qtable 1 ? strangely it performed better for the file i used > > compression wise > > Updated with latest code (in practice, no change in previous val

Re: [FFmpeg-devel] [RFC] AVFilter

2024-10-16 Thread Michael Niedermayer
Hi Niklas On Wed, Oct 16, 2024 at 02:30:47PM +0200, Niklas Haas wrote: > On Tue, 15 Oct 2024 18:12:21 +0200 Michael Niedermayer > wrote: > > Hi all > > > > This is a quick RFC about peoples oppinions on AVFilter > > > > The question: Should anyone be able to write a filter (which > > other peopl

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Jerome Martinez
Le 16/10/2024 à 21:51, Michael Niedermayer a écrit : did you try qtable 1 ? strangely it performed better for the file i used compression wise Updated with latest code (in practice, no change in previous values): 0,037x    0,471    No patch 0,051x    0,491    bitfield 0,046x    0,489    rangec

Re: [FFmpeg-devel] [PATCH v2 2/2] tests/fate: disable compression for zlib-based codecs

2024-10-16 Thread James Almer
On 10/16/2024 4:34 PM, Ramiro Polla wrote: On Mon, Oct 14, 2024 at 10:57 PM Michael Niedermayer wrote: On Sun, Sep 29, 2024 at 08:36:29PM +0200, Ramiro Polla wrote: FATE results differ when using the original zlib and zlib-ng. Since we don't need to test the result from zlib itself, this comm

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
Hi Jerome On Wed, Oct 16, 2024 at 06:27:09PM +0200, Jerome Martinez wrote: > Le 16/10/2024 à 15:54, Michael Niedermayer a écrit : > > 3rd implemantation :) > > you might ask why i implement this 4?! times > > Heres why: (tests done with 4 rawlsb bits, 16bit per sample input) > > I tested on my si

[FFmpeg-devel] [PATCH 8/8] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
This makes a 16bit RGB raw sample about 25% faster at a 2% loss of compression with rawlsb=4 This stores the LSB through non binary range coding, this is simpler than using a separate coder For cases where range coding is not wanted its probably best to use golomb rice for everything. We also p

[FFmpeg-devel] [PATCH 7/8] avcodec/rangecoder: Implement reading and writing upto 8 bits raw

2024-10-16 Thread Michael Niedermayer
This is much faster than doing 1 bit and updating a state Signed-off-by: Michael Niedermayer --- libavcodec/rangecoder.h | 46 +++ libavcodec/tests/rangecoder.c | 13 ++ 2 files changed, 59 insertions(+) diff --git a/libavcodec/rangecoder.h b/libavc

[FFmpeg-devel] [PATCH 6/8] avcodec/rangecoder: eliminate main branch from renorm_encoder()

2024-10-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/rangecoder.h | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/libavcodec/rangecoder.h b/libavcodec/rangecoder.h index cdd99eff565..15217a99a3c 100644 --- a/libavcodec/rangecoder.h +++ b/libavcodec/rangecoder.h @@ -

[FFmpeg-devel] [PATCH 5/8] avcodec/rangecoder: Remove unneeded outstanding byte mask

2024-10-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/rangecoder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/rangecoder.h b/libavcodec/rangecoder.h index 944ad492fda..cdd99eff565 100644 --- a/libavcodec/rangecoder.h +++ b/libavcodec/rangecoder.h @@ -72,7 +72,7 @@

[FFmpeg-devel] [PATCH 4/8] avcodec/rangecoder: Avoid checking for the first byte on every renormalization

2024-10-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/rangecoder.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/rangecoder.h b/libavcodec/rangecoder.h index da13c453edd..944ad492fda 100644 --- a/libavcodec/rangecoder.h +++ b/libavcodec/rangecoder.h @@ -62,10 +

[FFmpeg-devel] [PATCH 3/8] avcodec/rangecoder: Move refill check out of refill() function

2024-10-16 Thread Michael Niedermayer
If the function is not inlined, this is more efficient. Also it allows calling refill() without the check Signed-off-by: Michael Niedermayer --- libavcodec/rangecoder.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/rangecoder.h b/libavcodec/rangecoder.h i

[FFmpeg-devel] [PATCH 2/8] avcodec/rangecoder: Do not loop renormalization

2024-10-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/rangecoder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/rangecoder.h b/libavcodec/rangecoder.h index 110908d6bdd..2248161bca1 100644 --- a/libavcodec/rangecoder.h +++ b/libavcodec/rangecoder.h @@ -106,7 +106,7 @

[FFmpeg-devel] [PATCH 1/8] avcodec/rangecoder: only perform renorm check/loop for callers that need it

2024-10-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/rangecoder.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/rangecoder.h b/libavcodec/rangecoder.h index 89d178ac314..110908d6bdd 100644 --- a/libavcodec/rangecoder.h +++ b/libavcodec/rangecoder.h @@ -62,7 +62,

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: RCT is only possible with RGB

2024-10-16 Thread Michael Niedermayer
On Thu, Oct 03, 2024 at 04:35:27PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1dec.c | 2 +- > libavcodec/ffv1enc.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF673

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/ffv1: add a named constant for the quant table size

2024-10-16 Thread Michael Niedermayer
On Wed, Oct 16, 2024 at 01:17:34AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1.h | 4 +++- > libavcodec/ffv1_template.c | 18 +- > libavcodec/ffv1enc.c | 6 +++--- > 3 files changed, 15 insertions(+), 13 deletions

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/ffv1enc: Add option to select the quantization table

2024-10-16 Thread Michael Niedermayer
On Tue, Oct 15, 2024 at 12:46:49AM +0200, Michael Niedermayer wrote: > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1.h| 1 + > libavcodec/ffv1enc.c | 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) will apply [...] -- Michael G

Re: [FFmpeg-devel] [PATCH v2 2/2] tests/fate: disable compression for zlib-based codecs

2024-10-16 Thread Ramiro Polla
On Mon, Oct 14, 2024 at 10:57 PM Michael Niedermayer wrote: > On Sun, Sep 29, 2024 at 08:36:29PM +0200, Ramiro Polla wrote: > > FATE results differ when using the original zlib and zlib-ng. > > > > Since we don't need to test the result from zlib itself, this commit > > disables compression on tes

[FFmpeg-devel] [PATCH] avcodec/ffv1: Support >8bit rice golomb

2024-10-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/ffv1.h| 2 +- libavcodec/ffv1enc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h index 02bfc33f680..7e84c98235f 100644 --- a/libavcodec/ffv1.h +++ b/libavcodec/ffv1.h @@ -54,8

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Jerome Martinez
Le 16/10/2024 à 15:54, Michael Niedermayer a écrit : 3rd implemantation :) you might ask why i implement this 4?! times Heres why: (tests done with 4 rawlsb bits, 16bit per sample input) I tested on my side also including the speed as the goal is to avoid the speed cost of the LSB, with 6K con

Re: [FFmpeg-devel] [Uncompressed MP4] RFC - Draft Encoder

2024-10-16 Thread Devon Sookhoo
With this patch, I can generate an uncompressed mp4 without specifying the -c:v rawvideo option: $ ffmpeg -i input.mp4 -c:v rawvideo -pix_fmt rgb24 output.mp4 Originally, it was failing the mux.c validate_codec_tag() function and never reached mov_get_rawvideo_codec_tag(). I found the followi

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
On Wed, Oct 16, 2024 at 03:36:55PM +0200, Michael Niedermayer wrote: > On Wed, Oct 16, 2024 at 02:13:35AM +0200, Lynne via ffmpeg-devel wrote: > > On 16/10/2024 01:17, Michael Niedermayer wrote: > > > This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression > > > with rawlsb=4 > >

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
On Wed, Oct 16, 2024 at 03:26:39PM +0200, Michael Niedermayer wrote: > This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression with > rawlsb=4 > > Please test and comment > > This stores the LSB through non binary range coding, this is simpler than > using a > separate coder >

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
On Wed, Oct 16, 2024 at 02:13:35AM +0200, Lynne via ffmpeg-devel wrote: > On 16/10/2024 01:17, Michael Niedermayer wrote: > > This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression > > with rawlsb=4 > > > > Please test and comment > > > > This stores the LSB through non binary

[FFmpeg-devel] [PATCH 5/5] libavcodec/ffv1: Support storing LSB raw

2024-10-16 Thread Michael Niedermayer
This makes a 16bit RGB raw sample 25% faster at a 2% loss of compression with rawlsb=4 Please test and comment This stores the LSB through non binary range coding, this is simpler than using a separate coder For cases where range coding is not wanted its probably best to use golomb rice for eve

[FFmpeg-devel] [PATCH 4/5] avcodec/rangecoder: Implement reading and writing upto 8 bits raw

2024-10-16 Thread Michael Niedermayer
This is much faster than doing 1 bit and updating a state Signed-off-by: Michael Niedermayer --- libavcodec/rangecoder.h | 53 +++ libavcodec/tests/rangecoder.c | 13 + 2 files changed, 66 insertions(+) diff --git a/libavcodec/rangecoder.h b/libavco

[FFmpeg-devel] [PATCH 3/5] avcodec/rangecoder: Move refill check out of refill() function

2024-10-16 Thread Michael Niedermayer
If the function is not inlined, this is more efficient. Also it allows calling refill() without the check Signed-off-by: Michael Niedermayer --- libavcodec/rangecoder.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/rangecoder.h b/libavcodec/rangecoder.h i

[FFmpeg-devel] [PATCH 2/5] avcodec/rangecoder: Do not loop renormalization

2024-10-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/rangecoder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/rangecoder.h b/libavcodec/rangecoder.h index 110908d6bdd..2248161bca1 100644 --- a/libavcodec/rangecoder.h +++ b/libavcodec/rangecoder.h @@ -106,7 +106,7 @

[FFmpeg-devel] [PATCH 1/5] avcodec/rangecoder: only perform renorm check/loop for callers that need it

2024-10-16 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/rangecoder.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/rangecoder.h b/libavcodec/rangecoder.h index 89d178ac314..110908d6bdd 100644 --- a/libavcodec/rangecoder.h +++ b/libavcodec/rangecoder.h @@ -62,7 +62,

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vvcdec: remove unused tb_pos_x0 and tb_pos_y0

2024-10-16 Thread Nuo Mi
On Fri, Oct 4, 2024 at 10:31 PM Nuo Mi wrote: > This change will save approximately 531 MB for an 8K clip when processed > with 16 threads. > Applied. > The calculation is as follows: > 7680 * 4320 * sizeof(int) * 2 * 2 * 16 / (4 * 4). > --- > libavcodec/vvc/ctu.c | 10 +++--- > libavcodec/

Re: [FFmpeg-devel] [RFC] AVFilter

2024-10-16 Thread Niklas Haas
On Tue, 15 Oct 2024 18:12:21 +0200 Michael Niedermayer wrote: > Hi all > > This is a quick RFC about peoples oppinions on AVFilter > > The question: Should anyone be able to write a filter (which > other people can use) ? > Or should only we be able to add filters ? As a compromise, we could all

Re: [FFmpeg-devel] [PATCH] avcodec/vvc/thread: Check frame to be non NULL

2024-10-16 Thread Nuo Mi
On Mon, Oct 14, 2024 at 11:25 PM Nuo Mi wrote: > Fixes: NULL pointer dereference > Fixes: > 71303/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-4875859050168320 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Reported-by >

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Validate subpartitioning structure

2024-10-16 Thread Nuo Mi
On Tue, Oct 15, 2024 at 7:54 AM Frank Plowman wrote: > Thank you for your reply. > > On 14/10/2024 16:16, Nuo Mi wrote: > > On Mon, Oct 14, 2024 at 3:14 AM Frank Plowman > wrote: > > > >> On 13/10/2024 05:43, Nuo Mi wrote: > >>> On Sun, Oct 6, 2024 at 6:49 AM Frank Plowman > >> wrote: > >>> > >

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

2024-10-16 Thread Lynne via ffmpeg-devel
On 16/10/2024 14:06, Niklas Haas wrote: On Mon, 14 Oct 2024 11:03:49 -0700 Dale Curtis wrote: Any issues remaining with this patch? Thanks in advance for applying. - dale I guess I'll apply it in 24h if there are no objections. The dynamically allocated version, right? OpenPGP_0xA2FEA5F0

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

2024-10-16 Thread Niklas Haas
On Mon, 14 Oct 2024 11:03:49 -0700 Dale Curtis wrote: > Any issues remaining with this patch? Thanks in advance for applying. > > - dale I guess I'll apply it in 24h if there are no objections. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCH 2/2] vulkan: enable selecting a compatible representation of format

2024-10-16 Thread Lynne via ffmpeg-devel
On 16/10/2024 11:56, emufan 4568 wrote: This works okay on the VC2 vulkan encoder patch Στις Τετ 16 Οκτ 2024 στις 10:21 π.μ., ο/η Lynne via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> έγραψε: When using **integer** images inside shaders, it turns out that conversion doesn't automatically happen, b

Re: [FFmpeg-devel] [PATCH] hw_base_encode: Free pictures on close

2024-10-16 Thread Lynne via ffmpeg-devel
On 15/10/2024 17:51, Lynne via ffmpeg-devel wrote: On 15/10/2024 16:49, David Rosca wrote: Fixes leaking recon surfaces with VAAPI. ---   libavcodec/hw_base_encode.c | 5 +   1 file changed, 5 insertions(+) diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c index 7b6ec97d

Re: [FFmpeg-devel] [PATCH] lavf/mxfdec: Set a scan direction explicitly

2024-10-16 Thread Tomas Härdin
mån 2024-10-14 klockan 16:46 +0200 skrev Tomas Härdin: > Passes fate-mxf Will push in a few days /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ff

Re: [FFmpeg-devel] [Uncompressed MP4] RFC - Draft Encoder

2024-10-16 Thread Tomas Härdin
Have a look at mov_get_rawvideo_codec_tag() /Tomas tis 2024-10-15 klockan 08:17 -0600 skrev Devon Sookhoo: > This updated patch registers the 'uncv' tag in the isom_tags.c > ff_codec_movvideo_tags[] list. However, I still need to specify the > tag > with the "-tag:v uncv" option. I hoped this cha

Re: [FFmpeg-devel] [PATCH 2/2] vulkan: enable selecting a compatible representation of format

2024-10-16 Thread emufan 4568
This works okay on the VC2 vulkan encoder patch Στις Τετ 16 Οκτ 2024 στις 10:21 π.μ., ο/η Lynne via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> έγραψε: > When using **integer** images inside shaders, it turns out > that conversion doesn't automatically happen, but we need to > explicitly use the imag

Re: [FFmpeg-devel] [PATCH v3] fate/png: add mDCv and cLLi read and write test

2024-10-16 Thread 金波
Sorry, X86 seems not test fate-png-mdcv. BUT arm and loongarch tested, FATE failed on them. > -原始邮件- > 发件人: 金波 > 发送时间:2024-10-16 14:55:54 (星期三) > 收件人: "FFmpeg development discussions and patches" > 主题: Re: [FFmpeg-devel] [PATCH v3] fate/png: add mDCv and cLLi read and write > test > >

[FFmpeg-devel] [PATCH 1/2] hwcontext_vulkan: always enable MUTABLE creation flag

2024-10-16 Thread Lynne via ffmpeg-devel
We need it even for something as simple as bitexact opening of images. --- libavutil/hwcontext_vulkan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 6a5f1325ac..dec5fdaa46 100644 --- a/libavutil/hwcontex

[FFmpeg-devel] [PATCH 2/2] vulkan: enable selecting a compatible representation of format

2024-10-16 Thread Lynne via ffmpeg-devel
When using **integer** images inside shaders, it turns out that conversion doesn't automatically happen, but we need to explicitly use the imageviews to get the image exposed as a suitable representation for the shader. Finally enables bitexact image representations. --- libavfilter/vf_nlmeans_vu