Re: [FFmpeg-devel] [PATCH 05/10] avcodec/vvc/thread: Check frame to be non NULL

On Thu, Oct 10, 2024 at 3:40 AM Michael Niedermayer wrote: > Hi Nuo mi > > On Sun, Sep 22, 2024 at 11:56:40PM +0200, Michael Niedermayer wrote: > > Fixes: NULL pointer dereference > > Fixes: > 71303/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-4875859050168320 > > > > Found-by: co

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check return value of avcodec_parameters_copy()

Marth64 于2024年10月13日周日 01:25写道： > > Written in the dominant style of the surrounding code block. > > Signed-off-by: Marth64 > --- > libavformat/hlsenc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 571d6b2752..1b3

[FFmpeg-devel] [PATCH] avformat/riff: map Y410 fourcc to RAWVIDEO decoder

md5 values change because the nut container now reports rawvideo as encoder and Y410 as codec type instead of the bogus RGB[15]. Signed-off-by: James Almer --- libavcodec/raw.c | 1 + libavformat/riff.c | 1 + tests/ref/fate/filter-pixdesc-xv30le

[FFmpeg-devel] [PATCH v3] configure: suggest installing nasm before using --disable-x86asm

--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index e8f6d2e2b6..8803148ab7 100755 --- a/configure +++ b/configure @@ -6448,7 +6448,7 @@ EOF for program in $x86asmexe nasm; do probe_x86asm $program && break don

Re: [FFmpeg-devel] [PATCH 1/2] configure: suggest installing nasm/yasm before using --disable-x86asm

On Wed, Oct 9, 2024 at 3:51 PM wrote: > > > On 9 Oct 2024, at 22:15, Alexander Strasser via ffmpeg-devel wrote: > > > On 2024-10-03 04:04 +0200, Lynne via ffmpeg-devel wrote: > >> On 01/10/2024 15:24, vipyne wrote: > >>> --- > >>> configure | 2 +- > >>> 1 file changed, 1 insertion(+), 1 delet

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/dnxuc_parser: Use av_fourcc2str instead of av_fourcc_make_string

On 12.10.24 23:18, epira...@gmail.com wrote: Maybe just squash them into one commit. Yes -- this looks like the most desirable solution. And thanks to Alex for the suggested improvement! Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/dnxuc_parser: Use av_fourcc2str instead of av_fourcc_make_string

On 12 Oct 2024, at 23:08, Alexander Strasser via ffmpeg-devel wrote: > The string representation of the FourCC is only used once for logging. > --- > > Could also merge this with the first patch in this series and make > it a single patch. > > Or drop this one. > > I don't have a strong opinion

[FFmpeg-devel] [PATCH 2/2] libavcodec/dnxuc_parser: Use av_fourcc2str instead of av_fourcc_make_string

The string representation of the FourCC is only used once for logging. --- Could also merge this with the first patch in this series and make it a single patch. Or drop this one. I don't have a strong opinion on these details. libavcodec/dnxuc_parser.c | 5 + 1 file changed, 1 insertion(+)

[FFmpeg-devel] [PATCH 1/2] lavc/dnxuc_parser: Adhere to av_fourcc_make_string API

The documentation of av_fourcc_make_string states the passed in buffer must be of at least the size of AV_FOURCC_MAX_STRING_SIZE Also move the buffer into inner scope where it is used. Fixes: CID 1632380 --- libavcodec/dnxuc_parser.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH 3/3] fate/filter-video: add tests for packed YUV in yuvtestsrc

Signed-off-by: James Almer --- tests/fate/filter-video.mak | 6 ++ tests/ref/fate/filter-yuvtestsrc-ayuv | 10 ++ tests/ref/fate/filter-yuvtestsrc-vuyx | 10 ++ 3 files changed, 26 insertions(+) create mode 100644 tests/ref/fate/filter-yuvtestsrc-ayuv create mode

[FFmpeg-devel] [PATCH 2/3] avfilter/vsrc_testsrc: add support for packed YUV formats in yuvtestsrc

Signed-off-by: James Almer --- libavfilter/vsrc_testsrc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavfilter/vsrc_testsrc.c b/libavfilter/vsrc_testsrc.c index b182abea0f..0df857c766 100644 --- a/libavfilter/vsrc_testsrc.c +++ b/libavfilter/vsrc_testsrc.c @@ -1155,6 +1155,13

[FFmpeg-devel] [PATCH 1/3] avfilter/vsdc_testsrc: simplify yuvtest_fill_picture

Copy what's done for rgbtest_fill_picture. It will be useful for the following commit. Signed-off-by: James Almer --- libavfilter/drawutils.c| 48 +++- libavfilter/drawutils.h| 1 + libavfilter/vsrc_testsrc.c | 145 +++-- 3 files changed, 75 ins

[FFmpeg-devel] [PATCH] avcodec/mpeg12dec: set FF_CODEC_PROPERTY_CLOSED_CAPTIONS in mpeg_set_cc_format()

When Closed Captions are discovered, this method is always invoked. Therefore, use it to set the property instead of repeating the statement. Signed-off-by: Marth64 --- libavcodec/mpeg12dec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavc

Re: [FFmpeg-devel] [PATCH 01/24] lavfi/vf_frei0r: switch to query_func2()

Anton Khirnov (12024-10-12): > 1 file changed, 7 insertions(+), 5 deletions(-) > 1 file changed, 5 insertions(+), 3 deletions(-) > 1 file changed, 6 insertions(+), 4 deletions(-) > 1 file changed, 7 insertions(+), 6 deletions(-) > 1 file changed, 6 insertions(+), 4 deletions(-) > 1 file chang

[FFmpeg-devel] [PATCH] avformat/sapdec: check return value of avcodec_parameters_copy()

Written in the dominant style of the surrounding code block. Signed-off-by: Marth64 --- libavformat/sapdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/sapdec.c b/libavformat/sapdec.c index d5b5d71c02..22db3803c9 100644 --- a/libavformat/sapdec.c +++ b/lib

[FFmpeg-devel] [PATCH] avformat/hlsenc: check return value of avcodec_parameters_copy()

Written in the dominant style of the surrounding code block. Signed-off-by: Marth64 --- libavformat/hlsenc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 571d6b2752..1b3f3ef2bb 100644 --- a/libavformat/hlsenc.c +++ b/lib

[FFmpeg-devel] [PATCH] avformat/smoothstreamingenc: check return value of avcodec_parameters_copy()

Written in the dominant style of the surrounding code block. Signed-off-by: Marth64 --- libavformat/smoothstreamingenc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/smoothstreamingenc.c b/libavformat/smoothstreamingenc.c index 9547419d31..adf3008003 100644

[FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: treat apad filter as a source

Ideally lavfi should have a dedicated API for detecting this. Fixes #11168 and #11061 --- fftools/ffmpeg_filter.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 4524a3e535..741a8482c3 100644 --- a/

[FFmpeg-devel] [PATCH] avcodec/codec_par: ensure the target AVCodecContext doesn't have stale allocations on error

This copies the behavior of avcodec_parameters_from_context(). Signed-off-by: James Almer --- libavcodec/codec_par.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/codec_par.c b/libavcodec/codec_par.c index 790ea01d10..d178b02ff1 100644 --- a/libavcodec/co

[FFmpeg-devel] [PATCH 08/24] lavfi/vf_libplacebo: move vulkan initialization to init

avfilter API requires all the filter parameters, including hw context (if present) to be available during init, so that is the proper place to perform such setup. --- libavfilter/vf_libplacebo.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/li

[FFmpeg-devel] [PATCH 03/24] lavfi/vf_hwdownload: switch to query_func2()

--- libavfilter/vf_hwdownload.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_hwdownload.c b/libavfilter/vf_hwdownload.c index 0b70727b29..4a8a1a1d91 100644 --- a/libavfilter/vf_hwdownload.c +++ b/libavfilter/vf_hwdownload.c @@ -35,14 +35,16 @@ typed

[FFmpeg-devel] [PATCH 04/24] lavfi/vf_hwupload: validate the hw device in init

Rather than query_formats(). Init is a more appropriate place, as query_formats() is supposed to be free of side-effects. --- libavfilter/vf_hwupload.c | 49 ++- 1 file changed, 28 insertions(+), 21 deletions(-) diff --git a/libavfilter/vf_hwupload.c b/libavfil

[FFmpeg-devel] [PATCH 24/24] lavfi/vf_scale: switch to query_func2()

--- libavfilter/vf_scale.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 3319428d9c..a89ebe8c47 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -471,9 +471,11 @@ static av_cold

[FFmpeg-devel] [PATCH 15/24] lavfi/vf_overlay_qsv: switch to query_func2()

--- libavfilter/vf_overlay_qsv.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_overlay_qsv.c b/libavfilter/vf_overlay_qsv.c index 39bc700637..17da4a4d1a 100644 --- a/libavfilter/vf_overlay_qsv.c +++ b/libavfilter/vf_overlay_qsv.c @@ -366,7 +366,9 @@

[FFmpeg-devel] [PATCH 20/24] lavfi/vf_quirc: use FILTER_PIXFMTS_ARRAY() instead of query_formats()

--- libavfilter/vf_quirc.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/libavfilter/vf_quirc.c b/libavfilter/vf_quirc.c index afd172fa34..d44233af5c 100644 --- a/libavfilter/vf_quirc.c +++ b/libavfilter/vf_quirc.c @@ -71,23 +71,6 @@ static i

[FFmpeg-devel] [PATCH 23/24] lavfi/vf_remap: switch to query_func2()

--- libavfilter/vf_remap.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_remap.c b/libavfilter/vf_remap.c index df81c247eb..cc83aa7ffe 100644 --- a/libavfilter/vf_remap.c +++ b/libavfilter/vf_remap.c @@ -82,9 +82,11 @@ typedef struct ThreadData

[FFmpeg-devel] [PATCH 05/24] lavfi/vf_hwupload: switch to query_func2()

--- libavfilter/vf_hwupload.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_hwupload.c b/libavfilter/vf_hwupload.c index 70ee262c09..97d50d7877 100644 --- a/libavfilter/vf_hwupload.c +++ b/libavfilter/vf_hwupload.c @@ -66,9 +66,11 @@ static int hw

[FFmpeg-devel] [PATCH 19/24] lavfi/vf_premultiply: switch to query_func2()

--- libavfilter/vf_premultiply.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_premultiply.c b/libavfilter/vf_premultiply.c index 30be869919..22dfbd52c4 100644 --- a/libavfilter/vf_premultiply.c +++ b/libavfilter/vf_premultiply.c @@ -63,9 +63,11 @

[FFmpeg-devel] [PATCH 16/24] lavfi/vf_pad: switch to query_func2()

--- libavfilter/vf_pad.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_pad.c b/libavfilter/vf_pad.c index e0cf84002b..dc9ffaa46d 100644 --- a/libavfilter/vf_pad.c +++ b/libavfilter/vf_pad.c @@ -72,9 +72,12 @@ enum var_name { VARS_NB }; -static

[FFmpeg-devel] [PATCH 18/24] lavfi/vf_paletteuse: switch to query_func2()

--- libavfilter/vf_paletteuse.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index 0cd00d520e..100f462750 100644 --- a/libavfilter/vf_paletteuse.c +++ b/libavfilter/vf_paletteuse.c @@ -136,18 +136,20 @@ A

[FFmpeg-devel] [PATCH 13/24] lavfi/vf_noise: switch to query_func2()

--- libavfilter/vf_noise.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_noise.c b/libavfilter/vf_noise.c index b5ef416dec..5a4ed9795d 100644 --- a/libavfilter/vf_noise.c +++ b/libavfilter/vf_noise.c @@ -131,7 +131,9 @@ static av_cold int init_noise(Noi

[FFmpeg-devel] [PATCH 17/24] lavfi/vf_palettegen: switch to query_func2()

--- libavfilter/vf_palettegen.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index 666bb6e349..d1ac5fcf34 100644 --- a/libavfilter/vf_palettegen.c +++ b/libavfilter/vf_palettegen.c @@ -100,15 +100,17 @@ sta

[FFmpeg-devel] [PATCH 22/24] lavfi/vf_mergeplanes: switch to query_func2()

--- libavfilter/vf_mergeplanes.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_mergeplanes.c b/libavfilter/vf_mergeplanes.c index 9f7930d44b..d97438a2c4 100644 --- a/libavfilter/vf_mergeplanes.c +++ b/libavfilter/vf_mergeplanes.c @@ -121,9 +121,11

[FFmpeg-devel] [PATCH 14/24] lavfi/vf_overlay: switch to query_func2()

--- libavfilter/vf_overlay.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index 03b48bf681..f0f0961ed2 100644 --- a/libavfilter/vf_overlay.c +++ b/libavfilter/vf_overlay.c @@ -161,9 +161,11 @@ static const

[FFmpeg-devel] [PATCH 11/24] lavfi/vf_lut2: switch to query_func2()

--- libavfilter/vf_lut2.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_lut2.c b/libavfilter/vf_lut2.c index 2488c9fdc2..88b45f45e5 100644 --- a/libavfilter/vf_lut2.c +++ b/libavfilter/vf_lut2.c @@ -140,9 +140,11 @@ static av_cold voi

[FFmpeg-devel] [PATCH 12/24] lavfi/vf_mix: switch to query_func2()

--- libavfilter/vf_mix.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_mix.c b/libavfilter/vf_mix.c index 16d6bf328c..f1e0cf617c 100644 --- a/libavfilter/vf_mix.c +++ b/libavfilter/vf_mix.c @@ -64,7 +64,9 @@ typedef struct MixContext { FFFrameS

[FFmpeg-devel] [PATCH 21/24] lavfi/vf_mergeplanes: remove redundant assignment

It is already done in init. --- libavfilter/vf_mergeplanes.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/vf_mergeplanes.c b/libavfilter/vf_mergeplanes.c index 8c1537e0bc..9f7930d44b 100644 --- a/libavfilter/vf_mergeplanes.c +++ b/libavfilter/vf_mergeplanes.c @@ -127,7 +127,6 @@

[FFmpeg-devel] [PATCH 10/24] lavfi/vf_lut: switch to query_func2()

--- libavfilter/vf_lut.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_lut.c b/libavfilter/vf_lut.c index 7e7fd2fa4a..af7172dc01 100644 --- a/libavfilter/vf_lut.c +++ b/libavfilter/vf_lut.c @@ -145,14 +145,16 @@ static const enum AVPixelFormat yuv_pi

[FFmpeg-devel] [PATCH 06/24] lavfi/vf_hwupload_cuda: switch to query_func2()

--- libavfilter/vf_hwupload_cuda.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_hwupload_cuda.c b/libavfilter/vf_hwupload_cuda.c index 1d04045551..1b99b3fa60 100644 --- a/libavfilter/vf_hwupload_cuda.c +++ b/libavfilter/vf_hwupload_cuda.c @@ -52,7 +

[FFmpeg-devel] [PATCH 09/24] lavfi/vf_libplacebo: convert to query_func2()

Drop a redundant error message for out_format, as it is already validated in init. --- libavfilter/vf_libplacebo.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/libavfilter/vf_libplacebo.c b/libavfilter/vf_libplacebo.c index 5bf8b7e77a..77219b830a 1

[FFmpeg-devel] [PATCH 07/24] lavfi/vf_il: switch to query_func2()

--- libavfilter/vf_il.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_il.c b/libavfilter/vf_il.c index 9a3a9d47a9..5e5d4c16e8 100644 --- a/libavfilter/vf_il.c +++ b/libavfilter/vf_il.c @@ -83,11 +83,14 @@ static const AVOption il_options[] = { AVFIL

[FFmpeg-devel] [PATCH 01/24] lavfi/vf_frei0r: switch to query_func2()

--- libavfilter/vf_frei0r.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_frei0r.c b/libavfilter/vf_frei0r.c index 83ca9c98b1..d3d7b33c4d 100644 --- a/libavfilter/vf_frei0r.c +++ b/libavfilter/vf_frei0r.c @@ -330,9 +330,11 @@ static int config_inpu

[FFmpeg-devel] [PATCH 02/24] lavfi/vf_hflip: switch to query_func2()

--- libavfilter/vf_hflip.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_hflip.c b/libavfilter/vf_hflip.c index 47870a167d..1f60e79bd7 100644 --- a/libavfilter/vf_hflip.c +++ b/libavfilter/vf_hflip.c @@ -37,7 +37,9 @@ #include "libavutil/intreadwrite.h

[FFmpeg-devel] [PATCH] doc/bitstream_filters: elaborate on h264_redundant_pps

As explained by jkqxz on IRC (thanks). Signed-off-by: Marth64 --- doc/bitstream_filters.texi | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index e1cb87a522..1e625ac913 100644 --- a/doc/bitstream_fil

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vvc_mc: R-V V dmvr

Fixed asm through `dmvr_hv\vlen\w:` to `func dmvr_hv\vlen\w, zve32x, zbb, zba` Rémi Denis-Courmont 于2024年10月12日周六 14:33写道： > Hi, > > This fails to assemble here (binutils 2.43.1). > > -- > 雷米‧德尼-库尔蒙 > http://www.remlab.net/ > ___ > ffmpeg-devel mailing

[FFmpeg-devel] [PATCH 2/2] lavc/vvc_mc: R-V V dmvr

From: sunyuechi k230 banana_f3 dmvr_8_12x20_c: 619.3 ( 1.00x)624.1 ( 1.00x) dmvr_8_12x20_rvv_i32: 128.6 ( 4.82x)103.4 ( 6.04x) dmvr_8_20x12_c: 610.0 ( 1.00x)665.6 ( 1.00x) dm

Re: [FFmpeg-devel] [Uncompressed MP4] RFC - Draft Encoder

ons 2024-10-09 klockan 20:08 -0600 skrev Devon Sookhoo: > Sounds good, I'll look into adding rawvideo to the list of > movcodec_tags. > > Looking at the AVPixFmtDescriptor, I noticed: AVComponentDescriptor > comp[4]; Does this line limit the component count to only four? > Encoding > video with ma