Re: [FFmpeg-devel] [PATCH] avcodec/decode: clean-up if get_hw_frames_parameters fails

2024-10-06 Thread Thomas Guillem via ffmpeg-devel
Ping. On Mon, Sep 30, 2024, at 13:44, Thomas Guillem via ffmpeg-devel wrote: > cf. https://trac.ffmpeg.org/ticket/11013 > > > On Mon, Sep 30, 2024, at 10:27, Thomas Guillem via ffmpeg-devel wrote: >> Fixes the following assert: >> >> [7f1df83d17e0] vaapi generic error: >> avcodec_get_hw_frame

Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: add support for AV1 MF encoders

2024-10-06 Thread Dash Santosh
Thanks for pointing this out, Martin. Please find the updated patch below: >From 83e8cfa99bcb13965421fb32c1feb4c792649c22 Mon Sep 17 00:00:00 2001 From: Min Chen Date: Fri, 4 Oct 2024 23:04:04 +0530 Subject: [PATCH] avcodec/mfenc: add support for AV1 MF encoders X-Unsent: 1 To: ffmpeg-devel@ffmpe

[FFmpeg-devel] [PATCH] fate/ffmpeg: add samples dependency to fate-ffmpeg-spec-disposition

2024-10-06 Thread Emily via ffmpeg-devel
From: Emily --- In the NixOS FFmpeg package, we run `make check` without downloading the entire FATE suite. The FFmpeg 7.1 update broke this, seemingly because of an undeclared FATE sample dependency. This package is my best‐guess attempt at fixing that based on the other commits and files that

Re: [FFmpeg-devel] [PATCH 02/12] tests/swscale: fix minor typos

2024-10-06 Thread Michael Niedermayer
On Sat, Oct 05, 2024 at 09:23:53PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/tests/swscale.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libswscale/tests/swscale.c b/libsw

Re: [FFmpeg-devel] [PATCH 12/12] swscale/input: parametrize ff_sws_init_input_funcs() pointers

2024-10-06 Thread Michael Niedermayer
On Sat, Oct 05, 2024 at 09:24:03PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Following the precedent set by ff_sws_init_output_funcs(). > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/input.c| 388 +- > l

Re: [FFmpeg-devel] [PATCH 11/12] swscale/internal: add typedefs for input reading functions

2024-10-06 Thread Michael Niedermayer
On Sat, Oct 05, 2024 at 09:24:02PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/swscale_internal.h | 47 +++ > 1 file changed, 31 insertions(+), 16 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 10/12] swscale/internal: forward typedef SwsContext

2024-10-06 Thread Michael Niedermayer
On Sat, Oct 05, 2024 at 09:24:01PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/swscale_internal.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) LGTM thx [...] -- Michael GnuPG finge

Re: [FFmpeg-devel] [PATCH 09/12] swscale/internal: constify SwsFunc

2024-10-06 Thread Michael Niedermayer
On Sat, Oct 05, 2024 at 09:24:00PM +0200, Niklas Haas wrote: > From: Niklas Haas > > I want to move away from having random leaf processing functions mutate > plane pointers, and while we're at it, we might as well make the strides > and tables const as well. > > Sponsored-by: Sovereign Tech Fun

Re: [FFmpeg-devel] [PATCH 08/12] swscale/internal: turn cascaded_tmp into an array

2024-10-06 Thread Michael Niedermayer
On Sat, Oct 05, 2024 at 09:23:59PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Slightly more convenient to access from the new wrapping code. > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/swscale.c | 20 ++-- > libswscale/s

Re: [FFmpeg-devel] [PATCH 07/12] swscale/internal: expose ff_update_palette() internally

2024-10-06 Thread Michael Niedermayer
On Sat, Oct 05, 2024 at 09:23:58PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/swscale.c | 4 ++-- > libswscale/swscale_internal.h | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) sure, o

Re: [FFmpeg-devel] [PATCH 04/12] swscale/internal: swap SWS_DITHER_NONE and SWS_DITHER_AUTO

2024-10-06 Thread Michael Niedermayer
On Sat, Oct 05, 2024 at 09:23:55PM +0200, Niklas Haas wrote: > From: Niklas Haas > > This is done for consistency with the other public enums which will be > added in the upcoming swscale API refactor. I went through the code and > checked > carefully that the value of `dither` is never implicit

Re: [FFmpeg-devel] [PATCH 03/12] swscale/internal: rename NB_SWS_DITHER for consistency

2024-10-06 Thread Michael Niedermayer
On Sat, Oct 05, 2024 at 09:23:54PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Niklas Haas > --- > libswscale/options.c | 2 +- > libswscale/swscale_internal.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) LGTM [..

[FFmpeg-devel] [PATCH][WIP] avisynth: support variable fps

2024-10-06 Thread Stephen Hutchinson
Draft #1. For testing reasons, the patch turns on vfr mode by default so it can be tested more quickly. The seeking issues described below are problematic enough that this behavior would be reversed when actually committed, unless it can be satisfactorily resolved before then. Currently has only

Re: [FFmpeg-devel] [PATCH v2] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-10-06 Thread Martin Storsjö
On Sat, 5 Oct 2024, Sean McGovern wrote: Hi On Sat, Oct 5, 2024, 19:15 Lynne via ffmpeg-devel wrote: On 05/10/2024 20:58, Sean McGovern wrote: --- libavcodec/aacenc_pred.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/aacenc_pred.c b/libavcodec/aace

[FFmpeg-devel] [PATCH] configure: add spirv_compiler to avcodec_suggest

2024-10-06 Thread Lynne via ffmpeg-devel
893f3fde4cdeb made libavcodec link to libshaderc/libglslang, though no codecs depend on it at this immediate moment. This was merged largely as a coordination effort to synchronize three different developers' repositories to allow them to send patches without overlapping functionality in between.

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecenc: Fix access of uninitialized value

2024-10-06 Thread Matthieu Bouron
On Thu, Oct 3, 2024 at 7:31 PM Zhao Zhili wrote: > > From: Zhao Zhili > > When crop is skipped, av_strlcatf will access `str` which isn't > initialized properly. > --- > libavcodec/mediacodecenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mediacodecenc.c

Re: [FFmpeg-devel] [PATCH 2/3] scale_cuda frame crop support

2024-10-06 Thread Timo Rothenpieler
On 10.09.2024 20:10, Koushik Dutta wrote: The crop filter has no effect on scale_cuda: -vf crop=100:100,scale_cuda=300x300 Hardware frames (AV_PIX_FMT_FLAG_HWACCEL) are expected to use the crop_* properties, as seen in the implementation vf_crop.c. The current workaround is to hwdownload the

Re: [FFmpeg-devel] [PATCH 06/12] swscale/internal: expose low level swscale() internally

2024-10-06 Thread Ramiro Polla
On Sat, Oct 5, 2024 at 10:14 PM Niklas Haas wrote: > > From: Niklas Haas > > And give it const parameters while we're at it, because this function does > not mutate its parameters. Not entirely correct since it still modifies srcStride. After fixing this it should then be possible to remove the

[FFmpeg-devel] [PATCH] configure: add spirv_compiler to avcodec_suggest

2024-10-06 Thread Lynne via ffmpeg-devel
893f3fde4cdeb made libavcodec link to libshaderc/libglslang, though no codecs depend on it at this immediate moment. This was merged largely as a coordination effort to synchronize three different developers' repositories to allow them to send patches without overlapping functionality in between.

Re: [FFmpeg-devel] [PATCH 05/12] swscale/internal: fix and expose xyz12Torgb48 and rgb48Toxyz12

2024-10-06 Thread Niklas Haas
On Sun, 06 Oct 2024 17:26:25 +0200 Ramiro Polla wrote: > On Sat, Oct 5, 2024 at 9:25 PM Niklas Haas wrote: > > From: Niklas Haas > > > > In the process of refactoring the signature to be more generically useful, > > this fixes an 11-year-old bug where the functions (incorrectly) did nothing > >

Re: [FFmpeg-devel] [PATCH 05/12] swscale/internal: fix and expose xyz12Torgb48 and rgb48Toxyz12

2024-10-06 Thread Ramiro Polla
On Sat, Oct 5, 2024 at 9:25 PM Niklas Haas wrote: > From: Niklas Haas > > In the process of refactoring the signature to be more generically useful, > this fixes an 11-year-old bug where the functions (incorrectly) did nothing > when the stride was negative, since the stride was being used as the