Re: [FFmpeg-devel] [PATCH 2/2] lavc/vvc_mc: R-V V dmvr

2024-09-27 Thread Rémi Denis-Courmont
Hi, Le perjantaina 27. syyskuuta 2024, 20.09.30 EEST u...@foxmail.com a écrit : > From: sunyuechi > > k230 banana_f3 > dmvr_8_12x20_c: 628.5 ( 1.00x)624.1 ( 1.00x) > dmvr_8_12x20_rvv_i32: 137.5 ( 4.57x)

Re: [FFmpeg-devel] [PATCH 1/5] compat: add a fallback implementation of C23 stdckdint.h

2024-09-27 Thread Rémi Denis-Courmont
Le perjantaina 27. syyskuuta 2024, 4.44.32 EEST James Almer a écrit : > From: Justine Tunney > > Header contents taken from > https://github.com/jart/jtckdint/commit/62df1fc0966926299253b7af46c23e3 > 45545 > > Signed-off-by: James Almer No objections but ... The same idea (with no concrete

Re: [FFmpeg-devel] [PATCH v3] avcodec/videotoolbox: add AV1 hardware acceleration

2024-09-27 Thread Cameron Gutman
On Thu, Sep 26, 2024 at 4:25 PM Martin Storsjö wrote: > > From: Jan Ekström > > Use AV1DecContext's current_obu to access the original OBUs, and > feed them to videotoolbox, rather than the bare slice data passed > via decode_slice. > > This requires a small addition to AV1DecContext, for keeping

Re: [FFmpeg-devel] [PATCH 02/10] MAINTAINERS: aacdec seems unmaintained, aacdec_usac seems maintained by Lynne

2024-09-27 Thread Lynne via ffmpeg-devel
On 22/09/2024 23:56, Michael Niedermayer wrote: CC: Lynne Signed-off-by: Michael Niedermayer --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b6fbfdc48d..882ecae1d32 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -146,6 +146,8 @@ Codecs:

Re: [FFmpeg-devel] [PATCH] ppc: Recognize the PPC VSX and Power8 CPU flags

2024-09-27 Thread Brad Smith
ping. On 2024-09-21 5:05 a.m., Brad Smith wrote: ppc: Recognize the PPC VSX and Power8 CPU flags Signed-off-by: Brad Smith --- libavutil/cpu.c | 2 ++ libavutil/tests/cpu.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/libavutil/cpu.c b/libavutil/cpu.c index df00bd541f..44cb

Re: [FFmpeg-devel] [PATCH 01/10] fftools/ffmpeg_filter: stop using avfilter_graph_alloc_filter() incorrectly

2024-09-27 Thread epirat07
On 28 Sep 2024, at 0:27, James Almer wrote: > On 9/25/2024 10:29 AM, Anton Khirnov wrote: >> This function creates AND initializes a filter, so setting any filter >> options after it is wrong. It happens to work when the filter's init >> function does not touch the options in question, but is f

Re: [FFmpeg-devel] [PATCH 08/10] swscale/swscale_unscaled: Fix odd height with nv24_to_yuv420p_chroma()

2024-09-27 Thread Michael Niedermayer
On Wed, Sep 25, 2024 at 03:16:30PM +0200, Ramiro Polla wrote: > On Tue, Sep 24, 2024 at 3:35 PM Michael Niedermayer > wrote: > > On Mon, Sep 23, 2024 at 12:42:22AM +0200, Ramiro Polla wrote: > > > Hi, > > > > > > On Mon, Sep 23, 2024 at 12:04 AM Michael Niedermayer > > > wrote: > > > > > > > > Fi

Re: [FFmpeg-devel] [RFC] Swscale refactor progress and feedback

2024-09-27 Thread Michael Niedermayer
Hi On Fri, Sep 27, 2024 at 04:49:58PM +0200, Niklas Haas wrote: > Hi all, > > After a bit of a hiatus due to delays in negotioting the appropriate > contracts, I've finally been able to resume work on the swscale refactor > and have my current draft to demonstrate and gather critique on. > > Rat

[FFmpeg-devel] [PATCH 1/2] Update R-V V vvc_mc vset to support more lengths

2024-09-27 Thread uk7b
From: sunyuechi --- libavcodec/riscv/vvc/vvc_mc_rvv.S | 46 +++ 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/libavcodec/riscv/vvc/vvc_mc_rvv.S b/libavcodec/riscv/vvc/vvc_mc_rvv.S index 45f4750f82..18532616d9 100644 --- a/libavcodec/riscv/vvc/vvc_mc

Re: [FFmpeg-devel] [PATCH 01/10] fftools/ffmpeg_filter: stop using avfilter_graph_alloc_filter() incorrectly

2024-09-27 Thread James Almer
On 9/25/2024 10:29 AM, Anton Khirnov wrote: This function creates AND initializes a filter, so setting any filter options after it is wrong. It happens to work when the filter's init function does not touch the options in question, but is forbidden by the API and is not guaranteed to remain funct

[FFmpeg-devel] [PATCH v4] avcodec/h264: ignore POC when flag is set

2024-09-27 Thread Kevin Wang
When the flag AV_CODEC_FLAG_OUTPUT_CORRUPT or AV_CODEC_FLAG2_SHOW_ALL is set, ignore any out of order POC's as they may still be valid frames. --- Apologies for the non-inlined patch but for some reason patchwork doesn't apply it correctly. This is the same patch as https://ffmpeg.org/pipermail/ff

[FFmpeg-devel] [PATCH v2 13/16] swscale/x86/range_convert: update sse2 and avx2 range_convert functions to new API

2024-09-27 Thread Ramiro Polla
chrRangeFromJpeg8_1920_c: 5804.5 ( 1.00x) chrRangeFromJpeg8_1920_sse2: 1960.2 ( 2.96x) 1955.2 ( 2.97x) chrRangeFromJpeg8_1920_avx2: 996.1 ( 5.83x) 988.9 ( 5.87x) chrRangeToJpeg8_1920_c: 9388.6 ( 1.00x) chrRangeToJpeg8_1920_sse2:1963.7 ( 4.78x) 1949.9 ( 4.81x) chrRangeToJpeg8_19

Re: [FFmpeg-devel] [PATCH] avformat/hlsplaylist: set stream name according to var_stream_map varname

2024-09-27 Thread Steven Liu
> On Sep 27, 2024, at 19:57, jb wrote: > > Sorry for the last empty replay! > > That patch is not working correctly. > > The variable `varname` is also used for multiple video streams. What about try to use a varname for webvtt, eg. subtitle_varname ? > > Is there another way, to specify th

Re: [FFmpeg-devel] [PATCH 1/2] avdevice/decklink_dec: fix leak on error

2024-09-27 Thread Marton Balint
On Sun, 22 Sep 2024, Marton Balint wrote: On Thu, 12 Sep 2024, Marvin Scholz wrote: In the early return when both draw_bars and signal_loss_action options are used, the context allocated previously was not properly freed. Introduced in 9bcb86b0fa58f1a5a2a8613065349e26abadb329 Fixes

[FFmpeg-devel] [PATCH v2 02/16] swscale/range_convert: drop redundant conditionals from arch-specific init functions

2024-09-27 Thread Ramiro Polla
These conditions are already checked for in the main init function. --- libswscale/aarch64/swscale.c | 2 -- libswscale/loongarch/swscale_init_loongarch.c | 4 libswscale/riscv/swscale.c| 3 +-- libswscale/swscale.c | 2 +- libswsc

[FFmpeg-devel] [PATCH 1/2] avformat/avformat: add side data to AVStreamGroupTileGrid

2024-09-27 Thread James Almer
Will be used to export certain information present in HEIF samples, like rotation metadata, ICC profiles, and potentially others. Signed-off-by: James Almer --- libavformat/avformat.h | 13 + libavformat/dump.c | 30 ++ 2 files changed, 31 insertions(+

[FFmpeg-devel] [PATCH 2/2] avformat/mov: get heif image rotation from irot box

2024-09-27 Thread James Almer
Based on a patch by Hacene Bouaroua. Co-authored-by: Hacene Bouaroua Signed-off-by: James Almer --- libavformat/isom.h | 1 + libavformat/mov.c | 75 +++--- 2 files changed, 72 insertions(+), 4 deletions(-) diff --git a/libavformat/isom.h b/libavformat

[FFmpeg-devel] [PATCH 2/2] lavc/vvc_mc: R-V V dmvr

2024-09-27 Thread uk7b
From: sunyuechi k230 banana_f3 dmvr_8_12x20_c: 628.5 ( 1.00x)624.1 ( 1.00x) dmvr_8_12x20_rvv_i32: 137.5 ( 4.57x)92.9 ( 6.72x) dmvr_8_20x12_c: 609.7 ( 1.00x)655.4 ( 1.00x) dmv

Re: [FFmpeg-devel] [PATCH] avformat/mov: get heif image rotation from irot box

2024-09-27 Thread James Almer
On 9/27/2024 1:43 PM, Anton Khirnov wrote: Quoting James Almer (2024-09-25 02:14:46) Based on a patch by Hacene Bouaroua. Co-authored-by: Hacene Bouaroua Signed-off-by: James Almer --- libavformat/avformat.h | 6 + libavformat/isom.h | 1 + libavformat/mov.c | 54 ++

[FFmpeg-devel] [PATCH v2 14/16] swscale/x86: add sse2, sse4, and avx2 {lum, chr}ConvertRange16

2024-09-27 Thread Ramiro Polla
chrRangeFromJpeg16_1920_c: 5809.1 chrRangeFromJpeg16_1920_sse2: 3909.5 ( 1.49x) chrRangeFromJpeg16_1920_avx2: 1985.3 ( 2.93x) chrRangeToJpeg16_1920_c: 9261.5 chrRangeToJpeg16_1920_sse2:6053.2 ( 1.53x) chrRangeToJpeg16_1920_sse4:4493.6 ( 2.06x) chrRangeToJpeg16_1920_avx2:2405

[FFmpeg-devel] [PATCH 5/5 v2] avformat/mov: use checked arithmetic functions in mov_read_stts()

2024-09-27 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index a2333ac1fd..0c3392b1a0 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -28,6 +28,7 @@ #include #inclu

Re: [FFmpeg-devel] [PATCH v3 1/3] aarch64/vvc: Add w_avg

2024-09-27 Thread Martin Storsjö
On Thu, 26 Sep 2024, Zhao Zhili wrote: From: Zhao Zhili w_avg_8_2x2_c: 0.0 ( 0.00x) w_avg_8_2x2_neon:0.0 ( 0.00x) w_avg_8_4x4_c: 0.2 ( 1.00x) w_avg_8_4x4_neon:

Re: [FFmpeg-devel] [PATCH] avformat/mov: get heif image rotation from irot box

2024-09-27 Thread Anton Khirnov
Quoting James Almer (2024-09-27 19:07:42) > On 9/27/2024 1:43 PM, Anton Khirnov wrote: > > Quoting James Almer (2024-09-25 02:14:46) > >> Based on a patch by Hacene Bouaroua. > >> > >> Co-authored-by: Hacene Bouaroua > >> Signed-off-by: James Almer > >> --- > >> libavformat/avformat.h | 6

Re: [FFmpeg-devel] [PATCH] avformat/mov: get heif image rotation from irot box

2024-09-27 Thread Anton Khirnov
Quoting James Almer (2024-09-25 02:14:46) > Based on a patch by Hacene Bouaroua. > > Co-authored-by: Hacene Bouaroua > Signed-off-by: James Almer > --- > libavformat/avformat.h | 6 + > libavformat/isom.h | 1 + > libavformat/mov.c | 54 ++

[FFmpeg-devel] [PATCH v2 11/16] swscale/aarch64/range_convert: saturate output instead of limiting input

2024-09-27 Thread Ramiro Polla
aarch64 A55: chrRangeFromJpeg8_1920_c: 28839.3 ( 1.00x) chrRangeFromJpeg8_1920_neon: 5312.2 ( 5.43x) 5309.9 ( 5.43x) chrRangeToJpeg8_1920_c: 44196.1 ( 1.00x) chrRangeToJpeg8_1920_neon: 6035.9 ( 7.32x) 5550.8 ( 7.96x) lumRangeFromJpeg8_1920_c: 15384.3 ( 1.00x) lumRangeFromJpeg8

Re: [FFmpeg-devel] [PATCH] avformat/mov: get heif image rotation from irot box

2024-09-27 Thread James Almer
On 9/24/2024 9:14 PM, James Almer wrote: Based on a patch by Hacene Bouaroua. Co-authored-by: Hacene Bouaroua Signed-off-by: James Almer --- libavformat/avformat.h | 6 + libavformat/isom.h | 1 + libavformat/mov.c | 54 ++ 3 files ch

[FFmpeg-devel] [RFC] Swscale refactor progress and feedback

2024-09-27 Thread Niklas Haas
Hi all, After a bit of a hiatus due to delays in negotioting the appropriate contracts, I've finally been able to resume work on the swscale refactor and have my current draft to demonstrate and gather critique on. Rather than the initial goal of introducing a new AVScale header, I have updated m

Re: [FFmpeg-devel] [PATCH] avformat/hlsplaylist: set stream name according to var_stream_map varname

2024-09-27 Thread jb
Sorry for the last empty replay! That patch is not working correctly. The variable `varname` is also used for multiple video streams. Is there another way, to specify the language name? Am 26.09.24 um 09:28 schrieb Jonathan Baecker: From: jb-alvarado If name:* is set in var_stream_map varia

[FFmpeg-devel] [PATCH v2 07/16] checkasm/sw_range_convert: only run benchmarks on largest input width

2024-09-27 Thread Ramiro Polla
--- tests/checkasm/sw_range_convert.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/checkasm/sw_range_convert.c b/tests/checkasm/sw_range_convert.c index df27b6c81e..e97388d14a 100644 --- a/tests/checkasm/sw_range_convert.c +++ b/tests/checkasm/sw_range_convert.c @@ -62,6 +62,7 @@ s

[FFmpeg-devel] [PATCH v2 12/16] swscale/range_convert: fix mpeg ranges in yuv range conversion for non-8-bit pixel formats

2024-09-27 Thread Ramiro Polla
There is an issue with the constants used in YUV to YUV range conversion, where the upper bound is not respected when converting to mpeg range. With this commit, the constants are calculated at runtime, depending on the bit depth. This approach also allows us to more easily understand how the cons

[FFmpeg-devel] [PATCH v2 15/16] swscale/aarch64/range_convert: update neon range_convert functions to new API

2024-09-27 Thread Ramiro Polla
A55: chrRangeFromJpeg8_1920_c:28833.8 ( 1.00x) chrRangeFromJpeg8_1920_neon: 5309.9 ( 5.43x) 5313.1 ( 5.43x) chrRangeToJpeg8_1920_c: 23070.6 ( 1.00x) chrRangeToJpeg8_1920_neon:5550.8 ( 4.16x) 5550.8 ( 4.16x) lumRangeFromJpeg8_1920_c:15388.1 ( 1.00x) lumRangeFromJpeg8_1920_neon:

[FFmpeg-devel] [PATCH v2 08/16] checkasm/sw_range_convert: test all supported bit depths

2024-09-27 Thread Ramiro Polla
This commit also reduces the number of times ff_sws_init_scale() gets called (only once per bit depth), and the number of times randomize_buffers() gets called (only if the function must be checked). Benchmarks are only performed on bit depths 8 and 16 (since they are different functions, and not

[FFmpeg-devel] [PATCH v2 05/16] checkasm/sw_range_convert: use YUV pixel formats instead of YUVJ

2024-09-27 Thread Ramiro Polla
We are already setting the range, so we can use regular YUV pixel formats instead of YUVJ. --- tests/checkasm/sw_range_convert.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/sw_range_convert.c b/tests/checkasm/sw_range_convert.c index 1f04988097..8c8a

[FFmpeg-devel] [PATCH v2 03/16] swscale/range_convert: indent after previous commit

2024-09-27 Thread Ramiro Polla
--- libswscale/loongarch/swscale_init_loongarch.c | 32 +-- libswscale/swscale.c | 8 ++--- libswscale/x86/swscale.c | 12 +++ 3 files changed, 26 insertions(+), 26 deletions(-) diff --git a/libswscale/loongarch/swscale_init_loong

Re: [FFmpeg-devel] [PATCH 1/5] lavf/mxfdec: Speed up klv_read_packet()

2024-09-27 Thread Tomas Härdin
I'll push patches 1, 4 and 5 in a few days. /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscrib

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: remove libopenjpeg decoder entry

2024-09-27 Thread Gyan Doshi
On 2024-09-27 05:03 am, Michael Niedermayer wrote: On Wed, Sep 25, 2024 at 09:18:56PM +0530, Gyan Doshi wrote: The decoder wrapper was removed in 60ccb3fe78 --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) LGTM Thanks. Pushed as 2b689261c5bae0005a76403219392f8a597717ed Regards, Gy

[FFmpeg-devel] [PATCH 00/16] swscale/range_convert: fix mpeg ranges in yuv range conversion for non-8-bit pixel formats

2024-09-27 Thread Ramiro Polla
There is an issue with the constants used in YUV to YUV range conversion, where the upper bound is not respected when converting to mpeg range. With this patchset, the constants are calculated at runtime, depending on the bit depth. This approach also allows us to more easily understand how the co

[FFmpeg-devel] [PATCH v2 04/16] checkasm: use FF_ARRAY_ELEMS instead of hardcoding size of arrays

2024-09-27 Thread Ramiro Polla
--- tests/checkasm/sw_gbrp.c | 15 --- tests/checkasm/sw_range_convert.c | 8 ++-- tests/checkasm/sw_scale.c | 11 --- 3 files changed, 10 insertions(+), 24 deletions(-) diff --git a/tests/checkasm/sw_gbrp.c b/tests/checkasm/sw_gbrp.c index d843730f3e..74

[FFmpeg-devel] [PATCH v2 10/16] swscale/range_convert: saturate output instead of limiting input

2024-09-27 Thread Ramiro Polla
For bit depths <= 14, the result is saturated to 15 bits. For bit depths > 14, the result is saturated to 19 bits. x86_64: chrRangeFromJpeg8_1920_c:5827.4 5804.5 ( 1.00x) chrRangeFromJpeg16_1920_c: 5793.2 5792.8 ( 1.00x) chrRangeToJpeg8_1920_c: 11726.2 9388.6 ( 1.25x) chrRangeTo

[FFmpeg-devel] [PATCH v2 16/16] swscale/aarch64: add neon {lum, chr}ConvertRange16

2024-09-27 Thread Ramiro Polla
A55 A76 chrRangeFromJpeg16_1920_c: 28840.6 6323.5 chrRangeFromJpeg16_1920_neon: 8436.5 ( 3.42x) 3365.2 ( 1.88x) chrRangeToJpeg16_1920_c: 23075.1 9195.6 chrRangeToJpeg16_1920_neon: 9393.6 ( 2.46x) 4084.5 ( 2.25x) l

[FFmpeg-devel] [PATCH v2 06/16] checkasm/sw_range_convert: reduce number of input sizes tested

2024-09-27 Thread Ramiro Polla
Reduce input sizes to 8 (to test that the function works with widths smaller than the vector length) and 1920 (raising the largest input size to improve benchmark results). --- tests/checkasm/sw_range_convert.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/check

[FFmpeg-devel] [PATCH v2 09/16] checkasm/sw_range_convert: indent after previous couple of commits

2024-09-27 Thread Ramiro Polla
--- tests/checkasm/sw_range_convert.c | 48 +++ 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/tests/checkasm/sw_range_convert.c b/tests/checkasm/sw_range_convert.c index e3e5096729..01c4549e53 100644 --- a/tests/checkasm/sw_range_convert.c +++ b/tests

[FFmpeg-devel] [PATCH v2 01/16] swscale/range_convert: call arch-specific init functions from main init function

2024-09-27 Thread Ramiro Polla
This commit also fixes the issue that the call to ff_sws_init_range_convert() from sws_init_swscale() was not setting up the arch-specific optimizations. --- libswscale/aarch64/swscale.c | 5 - libswscale/loongarch/swscale_init_loongarch.c | 1 - libswscale/riscv/swscale.c

Re: [FFmpeg-devel] [PATCH] avformat/hlsplaylist: set stream name according to var_stream_map varname

2024-09-27 Thread jb
Am 26.09.24 um 09:28 schrieb Jonathan Baecker: From: jb-alvarado If name:* is set in var_stream_map variable, take that as NAME= variable. This helps gives better stream names in html players. --- libavformat/hlsenc.c | 2 +- libavformat/hlsplaylist.c | 9 +++-- libavformat/hlsp

Re: [FFmpeg-devel] Exposing ability to add new filters without recompiling libavfilter?

2024-09-27 Thread Steven Liu
> On Sep 27, 2024, at 19:22, Carlos Ruiz wrote: > > Hi all, > > Not sure if this should be directed at libav-user instead, feel free to > redirect > me if needed. > > I've read the writing_filters.txt documentation and numerous StackOverflow > posts and everything indicates that in order to

Re: [FFmpeg-devel] [PATCH] Respect `append_list` flag in subtitle playlists

2024-09-27 Thread Steven Liu
> On Sep 27, 2024, at 14:32, Jonathan Baecker wrote: Hi Jonathan, thanks for your valuable patch. > > Ensure that when the `-hls_flags append_list` option is set, that *.vtt files > in stream_vtt.m3u8 are correctly updated. This fixes > https://trac.ffmpeg.org/ticket/11208 > > This is a bi

[FFmpeg-devel] Exposing ability to add new filters without recompiling libavfilter?

2024-09-27 Thread Carlos Ruiz
Hi all, Not sure if this should be directed at libav-user instead, feel free to redirect me if needed. I've read the writing_filters.txt documentation and numerous StackOverflow posts and everything indicates that in order to add your own custom filter, the Makefile in libavfilter needs to modifi