Menu 0 is the VIDEO_TS root menu, which does not appear to be used
commonly for menu segments. Instead, default to the menu of VTS 1.
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/d
Some discs present titles with bogus NAV packets. We apply this check
for menus and for title MPEG blocks, but we should also apply it
for NAV packets during title demuxing.
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/libavforma
DVDs naturally consist of segmented MPEG-PS blobs within a VOB
(i.e. VOBs are not linear). NAV packs set the segment boundaries.
When switching between segments, discontinuities occur and thus
the subdemuxer needs to be reset. The current approach to manage
this is by invoking ff_read_frame_flush()
The function has a few branches where it discards frames via
FFERROR_REDO; consolidate is via a goto block to simplify the
function and improve readability. Logging still maintains
all the relevant details for the reason of the discard.
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 44 +
Menus are generally segmented by cell, so use them as the
marker delimiters. Requires preindex option to be enabled.
Signed-off-by: Marth64
---
doc/demuxers.texi | 1 -
libavformat/dvdvideodec.c | 53 ++-
2 files changed, 35 insertions(+), 19 deletion
This consolidates the FFERROR_REDO handling of NAV packets to
dvdvideo_subdemux_read_data(), is a pre-requisite to calculating
chapter markers for menus, and a pre-requisite to fixing the
frame desync issue when the subdemuxer is flushed.
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 31
Readability improvement; the warning can be bundled beneath
the preceding validations rather than awkwardly between the memcpy
and return.
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/dvdvideodec.c b/liba
The default "auto" mode is effectively useless; the reasonable
default use case is to use the first PG (segment) of the
selected PGC for both menus and standard titles. Just
default the value to 1, since the option is irrelevant
unless -pgc is also set.
Note that this should not break users using
This will be a pre-requisite to calculating chapter markers
for menus.
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index da41a9d329..18c356c132 100644
--- a/libavformat/dvdvideodec.
This set aims to fix very subtle desync issues when handling discontinuities,
do some cleanup, and improve menu support.
Signed-off-by: Marth64
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To u
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index 4e33d1aba6..da41a9d329 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -344,7 +344,7 @@ st
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index 6bd1dbc17f..4e33d1aba6 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -44,8 +44,6 @@
#include "libavuti
Quoting j...@jonb.org (2024-09-04 10:06:15)
> From: Jonathan Baudanza
>
> I encountered this problem with NTP timestamps that are extremely old,
> like from January, 1990.
>
> Although RFC3550 suggests that the timestamps in the RTCP packets use
> the actual wallclock, some implementations use o
Quoting Lynne via ffmpeg-devel (2024-09-14 08:58:46)
> @@ -551,6 +552,30 @@ int
> ff_hw_base_encode_set_output_property(FFHWBaseEncodeContext *ctx,
> (3 * ctx->output_delay + ctx->async_depth)];
> }
>
> +if ((avctx->codec_id == AV_CODEC_ID_AV1) &&
> +
Quoting Filip Mašić (2024-09-19 18:23:27)
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index 56c1c80289..a2ef209e35 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -2933,10 +2933,13 @@ void av_dump_format(AVFormatContext *ic,
> * @param buf destinatio
Quoting fei.w.wang-at-intel@ffmpeg.org (2024-09-18 09:10:30)
> static void export_frame_params(VVCContext *s, const VVCFrameContext *fc)
> {
> AVCodecContext *c = s->avctx;
> const VVCSPS *sps = fc->ps.sps;
> const VVCPPS *pps = fc->ps.pps;
>
> -c->pix_fmt = sps->pix
Quoting fei.w.wang-at-intel@ffmpeg.org (2024-09-18 09:10:28)
> diff --git a/libavcodec/vvc/refs.h b/libavcodec/vvc/refs.h
> index 8ae33d4a9a..fc8e0aae6d 100644
> --- a/libavcodec/vvc/refs.h
> +++ b/libavcodec/vvc/refs.h
> @@ -25,6 +25,11 @@
>
> #include "dec.h"
>
> +#define FF_VVC_FRAME_FL
Quoting James Almer (2024-09-23 04:17:46)
> On 9/22/2024 3:00 PM, Anton Khirnov wrote:
> > The HEVC decoder will start setting stereoscopic view position (left or
> > right) based on 3D Reference Displays Info SEI message in future
> > commits. This information should be merged with container-deriv
On 9/22/2024 3:00 PM, Anton Khirnov wrote:
The HEVC decoder will start setting stereoscopic view position (left or
right) based on 3D Reference Displays Info SEI message in future
commits. This information should be merged with container-derived
stereo3D side data.
After this set, a re-encode w
Hi,
I recommend to review the Contributing guide
https://ffmpeg.org/developer.html#Introduction
Generally the process consists of organizing your commits nicely and
using git to format as patch files, then email them to this address.
Best of luck!
___
f
On Wed, Aug 14, 2024 at 08:29:37AM +0200, Christophe Gisquet wrote:
> Hi,
>
> Le mar. 13 août 2024 à 23:39, Dale Curtis a écrit :
> >
> > On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes wrote:
> >
> > > Disabling random codec features seems like an anti-feature to me, in
> > > the future it'll m
On Thu, Sep 12, 2024 at 4:44 PM James Almer wrote:
> On 9/12/2024 5:16 AM, Ramiro Polla wrote:
> > On Thu, Sep 12, 2024 at 8:44 AM James Almer wrote:
> >>
> >> Should fix fate-checkasm-sw_rgb under gcc-ubsan.
> >>
> >> Signed-off-by: James Almer
> >> ---
> >> tests/checkasm/sw_rgb.c | 2 +-
> >
Hi,
On Mon, Sep 23, 2024 at 12:04 AM Michael Niedermayer
wrote:
>
> Fixes: out of array read
> Fixes: 71726/clusterfuzz-testcase-ffmpeg_SWS_fuzzer-5876893532880896
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael N
On Tue, 13 Aug 2024 14:38:48 -0700 Dale Curtis wrote:
> On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes wrote:
>
> > Disabling random codec features seems like an anti-feature to me, in
> > the future it'll make every feature be questioned and compile-time
> > conditional, and make everything te
On Thu, 12 Sep 2024, Martin Schitter wrote:
---
libavcodec/Makefile| 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/dnxucdec.c | 391 +
3 files changed, 393 insertions(+)
create mode 100644 libavcodec/dnxucdec.c
diff --git a/libavcodec/Makefile b/
Fixes: Timeout
Fixes:
71739/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XAN_WC3_fuzzer-6170301405134848
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpe
Signed-off-by: Michael Niedermayer
---
libavcodec/xan.c | 3 +++
1 file changed, 3 in
Fixes: Timeout
Fixes:
71727/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VBLE_fuzzer-6126342574243840
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/vble.c | 8
1 file changed,
Fixes: out of array read
Fixes: 71726/clusterfuzz-testcase-ffmpeg_SWS_fuzzer-5876893532880896
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libswscale/swscale_unscaled.c | 2 ++
1 file changed, 2 insert
Fixes: Timeout
Fixes:
71712/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SGIRLE_fuzzer-5763700835811328
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/sgirledec.c | 3 +++
1 file changed
Fixes: Timeout
Fixes:
71324/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IMM4_fuzzer-5388489435185152
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/imm4.c | 4
1 file changed, 4 in
Fixes: NULL pointer dereference
Fixes:
71303/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-4875859050168320
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/vvc/thread.c | 3 ++-
Fixes: Timeout
Fixes:
71295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SVQ3_fuzzer-441125111808
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
libavcodec/svq3.c | 3 +++
1 file changed, 3 ins
Fixes: OOM and Timeout
Fixes: 71254/clusterfuzz-testcase-minimized-ffmpeg_SWR_fuzzer-5941896977907712
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
tools/target_swr_fuzzer.c | 3 +++
1 file changed, 3 i
CC: Lynne
Signed-off-by: Michael Niedermayer
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5b6fbfdc48d..882ecae1d32 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -146,6 +146,8 @@ Codecs:
4xm.c [2] Michael Nied
Fixes: Timeout
Fixes:
71234/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SRGC_fuzzer-5098445864501248
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer
---
tools/target_dec_fuzzer.c | 1 +
1 file changed,
On Thu, 12 Sep 2024, Marvin Scholz wrote:
In the early return when both draw_bars and signal_loss_action
options are used, the context allocated previously was not
properly freed.
Introduced in 9bcb86b0fa58f1a5a2a8613065349e26abadb329
Fixes CID1619296
---
libavdevice/decklink_dec.cpp | 1 +
On Sun, 22 Sep 2024, Tomas Härdin wrote:
mxf_match_uid() is rather slow and gets called a lot. Unrolling it like
this saves some cycles, but probably not enough to justify making the
code much more verbose
Yeah, this looks a bit overkill.
Regards,
Marton
From: nihil-admirari <50202386+nihil-admir...@users.noreply.github.com>
Fixes build issue for Win32 targets
---
libavcodec/vulkan_encode_h264.c | 2 +-
libavcodec/vulkan_encode_h265.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/vulkan_encode_h264.c b/libavcod
From: nihil-admirari <50202386+nihil-admir...@users.noreply.github.com>
Fixes build issue for Win32 targets
---
libavcodec/vulkan_encode_h264.c | 2 +-
libavcodec/vulkan_encode_h265.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/vulkan_encode_h264.c b/libavcod
Otherwise it may accumulate when e.g. global side data is repeatedly
copied to the frame with in each subsequent reget_buffer() call.
---
libavcodec/decode.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index 1f2fbda6ad..57cca44d05 100644
--- a/li
Also, deduplicate the code performing the mapping.
---
libavcodec/decode.c | 98 +
1 file changed, 54 insertions(+), 44 deletions(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index 57cca44d05..9303254ef3 100644
--- a/libavcodec/decode.c
+++
The HEVC decoder will start setting stereoscopic view position (left or
right) based on 3D Reference Displays Info SEI message in future
commits. This information should be merged with container-derived
stereo3D side data.
---
libavcodec/decode.c | 46 -
From e036dec9bdd621db809bb23822b7d22f66ab43fc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomas=20H=C3=A4rdin?=
Date: Sun, 15 Sep 2024 22:46:55 +0200
Subject: [PATCH 5/5] lavf/mxfdec: Remove a call to avio_tell() in
klv_read_packet()
---
libavformat/mxfdec.c | 22 ++
1 file ch
This is the big one. The offset_temp calculations that used to be part
of mxf_edit_unit_absolute_offset() are moved to
mxf_compute_index_tables() and are done only once. This also makes
random access in mxf_edit_unit_absolute_offset() possible
/Tomas
From 8d1f84e6b047fcaeba74a76cfc6b8f3ebc450145 M
mxf_match_uid() is rather slow and gets called a lot. Unrolling it like
this saves some cycles, but probably not enough to justify making the
code much more verbose
/Tomas
From ed92d030212e230c7a12d2b265feb470ffd5caa8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomas=20H=C3=A4rdin?=
Date: Sat, 14 Se
This gives some gains, but would probably be nicer if it leveraged the
type system by defining a specific type for 12-byte keys so there can
be no accidental mixup
/Tomas
From 367a59ac08624326841bfbecbb5cffb664567d27 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomas=20H=C3=A4rdin?=
Date: Sat, 14 Sep
This patchset speeds up mxfdec in various ways. The test file has been
generated with
ffmpeg -t 1 -f lavfi -i testsrc -s 160x120 out2.mxf
Performance is measured with callgrind using the command
valgrind --tool=callgrind ./ffmpeg_g -loglevel quiet -i out2.mxf -codec copy
-f null -
The ca
On Mon, Jul 01, 2024 at 01:12:42AM +0200, Michael Niedermayer wrote:
> I did not investigate exactly why frame is NULL, happy to provide the sample
> if someone wants to investigate further
>
> Fixes: NULL pointer dereference
> Fixes:
> 69893/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_
fre 2024-09-20 klockan 04:59 +0200 skrev Martin Schitter:
> ---
> libavformat/mxf.c | 1 +
> libavformat/mxfdec.c | 1 +
> 2 files changed, 2 insertions(+)
Looks fine, as previously discussed
/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.
On Mon, Jul 01, 2024 at 02:16:09PM +0200, Andreas Rheinhardt wrote:
> Effectively reverts c59b5e3d1e0121ea23b5b326529f5bdca44cf982.
> This is possible now that ff_print_debug_info2() uses
> the MPVPicture dimensions.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/vc1dec.c | 6 ++
>
Hi
On Mon, Jul 01, 2024 at 02:16:01PM +0200, Andreas Rheinhardt wrote:
> This is a more appropriate place than a function designed
> to reconstruct a macroblock. It furthermore limits these checks
> to the codecs that actually need it (and removes it from e.g.
> RV10 and RV20 -- the latter actuall
On Mon, Jul 01, 2024 at 02:16:06PM +0200, Andreas Rheinhardt wrote:
> The mpegvideo-based encoders do one uncommon thing with
> the packet's data given by ff_alloc_packet(): They potentially
> reallocate it. But this only affects the internal buffer
> and is not user-facing at all, so one can never
This permits:
- The use of Vulkan filtering on many more devices
- Better debugging due to lack of descriptor buffer support in layers
---
libavfilter/vf_gblur_vulkan.c | 2 +-
libavfilter/vf_nlmeans_vulkan.c | 21 +-
libavfilter/vulkan_filter.c | 120 +-
libavutil/hwcontext_vul
Just avoids a single temporary allocation.
---
libavutil/vulkan.c | 35 +++
libavutil/vulkan.h | 4 ++--
2 files changed, 21 insertions(+), 18 deletions(-)
diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c
index da71f241f0..e3fb70da46 100644
--- a/libavutil/vul
---
libavutil/hwcontext_vulkan.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c
index 23abd19eeb..6604dffd30 100644
--- a/libavutil/hwcontext_vulkan.c
+++ b/libavutil/hwcontext_vulkan.c
@@ -2695,7 +2695,8 @@ static
This allows disabling of certain extensions when debug mode is turned on.
---
libavutil/hwcontext_vulkan.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c
index 6604dffd30..5e56a215e8 100644
56 matches
Mail list logo
