[FFmpeg-devel] [PATCH v7 6/6] tests: Fate sample tests for DNxUncompressed

2024-09-15 Thread Martin Schitter
--- tests/Makefile | 1 + tests/fate/dnxuc.mak| 40 + tests/ref/fate/dnxuc-cb-rgb-10 | 8 ++ tests/ref/fate/dnxuc-cb-rgb-12 | 8 ++ tests/ref/fate/dnxuc-cb-rgb-8 | 8 ++ tests/ref/fate/dnxuc-cb-rgb-flo

[FFmpeg-devel] [PATCH v7 5/6] doc: DNxUncompressed Changelog and doc entries

2024-09-15 Thread Martin Schitter
--- Changelog | 1 + doc/general_contents.texi | 1 + 2 files changed, 2 insertions(+) diff --git a/Changelog b/Changelog index b6f91d7..1c54e20 100644 --- a/Changelog +++ b/Changelog @@ -19,6 +19,7 @@ version : - Cropping metadata parsing and writing in Matroska and MP4/MOV de/m

[FFmpeg-devel] [PATCH v7 4/6] libavcodec/dnxucdec: DNxUncompressed decoder

2024-09-15 Thread Martin Schitter
--- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/dnxucdec.c | 391 + 3 files changed, 393 insertions(+) create mode 100644 libavcodec/dnxucdec.c diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 55444cb..b2f00af 10

[FFmpeg-devel] [PATCH v7 3/6] libavcodec/dnxuc_parser: DNxUncompressed essence parser

2024-09-15 Thread Martin Schitter
--- libavcodec/Makefile | 1 + libavcodec/dnxuc_parser.c | 124 ++ libavcodec/parsers.c | 1 + 3 files changed, 126 insertions(+) create mode 100644 libavcodec/dnxuc_parser.c diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 1d27e55..

[FFmpeg-devel] [PATCH v7 2/6] libavformat/mxf: Add ULs for DNxUncompressed

2024-09-15 Thread Martin Schitter
--- libavformat/mxf.c| 1 + libavformat/mxfdec.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index a73e40e..b6c1f17 100644 --- a/libavformat/mxf.c +++ b/libavformat/mxf.c @@ -61,6 +61,7 @@ const MXFCodecUL ff_mxf_codec_uls[] = { { { 0x06,0x

[FFmpeg-devel] [PATCH v7 1/6] libavcodec/: Add ID and desc for DNxUncompressed

2024-09-15 Thread Martin Schitter
This is a corrected full patch set of my DNxUncompressed decoder implementation. Please review it again and merge it if acceptable. I already posted the sample files used in the fate tests in an earlier message. (https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2024-September/333471.html) thanks

Re: [FFmpeg-devel] [PATCH v6 2/5] libavformat/mxf: Add ULs for DNxUncompressed

2024-09-15 Thread martin schitter
On 15.09.24 20:26, Tomas Härdin wrote: tor 2024-09-12 klockan 07:52 +0200 skrev Martin Schitter: +    { { 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0D,0x04,0x01,0x02,0x02,0x03,0x07,0x01,0x00 }, 14,  AV_CODEC_ID_DNXUC }, /* DNxUncompressed/SMPTE RDD 50 */ +    { { 0x06,0x0e,0x2b,0x34,0x04,0x0

[FFmpeg-devel] [PATCH v3] avcodec/h264: ignore POC when flag is set

2024-09-15 Thread Kevin Wang
When the flag AV_CODEC_FLAG_OUTPUT_CORRUPT or AV_CODEC_FLAG2_SHOW_ALL is set, ignore any out of order POC's as they may still be valid frames. --- Reformat with more lines so the patch is better. libavcodec/h264_slice.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libav

[FFmpeg-devel] [PATCH v2] avcodec/h264: ignore POC when flag is set

2024-09-15 Thread Kevin Wang
When the flag AV_CODEC_FLAG_OUTPUT_CORRUPT or AV_CODEC_FLAG2_SHOW_ALL is set, ignore any out of order POC's as they may still be valid frames. --- Fixes the patch formatting. libavcodec/h264_slice.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_slice.c b/li

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/vvc: Fix output and unref a frame which isn't decoding yet

2024-09-15 Thread Nuo Mi
On Sun, Sep 15, 2024 at 4:54 PM Anton Khirnov wrote: > Quoting Nuo Mi (2024-09-15 10:49:31) > > On Sun, Sep 15, 2024 at 1:04 PM Zhao Zhili > wrote: > > > > > From: Zhao Zhili > > > > > > ff_vvc_output_frame is called before actually decoding. It's possible > > > for ff_vvc_output_frame to selec

Re: [FFmpeg-devel] [PATCH 21/23] tests/fate/hevc: add a test for nontrivial values of nuh_layer_id

2024-09-15 Thread James Almer
On 9/14/2024 7:45 AM, Anton Khirnov wrote: Typical files use 0 for the base layer and 1 for the secondary one, but any value for the secondary layer should be supported. --- tests/fate/hevc.mak | 4 tests/ref/fate/hevc-mv-nuh-layer-id | 15 +++ 2 files change

Re: [FFmpeg-devel] [PATCH 20/23] tests/fate/hevc: add MV-HEVC conformance sample tests

2024-09-15 Thread James Almer
On 9/14/2024 7:45 AM, Anton Khirnov wrote: Only those that can be decoded with our implementation, so excluding * C and D - independent layers * G, H, I - more than 2 layers Frame hashes verified against the reference implementation from https://hevc.hhi.fraunhofer.de/svn/svn_3DVCSoftware/ ---

Re: [FFmpeg-devel] [PATCH 19/23] fftools/ffmpeg: add support for multiview video

2024-09-15 Thread James Almer
On 9/14/2024 7:45 AM, Anton Khirnov wrote: This extends the syntax for specifying input streams in -map and complex filtergraph labels, to allow selecting a view by view ID, index, or position. The corresponding decoder is then set up to decode the appropriate view and send frames for that view t

Re: [FFmpeg-devel] [PATCH 03/23] lavu/frame: add side data storing view ID for multi-view video

2024-09-15 Thread Anton Khirnov
Quoting James Almer (2024-09-15 22:35:09) > What is the use case for AVFrame->metadata? As far as I'm concerned, it's a mistake that should never have existed. > What gets written there and what is expected by library users? Is it > documented at all? Because a single int like this feels like wou

Re: [FFmpeg-devel] [PATCH 01/23] compat: drop gcc, suncc, and pthreads stdatomic emulation

2024-09-15 Thread Anton Khirnov
Quoting James Almer (2024-09-15 22:31:47) > On 9/14/2024 7:45 AM, Anton Khirnov wrote: > > Since we now require a C11-compliant compiler, there should be no > > supported configurations where any of these is used. > > --- > > compat/atomics/gcc/stdatomic.h | 173 - > >

Re: [FFmpeg-devel] [PATCH 03/23] lavu/frame: add side data storing view ID for multi-view video

2024-09-15 Thread James Almer
On 9/14/2024 7:45 AM, Anton Khirnov wrote: --- doc/APIchanges| 3 +++ fftools/ffprobe.c | 2 ++ libavfilter/vf_showinfo.c | 2 ++ libavutil/frame.c | 1 + libavutil/frame.h | 9 + libavutil/version.h | 2 +- 6 files changed, 18 insertions(

[FFmpeg-devel] [PATCH] fftools/cmdutils: extend stream specifiers to match by disposition

2024-09-15 Thread Anton Khirnov
--- Changelog | 1 + doc/fftools-common-opts.texi | 4 +++ fftools/cmdutils.c | 41 ++ fftools/cmdutils.h | 2 ++ tests/fate/ffmpeg.mak | 4 +++ tests/ref/fate/ffmpeg-spec-di

Re: [FFmpeg-devel] [PATCH 01/23] compat: drop gcc, suncc, and pthreads stdatomic emulation

2024-09-15 Thread James Almer
On 9/14/2024 7:45 AM, Anton Khirnov wrote: Since we now require a C11-compliant compiler, there should be no supported configurations where any of these is used. --- compat/atomics/gcc/stdatomic.h | 173 - compat/atomics/pthread/stdatomic.c | 39 -- compat/ato

[FFmpeg-devel] [PATCH] scale_vt implementation for negative width/height sizing

2024-09-15 Thread Koushik Dutta
--- libavfilter/vf_scale_vt.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_scale_vt.c b/libavfilter/vf_scale_vt.c index 3da46a6cd5..3785b884d9 100644 --- a/libavfilter/vf_scale_vt.c +++ b/libavfilter/vf_scale_vt.c @@ -33,8 +33,6 @@ typedef struct

Re: [FFmpeg-devel] [PATCH v2 02/23] compat: add a fallback implementation of C23 stdbit.h

2024-09-15 Thread James Almer
On 9/14/2024 11:56 AM, Anton Khirnov wrote: From: Rémi Denis-Courmont Header contents taken from VLC commit 7a970a33329c9836d169727ddbaf49a33240d587. Signed-off-by: Anton Khirnov --- compat/stdbit/stdbit.h | 596 + configure | 4 + te

Re: [FFmpeg-devel] [PATCH 5/7] avformat/mxfdec: More offset_temp checks

2024-09-15 Thread Tomas Härdin
fre 2024-09-13 klockan 01:33 +0200 skrev Michael Niedermayer: > Fixes: signed integer overflow: 9223372036854775807 - - > 1927491430256034080 cannot be represented in type 'long' > Fixes: 70607/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer- > 5282235077951488 > > Found-by: continuous fuzzin

Re: [FFmpeg-devel] [WIP PATCH 0/1] avcodec/aacenc: improve bit_rate_tolerance=0

2024-09-15 Thread Lynne via ffmpeg-devel
On 15/09/2024 17:14, Pauli Virtanen wrote: la, 2024-09-14 kello 00:15 +0300, Pauli Virtanen kirjoitti: [clip] - it appears the resulting frame_bits depends also on some other state than s->lambda. iteration with lambda1, lambda2>lambda1, and then again with lambda1 can produce different f

Re: [FFmpeg-devel] [PATCH] avcodec/h264: ignore POC when flag is set

2024-09-15 Thread Michael Niedermayer
On Thu, Sep 12, 2024 at 10:40:17PM -0700, kevmo...@gmail.com wrote: > From: Kevin Wang > > When the flag AV_CODEC_FLAG_OUTPUT_CORRUPT or AV_CODEC_FLAG2_SHOW_ALL > is set, ignore any out of order POC's as they may still be valid > frames. > > Fixes https://trac.ffmpeg.org/ticket/11190. > > Signe

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself as vf_xfade_vulkan maintainer

2024-09-15 Thread Michael Niedermayer
On Wed, Sep 11, 2024 at 09:32:12PM +0200, Marvin Scholz wrote: > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable co

Re: [FFmpeg-devel] [PATCH 1/7] avformat/mov_chan: Check for FF_SANE_NB_CHANNELS

2024-09-15 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-09-13 19:48:46) > On Fri, Sep 13, 2024 at 12:08:45PM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-09-13 01:33:31) > > > We do not support more channels. For example avcodec_open2() limits > > > channels this way too > > > > > > The example fi

Re: [FFmpeg-devel] [PATCH 5/7] avformat/mxfdec: More offset_temp checks

2024-09-15 Thread Tomas Härdin
fre 2024-09-13 klockan 01:33 +0200 skrev Michael Niedermayer: > Fixes: signed integer overflow: 9223372036854775807 - - > 1927491430256034080 cannot be represented in type 'long' > Fixes: 70607/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer- > 5282235077951488 > > Found-by: continuous fuzzin

Re: [FFmpeg-devel] [PATCH] lavc/vvc_mc: R-V V avg w_avg

2024-09-15 Thread flow gg
> LGTM for the RISC-V side. No clue about the VVC side. Hi, Nuomi, could you please reply here? Thanks flow gg 于2024年9月13日周五 00:45写道: > ping > > flow gg 于2024年8月28日周三 14:38写道: > >> Updated: zve32x -> zve32x, zbb, zba >> >> 于2024年8月28日周三 14:37写道: >> >>> From: sunyuechi >>> >>>

Re: [FFmpeg-devel] [PATCH 4/7] avformat/mxfdec: Check timecode for overflow

2024-09-15 Thread Tomas Härdin
fre 2024-09-13 klockan 01:33 +0200 skrev Michael Niedermayer: > Fixes: signed integer overflow: 9223372036840103968 + 538976288 > cannot be represented in type 'long' > Fixes: 70604/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer- > 4844090340999168 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v6 2/5] libavformat/mxf: Add ULs for DNxUncompressed

2024-09-15 Thread Tomas Härdin
tor 2024-09-12 klockan 07:52 +0200 skrev Martin Schitter: > +    { { > 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0D,0x04,0x01,0x02,0x02,0x03,0x07,0x01,0x00 > }, 14,  AV_CODEC_ID_DNXUC }, /* DNxUncompressed/SMPTE RDD 50 */ > +    { { > 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x02,0x0d,0x01,0x03,0x01,0x

Re: [FFmpeg-devel] [WIP PATCH 0/1] avcodec/aacenc: improve bit_rate_tolerance=0

2024-09-15 Thread Pauli Virtanen
la, 2024-09-14 kello 00:15 +0300, Pauli Virtanen kirjoitti: [clip] > - it appears the resulting frame_bits depends also on some other state > than s->lambda. iteration with lambda1, lambda2>lambda1, and then again > with lambda1 can produce different frame_bits on the two lambda1 > iteration

Re: [FFmpeg-devel] [PATCH v3 2/2] fate/vvc: Add a sample which lose frames before b02b411

2024-09-15 Thread James Almer
On 9/15/2024 1:54 AM, Zhao Zhili wrote: From: Zhao Zhili --- sample: 8054b4b8e62c0171476b40206d044590 Hierarchical.bit https://drive.google.com/file/d/1U5WGWeSsMFiEkhsl_vL4NiMma-LLh02t/view?usp=sharing tests/fate/vvc.mak | 1 + tests/ref/fate/vvc-conformance-Hiera

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

2024-09-15 Thread Anton Khirnov
Quoting Antoni Bizoń (2024-09-13 15:20:16) > Hello, > I recently upgraded FFmpeg to version 6.1 in my web application and > encountered a change while running my app's tests. After the upgrade, > ffprobe reported an r_frame_rate of 60/1 instead of the expected 30/1 > for two videos in my test suite

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: implement seeking

2024-09-15 Thread Anton Khirnov
Quoting Marth64 (2024-09-13 07:37:44) > Player applications can now enjoy seeking while playing back > a title. Accuracy is at the mercy of what libdvdnav exposes, > which is currently dvdnav_time_search(). > > Signed-off-by: Marth64 > --- > libavformat/dvdvideodec.c | 77 +++

Re: [FFmpeg-devel] [PATCH v2] lavf/tls_mbedtls: restrict TLSv1.3 verification workaround to affected version

2024-09-15 Thread Anton Khirnov
Quoting sfan5 (2024-09-10 17:47:41) > From 2db025b18be995afea46dea6c15a3caf1d985a82 Mon Sep 17 00:00:00 2001 > From: sfan5 > Date: Wed, 4 Sep 2024 17:56:05 +0200 > Subject: [PATCH v2] lavf/tls_mbedtls: restrict TLSv1.3 verification workaround > to affected version > > Now that mbedTLS 3.6.1 is r

Re: [FFmpeg-devel] [PATCH 1/2] lavc: add Vulkan video encoding base code

2024-09-15 Thread Lynne via ffmpeg-devel
On 09/09/2024 12:37, Lynne wrote: This commit adds the common Vulkan video encoding framework. It makes full use of the asynchronous features of our new common hardware encoding code, and of Vulkan. The code is able to handle anything from H264 to AV1 and MJPEG. --- configure |

Re: [FFmpeg-devel] [PATCH 1/2] lavc: add Vulkan video encoding base code

2024-09-15 Thread Lynne via ffmpeg-devel
On 12/09/2024 15:20, Benjamin Cheng wrote: On Wed Sep 11, 2024 at 12:03 AM EDT, Lynne wrote: On 10/09/2024 15:29, Benjamin Cheng wrote: On Mon Sep 9, 2024 at 6:37 AM EDT, Lynne via ffmpeg-devel wrote: This commit adds the common Vulkan video encoding framework. It makes full use of the asynchr

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/vvc: Fix output and unref a frame which isn't decoding yet

2024-09-15 Thread Anton Khirnov
Quoting Nuo Mi (2024-09-15 10:49:31) > On Sun, Sep 15, 2024 at 1:04 PM Zhao Zhili wrote: > > > From: Zhao Zhili > > > > ff_vvc_output_frame is called before actually decoding. It's possible > > for ff_vvc_output_frame to select current frame to output. If current > > frame is nonref frame, it wi

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/vvc: Fix output and unref a frame which isn't decoding yet

2024-09-15 Thread Nuo Mi
On Sun, Sep 15, 2024 at 1:04 PM Zhao Zhili wrote: > From: Zhao Zhili > > ff_vvc_output_frame is called before actually decoding. It's possible > for ff_vvc_output_frame to select current frame to output. If current > frame is nonref frame, it will be released by ff_vvc_unref_frame. > > Fix this