[FFmpeg-devel] [PATCH] avcodec/amfenc: Avoid polling with fixed sleep

2024-09-03 Thread Cameron Gutman
Using QUERY_TIMEOUT rather than a polling loop with a fixed sleep results in both better performance and lower power consumption by sleeping until the frame is ready. The length of the fixed sleep is constrained to a granularity of at least the process's timer resolution (typically ~15 ms) which ac

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Remove experimental flag

2024-09-03 Thread Nuo Mi
On Sun, Aug 25, 2024 at 12:43 PM Nuo Mi wrote: > > > On Sat, Aug 24, 2024 at 5:40 AM James Almer wrote: > >> On 8/23/2024 10:17 AM, Anton Khirnov wrote: >> > tsan reports races in the decoder, it would be nice if someone could >> > look at them before this goes in. >> >> Not data races, but "loc

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhdenc: use BlockDSPContext from MpegEncContext

2024-09-03 Thread Ramiro Polla
On Wed, Aug 28, 2024 at 2:11 PM Ramiro Polla wrote: > On Thu, Aug 22, 2024 at 1:24 AM Ramiro Polla wrote: > > MpegEncContext already has a BlockDSPContext, so we don't need another > > one for DNXHDEncContext (which has an MpegEncContext). > > --- > > libavcodec/dnxhdenc.c | 10 +- > > l

Re: [FFmpeg-devel] [PATCH 1/3] swscale/x86/rgb2rgb: fix deinterleaveBytes for unaligned dst pointers

2024-09-03 Thread Ramiro Polla
On Sun, Sep 1, 2024 at 3:09 PM Ramiro Polla wrote: > > --- > libswscale/x86/input.asm | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/libswscale/x86/input.asm b/libswscale/x86/input.asm > index 21cd8b37fd..516e4384b1 100644 > --- a/libswscale/x86/input.asm

Re: [FFmpeg-devel] [PATCH 2/4] swscale/rgb2rgb: improve chroma conversion in ff_rgb24toyv12_c

2024-09-03 Thread Ramiro Polla
On Wed, Aug 28, 2024 at 10:43 PM Ramiro Polla wrote: > > The current code subsamples by dropping 3/4 pixels to calculate the > chroma components. This commit calculates the average of 4 rgb pixels > before calculating the chroma components, putting it in line with the > mmxext implementation. > --

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: remove redundant workaround to recalculate last nonzero coefficient

2024-09-03 Thread Ramiro Polla
On Thu, Aug 29, 2024 at 9:13 PM Michael Niedermayer wrote: > On Wed, Aug 28, 2024 at 02:14:33PM +0200, Ramiro Polla wrote: > > On Thu, Aug 22, 2024 at 1:24 AM Ramiro Polla wrote: > > > The x86 optimized dct_quantize only calculates the last nonzero > > > coefficient correctly if the zigzag scan o

Re: [FFmpeg-devel] [PATCH] avcodec/x86/mpegvideoenc: remove av_assert2() for variable alignment

2024-09-03 Thread Ramiro Polla
On Wed, Aug 28, 2024 at 2:12 PM Ramiro Polla wrote: > On Thu, Aug 22, 2024 at 3:05 AM Ramiro Polla wrote: > > It's safe to assume that LOCAL_ALIGNED_16 does indeed align. Otherwise > > we would have many more problems... > > > > This assert was added in f8188626 all the way back in 2003. > > ---

Re: [FFmpeg-devel] [PATCH 38/42] fftools/ffmpeg: add support for multiview video

2024-09-03 Thread James Almer
On 9/3/2024 9:44 AM, Anton Khirnov wrote: Quoting James Almer (2024-09-03 14:26:21) On 9/3/2024 6:47 AM, Anton Khirnov wrote: Quoting James Almer (2024-08-31 15:56:24) On 8/31/2024 4:44 AM, Anton Khirnov wrote: Quoting James Almer (2024-08-30 02:40:49) On 8/29/2024 8:26 PM, Michael Niedermay

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Remove assertions on qPy_{a, b}

2024-09-03 Thread Nuo Mi
On Sat, Aug 31, 2024 at 3:02 PM Nuo Mi wrote: > > > On Thu, Aug 29, 2024 at 12:39 AM Frank Plowman > wrote: > >> On 28/08/2024 16:13, Anton Khirnov wrote: >> > Quoting Frank Plowman (2024-08-25 13:50:41) >> >> These assertions are not violated, even by illegal bitstreams. >> > >> > I don't follo

Re: [FFmpeg-devel] [PATCH 28/42] lavc/hevc/ps: implement SPS parsing for nuh_layer_id>0

2024-09-03 Thread James Almer
On 9/3/2024 6:39 AM, Anton Khirnov wrote: Quoting James Almer (2024-08-30 04:52:39) On 8/27/2024 12:05 PM, Anton Khirnov wrote: @@ -1167,16 +1167,26 @@ int ff_hevc_parse_sps(HEVCSPS *sps, GetBitContext *gb, unsigned int *sps_id, } sps->max_sub_layers = get_bits(gb, 3) + 1; +

Re: [FFmpeg-devel] [PATCH 38/42] fftools/ffmpeg: add support for multiview video

2024-09-03 Thread Anton Khirnov
Quoting James Almer (2024-09-03 14:26:21) > On 9/3/2024 6:47 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-08-31 15:56:24) > >> On 8/31/2024 4:44 AM, Anton Khirnov wrote: > >>> Quoting James Almer (2024-08-30 02:40:49) > On 8/29/2024 8:26 PM, Michael Niedermayer wrote: > > On Tue,

Re: [FFmpeg-devel] [PATCH 38/42] fftools/ffmpeg: add support for multiview video

2024-09-03 Thread James Almer
On 9/3/2024 6:47 AM, Anton Khirnov wrote: Quoting James Almer (2024-08-31 15:56:24) On 8/31/2024 4:44 AM, Anton Khirnov wrote: Quoting James Almer (2024-08-30 02:40:49) On 8/29/2024 8:26 PM, Michael Niedermayer wrote: On Tue, Aug 27, 2024 at 05:05:18PM +0200, Anton Khirnov wrote: This extend

Re: [FFmpeg-devel] [RFC/PATCH] MV-HEVC decoding

2024-09-03 Thread Anton Khirnov
If nobody objects or wants more time for review, I'd like to push patches up to 24 (excluding 04 and 05) in a few days. That includes mainly * av_opt_set_array(), which we want anyway, whatever happens to the rest of the set; * adding HEVC multiview, which is trivial and independent of actual d

Re: [FFmpeg-devel] [PATCH 38/42] fftools/ffmpeg: add support for multiview video

2024-09-03 Thread Anton Khirnov
Quoting James Almer (2024-08-31 15:56:24) > On 8/31/2024 4:44 AM, Anton Khirnov wrote: > > Quoting James Almer (2024-08-30 02:40:49) > >> On 8/29/2024 8:26 PM, Michael Niedermayer wrote: > >>> On Tue, Aug 27, 2024 at 05:05:18PM +0200, Anton Khirnov wrote: > This extends the syntax for specifyi

Re: [FFmpeg-devel] [PATCH 28/42] lavc/hevc/ps: implement SPS parsing for nuh_layer_id>0

2024-09-03 Thread Anton Khirnov
Quoting James Almer (2024-08-30 04:52:39) > On 8/27/2024 12:05 PM, Anton Khirnov wrote: > > @@ -1167,16 +1167,26 @@ int ff_hevc_parse_sps(HEVCSPS *sps, GetBitContext > > *gb, unsigned int *sps_id, > > } > > > > sps->max_sub_layers = get_bits(gb, 3) + 1; > > +multi_layer_ext = nu

[FFmpeg-devel] [PATCH v2 25/42] avcodec/hevc/sei: add support for 3D Reference Displays Information SEI

2024-09-03 Thread Anton Khirnov
From: James Almer Signed-off-by: James Almer Signed-off-by: Anton Khirnov --- libavcodec/hevc/sei.c | 55 +++ libavcodec/hevc/sei.h | 17 + 2 files changed, 72 insertions(+) diff --git a/libavcodec/hevc/sei.c b/libavcodec/hevc/sei.c index e3

[FFmpeg-devel] [PATCH v3 3/3] fftools/ffmpeg: Fix honor -r output option with streamcopy

2024-09-03 Thread Nicolas Gaullier
Fix "ost->st->avg_frame_rate = ost->frame_rate" in streamcopy_init() being reset to input's frame rate a few lines below. Note that in current code, there are some discrepancies amongst the muxers. For example, avienc relies on time_base, so it is not affected by this patch, whereas mxfenc and matr

[FFmpeg-devel] [PATCH v3 2/3] tests: Remove void -time_base overrides when streamcopying to mxf

2024-09-03 Thread Nicolas Gaullier
Signed-off-by: Nicolas Gaullier --- tests/fate/ffmpeg.mak | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak index 9e0c68da20..3ffaaeb295 100644 --- a/tests/fate/ffmpeg.mak +++ b/tests/fate/ffmpeg.mak @@ -146,7 +146,7 @@ fate-copy

[FFmpeg-devel] [PATCH v3 1/3] avformat/mxfenc: Fix guess frame_rate

2024-09-03 Thread Nicolas Gaullier
The time_base was a bad guess. Currently, fate-time_base test data assumed that overriding the input time_base would affect the frame_rate, but this behaviour is not documented, so just fix the fate data now that this is fixed. Fix regression since 10185e2d4c1e9839bc58a1d6a63c861677b13fd0: previo

[FFmpeg-devel] [PATCH v3 0/3] framerate / streamcopy

2024-09-03 Thread Nicolas Gaullier
This is the whole serie properly posted with the latest addition, the third patch related to ffmpeg. This last patch is independent but somewhat related, so maybe it is a good thing to review it to possibly apply the complete serie as a whole. (the first two patches seem ready to apply) Nicolas Ga