[FFmpeg-devel] [PATCH 2/2] vulkan(_decode): fix, simplify and improve queries

The old query code never worked properly, and did some hideous heuristics to read the status bit, and work that into a return code. This is all best left to callers to do, which simplifies our code a lot. This also fixes minor validation errors regarding calling queries which are not in their acti

[FFmpeg-devel] [PATCH 1/2] hwcontext_vulkan: disable more false positive validation checks

Both of these are fundamentally incompatible with video decoding. --- libavutil/hwcontext_vulkan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index 763fb9d120..b214791738 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavuti

Re: [FFmpeg-devel] [PATCH] avfilter/formats: correct error message

On 2024-08-31 04:29 pm, Gyan Doshi wrote: On 2024-08-28 03:52 pm, Gyan Doshi wrote: The check is for color space, not range. Will push tomorrow. Pushed as b5daaa1503fd149a8e6c4964266ceb93fd7d09cd Regards, Gyan ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] [PATCH 2/2] vulkan_decode: use ff_vk_init

On Sun, 1 Sept 2024 at 04:42, Lynne via ffmpeg-devel wrote: > > This solves the issue of an av_log function being called > with a context with invalid class. > > Most of the patch was written by Anton Khirnov. Does ffmpeg have conventions for such situations? I think most of the time `Co-Authored

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvcdec: filter, fix uninitialized variables for YUV400 format

On Sat, Aug 31, 2024 at 2:36 PM Nuo Mi wrote: > > > On Fri, Aug 23, 2024 at 11:04 PM Nuo Mi wrote: > >> fix >> ==135000== Conditional jump or move depends on uninitialised value(s) >> ==135000==at 0x169FF95: vvc_deblock_bs (filter.c:699) >> and >> ==135000== Conditional jump or move depends

[FFmpeg-devel] [PATCH v2 1/2] vulkan: add a ff_vk_init function

This function sets the class correctly, and calls functions that all users have to call anyway. --- v1 had stray changes. libavutil/vulkan.c | 57 +- libavutil/vulkan.h | 12 +- 2 files changed, 67 insertions(+), 2 deletions(-) diff --git a/lib

[FFmpeg-devel] [PATCH 2/2] vulkan_decode: use ff_vk_init

This solves the issue of an av_log function being called with a context with invalid class. Most of the patch was written by Anton Khirnov. --- libavcodec/vulkan_decode.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/libavcodec/vulkan_decode.c b/libavcodec/vul

[FFmpeg-devel] [PATCH 1/2] vulkan: add a ff_vk_init function

This function sets the class correctly, and calls functions that all users have to call anyway. --- libavutil/vulkan.c | 62 +++--- libavutil/vulkan.h | 12 - 2 files changed, 69 insertions(+), 5 deletions(-) diff --git a/libavutil/vulkan.c b/libavu

[FFmpeg-devel] [PATCH] hwcontext_vulkan: ask for storage images by default

The issue is that we ask for storage images by default if available, but because that is gated by the format supporting storage images, and the check for the format supporting storage images is gated by the usage, this resulted in a catch-22. --- libavutil/hwcontext_vulkan.c | 3 ++- 1 file change

[FFmpeg-devel] [PATCH 10/10] vulkan_filter: require storage images properly, set usage flags explicitly

This caused images to be created without a storage usage, which broke at least lavapipe. --- libavfilter/vulkan_filter.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavfilter/vulkan_filter.c b/libavfilter/vulkan_filter.c index 64e9b8768a..c31d42b91a 100644 ---

[FFmpeg-devel] [PATCH 09/10] hwcontext_vulkan: add PREP_MODE_GENERAL for non-transfer_dst images

Vulkan filters don't need images which can be transferred into. --- libavutil/hwcontext_vulkan.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index e4f155db6e..383e75397e 100644 --- a/libavutil/hwcontext_vul

[FFmpeg-devel] [PATCH 08/10] vulkan_video: move imageview creation and DPB fields to common context

Shared between decoders and encoders. --- libavcodec/vulkan_av1.c| 3 +- libavcodec/vulkan_decode.c | 137 + libavcodec/vulkan_decode.h | 9 --- libavcodec/vulkan_h264.c | 3 +- libavcodec/vulkan_hevc.c | 3 +- libavcodec/vulkan_video.c | 80 ++

[FFmpeg-devel] [PATCH 07/10] vulkan: error out if query is called without being initialized

--- libavutil/vulkan.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c index fe5affa72a..c2a3b5cfa3 100644 --- a/libavutil/vulkan.c +++ b/libavutil/vulkan.c @@ -446,6 +446,11 @@ VkResult ff_vk_exec_get_query(FFVulkanContext *s, FFVkExecContext *e,

[FFmpeg-devel] [PATCH 06/10] vulkan: use correct return codes for query errors

--- libavutil/vulkan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c index bb8e7ae786..fe5affa72a 100644 --- a/libavutil/vulkan.c +++ b/libavutil/vulkan.c @@ -444,7 +444,7 @@ VkResult ff_vk_exec_get_query(FFVulkanContext *s, FFVkExecCo

[FFmpeg-devel] [PATCH 05/10] vulkan_video: add utilities for H264 level/profile mapping

--- libavcodec/vulkan_video.c | 49 +++ libavcodec/vulkan_video.h | 8 +++ 2 files changed, 57 insertions(+) diff --git a/libavcodec/vulkan_video.c b/libavcodec/vulkan_video.c index b9a0ed5022..a676f0332a 100644 --- a/libavcodec/vulkan_video.c +++ b/libavc

[FFmpeg-devel] [PATCH 04/10] hw_base_encode: make recon_frames_ref optional

Vulkan supports some stupidly odd hardware, that unfortunately, most modern GPUs happen to be. The DPB images for encoders may be required to be preallocated all at once, and rather than be individual frames, be layers of a single frame. As the hw_base_encode code is written with the thought that

[FFmpeg-devel] [PATCH 03/10] hw_base_encode: allocate DPB image upfront

Vulkan requires this, as it needs to initialize state upfront. --- libavcodec/d3d12va_encode.c | 6 -- libavcodec/hw_base_encode.c | 6 ++ libavcodec/vaapi_encode.c | 5 - 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/libavcodec/d3d12va_encode.c b/libavcodec/d3d12va

[FFmpeg-devel] [PATCH 02/10] hw_base_encode: move VAAPI SPS/PPS constructors to a shared file

--- libavcodec/Makefile | 2 +- libavcodec/hw_base_encode_h264.c | 265 +++ libavcodec/hw_base_encode_h264.h | 53 +++ libavcodec/vaapi_encode_h264.c | 262 +++--- 4 files changed, 341 insertions(+), 241 deletions(-) create

Re: [FFmpeg-devel] [PATCH 1/5] MAINTAINERS: Mark parts from Robert as unmaintained

On Sat, Aug 31, 2024 at 11:44:45PM +0200, Michael Niedermayer wrote: What my summary mail said, that git decided to not send :) was, that this is a bit trial and error on how to best update MAINTAINERs also people are welcome to update their entries in MANITAINERs as well as add entries for unmai

[FFmpeg-devel] [PATCH 5/5] MAINTAINERS: Add status to icecast

Last icecast threads have Marvin in them so it seems maintained CC: Marvin Scholz Signed-off-by: Michael Niedermayer --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index f540595ee24..14aebe147f8 100644 --- a/MAINTAINERS +++ b/MAINTA

[FFmpeg-devel] [PATCH 4/5] MAINTAINERS: Rangecoder looks quite familiar, ill maintain it

Signed-off-by: Michael Niedermayer --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 809baa855df..f540595ee24 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -122,7 +122,7 @@ Generic Parts: DSP utilities: dsputils.c, dsputils

[FFmpeg-devel] [PATCH 3/5] MAINTAINERS: Mark parts from Ludmila as unmaintained

Last i see from Ludmila is from 2015 CC: Ludmila Glinskih Signed-off-by: Michael Niedermayer --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 98d64dd7db6..809baa855df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -55,7 +55,7 @@

[FFmpeg-devel] [PATCH 2/5] MAINTAINERS: Update fate admin

Timothy has not reacted to any fate admin related mails i can remember last was handled by timo, prior where probably handled by me CC: Timothy Gu CC: Timo Rothenpieler Signed-off-by: Michael Niedermayer --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTA

[FFmpeg-devel] [PATCH 1/5] MAINTAINERS: Mark parts from Robert as unmaintained

Last mail and commit from Robert seems from 2011, thats 13 years ago CC: Rob Signed-off-by: Michael Niedermayer --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 578a273a2df..7c055fa24c7 100644 --- a/MAINTAINERS +++ b/MAINTAI

[FFmpeg-devel] [RFC] [PATCH] avcodec/cbs_h266: Fix copy paste mistake

The us macro expect the range_max here, which seems should be MAX_UINT_BITS(hlen) here. Fix CID1618757 Copy-paste error --- This code is non-trivial to understand so I might be wrong about this, it would be great if someone actually familiar with this can have a look if my assesment is correct he

Re: [FFmpeg-devel] [PATCH] avformat/iamf_parse: Fix return of uninitialized value

On 8/31/2024 5:45 PM, Marvin Scholz wrote: The ret value here is not yet intialized so the return would return uninitialized data. What was probably meant to be checked here was the return value of ffio_read_size, which can return an error. Introduced in 38bcb3ba7b3424abd772c72f8bdf445d75285e88

Re: [FFmpeg-devel] [PATCH 01/10] MAINTAINERS: Add L field based on the linux kernel MAINTAINERs

On Wed, Aug 28, 2024 at 07:12:38PM +0200, Michael Niedermayer wrote: > Text was stolen from the linux kernel > This is thus identical to the kernel just a different more compact format. > I am very happy also to switch the file entirely to the format of the linux > kernel maintainer list > if peop

Re: [FFmpeg-devel] [PATCH 08/10] MAINTAINERS: Add S field based on the linux kernel MAINTAINERs

On Thu, Aug 29, 2024 at 07:59:27AM -0400, Ronald S. Bultje wrote: > Hi, > > On Wed, Aug 28, 2024 at 1:25 PM Michael Niedermayer > wrote: > > > +(T ) *SCM* tree type and location. > > + Type is one of: git, hg, quilt, stgit, topgit > > > > S (see subject) or T (see text)? One of the

Re: [FFmpeg-devel] [PATCH 03/10] MAINTAINERS: Add W field based on the linux kernel MAINTAINERs

On Wed, Aug 28, 2024 at 10:30:37AM -0700, James Zern via ffmpeg-devel wrote: > On Wed, Aug 28, 2024 at 10:13 AM Michael Niedermayer > wrote: > > > > Text was stolen from the linux kernel > > This is thus identical to the kernel just a different more compact format. > > I am very happy also to swit

[FFmpeg-devel] [PATCH] avformat/iamf_parse: Fix return of uninitialized value

The ret value here is not yet intialized so the return would return uninitialized data. What was probably meant to be checked here was the return value of ffio_read_size, which can return an error. Introduced in 38bcb3ba7b3424abd772c72f8bdf445d75285e88 Fixes: CID1618758 --- libavformat/iamf_pars

Re: [FFmpeg-devel] [PATCH] swscale/aarch64/rgb2rgb: add deinterleaveBytes neon implementation

On Fri, Aug 30, 2024 at 08:56:55PM +0200, Ramiro Polla wrote: > A55 A76 > deinterleave_bytes_c: 70342.0 34497.5 > deinterleave_bytes_neon: 21594.5 ( 3.26x) 5535.2 ( 6.23x) > deinterleave_bytes_aligned_c: 71340.

Re: [FFmpeg-devel] [PATCH v3 03/17] avcodec/encode: switch to avcodec_get_supported_config()

On Fri, Aug 30, 2024 at 12:15:26PM +0200, Niklas Haas wrote: > From: Niklas Haas > > --- > libavcodec/encode.c | 90 - > 1 file changed, 57 insertions(+), 33 deletions(-) breaks: make V=2 fate-png-icc Stream #0:0: Video: png, rgb24(pc, gbr/bt709/un

Re: [FFmpeg-devel] [PATCH v4] avfilter: add pu21 filter

Hi, Thanks for your patch. On 23/08/2024 20:15, Rajiv Harlalka wrote: > Adds the PU21 encoding filter for high dynamic range images and video > quality assessment > Mantiuk, R., & Azimi, M. PU21: A novel perceptually uniform encoding > for adapting existing quality metrics for HDR > https://githu

Re: [FFmpeg-devel] [PATCH] avformat/libzmq: fix check for zmq protocol prefix

On Mon, 26 Aug 2024, Marton Balint wrote: Fixes ticket #11134. Will apply and backport. Regards, Marton Signed-off-by: Marton Balint --- libavformat/libzmq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/libzmq.c b/libavformat/libzmq.c index f4bb849e46.

[FFmpeg-devel] [PATCH 13/13] fftools/ffmpeg_demux: merge streams in a LCEVC stream group

Add the LCEVC data stream payloads as packet side data to the main video stream, ensuring the former is always output by the demuxer even if not used by the process. Signed-off-by: James Almer --- configure | 2 +- fftools/ffmpeg.h | 17 +++ fftools/ffmpeg_demux.c | 307 +++

[FFmpeg-devel] [PATCH 12/13] avcodec: add an LCEVC merger bsf

Signed-off-by: James Almer --- libavcodec/bitstream_filters.c | 1 + libavcodec/bsf/Makefile | 3 +- libavcodec/bsf/lcevc_merge_bsf.c | 265 +++ 3 files changed, 268 insertions(+), 1 deletion(-) create mode 100644 libavcodec/bsf/lcevc_merge_bsf.c diff

[FFmpeg-devel] [PATCH 11/13] avcodec/packet: add a LCEVC packet side data type

Signed-off-by: James Almer --- libavcodec/decode.c | 1 + libavcodec/packet.c | 1 + libavcodec/packet.h | 5 + 3 files changed, 7 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 033c4913c0..7303a08dc1 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -

[FFmpeg-devel] [PATCH 08/13] avcodec/codec_id: add an LCEVC codec id for raw LCEVC data

Signed-off-by: James Almer --- libavcodec/codec_desc.c | 6 ++ libavcodec/codec_id.h | 1 + 2 files changed, 7 insertions(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index a28ef68061..03dea5751a 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -36

[FFmpeg-devel] [PATCH 10/13] avformat/mov: support for LCEVC tracks

Co-authored-by: V-Nova Team Signed-off-by: James Almer --- libavformat/isom.h | 3 ++ libavformat/isom_tags.c | 2 + libavformat/mov.c | 86 + 3 files changed, 91 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index 15e946

[FFmpeg-devel] [PATCH 07/13] avcodec/hevcdec: export LCEVC metadata as frame side data

Signed-off-by: James Almer --- configure | 1 + libavcodec/hevc/hevcdec.c | 3 +++ libavcodec/hevc/refs.c| 15 ++- 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 84f63bbb87..3b7cf05bb5 100755 --- a/configure +++ b/confi

[FFmpeg-devel] [PATCH 09/13] avformat: add an LCEVC stream group

Signed-off-by: James Almer --- libavformat/avformat.c | 5 + libavformat/avformat.h | 15 +++ libavformat/dump.c | 27 +++ libavformat/options.c | 29 - 4 files changed, 75 insertions(+), 1 deletion(-) diff --git a/libavfo

[FFmpeg-devel] [PATCH 06/13] avcodec/h264dec: export LCEVC metadata as frame side data

Signed-off-by: James Almer --- configure | 2 +- libavcodec/h264_slice.c | 8 libavcodec/h264dec.c| 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 261ab6252e..84f63bbb87 100755 --- a/configure +++ b/configure @@ -2970,7

[FFmpeg-devel] [PATCH 05/13 v3] avcodec/h2645_sei: export raw LCEVC metadata

Signed-off-by: James Almer --- libavcodec/h2645_sei.c | 34 ++ libavcodec/h2645_sei.h | 5 + libavcodec/itut35.h| 2 ++ 3 files changed, 41 insertions(+) diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c index 7c83747cd0..c46a563308 100644 ---

[FFmpeg-devel] [PATCH 04/13] avcodec/decode: split ProgressFrame allocator into two functions

Signed-off-by: James Almer --- libavcodec/decode.c| 11 +++ libavcodec/progressframe.h | 16 ++-- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index dc868714ac..033c4913c0 100644 --- a/libavcodec/decode.c +++

[FFmpeg-devel] [PATCH 03/13] avcodec/decode: support applying LCEVC enhacements

Signed-off-by: James Almer --- libavcodec/avcodec.c | 2 ++ libavcodec/avcodec.h | 5 + libavcodec/decode.c| 42 +- libavcodec/internal.h | 2 ++ libavcodec/lcevcdec.c | 2 ++ libavcodec/options_table.h | 1 + libavcodec/p

[FFmpeg-devel] [PATCH 02/13 v3] avcodec: add LCEVC decoding support via LCEVCdec

Signed-off-by: James Almer --- configure | 3 + doc/general_contents.texi | 13 ++ libavcodec/Makefile | 1 + libavcodec/lcevcdec.c | 289 ++ libavcodec/lcevcdec.h | 45 ++ 5 files changed, 351 insertions(+) create mode

[FFmpeg-devel] [PATCH 01/13 v3] avutil/frame: add an LCEVC enhancement data payload side data type

Signed-off-by: James Almer --- libavutil/frame.c | 1 + libavutil/frame.h | 5 + 2 files changed, 6 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 5cbfc6a48b..2758f90e27 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -46,6 +46,7 @@ static const AVSideDataDe

Re: [FFmpeg-devel] [PATCH v4 0/1] lavfi/vf_gopromax_opencl: add GoPor Max 360 video filter

ping again On 2024/08/15 17:10, TADANO Tokumei wrote: ping On 2024/08/03 9:56, TADANO Tokumei wrote: This is updated patch of: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3943 I contacted to Ronan LE MEILLAT and agreed with him to submit new patch. Abstruct of GoPro Max .360 vide

Re: [FFmpeg-devel] [PATCH 38/42] fftools/ffmpeg: add support for multiview video

On 8/31/2024 4:44 AM, Anton Khirnov wrote: Quoting James Almer (2024-08-30 02:40:49) On 8/29/2024 8:26 PM, Michael Niedermayer wrote: On Tue, Aug 27, 2024 at 05:05:18PM +0200, Anton Khirnov wrote: This extends the syntax for specifying input streams in -map and complex filtergraph labels, to a

Re: [FFmpeg-devel] [PATCH] avfilter/formats: correct error message

On 2024-08-28 03:52 pm, Gyan Doshi wrote: The check is for color space, not range. Will push tomorrow. Regards, Gyan --- libavfilter/formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index eabc3ec946..2b570b466e

Re: [FFmpeg-devel] [PATCH 2/2] aarch64/vvc: Bind h26x/sao filter implementation to vvc

On Thu, Aug 29, 2024 at 7:35 PM Martin Storsjö wrote: > On Wed, 28 Aug 2024, Zhao Zhili wrote: > > > From: Zhao Zhili > > > > --- > > libavcodec/aarch64/h26x/dsp.h | 6 +++- > > libavcodec/aarch64/h26x/sao_neon.S| 44 +-- > > libavcodec/aarch64/hevcdsp_init

Re: [FFmpeg-devel] [PATCH 8/8] lavfi/af_aformat: convert to query_func2()

Quoting Michael Niedermayer (2024-08-31 00:23:34) > On Thu, Aug 29, 2024 at 10:50:52AM +0200, Anton Khirnov wrote: > > --- > > libavfilter/af_aformat.c | 14 -- > > 1 file changed, 8 insertions(+), 6 deletions(-) > > Breaks fate here: > > Assertion !"Unreachable" failed at libavfilte

[FFmpeg-devel] [PATCH v2 1/8] lavfi: add query_func2()

It differs from query_func() in accepting arrays of input/output format configurations to be filled as callback parameters. This allows to mark the filter context as const, ensuring it is not modified by this function, as it is not supposed to have any side effects beyond returning the supported fo

Re: [FFmpeg-devel] [PATCH 38/42] fftools/ffmpeg: add support for multiview video

Quoting James Almer (2024-08-30 02:40:49) > On 8/29/2024 8:26 PM, Michael Niedermayer wrote: > > On Tue, Aug 27, 2024 at 05:05:18PM +0200, Anton Khirnov wrote: > >> This extends the syntax for specifying input streams in -map and complex > >> filtergraph labels, to allow selecting a view by view ID

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Validate explicit subpic locations

On Mon, Aug 26, 2024 at 1:50 AM Frank Plowman wrote: > Implement the missing requirements from H.266 (V3) p. 106 on the > position and size of subpictures whose dimensions are provided > explicitly. > Applied this and "[FFmpeg-devel] [PATCH] lavc/vvc: Prevent OOB access in subpic_tiles" Thank you

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Remove assertions on qPy_{a, b}

On Thu, Aug 29, 2024 at 12:39 AM Frank Plowman wrote: > On 28/08/2024 16:13, Anton Khirnov wrote: > > Quoting Frank Plowman (2024-08-25 13:50:41) > >> These assertions are not violated, even by illegal bitstreams. > > > > I don't follow this argument, not being violated by any reachable > > runti