Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-21 Thread Anton Khirnov
Quoting Stefan Oltmanns (2024-07-18 14:12:42) > Hello Anton, > > can you eloborate on that? What is unacceptable with my patch that is > perfectly fine in the AviSynth input module? It's the very same concept. It's not perfectly fine in avisynth, I dislike it there as well. There are also recent

Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-21 Thread Hendrik Leppkes
On Mon, Jul 22, 2024 at 2:43 AM Stefan Oltmanns via ffmpeg-devel wrote: > > Am 22.07.24 um 00:15 schrieb Hendrik Leppkes: > > On Mon, Jul 22, 2024 at 12:08 AM Stefan Oltmanns via ffmpeg-devel > > wrote: > >> > >> Am 18.07.24 um 17:23 schrieb epira...@gmail.com: > >>> > > > > Well, the DLL

Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if no video device is present

2024-07-21 Thread patches via ffmpeg-devel
Good morning, can someone merge this little fix? Best Jens -Original Message- From: ffmpeg-devel On Behalf Of Roger Pack Sent: Wednesday, July 17, 2024 3:03 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avdevice/dshow: Don't skip audio devices if

[FFmpeg-devel] [PATCH] aacdec: set ac->output_elements upon channel element free

2024-07-21 Thread Lynne via ffmpeg-devel
The issue is that ac->output_elements is populated from ac->che, which may be freed, leaving dangling pointers in this list. Should fix clusterfuzz. --- libavcodec/aac/aacdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/aac/aacdec.c b/libavcodec/aac/aacdec.c index ea2ba84a80..

Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-21 Thread Stefan Oltmanns via ffmpeg-devel
Am 22.07.24 um 00:15 schrieb Hendrik Leppkes: On Mon, Jul 22, 2024 at 12:08 AM Stefan Oltmanns via ffmpeg-devel wrote: Am 18.07.24 um 17:23 schrieb epira...@gmail.com: Well, the DLL directory is added to PATH by the VapourSynth installer, but for safety reasons ffmpeg explictly tells the L

Re: [FFmpeg-devel] [PATCH 2/4 v2] libavcodec/h2645_sei: export raw LCEVC metadata

2024-07-21 Thread James Almer
On 7/21/2024 9:02 PM, Lynne via ffmpeg-devel wrote: On 22/07/2024 00:53, James Almer wrote: Signed-off-by: James Almer ---   libavcodec/h2645_sei.c | 37 +   libavcodec/h2645_sei.h |  5 +   libavcodec/itut35.h    |  2 ++   3 files changed, 44 insertions(+)

Re: [FFmpeg-devel] [PATCH 2/4 v2] libavcodec/h2645_sei: export raw LCEVC metadata

2024-07-21 Thread Lynne via ffmpeg-devel
On 22/07/2024 00:53, James Almer wrote: Signed-off-by: James Almer --- libavcodec/h2645_sei.c | 37 + libavcodec/h2645_sei.h | 5 + libavcodec/itut35.h| 2 ++ 3 files changed, 44 insertions(+) diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2

[FFmpeg-devel] [PATCH 4/4 v2] avcodec/h264dec: add support for LCEVC enhancement

2024-07-21 Thread James Almer
Signed-off-by: James Almer --- configure | 2 +- libavcodec/avcodec.h | 5 + libavcodec/h264_picture.c | 1 + libavcodec/h264_slice.c | 15 ++ libavcodec/h264dec.c | 41 --- libavcodec/h264dec.h | 3 +++ 6 fi

[FFmpeg-devel] [PATCH 3/4 v2] avcodec: add LCEVC decoding support via LCEVCdec

2024-07-21 Thread James Almer
Signed-off-by: James Almer --- configure | 3 + doc/general_contents.texi | 13 ++ libavcodec/Makefile | 1 + libavcodec/lcevcdec.c | 276 ++ libavcodec/lcevcdec.h | 44 ++ 5 files changed, 337 insertions(+) create mode

[FFmpeg-devel] [PATCH 2/4 v2] libavcodec/h2645_sei: export raw LCEVC metadata

2024-07-21 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h2645_sei.c | 37 + libavcodec/h2645_sei.h | 5 + libavcodec/itut35.h| 2 ++ 3 files changed, 44 insertions(+) diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c index 7c83747cd0..61d18e14b3 100644

[FFmpeg-devel] [PATCH 1/4 v2] avutil/frame: add an LCEVC enhancement data payload side data type

2024-07-21 Thread James Almer
Signed-off-by: James Almer --- libavutil/frame.c | 1 + libavutil/frame.h | 5 + 2 files changed, 6 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index 673a9afb3b..8da5eb28c8 100644 --- a/libavutil/frame.c +++ b/libavutil/frame.c @@ -46,6 +46,7 @@ static const AVSideDataDe

Re: [FFmpeg-devel] [PATCH v5 2/2] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-07-21 Thread Yigithan Yigit
Ping. Thanks, Yigithan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix build with older SDKs

2024-07-21 Thread Gnattu OC via ffmpeg-devel
> On Jul 22, 2024, at 06:45, Gnattu OC via ffmpeg-devel > wrote: > > > >> On Jul 22, 2024, at 06:04, Sean McGovern wrote: >> >> Hi Marvin, >> >> >> On Tue, Jul 9, 2024, 10:47 Marvin Scholz wrote: >> >>> I've accidentally used API not available on the checked version. >>> Additionally

[FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Check CVBufferCopyAttachments during configure

2024-07-21 Thread gnattu via ffmpeg-devel
The __builtin_available function does not do compile time check for the availablity of the CVBufferCopyAttachments function which will fail the build. Check the availability during configure. Signed-off-by: Gnattu OC --- configure | 2 ++ libavutil/hwcontext_videotoolbo

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix build with older SDKs

2024-07-21 Thread Gnattu OC via ffmpeg-devel
> On Jul 22, 2024, at 06:04, Sean McGovern wrote: > > Hi Marvin, > > > On Tue, Jul 9, 2024, 10:47 Marvin Scholz wrote: > >> I've accidentally used API not available on the checked version. >> Additionally check for the SDK to be new enough to even have the >> CVImageBufferCreateColorSpaceF

[FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Check CVBufferCopyAttachments during configure

2024-07-21 Thread gnattu via ffmpeg-devel
The __builtin_available function does not do compile time check for the availablity of the CVBufferCopyAttachments function which will fail the build. Check the availability during configure. Signed-off-by: Gnattu OC --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b

Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-21 Thread Hendrik Leppkes
On Mon, Jul 22, 2024 at 12:08 AM Stefan Oltmanns via ffmpeg-devel wrote: > > Am 18.07.24 um 17:23 schrieb epira...@gmail.com: > > > >>> > >>> Well, the DLL directory is added to PATH by the VapourSynth installer, > >>> but for safety reasons ffmpeg explictly tells the LoadLibrary function > >>> to

Re: [FFmpeg-devel] [PATCH v2] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-07-21 Thread Stefan Oltmanns via ffmpeg-devel
Am 18.07.24 um 17:23 schrieb epira...@gmail.com: Well, the DLL directory is added to PATH by the VapourSynth installer, but for safety reasons ffmpeg explictly tells the LoadLibrary function to only search the application directory and system32, quote from w32dlfcn.h: /** * Safe function u

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix build with older SDKs

2024-07-21 Thread Sean McGovern
Hi Marvin, On Tue, Jul 9, 2024, 10:47 Marvin Scholz wrote: > I've accidentally used API not available on the checked version. > Additionally check for the SDK to be new enough to even have the > CVImageBufferCreateColorSpaceFromAttachments API to not fail > the build. > --- > libavutil/hwconte

Re: [FFmpeg-devel] [PATCH 01/22] avformat/asfdec_o: Check size of index object

2024-07-21 Thread Michael Niedermayer
On Fri, Jul 12, 2024 at 01:33:55AM +0200, Michael Niedermayer wrote: > We subtract 24 so it must be at least 24 > > Fixes: CID1604482 Overflowed constant > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/asfdec_o.c | 3 +++ > 1 file changed, 3 insert

Re: [FFmpeg-devel] [PATCH 1/8] avfilter/vf_elbg: Use unsigned for shifting into the top bit

2024-07-21 Thread Michael Niedermayer
On Tue, Jul 09, 2024 at 12:24:03AM +0200, Michael Niedermayer wrote: > Fixes: part of CID1355110 Overflowed constant > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_elbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply 1-7 (n

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/aac/aacdec_usac: Avoid doing the same thing twice each iteration

2024-07-21 Thread Michael Niedermayer
On Mon, Jul 01, 2024 at 01:12:49AM +0200, Michael Niedermayer wrote: > This requires review by the author of the code, i have just changed > this so it looks plausible, this needs to be checked against the spec > > Fixes: CID1603194 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Sign

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_deshake_opencl: Use AV_VIDEO_MAX_PLANES

2024-07-21 Thread Michael Niedermayer
On Fri, Jun 14, 2024 at 10:40:27AM +0200, Michael Niedermayer wrote: > Fixes: CID1452758 Out-of-bounds read (actual out of bounds access depends on > a frame with more than 3 planes) > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_deshake_opencl

[FFmpeg-devel] [PATCH 2/2] web: move 4.1 to olddownloads

2024-07-21 Thread Michael Niedermayer
No distros are listed on downstreams that are not EOL that use 4.1 --- src/download| 37 - src/olddownload | 37 + 2 files changed, 37 insertions(+), 37 deletions(-) diff --git a/src/download b/src/download index 242de79.

[FFmpeg-devel] [PATCH 1/2] web: move 6.0 to olddownloads

2024-07-21 Thread Michael Niedermayer
Only ubuntu 23.10 uses 6.0 according to downstreams and that is EOL in a few days also 23.10 users will probably upgrade to 24.04 LTS so shouldnt affect anyone --- src/download| 36 src/olddownload | 36 2 files changed

Re: [FFmpeg-devel] [PATCH] lavc/vvc_mc: R-V V avg w_avg

2024-07-21 Thread flow gg
Okay, updated it Rémi Denis-Courmont 于2024年7月19日周五 23:56写道: > Le torstaina 18. heinäkuuta 2024, 18.04.15 EEST flow gg a écrit : > > > Again, I don't think that a maximul multiplier belongs here. If the > > > calling code cannot scale the multiplier up, then it should be a normal > > > loop provi

[FFmpeg-devel] [PATCH] lavc/vvc_mc: R-V V avg w_avg

2024-07-21 Thread uk7b
From: sunyuechi C908 X60 avg_8_2x2_c:1.21.0 avg_8_2x2_rvv_i32 :0.70.7 avg_8_2x4_c:2.02.2 avg_8_2x4_rvv_i3

Re: [FFmpeg-devel] [PATCH 3/5] avformat/iamfdec: Check nb_layers before dereferencing layer

2024-07-21 Thread Michael Niedermayer
On Wed, Jul 17, 2024 at 01:27:43PM +0200, Michael Niedermayer wrote: > Fixes: dereferencing pointers near NULL > Fixes: > 70432/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-5255672845893632 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/project

[FFmpeg-devel] FFmpeg point releases

2024-07-21 Thread Michael Niedermayer
Hi all several of our release branches have the latest release from 2023 also there have been many fixes that need backporting so i will start backporting and then making new releases. ill probably do the branches which have had no release for longest first. (limited to what is still supported)

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pnmdec: Use 64bit for input size check

2024-07-21 Thread Michael Niedermayer
On Fri, Jul 19, 2024 at 12:16:06AM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: poc3 > > Reported-by: VulDB CNA Team > Signed-off-by: Michael Niedermayer > --- > libavcodec/pnmdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...] -- Michael

Re: [FFmpeg-devel] [PATCH] cbs_av1: Reject thirty-two zero bits in uvlc code

2024-07-21 Thread Michael Niedermayer
On Tue, Dec 26, 2023 at 12:50:42AM +0100, Michael Niedermayer wrote: > Hi > > On Sun, Oct 22, 2023 at 07:35:52PM +0100, Mark Thompson wrote: > > The spec allows at least thirty-two zero bits followed by a one to mean > > 2^32-1, with no constraint on the number of zeroes. The libaom > > reference

Re: [FFmpeg-devel] [PATCH] lavu/riscv: do not fallback to AT_HWCAP auxillary vector

2024-07-21 Thread Rémi Denis-Courmont
Le 20 juillet 2024 00:28:23 GMT+03:00, Brad Smith a écrit : >On 2024-07-19 11:46 a.m., Rémi Denis-Courmont wrote: >> If __riscv_hwprobe() fails, then the kernel version is presumably too >> old. There is not much point falling back to the auxillary vector. >> >> - The Linux kernel requires I,