[FFmpeg-devel] [PATCH 2/2] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-03 Thread Sean McGovern
RaptorCS POWER9 (8c4t) @ 2.2GHz: flac_wasted_32_c: 50.1 flac_wasted_32_vsx: 17.3 --- libavcodec/flacdsp.c | 2 ++ libavcodec/flacdsp.h | 1 + libavcodec/ppc/Makefile | 2 ++ libavcodec/ppc/flacdsp_init.c | 38 libavcodec/ppc/flacdsp_vsx.c |

[FFmpeg-devel] [PATCH 1/2] configure: permit POWER9 cpu flags

2024-07-03 Thread Sean McGovern
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index b28221f258..bbda7a02cb 100755 --- a/configure +++ b/configure @@ -5493,7 +5493,7 @@ elif enabled ppc; then cpuflags="-mcpu=$cpu" disable vsx ;; -

[FFmpeg-devel] [PATCH] avformat/dvdvideodec: Remove unused cell count variable

2024-07-03 Thread Marth64
Signed-off-by: Marth64 --- libavformat/dvdvideodec.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index 5c9d578aaf..7a859071c3 100644 --- a/libavformat/dvdvideodec.c +++ b/libavformat/dvdvideodec.c @@ -111,7 +111,6 @@ typedef struct DV

Re: [FFmpeg-devel] [PATCH] doc/filter: fix grammar in tiltandshift filter

2024-07-03 Thread Vittorio Giovara
On Wed, Jul 3, 2024 at 9:29 PM Gyan Doshi wrote: > > > On 2024-07-02 10:45 am, Gyan Doshi wrote: > > --- > > doc/filters.texi | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/doc/filters.texi b/doc/filters.texi > > index 0ff7c142b6..c9c4f7cf6b 100644 > > -

Re: [FFmpeg-devel] [RFC] fix UB in fate-checkasm-sw_yuv2rgb

2024-07-03 Thread Sean McGovern
Hi Rémi, On Wed, Jul 3, 2024 at 4:34 PM Rémi Denis-Courmont wrote: > > Le keskiviikkona 3. heinäkuuta 2024, 22.07.42 EEST Sean McGovern a écrit : > > Hi, > > > > Attached is an RFC patch to address the undefined behaviour from the > > new `fate-checkasm-sw_yuv2rgb` test seen on both the x86 and p

[FFmpeg-devel] [PATCH 11/11] avformat/movenc: add support for writting hfov boxes

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 500ea25731..5f4c1cb6ea 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -2195,6 +2195,17 @@ static inline int64_t

[FFmpeg-devel] [PATCH 10/11] avformat/movenc: add support for writting vexu boxes

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 159 +-- 1 file changed, 154 insertions(+), 5 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 26a67e6e47..500ea25731 100644 --- a/libavformat/movenc.c +++ b/libavformat/moven

[FFmpeg-devel] [PATCH 08/11] avformat/hevc: add a function to write a lhvC box

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/hevc.c | 163 +++-- libavformat/hevc.h | 17 + 2 files changed, 145 insertions(+), 35 deletions(-) diff --git a/libavformat/hevc.c b/libavformat/hevc.c index f3e5542699..69e6f719e5 100644 --- a/libavformat/he

[FFmpeg-devel] [PATCH 07/11] avformat/hevc: store parameter set and layer IDs in HVCCNALUnit

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/hevc.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/libavformat/hevc.c b/libavformat/hevc.c index 6fe701032b..f3e5542699 100644 --- a/libavformat/hevc.c +++ b/libavformat/hevc.c @@ -45,6 +45,8 @@ enum {

[FFmpeg-devel] [PATCH 09/11] avformat/movenc: add support for writing lhvC boxes

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index f8eb6fadf7..26a67e6e47 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1557,6 +

[FFmpeg-devel] [PATCH 06/11] avformat/hevc: use a single array for per-PS NALUs

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/hevc.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/libavformat/hevc.c b/libavformat/hevc.c index 40f46668f9..6fe701032b 100644 --- a/libavformat/hevc.c +++ b/libavformat/hevc.c @@ -40,15 +40,20

[FFmpeg-devel] [PATCH 05/11] avformat/hevc: don't write the same array values per nal addition

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/hevc.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/libavformat/hevc.c b/libavformat/hevc.c index 651c3b4b1d..40f46668f9 100644 --- a/libavformat/hevc.c +++ b/libavformat/hevc.c @@ -672,11 +672,9

[FFmpeg-devel] [PATCH 04/11] avformat/hevc: don't write NALUs with nuh_layer_id > 0 in hvcC boxes

2024-07-03 Thread James Almer
hvcC should only contain nuh_layer_id == 0 NALUs. Support for a box meant to contain higher layer NALUs will be added in a following patch. To achieve this, all sources are parsed and filtered, including hvcC source that until now were propagated untouched. This is reflected in how the affected ref

[FFmpeg-devel] [PATCH 03/11] avformat/mov: Mark streams with a layered HEVC box as multilayer

2024-07-03 Thread James Almer
From: Derek Buitenhuis Signed-off-by: Derek Buitenhuis Signed-off-by: Anton Khirnov Signed-off-by: James Almer --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 30e8086855..b27666f50f 100644 --- a/libavformat/mov.c +++ b/li

[FFmpeg-devel] [PATCH 02/11] avformat: Add a new stream disposition for multilayer video

2024-07-03 Thread James Almer
From: Derek Buitenhuis This lets us detect when a container has flagged a stream as multilayer. Signed-off-by: Derek Buitenhuis Signed-off-by: Anton Khirnov Signed-off-by: James Almer --- doc/ffprobe.xsd | 1 + libavformat/avformat.h

[FFmpeg-devel] [PATCH 01/11] avformat/mov: add support for lhvC box parsing

2024-07-03 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index a3951a6942..30e8086855 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8157,6 +8157,53 @@ st

[FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI

2024-07-03 Thread Josh Allmann
Encoders may emit a buffering period SEI without a corresponding SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. During Annex B conversion, this may result in the SPS/PPS being inserted *after* the buffering period SEI but before the IDR NAL. Since the buffering period SEI references

Re: [FFmpeg-devel] [RFC] fix UB in fate-checkasm-sw_yuv2rgb

2024-07-03 Thread Rémi Denis-Courmont
Le keskiviikkona 3. heinäkuuta 2024, 22.07.42 EEST Sean McGovern a écrit : > Hi, > > Attached is an RFC patch to address the undefined behaviour from the > new `fate-checkasm-sw_yuv2rgb` test seen on both the x86 and ppc UBSan > FATE nodes. > > -- Sean McGovern __typeof__ is a GCCism. C23 has ty

Re: [FFmpeg-devel] [PATCH] doc/filter: fix grammar in tiltandshift filter

2024-07-03 Thread Gyan Doshi
On 2024-07-02 10:45 am, Gyan Doshi wrote: --- doc/filters.texi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 0ff7c142b6..c9c4f7cf6b 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -23546,13 +23546,13 @@ tile=3x2

[FFmpeg-devel] [RFC] fix UB in fate-checkasm-sw_yuv2rgb

2024-07-03 Thread Sean McGovern
Hi, Attached is an RFC patch to address the undefined behaviour from the new `fate-checkasm-sw_yuv2rgb` test seen on both the x86 and ppc UBSan FATE nodes. -- Sean McGovern From 7b7c5fe69443085250ce8fc35110cfa2d756 Mon Sep 17 00:00:00 2001 From: Sean McGovern Date: Tue, 2 Jul 2024 23:07:54 -

[FFmpeg-devel] [PATCH 5/5] lavc/h264dsp: R-V V 8-bit h264_idct8_add

2024-07-03 Thread Rémi Denis-Courmont
T-Head C908 (cycles): h264_idct8_add_8bpp_c: 1072.0 h264_idct8_add_8bpp_rvv_i32: 318.5 --- libavcodec/riscv/h264dsp_init.c | 2 + libavcodec/riscv/h264idct_rvv.S | 137 +++- 2 files changed, 138 insertions(+), 1 deletion(-) diff --git a/libavcodec/riscv/h264dsp_

Re: [FFmpeg-devel] [PATCH v2] avcodec/riscv: add h264 dc idct rvv

2024-07-03 Thread Rémi Denis-Courmont
Le keskiviikkona 3. heinäkuuta 2024, 13.47.29 EEST J. Dekker a écrit : > checkasm: bench runs 131072 (1 << 17) > h264_idct4_add_dc_8bpp_c: 1.5 > h264_idct4_add_dc_8bpp_rvv_i64: 0.7 > h264_idct4_add_dc_9bpp_c: 1.5 > h264_idct4_add_dc_9bpp_rvv_i64: 0.7 > h264_idct4_add_dc_10bpp_c: 1.5 > h264_idct4_ad

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aeadec, avcodec/atrac1: Fix 8 and 4-channel ATRAC1 support

2024-07-03 Thread asivery via ffmpeg-devel
On Sat, 15 Jun 2024 I was asked for samples by Anton Khirnov - this is why I wrote the test. If the test is not necessary after all, that patch doesn't need to be applied. I can also shorten the test file, if it's required. On Wednesday, July 3rd, 2024 at 4:49 PM, Andreas Rheinhardt wrote: >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aeadec, avcodec/atrac1: Fix 8 and 4-channel ATRAC1 support

2024-07-03 Thread Andreas Rheinhardt
asivery via ffmpeg-devel: > I'm sending the patch again, so that it is correctly rebased on the current > master. > Here are the two sample files required by the FATE test: > https://0x0.st/Xaw2.aea/boxboy333_house_music_multitrack.aea > https://0x0.st/Xaw_.pcm/boxboy333_house_music_multitrack.pcm

[FFmpeg-devel] [PATCH 2/2] fate/atrac1: add test for 4-track file

2024-07-03 Thread asivery via ffmpeg-devel
Empty MessageFrom 89743ce8da188800536c78b46fc3ee43e1538fb5 Mon Sep 17 00:00:00 2001 From: asivery Date: Wed, 3 Jul 2024 16:25:05 +0200 Subject: [PATCH 2/2] fate/atrac1: add test for 4-track file Signed-off-by: asivery --- tests/fate/atrac.mak | 4 1 file changed, 4 insertions(+) diff --gi

[FFmpeg-devel] [PATCH 1/2] avformat/aeadec, avcodec/atrac1: Fix 8 and 4-channel ATRAC1 support

2024-07-03 Thread asivery via ffmpeg-devel
I'm sending the patch again, so that it is correctly rebased on the current master. Here are the two sample files required by the FATE test: https://0x0.st/Xaw2.aea/boxboy333_house_music_multitrack.aea https://0x0.st/Xaw_.pcm/boxboy333_house_music_multitrack.pcm Please let me know if I need to pro

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pngenc: fix mDCv typo

2024-07-03 Thread Leo Izen
On 7/2/24 9:44 AM, Leo Izen wrote: When mDCv support was added, there was a typo in both variable names and also the MKTAG itself, incorrectly listing it as mDVc. The tag name stands for Mastering Display Color Volume so mDCv is correct. Typo originally introduced in 78949041417caaef0c82b2b23d7d

Re: [FFmpeg-devel] [PATCH] avcodec/hw_base_encode: Add missing include

2024-07-03 Thread Tong Wu
Andreas Rheinhardt: >Subject: [FFmpeg-devel] [PATCH] avcodec/hw_base_encode: Add missing include > >Fixes checkheaders. > >Signed-off-by: Andreas Rheinhardt >--- > libavcodec/hw_base_encode.h | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/libavcodec/hw_base_encode.h b/libavcodec/hw_base_en

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-07-03 Thread Niklas Haas
On Tue, 02 Jul 2024 15:27:00 +0200 Niklas Haas wrote: > 1. Is this a good idea, or too confusing / complex to be worth the gain? >Specifically, I am worried about confusion arising due to differences >in behavior, and implemented options, between all of the above. > >That said, I th

Re: [FFmpeg-devel] [PATCH 4/9] avcodec/vvc/ctu: Remove dead ret check

2024-07-03 Thread Nuo Mi
On Wed, Jul 3, 2024 at 2:44 AM Michael Niedermayer wrote: > On Sun, May 19, 2024 at 04:49:10AM +0200, Michael Niedermayer wrote: > > Fixes: CID1560040 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vvc/ctu.c | 2 -- > >

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/vvc/dec: Remove constant eos_at_start

2024-07-03 Thread Nuo Mi
On Wed, Jul 3, 2024 at 2:44 AM Michael Niedermayer wrote: > On Sun, May 19, 2024 at 04:49:11AM +0200, Michael Niedermayer wrote: > > Fixes: CID1560041 'Constant' variable guards dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vvc

Re: [FFmpeg-devel] [PATCH] avcodec/avformat: Added codec_name to AVCodecContext and AVCodecParameters

2024-07-03 Thread Bernardo Pilarz via ffmpeg-devel
On 03/07/2024 11:56, Bernardo Pilarz via ffmpeg-devel wrote: On 03/07/2024 11:10, Anton Khirnov wrote: Quoting Bernardo Pilarz via ffmpeg-devel (2024-07-03 10:10:15) +    char *codec_name;     const struct AVCodec  *codec;     enum AVCodecID codec_id; /* see AV_CODEC_ID_xxx */ Add

[FFmpeg-devel] [PATCH v2] avcodec/riscv: add h264 dc idct rvv

2024-07-03 Thread J. Dekker
checkasm: bench runs 131072 (1 << 17) h264_idct4_add_dc_8bpp_c: 1.5 h264_idct4_add_dc_8bpp_rvv_i64: 0.7 h264_idct4_add_dc_9bpp_c: 1.5 h264_idct4_add_dc_9bpp_rvv_i64: 0.7 h264_idct4_add_dc_10bpp_c: 1.5 h264_idct4_add_dc_10bpp_rvv_i64: 0.7 h264_idct4_add_dc_12bpp_c: 1.2 h264_idct4_add_dc_12bpp_rvv_i6

Re: [FFmpeg-devel] [PATCH] avcodec/avformat: Added codec_name to AVCodecContext and AVCodecParameters

2024-07-03 Thread Bernardo Pilarz via ffmpeg-devel
On 03/07/2024 11:10, Anton Khirnov wrote: Quoting Bernardo Pilarz via ffmpeg-devel (2024-07-03 10:10:15) +char *codec_name; const struct AVCodec *codec; enum AVCodecID codec_id; /* see AV_CODEC_ID_xxx */ Adding a new field here is an ABI break, it would need to go at t

Re: [FFmpeg-devel] [PATCH] avcodec/avformat: Added codec_name to AVCodecContext and AVCodecParameters

2024-07-03 Thread Anton Khirnov
Quoting Bernardo Pilarz via ffmpeg-devel (2024-07-03 10:10:15) > >> +char *codec_name; > >>const struct AVCodec *codec; > >>enum AVCodecID codec_id; /* see AV_CODEC_ID_xxx */ > >> > > Adding a new field here is an ABI break, it would need to go at the > > end of the struct.

Re: [FFmpeg-devel] [PATCH] avcodec/avformat: Added codec_name to AVCodecContext and AVCodecParameters

2024-07-03 Thread Bernardo Pilarz via ffmpeg-devel
On 03/07/2024 10:02, Hendrik Leppkes wrote: On Wed, Jul 3, 2024 at 9:48 AM Bernardo Pilarz via ffmpeg-devel wrote: Added the codec_name field, in which the unprocessed, not-interpreted codec name is stored. This is useful when codecs that are not handled by the libav (i.e. AV_CODEC_ID_NONE) are

Re: [FFmpeg-devel] [PATCH] avcodec/avformat: Added codec_name to AVCodecContext and AVCodecParameters

2024-07-03 Thread Hendrik Leppkes
On Wed, Jul 3, 2024 at 9:48 AM Bernardo Pilarz via ffmpeg-devel wrote: > > Added the codec_name field, in which the unprocessed, not-interpreted codec > name is stored. > This is useful when codecs that are not handled by the libav > (i.e. AV_CODEC_ID_NONE) are encountered, since the application m

[FFmpeg-devel] [PATCH] avcodec/avformat: Added codec_name to AVCodecContext and AVCodecParameters

2024-07-03 Thread Bernardo Pilarz via ffmpeg-devel
Added the codec_name field, in which the unprocessed, not-interpreted codec name is stored. This is useful when codecs that are not handled by the libav (i.e. AV_CODEC_ID_NONE) are encountered, since the application might still want to handle them. Having this field allows the application to deter