Re: [FFmpeg-devel] [PATCH] libavformat/vapoursynth: Update to API version 4, load library at runtime

On 6/21/24 9:37 PM, Stefan Oltmanns via ffmpeg-devel wrote: The current VapourSynth implementation is rarely used, as it links the VapourSynth library at build time, making the resulting build unable to run when VapourSynth is not installed. Therefore barely anyone compiles with VapourSynth activ

[FFmpeg-devel] [PATCH 18/18] avcodec/vvcdec: alf, support virtual boundaries

see https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=9503377 passed files: GDR_A_ERICSSON_2.bit GDR_B_NOKIA_2.bit GDR_C_NOKIA_2.bit VIRTUAL_A_MediaTek_3.bit VIRTUAL_B_MediaTek_3.bit --- libavcodec/vvc/ctu.h| 7 +++ libavcodec/vvc/filter.c | 134 ++

[FFmpeg-devel] [PATCH 16/18] avcodec/vvcdec: deblock, support virtual boundaries

--- libavcodec/vvc/filter.c | 34 ++ 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index a5635c60df..69d67cb7f6 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -55,6 +55,29 @@ s

[FFmpeg-devel] [PATCH 17/18] avcodec/vvcdec: sao, support virtual boundaries

--- libavcodec/vvc/filter.c | 46 + 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 69d67cb7f6..44dd895d7d 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -20,6 +20,

[FFmpeg-devel] [PATCH 14/18] cbs_h266: add VVC_MAX_VBS for max num of virtual boundaries

--- libavcodec/cbs_h266.h | 8 libavcodec/cbs_h266_syntax_template.c | 8 libavcodec/vvc.h | 3 +++ 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h index 21b9a4196c..5f12915b65 1006

[FFmpeg-devel] [PATCH 13/18] avcodec/vvcdec: misc, constify ALFParams

--- libavcodec/vvc/filter.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 457e2b99c2..a5635c60df 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -926,7 +926,7 @@ static void alf_prepare_b

[FFmpeg-devel] [PATCH 12/18] avcodec/vvcdec: misc, remove unused ALFParams.applied

--- libavcodec/vvc/ctu.h| 2 -- libavcodec/vvc/filter.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/libavcodec/vvc/ctu.h b/libavcodec/vvc/ctu.h index a987328d81..432dbc5ade 100644 --- a/libavcodec/vvc/ctu.h +++ b/libavcodec/vvc/ctu.h @@ -461,8 +461,6 @@ typedef struct ALFParams {

[FFmpeg-devel] [PATCH 11/18] avcodec/vvcdec: refact out alf_get_edges

--- libavcodec/vvc/filter.c | 53 - 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 3aa241ad90..671e599dab 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -1036,6 +

[FFmpeg-devel] [PATCH 10/18] avcodec/vvcdec: misc, reformat ff_vvc_sao_filter

--- libavcodec/vvc/filter.c | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 10d11ce31f..3aa241ad90 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -266,44 +

[FFmpeg-devel] [PATCH 08/18] avcodec/vvcdec: refact out sao_extends_edges

--- libavcodec/vvc/filter.c | 108 +++- 1 file changed, 50 insertions(+), 58 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 1326d2c82e..534ba57205 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -214,6 +2

[FFmpeg-devel] [PATCH 09/18] avcodec/vvcdec: refact, fix naming convention of x0, y0 for sao

it's mismatched with the ff_vvc_sao_filter function declaration --- libavcodec/vvc/filter.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 534ba57205..10d11ce31f 100644 --- a/libavcodec/vvc/filt

[FFmpeg-devel] [PATCH 06/18] avcodec/vvcdec: refact, unify ff_vvc_deblock_{horizontal, vertical}

--- libavcodec/vvc/filter.c | 153 1 file changed, 44 insertions(+), 109 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 82a58a7ea8..89b794195e 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -712,144

[FFmpeg-devel] [PATCH 07/18] avcodec/vvcdec: refact out sao_get_edges

--- libavcodec/vvc/filter.c | 119 ++-- 1 file changed, 65 insertions(+), 54 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 89b794195e..1326d2c82e 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -155,70 +

[FFmpeg-devel] [PATCH 05/18] avcodec/vvcdec: misc, use POS to simplify filter code

--- libavcodec/vvc/filter.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 7ae36b2344..82a58a7ea8 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -34,6 +34,10 @@ #define

[FFmpeg-devel] [PATCH 04/18] avcodec/vvcdec: refact, unify {horizontal, vertical}_bs, {horizontal, vertical}_p, {horizontal, vertical}_q

--- libavcodec/vvc/dec.c| 14 +++--- libavcodec/vvc/dec.h| 9 +++-- libavcodec/vvc/filter.c | 32 +++- 3 files changed, 21 insertions(+), 34 deletions(-) diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c index f5603306f3..356ed58e37 100644 -

[FFmpeg-devel] [PATCH 15/18] avcodec/vvcdec: ps, derive virtual boundaries

--- libavcodec/vvc/ps.c | 45 + libavcodec/vvc/ps.h | 6 ++ 2 files changed, 51 insertions(+) diff --git a/libavcodec/vvc/ps.c b/libavcodec/vvc/ps.c index 92368eafc2..58496c9fba 100644 --- a/libavcodec/vvc/ps.c +++ b/libavcodec/vvc/ps.c @@ -796,8 +

[FFmpeg-devel] [PATCH 02/18] avcodec/vvcdec: refact, unify vvc_deblock_bs_luma_{horizontal, vertical}

--- libavcodec/vvc/filter.c | 108 ++-- 1 file changed, 36 insertions(+), 72 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index d4c09b69f3..996e58dc3e 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -538,100

[FFmpeg-devel] [PATCH 03/18] avcodec/vvcdec: refact, unify vvc_deblock_bs_chroma_{horizontal, vertical}

--- libavcodec/vvc/filter.c | 62 + 1 file changed, 19 insertions(+), 43 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 996e58dc3e..06e1717b13 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -586,56 +

[FFmpeg-devel] [PATCH 01/18] avcodec/vvcdec: refact, unify vvc_deblock_subblock_bs_{horizontal, vertical}

--- libavcodec/vvc/filter.c | 93 ++--- 1 file changed, 32 insertions(+), 61 deletions(-) diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c index 7844d34eac..d4c09b69f3 100644 --- a/libavcodec/vvc/filter.c +++ b/libavcodec/vvc/filter.c @@ -406,30 +

[FFmpeg-devel] [PATCH 2/4] checkasm/vvc_alf: random select alf virtual boundaries position

A picture's virtual boundaries will split a CTU into 4 ALF blocks. The ALF virtual boundary may cross or not cross a ALF block. --- tests/checkasm/vvc_alf.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c inde

[FFmpeg-devel] [PATCH 1/4] checkasm/vvc_alf: only check the valid filter and classify sizes

--- tests/checkasm/vvc_alf.c | 61 ++-- 1 file changed, 34 insertions(+), 27 deletions(-) diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c index 84b0f9da15..902757aff1 100644 --- a/tests/checkasm/vvc_alf.c +++ b/tests/checkasm/vvc_alf.c @@ -90,3

[FFmpeg-devel] [PATCH 4/4] checkasm/vvc_alf: ensure right and bottom boundaries are not overwritten by asm

--- tests/checkasm/vvc_alf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/vvc_alf.c b/tests/checkasm/vvc_alf.c index be8b930810..15e79289cd 100644 --- a/tests/checkasm/vvc_alf.c +++ b/tests/checkasm/vvc_alf.c @@ -108,8 +108,8 @@ static void check_alf_f

[FFmpeg-devel] [PATCH 3/4] x86/vvc_alf: avoid overwriting for non-16 aligned widths

Previously, the code allowed overwriting on 16-aligned blocks, which was suitable when there were no picture's virtual boundaries because both CTU sizes and strides were 16-aligned. However, with picture's virtual boundaries, each CTU is divided into four ALF blocks, leading to potential issues

[FFmpeg-devel] [PATCH 8/8] fftools/ffprobe: only print AVStereo3D.view when it's defined

Signed-off-by: James Almer --- fftools/ffprobe.c | 3 ++- tests/ref/fate/matroska-spherical-mono | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index d7ba980ff9..f9124ad5d7 100644 --- a/fftools/ffprobe.c +++ b/fftoo

[FFmpeg-devel] [PATCH 1/7 v2] avutil/stereo3d add Monoscopic View enum value

We need a way to signal the frame has a single view that doesn't map to any particular eye, and it should be the default one. Signed-off-by: James Almer --- Now updating the fate test, to show how type and view clashed as is. libavutil/stereo3d.c | 3 ++- libavutil/stereo3d.h

[FFmpeg-devel] [PATCH 7/7] avformat/matroskadec: don't use sizeof(AVStereo3D)

It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavformat/matroskadec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 6bc5fa621e..d1a135ed63 100644 --- a/libavformat/matroskadec.c +++ b/li

[FFmpeg-devel] [PATCH 6/7] avformat/mov: don't use sizeof(AVStereo3D)

It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavformat/isom.h | 1 + libavformat/mov.c | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 35b767a52c..a0498f45e5 100644 --- a/libavformat/isom.h ++

[FFmpeg-devel] [PATCH 5/7] avutil/stereo3d: add a new allocator function that returns a size

av_stereo3d_alloc() is not useful in scenarios where you need to know the runtime size of AVStereo3D. Signed-off-by: James Almer --- libavutil/stereo3d.c | 8 libavutil/stereo3d.h | 8 2 files changed, 16 insertions(+) diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c i

[FFmpeg-devel] [PATCH 4/7] avformat/dump: print Stereo3D view only when type is view defined

Signed-off-by: James Almer --- libavformat/dump.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index 61a2c6a29f..33d72b7e18 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -259,9 +259,10 @@ static void dump_stereo3d

[FFmpeg-devel] [PATCH 3/3] avutil/stereo3d: add a Stereo3D type to signal that the packing is defined by the view field

Given that a video stream/frame may have only one view coded, or both packed in an undefined way, and as the values of AVStereo3DView and AVStereo3DType may clash (namely if type is AV_STEREO3D_2D, then AV_STEREO3D_VIEW_PACKED would be invalid, and if it's anything other than it, then only AV_STERE

[FFmpeg-devel] [PATCH] libavformat/vapoursynth: Update to API version 4, load library at runtime

Hello, this is my first patch, I hope I got all the formalities correct. The current VapourSynth implementation is rarely used, as it links the VapourSynth library at build time, making the resulting build unable to run when VapourSynth is not installed. Therefore barely anyone compiles with Vap

[FFmpeg-devel] [PATCH 2/2] avformat/mov: default to Monoscopic view when parsing eyes box

Signed-off-by: James Almer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 50e171c960..4fa39cf4fd 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -6546,7 +6546,7 @@ static int mov_read_eyes(MOVContext

[FFmpeg-devel] [PATCH 1/2] avutil/stereo3d add Monoscopic View enum value

We need a way to signal the frame has a single view that doesn't map to any particular eye, and it should be the default one. Signed-off-by: James Almer --- The Stereo spec from Apple, which was used to design this API, states "both has_left_eye_view and has_right_eye_view can be set to 0 to indi

[FFmpeg-devel] [PATCH v2] avcodec/aacdec_lpd: remove unused local variables

int idx, and int first_tcx_flag are set but not used, so this commit removes their declarations and assignments. --- libavcodec/aac/aacdec_lpd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c index 796edd2ab5..91

Re: [FFmpeg-devel] [PATCH 3/3] avutil/stereo3d: set a sane default value for AVRational fields

On Fri, Jun 21, 2024 at 09:19:36AM -0300, James Almer wrote: > On 6/18/2024 6:13 PM, Michael Niedermayer wrote: > > On Tue, Jun 18, 2024 at 04:20:34PM -0300, James Almer wrote: > > > Prevent potential divisions by 0 when using them immediately after > > > allocation. > > > > > > Signed-off-by: Ja

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/j2kenc: Merge dwt_norm into lambda

On Fri, Jun 21, 2024 at 11:38:46AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > This moves computations out of a loop > > > > Fixes: signed integer overflow: 31665934879948800 * 9998 cannot be > > represented in type 'long' > > Fixes: > > 69024/clusterfuzz-testcase-minimized-ffmpe

[FFmpeg-devel] [PATCH] avcodec/osq: avoid signed overflow in downsample path

Fixes: signed integer overflow: 865309950 * 256 cannot be represented in type 'int' Fixes: 69191/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_OSQ_fuzzer-6310214413385728 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

Re: [FFmpeg-devel] [PATCH] avcodec/iirfilter: Move ff_iir_filter() to lavc/tests/iirfilter.c

Andreas Rheinhardt: > It is only used by the test. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/iirfilter.c | 14 -- > libavcodec/iirfilter.h | 15 --- > libavcodec/tests/iirfilter.c | 17 - > 3 files changed, 16 insertions(+), 30 d

Re: [FFmpeg-devel] [PATCH 3/3] avutil/stereo3d: set a sane default value for AVRational fields

On 6/18/2024 6:13 PM, Michael Niedermayer wrote: On Tue, Jun 18, 2024 at 04:20:34PM -0300, James Almer wrote: Prevent potential divisions by 0 when using them immediately after allocation. Signed-off-by: James Almer --- libavutil/stereo3d.c | 14 +- 1 file changed, 13 insertions

Re: [FFmpeg-devel] [PATCH v13 2/8] avcodec/webp: separate VP8 decoding

Quoting Thilo Borgmann via ffmpeg-devel (2024-06-21 12:43:17) > From: Thilo Borgmann via ffmpeg-devel > > --- > libavcodec/webp.c | 50 +-- > 1 file changed, 44 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/webp.c b/libavcodec/webp.c > ind

Re: [FFmpeg-devel] [PATCH 1/3] avutil/ambient_viewing_environment: set a sane default value for AVRational fields

On Thu, Jun 20, 2024 at 6:54 PM James Almer wrote: > > On 6/18/2024 4:20 PM, James Almer wrote: > > Prevent potential divisions by 0 when using them immediately after > > allocation. > > > > Signed-off-by: James Almer > > --- > > libavutil/ambient_viewing_environment.c | 10 ++ > > 1

[FFmpeg-devel] [PATCH 2/2] configure: align conditional library deps assignments

--- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 1e58c0dbac..db11a78c74 100755 --- a/configure +++ b/configure @@ -7764,14 +7764,14 @@ enabled elbg_filter && prepend avfilter_deps "avcodec" enabled find_rect_filter&& pr

[FFmpeg-devel] [PATCH 1/2] configure: correct deps assigment for QR libs

--- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 3bca638459..1e58c0dbac 100755 --- a/configure +++ b/configure @@ -7767,8 +7767,8 @@ enabled mcdeint_filter && prepend avfilter_deps "avcodec" enabled movie_filter&& prepend

[FFmpeg-devel] [PATCH v13 6/8] libavformat/webp: add WebP demuxer

From: Josef Zlomek Adds the demuxer of animated WebP files. It supports non-animated, animated, truncated, and concatenated files. Reading from a pipe (and other non-seekable inputs) is also supported. The WebP demuxer splits the input stream into packets containing one frame. It also marks the

[FFmpeg-devel] [PATCH v13 7/8] fate: add test for animated WebP

From: Thilo Borgmann via ffmpeg-devel --- tests/fate/image.mak | 9 tests/ref/fate/webp-anim | 22 tests/ref/fate/webp-chfmt1 | 23 tests/ref/fate/webp-chfmt2 | 106 + 4 files changed, 160 insertions(+) create mode 100644 te

[FFmpeg-devel] [PATCH v13 8/8] avcodec/webp: export XMP metadata

From: Thilo Borgmann via ffmpeg-devel --- libavcodec/webp.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index bacf605ff2..c8be673060 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@

[FFmpeg-devel] [PATCH v13 3/8] avcodec/bsf: Add awebp2webp bitstream filter

From: Thilo Borgmann via ffmpeg-devel Splits a packet containing a webp animations into one non-compliant packet per frame of the animation. Skips RIFF and WEBP chunks for those packets except for the first. Copyies ICC, EXIF and XMP chunks first into each of the packets except for the first. ---

[FFmpeg-devel] [PATCH v13 5/8] avcodec/webp: make init_canvas_frame static

From: Thilo Borgmann via ffmpeg-devel --- libavcodec/webp.c | 146 +++--- 1 file changed, 72 insertions(+), 74 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 146d5cb393..bacf605ff2 100644 --- a/libavcodec/webp.c +++ b/libavcodec/web

[FFmpeg-devel] [PATCH v13 4/8] libavcodec/webp: add support for animated WebP

From: Josef Zlomek Fixes: 4907 Adds support for decoding of animated WebP. The WebP decoder adds the animation related features according to the specs: https://developers.google.com/speed/webp/docs/riff_container#animation The frames of the animation may be smaller than the image canvas. Theref

[FFmpeg-devel] [PATCH v13 1/8] avcodec/webp: remove unused definitions

From: Thilo Borgmann via ffmpeg-devel --- libavcodec/webp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index 7c2a5f0111..af4ebcec27 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp.c @@ -60,8 +60,6 @@ #define VP8X_FLAG_ALPHA 0x

[FFmpeg-devel] [PATCH v13 2/8] avcodec/webp: separate VP8 decoding

From: Thilo Borgmann via ffmpeg-devel --- libavcodec/webp.c | 50 +-- 1 file changed, 44 insertions(+), 6 deletions(-) diff --git a/libavcodec/webp.c b/libavcodec/webp.c index af4ebcec27..c52b9732b4 100644 --- a/libavcodec/webp.c +++ b/libavcodec/webp

[FFmpeg-devel] [PATCH v13 0/8] [WIP] webp: add support for animated WebP decoding

Marked WIP because we'd want to introduce private bsf's first; review welcome before that though v13 Switched to new ProgressFrame API Support for pixel format changes in animations Propagate MIN_DELAY in case of invalid delay in animations Added more tests for animations with pixel format changes

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/j2kenc: Merge dwt_norm into lambda

Michael Niedermayer: > This moves computations out of a loop > > Fixes: signed integer overflow: 31665934879948800 * 9998 cannot be > represented in type 'long' > Fixes: > 69024/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5949662967169024 > > Found-by: continuous fuzzing p

Re: [FFmpeg-devel] [PATCH v2 2/2] lavc/hevcdec: Update slice index before use it to construct slice RPL

Quoting fei.w.wang-at-intel@ffmpeg.org (2024-06-19 04:27:22) > From: Fei Wang > > Fixes regression from 47d34ba7fbb81 "fix bug" is not a meaningful description of the problem -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org