On Thu, Jun 13, 2024 at 04:02:52AM +0200, Andreas Rheinhardt wrote:
> The smv_frame is only allocated for the SMV decoder, yet
> it is unreferenced in the other decoders' flush functions, too.
> av_frame_unref(NULL) is not documented to be allowed, it just
> happens to work. Avoid it by using a ded
On Wed, 2024-06-12 at 20:12 +0800, Nuo Mi wrote:
> Hi Fei,
> Thank you for the patch.
> Which hardware supports this? Could you provide the link?
Lunar Lake will. Libvpl will update the supported HW in its code repo
later https://github.com/intel/libvpl. Here is a video on overview of
Lunar Lake:
On Fri, 2024-06-07 at 15:01 +0200, Anton Khirnov wrote:
> Specifically, calling hwaccel end_frame, verifying frame checksum,
> and printing the frame-was-decoded message.
> ---
> libavcodec/hevc/hevcdec.c | 187 +++-
> --
> libavcodec/hevc/hevcdec.h | 1 -
> 2 fil
Andreas Rheinhardt:
> The SEI handling of libx265 is buggy and can easily lead
> to memory corruption: It reuses certain buffers, but when
> reusing them it presumes that it is enough for these buffers
> to exist and does not check whether they are actually large
> enough to hold what is intended t
Rémi Denis-Courmont:
> Note that optimised implementations of these functions will be taken
> into actual use only if MpegEncContext.dct_unquantize_h263_{inter,intra}
> are *not* overloaded by existing optimisations.
>
> ---
> This adds the plus ones back, saving two branch instructions in C and
>
The smv_frame is only allocated for the SMV decoder, yet
it is unreferenced in the other decoders' flush functions, too.
av_frame_unref(NULL) is not documented to be allowed, it just
happens to work. Avoid it by using a dedicated flush function
for SMV.
Signed-off-by: Andreas Rheinhardt
---
liba
On Thu, 13 Jun 2024 at 01:36, Zhao Zhili wrote:
>
> From: Zhao Zhili
>
> The check should be >= 0, not > 0. The check itself is redundant
> since uninit only being called after init is success.
> ---
> tests/checkasm/checkasm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mjpegdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c
index ac2698a3c4..d618e53d13 100644
--- a/libavcodec/mjpegdec.c
+++ b/libavcodec/mjpegdec.c
@@ -2973,7 +2973,7 @@ av_cold i
On Thu, 13 Jun 2024 at 03:52, Stefano Sabatini wrote:
>
> On date Tuesday 2024-06-11 21:13:48 +0800, Shiqi Zhu wrote:
> > On Fri, 7 Jun 2024 at 19:55, Rémi Denis-Courmont wrote:
> > > Le 7 juin 2024 12:53:51 GMT+03:00, Michael Niedermayer
> > > a écrit :
> > > >We can require anything from an A
On Thu, 13 Jun 2024 at 04:14, Paul B Mahol wrote:
>
> On Wed, Jun 12, 2024 at 9:52 PM Stefano Sabatini wrote:
>
> > On date Tuesday 2024-06-11 21:13:48 +0800, Shiqi Zhu wrote:
> > > On Fri, 7 Jun 2024 at 19:55, Rémi Denis-Courmont
> > wrote:
> > > > Le 7 juin 2024 12:53:51 GMT+03:00, Michael Nie
On Wed, Jun 12, 2024 at 10:51:47PM +0300, radu.taraib...@gmail.com wrote:
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Michael Niedermayer
> > Sent: marți, 11 iunie 2024 20:18
> > To: FFmpeg development discussions and patches
> > Subject: Re: [FFmpeg-devel] [PATCH v2] a
On 12 Jun 2024, at 1:45, Sean McGovern wrote:
> Hi,
>
> Can someone help me reset my password on Patchwork? I've used the 'Forgot
> password ' link several times and never received an email.
IIRC patchwork can not send emails, I had the same issue a while ago but
Andriy should be able to manua
Hi
adding Andriy to CC, to make sure its not missed
On Tue, Jun 11, 2024 at 07:45:21PM -0400, Sean McGovern wrote:
> Hi,
>
> Can someone help me reset my password on Patchwork? I've used the 'Forgot
> password ' link several times and never received an email.
[...]
--
Michael GnuPG fingerp
On Wed, Jun 12, 2024 at 10:02:37PM +0200, Stefano Sabatini wrote:
> On date Wednesday 2024-06-12 19:46:59 +0200, Michael Niedermayer wrote:
> > The 2 links are the clearest i found.
> >
> > Signed-off-by: Michael Niedermayer
> > ---
> > doc/faq.texi | 5 +
> > 1 file changed, 5 insertions(+)
On Wed, Jun 12, 2024 at 08:23:08PM +0200, epira...@gmail.com wrote:
>
>
> On 12 Jun 2024, at 19:46, Michael Niedermayer wrote:
>
> > The 2 links are the clearest i found.
> >
> > Signed-off-by: Michael Niedermayer
> > ---
> > doc/faq.texi | 5 +
> > 1 file changed, 5 insertions(+)
> >
> >
Helps with: CID1439572 Uninitialized pointer read
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_convolution_opencl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavfilter/vf_convolution_opencl.c
b/libavfilter/vf_convolution_opencl.c
index 0
Fixes: CID1439581 Result is not floating-point
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_bm3d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/vf_bm3d.c b/libavfilter/vf_bm3d.c
index f53a206b518..eb7f6d34d99 100644
--
Fixes: CID1437470 Out-of-bounds read (out of bounds read would only occur with
a pixel format of more than 4 planes)
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_avgblur_opencl.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --
On date Tuesday 2024-06-04 15:47:21 +0100, Andrew Sayers wrote:
> Derived from explanations kindly provided by Stefano Sabatini and others:
> https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/325903.html
> ---
> doc/context.md | 430 +
> 1 file ch
On Wed, Jun 12, 2024 at 9:52 PM Stefano Sabatini wrote:
> On date Tuesday 2024-06-11 21:13:48 +0800, Shiqi Zhu wrote:
> > On Fri, 7 Jun 2024 at 19:55, Rémi Denis-Courmont
> wrote:
> > > Le 7 juin 2024 12:53:51 GMT+03:00, Michael Niedermayer <
> mich...@niedermayer.cc> a écrit :
> > > >We can req
On date Wednesday 2024-06-12 19:46:59 +0200, Michael Niedermayer wrote:
> The 2 links are the clearest i found.
>
> Signed-off-by: Michael Niedermayer
> ---
> doc/faq.texi | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/faq.texi b/doc/faq.texi
> index 477cc60533a..d07ed533dd7
On date Tuesday 2024-06-11 21:13:48 +0800, Shiqi Zhu wrote:
> On Fri, 7 Jun 2024 at 19:55, Rémi Denis-Courmont wrote:
> > Le 7 juin 2024 12:53:51 GMT+03:00, Michael Niedermayer
> > a écrit :
> > >We can require anything from an API that we are able to change and extend
> > >Of course we can deci
Le keskiviikkona 12. kesäkuuta 2024, 22.39.49 EEST James Almer a écrit :
> >> These are not padded, and unless I'm reading this wrong, an asm
> >> implementation loading say 16 bytes at a time will overread/write in
> >> dct_unquantize_intra (which offsets block by 1).
> >
> > AFAIU, there is no p
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Michael Niedermayer
> Sent: marți, 11 iunie 2024 20:18
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH v2] area changed: scdet filter
>
> On Tue, Jun 11, 2024 at 10:07:32AM +0300, radu.taraib..
On 6/12/2024 4:15 PM, Rémi Denis-Courmont wrote:
Le keskiviikkona 12. kesäkuuta 2024, 21.39.12 EEST James Almer a écrit :
On 6/12/2024 1:47 AM, Rémi Denis-Courmont wrote:
---
tests/checkasm/h263dsp.c | 47 +++-
1 file changed, 46 insertions(+), 1 deleti
On date Monday 2024-06-03 11:41:59 +0200, Stefano Sabatini wrote:
> On date Tuesday 2024-05-28 18:58:28 +0200, Stefano Sabatini wrote:
> > On date Monday 2024-05-27 23:37:33 +0200, Stefano Sabatini wrote:
> > > Hi,
> > >
> > > still missing documentation and might be optimized (and maybe extended
Le keskiviikkona 12. kesäkuuta 2024, 21.39.12 EEST James Almer a écrit :
> On 6/12/2024 1:47 AM, Rémi Denis-Courmont wrote:
> > ---
> >
> > tests/checkasm/h263dsp.c | 47 +++-
> > 1 file changed, 46 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/che
On 6/12/2024 1:47 AM, Rémi Denis-Courmont wrote:
---
tests/checkasm/h263dsp.c | 47 +++-
1 file changed, 46 insertions(+), 1 deletion(-)
diff --git a/tests/checkasm/h263dsp.c b/tests/checkasm/h263dsp.c
index 2d0957a90b..8a2cdb34df 100644
--- a/tests/checkas
On 12 Jun 2024, at 19:46, Michael Niedermayer wrote:
> The 2 links are the clearest i found.
>
> Signed-off-by: Michael Niedermayer
> ---
> doc/faq.texi | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/faq.texi b/doc/faq.texi
> index 477cc60533a..d07ed533dd7 100644
> --- a/do
Le keskiviikkona 12. kesäkuuta 2024, 20.40.37 EEST James Almer a écrit :
> On 6/12/2024 1:47 AM, Rémi Denis-Courmont wrote:
> > Note that optimised implementations of these functions will be taken
> > into actual use only if MpegEncContext.dct_unquantize_h263_{inter,intra}
> > are *not* overloaded
The 2 links are the clearest i found.
Signed-off-by: Michael Niedermayer
---
doc/faq.texi | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/faq.texi b/doc/faq.texi
index 477cc60533a..d07ed533dd7 100644
--- a/doc/faq.texi
+++ b/doc/faq.texi
@@ -683,4 +683,9 @@ Do you happen to have a @
On 6/12/2024 1:47 AM, Rémi Denis-Courmont wrote:
Note that optimised implementations of these functions will be taken
into actual use only if MpegEncContext.dct_unquantize_h263_{inter,intra}
are *not* overloaded by existing optimisations.
---
This adds the plus ones back, saving two branch instr
From: Zhao Zhili
The check should be >= 0, not > 0. The check itself is redundant
since uninit only being called after init is success.
---
tests/checkasm/checkasm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
index
On 6/10/2024 5:23 PM, Rémi Denis-Courmont wrote:
---
tests/checkasm/h263dsp.c | 53 +++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff --git a/tests/checkasm/h263dsp.c b/tests/checkasm/h263dsp.c
index 2d0957a90b..a8530403ee 100644
--- a/tests/checkas
On 6/10/2024 5:23 PM, Rémi Denis-Courmont wrote:
Note that optimised implementations of these functions will be taken
into actual use only if MpegEncContext.dct_unquantize_h263_{inter,intra}
are *not* overloaded by existing optimisations.
---
libavcodec/h263dsp.c | 25 +
From: Zhao Zhili
Firstly, make ff_kperf_cycles as an implementation of AV_READ_TIME
avoids code duplication.
Secondly, fix compilation error since 6a18c0bc87e when macos-kperf
is enabled. mach_time.h is included only when CONFIG_MACOS_KPERF
is 0. The error happened due to define mach_absolute_ti
From: Zhao Zhili
On m1, kpc_get_counter_count(KPC_MASK) return 8. The exact value
doesn't matter in our case.
---
libavutil/macos_kperf.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/libavutil/macos_kperf.c b/libavutil/macos_kperf.c
index a0bc845fd3..906b27
> Does this not render the type parameter of bilin_load useless (always h)?
> (Not a blocker for this patch.)
Yes, this was needed in the initial version, but it is no longer required.
I just sent a patch.
> Not sure if I already asked this but is this really faster than slide1?
> Normally we wan
From: sunyuechi
---
libavcodec/riscv/vp8dsp_rvv.S | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/libavcodec/riscv/vp8dsp_rvv.S b/libavcodec/riscv/vp8dsp_rvv.S
index a5f2e34f44..6ad349741e 100644
--- a/libavcodec/riscv/vp8dsp_rvv.S
+++ b/libavcodec/riscv/vp8dsp_rvv
Hi,
On Tue, Jun 11, 2024 at 8:42 PM James Almer wrote:
>
> On 6/11/2024 3:26 PM, Michael Niedermayer wrote:
> > On Tue, Jun 11, 2024 at 02:28:56PM +0200, Ramiro Polla wrote:
> >> chrRangeFromJpeg_8_c: 28.7
> >> chrRangeFromJpeg_8_sse4: 16.2
> >> chrRangeFromJpeg_24_c: 152.7
> >> chrRangeFromJpeg_
Le torstaina 30. toukokuuta 2024, 18.26.53 EEST u...@foxmail.com a écrit :
> From: sunyuechi
>
> Since len < 64, the registers are sufficient, so it can be
> directly unrolled (a4 is even).
>
> Another benefit of unrolling is that it reduces one load operation
> vertically compared to horizontal
FFmpeg RIP
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
ff_init_block_index() sets MpegEncContext.dest and
MpegEncContext.block_index. The latter is unused by
ff_mpv_reconstruct_mb() (which is what this code is
preparatory for) and dest is overwritten a few lines below.
So don't initialize block_index at all.
Signed-off-by: Andreas Rheinhardt
---
lib
inter_scantable is only used by the dct_unquantize_h263_inter
functions, yet this is not used by the MPEG-4 decoder at all
(in case H.263 quantization is used, the unquantization already
happens in mpeg4_decode_block()).
Also move the common initialization of ff_permute_scantable()
out of the if.
The WMV2 decoder does not support lowres, so one can optimize
the WMV2 specific code away in the lowres version of this function.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpv_reconstruct_mb_template.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mpv_reco
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 27f7ebf933..4b5b864b83 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -296,20
No mpegvideo-based decoder supports lowres > 3,
so the FFMIN here are unnecessary.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo_dec.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c
index 4e2
There are only two mpegvideo decoders that use another
(software) pixel format than YUV420: MPEG-1/2 and
the MPEG-4 studio profile. Neither of these use this part
of the code, so one can optimize the 422 code away when
this code is compiled for the decoder.
Signed-off-by: Andreas Rheinhardt
---
h261_resync() can be completely removed, because
h261_decode_gob_header() checks for a GOB header itself if
gob_start_code_skipped is zero.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h261dec.c | 27 +--
1 file changed, 1 insertion(+), 26 deletions(-)
diff --git a/l
last_resync_gb is never initialized, causing NULL + 0
in align_get_bits(). In addition to that, the loop is never
entered.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h261dec.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/libavcodec/h261dec.c b/liba
It always gets reset at the start of h261_decode_frame().
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h261dec.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c
index be285ce5e9..8671800c3e 100644
--- a/libavcodec/h261dec.c
+++ b/libavcodec/h2
Signed-off-by: Andreas Rheinhardt
---
libavcodec/msmpeg4enc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavcodec/msmpeg4enc.c b/libavcodec/msmpeg4enc.c
index 642a0ff100..3103a73663 100644
--- a/libavcodec/msmpeg4enc.c
+++ b/libavcodec/msmpeg4enc.c
@@ -71,8 +71,7 @@ v
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpeg12enc.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c
index 3948dbe599..b840fe887d 100644
--- a/libavcodec/mpeg12enc.c
+++ b/libavcodec/mpeg12enc.c
@@ -137,16 +13
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpeg12enc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c
index ba56f0c37a..3948dbe599 100644
--- a/libavcodec/mpeg12enc.c
+++ b/libavcodec/mpeg12enc.c
@@ -180,7 +180,6 @@ stat
All valid values of dc_lum and dc_chrom are in the range 0..9,
because they are initialized via tables with 10 elements.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpeg4videodec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mp
Everything that init_block_index() sets will be overwritten
a few lines below again, so don't call it and simply calculate
the only thing that is used (namely block_index[0]) manually.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vc1_block.c | 3 +--
1 file changed, 1 insertion(+), 2 deletio
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vc1_block.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c
index 640f7329ca..384979caf5 100644
--- a/libavcodec/vc1_block.c
+++ b/libavcodec/vc1_block.c
@@ -2675,12 +2675,11 @@
Only the intra scantable is used for studio profile.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpeg4videodec.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c
index f1b542cebf..18329132aa 100644
Partitioned macroblocks are always 8bit and not studio profile.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpeg4videodec.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c
index 116dc1507e..f1b542cebf 100644
-
The no-output mode (guarded by AV_CODEC_FLAG2_NO_OUTPUT)
does not provide a noteworthy speedup; in fact, it even
turned out to be slower than the code with the no-output
code removed (ordinary encode: 153259721 decicycles,
noout encode: 153259721; encode with this patch applied:
152451581 decicycle
Signed-off-by: Andreas Rheinhardt
---
libavcodec/ituh263enc.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c
index b1fe4e241e..3982b1e675 100644
--- a/libavcodec/ituh263enc.c
+++ b/libavcodec/ituh263enc.c
@@ -709,9 +7
Possible since 404fe63e23433aa559cee5366cb26f78b425e7e5.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/svq1enc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c
index 6e687166b8..4065c9b21a 100644
--- a/libavcodec/svq1enc.c
The earlier code had two problems:
1. For reference frames that are not directly output (happens unless
low_delay is set), the mb skip values referred to the next reference
frame to be decoded.
2. For non-reference frames, every macroblock was always considered
skipped.
This makes the output (worse
It is not a stream property, but a property of an individual picture
(in fact, it is only set by the FLV decoder that does not even support
frame threading).
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo_dec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/mpegvideo_d
It is always allocated in ff_mpv_frame_start(), so the only
reason to put it into ff_mpeg_update_thread_context()
would be for the case that a frame-threaded decoder
that supports coded fields implements frame-threading.
The only mpegvideo-decoders supporting coded fields
are MPEG-1/2 and VC-1. Th
They are no longer used by the MPEG-1/2 decoders except when
using lowres.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpeg12dec.c | 4
libavcodec/mpegpicture.h | 10 ++
2 files changed, 14 insertions(+)
diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c
index e0e
There is no reason to use a temporary buffer as destination
for the new macroblock before copying it into its proper place.
(History: 3994623df2efd2749631c3492184dd8d4ffa9d1b changed
the precursor of ff_mpv_reconstruct_mb() to always decode
to the first row of macroblocks for B pictures when
a dra
Broken in 5ecf5b93dda9d0c69875b80d28929f0d97dd7d06.
More precisely, 3994623df2efd2749631c3492184dd8d4ffa9d1b changed
the precursor of ff_mpv_reconstruct_mb() to always decode
to the first row of macroblocks for B pictures when
a draw_horiz_band callback is set and to (they are exported to
the call
The new value will be overwritten in ff_set_qscale() below.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo_enc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index 6d26b2d619..125d16e694 100644
--- a
Calling it is the first thing ff_clean_h263_qscales() and
ff_clean_mpeg4_qscales() do anyway.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h263enc.h | 1 -
libavcodec/ituh263enc.c| 2 --
libavcodec/mpegvideo_enc.c | 6 +++---
3 files changed, 3 insertions(+), 6 deletions(-)
diff -
A MECmpContext is quite big (792B here) and given
how ff_update_duplicate_context() works, it is (unfortunately)
copied quite frequently when using slice threading.
Therefore keep only what is needed from MECmpContext
and remove MECmpContext from MpegEncContext.
Signed-off-by: Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo.h | 1 +
libavcodec/mpegvideo_enc.c | 23 +++
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/libavcodec/mpegvideo.h b/libavcodec/mpegvideo.h
index 44695776ad..79c5561793 100644
--- a/libavcodec/m
Not every function will be set, so zero the context
to initialize everything.
This also allows to remove an initialization in dvenc.c.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/dvenc.c| 1 -
libavcodec/me_cmp.c | 2 ++
libavcodec/tests/motion.c | 2 --
tests/checkasm/motion
This avoids using MpegEncContext.mecc; it already allows
to avoid touching the latter for snowenc and svq1enc.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/motion_est.c | 7 +--
libavcodec/motion_est.h | 3 +++
libavcodec/snowenc.c| 1 -
libavcodec/svq1enc.c| 1 -
4 files changed
Several of the potential choices of comparison functions
need an initialized MpegEncContext (initialized for encoding,
not only ff_mpv_common_init()) or they crash when called.
Modify ff_set_cmp() to check for this.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/dvenc.c | 2 +-
libav
MECmpContext.ildct_cmp is an array of function pointers that
are not set by ff_me_cmp_init(), but that are set by users
to one of the other arrays via ff_set_cmp().
Remove these pointers from MECmpContext and add pointers
for the actually used functions to its users. (The DV encoder
already did so
MECmpContext has several arrays of function pointers that
are not set by ff_me_cmp_init(), but that are set by users
to one of the other arrays via ff_set_cmp().
One of these other users is mpegvideo_enc; it is the only user
of MECmpContext.frame_skip_cmp and it only uses one of these
function poi
MECmpContext has several arrays of function pointers that
are not set by ff_me_cmp_init(), but that are set by users
to one of the other arrays via ff_set_cmp().
One of these other users is the motion estimation API.
It uses MECmpContext.(me_pre|me|me_sub|mb)_cmp. It is
basically the only user of
Signed-off-by: Andreas Rheinhardt
---
libavcodec/me_cmp.c | 2 +-
libavcodec/me_cmp.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/me_cmp.c b/libavcodec/me_cmp.c
index 670103cc05..cff8936e44 100644
--- a/libavcodec/me_cmp.c
+++ b/libavcodec/me_cmp.c
@@ -473,7
The majority of the stuff performed in it needs to be done only
once; so factor it out into a function of its own to be called
in the user's init function.
Also avoid using MpegEncContext in it, to separate the two
a bit more.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/motion_est.c| 89
Not every type of comparison function implements every function.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/dvenc.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/libavcodec/dvenc.c b/libavcodec/dvenc.c
index 3afeedbb87..08ed53d823 100644
--- a/
Not all compare functions are implemented for all compare function
types. Therefore check for the existence of the used functions.
Fixes issue #10245.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo_enc.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/l
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo_enc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index 6ad5b0eb39..11f2a72804 100644
--- a/libavcodec/mpegvideo_enc.c
+++ b/libavcodec/mpegvideo_enc.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/ituh263dec.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/libavcodec/ituh263dec.c b/libavcodec/ituh263dec.c
index 47ad891391..e0f3034e57 100644
--- a/libavcodec/ituh263dec.c
+++ b/libavcodec/ituh263dec.c
@@ -59,7
Possible by using MB_TYPE_CODEC_SPECIFIC for MB_TYPE_ZERO_MV
and due to the MB_TYPE_*_MV flags fitting into an int16_t.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpeg12.c| 42 +-
libavcodec/mpeg12dec.c | 28
libavcod
Possible now that MB_TYPE_L1 (which does not fit into
an int16_t) is no longer used).
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpeg4videodec.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c
index ebbd
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h264dec.h | 8
libavcodec/mpegutils.h | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavcodec/h264dec.h b/libavcodec/h264dec.h
index fc50df90f2..ccd7583bf4 100644
--- a/libavcodec/h264dec.h
+++ b/libavcode
MB_TYPE_L[01] is based upon H.264 terminology (it stands for
list); yet the mpegvideo based decoders don't have lists
of reference frames, they have at most one forward and one
backward reference. So use terminology based upon this.
This also has a second advantage: MB_TYPE_L[01] is actually
an OR
SVQ3 does not call ff_print_debug_info2().
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegutils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c
index 4b1bcaa995..acc4989aba 100644
--- a/libavcodec/mpegutils.c
+++ b/libav
The "invalid mtype index" here is always -1, because that is
the value the VLC api uses for not existent leafs in an incomplete tree.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h261dec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavcodec/h261dec.c b/libavcodec
This is possible now that MB_TYPE_CBP and MB_TYPE_QUANT
fit into an int16_t; only MB_TYPE_H261_FIL needs to
be remapped to MB_TYPE_CODEC_SPECIFIC.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h261.h | 5 +++--
libavcodec/h261data.c | 2 +-
libavcodec/h261dec.c | 9 -
3 files cha
Do this to make MB_TYPE_{CBP,QUANT} fit into an int16_t,
so that can be used in a VLC symbol table.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegutils.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/mpegutils.h b/libavcodec/mpegutils.h
index 0cca4
MB_TYPE_ACPRED is currently reused for MB_TYPE_REF0 by H.264,
so that the value fits into an uint16_t. Given that MB_TYPE_ACPRED
is not subject to any such restriction (apart from fitting into
32bits), it can be remapped to a hithereto unused bit.
The then available bit will be declared to be codec
Obsolete since 3ceffe783965767e62d59e8e68ecd265c98460ec.
Signed-off-by: Andreas Rheinhardt
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 83284427df..3525d9991c 100755
--- a/configure
+++ b/configure
@@ -3019,7 +3019,7 @@ mpeg1video_
Everything except dct_unquantize_intra for MPEG-4 need only
be set once.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/h263dec.c | 8
libavcodec/mpegvideo_dec.c | 21 +++--
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/libavcodec/h263dec.c b/
Set them in ff_mpv_idct_init() so that they are already set
in ff_mpv_decode_init(). This is in preparation for avoiding
to set dct_unquantize in every ff_mpv_frame_start().
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo.c | 54 +-
1 file chang
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 4fe9350c40..bbee9a5f61 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -273,7 +273,7 @@ sta
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo_enc.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index eda2305630..6ad5b0eb39 100644
--- a/libavcodec/mpegvideo_enc.c
+++ b/libavcodec/mpegvideo_e
---
configure | 14 ++
libavcodec/Makefile | 7 +
libavcodec/allcodecs.c| 7 +
libavcodec/mediacodecdec.c| 215 ++-
libavcodec/mediacodecdec_common.c | 333 +++---
5 files changed, 545 insertions
Submitting a buffer with a negative timestamp seems to stall the Mediacodec
audio
decoders.
---
libavcodec/mediacodecdec_common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/mediacodecdec_common.c
b/libavcodec/mediacodecdec_common.c
index d6f91e6e89..4d22db8ecf 100644
--- a/
1 - 100 of 114 matches
Mail list logo
