checkasm: bench runs 131072 (1 << 17)
h264_idct4_add_dc_8bpp_c: 1.5
h264_idct4_add_dc_8bpp_rvv_i64: 0.7
h264_idct4_add_dc_9bpp_c: 1.5
h264_idct4_add_dc_9bpp_rvv_i64: 0.7
h264_idct4_add_dc_10bpp_c: 1.5
h264_idct4_add_dc_10bpp_rvv_i64: 0.7
h264_idct4_add_dc_12bpp_c: 1.2
h264_idct4_add_dc_12bpp_rvv_i6
Returning a void is not allowed by the spec. Just return instead.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/vvc/inter.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c
index 98cb43322f..aaf3230c1e 100644
--- a/li
On 07/06/2024 18:48, Lynne wrote:
On 07/06/2024 17:22, Wu, Tong1 wrote:
From: ffmpeg-devel On Behalf Of Lynne
via ffmpeg-devel
Sent: Friday, June 7, 2024 11:10 PM
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne
Subject: Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move
the dpb logic from V
On Sat, Jun 08, 2024 at 08:17:54PM -0400, Leo Izen wrote:
> int idx, and int first_tcx_flag are set but not used, so this commit
> removes their declarations and assignments.
>
> Signed-off-by: Leo Izen
> ---
> libavcodec/aac/aacdec_lpd.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(
On Sun, Jun 09, 2024 at 03:10:09PM +0200, Vittorio Giovara wrote:
> On Sun, Jun 9, 2024 at 12:50 AM Timo Rothenpieler
> wrote:
>
> > On 08.06.2024 21:49, Vittorio Giovara wrote:
> > > On Sat, Jun 8, 2024 at 6:02 PM Michael Niedermayer <
> > mich...@niedermayer.cc>
> > > wrote:
> > >
> > >> On Tue
On Sun, Jun 09, 2024 at 12:49:57AM +0200, Timo Rothenpieler wrote:
> On 08.06.2024 21:49, Vittorio Giovara wrote:
> > On Sat, Jun 8, 2024 at 6:02 PM Michael Niedermayer
> > wrote:
> >
> > > On Tue, May 14, 2024 at 01:38:16AM +0200, Michael Niedermayer wrote:
> > > > Hi all
> > > >
> > > > To kee
Hi,
Attached is a patch to do proper removal of support for the DEC Alpha.
I hope it is not mangled.
Side note: it seems GMail now prevents sending patches directly with
git send-email -- I really wish we could move to a CI platform like
GitLab or Gitea.
-- Sean McGovern
From 68d2bc76dfd8d153de5
Video devices categorized by AVFoundation as
'AVCaptureDeviceTypeExternal(Unknown)' (like USB video streams) were not
recognized by libavdevice.
Signed-off-by: Theo Fabi
---
libavdevice/avfoundation.m | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavdevice/avfoundation.m b/libavdevice
Add check for av_packet_new_side_data() to avoid null pointer dereference if
allocation fails.
Fixes: bdc1220eeb ("h263enc: Add an option for outputting info about MBs as
side data")
Signed-off-by: Jiasheng Jiang
---
libavcodec/mpegvideo_enc.c | 2 ++
1 file changed, 2 insertions(+)
diff --gi
BeforeAfter
-
make fate-vvc CPU Time (No ASM) 131.52s 134.83s
libavcodec/vvc/* Line Coverage 95.3%96.9%
inter_template.c Line Coverage 74.3%88.2%
inter.c Line Coverage 85.3%99.2%
Le sunnuntaina 9. kesäkuuta 2024, 19.13.54 EEST Andreas Rheinhardt a écrit :
> Rémi Denis-Courmont:
> > ---
> >
> > libavcodec/mpegvideo.c | 30 +-
> > 1 file changed, 5 insertions(+), 25 deletions(-)
> >
> > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.
Rémi Denis-Courmont:
> ---
> libavcodec/mpegvideo.c | 30 +-
> 1 file changed, 5 insertions(+), 25 deletions(-)
>
> diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
> index 7af823b8bd..fa25d14970 100644
> --- a/libavcodec/mpegvideo.c
> +++ b/libavcodec/mpeg
T-Head C908:
h263dsp.dct_unquantize_inter_c: 3.7
h263dsp.dct_unquantize_inter_rvv_i32: 1.7
h263dsp.dct_unquantize_intra_c: 4.0
h263dsp.dct_unquantize_intra_rvv_i32: 2.0
SpacemiT X60:
h263dsp.dct_unquantize_inter_c: 3.5
h263dsp.dct_unquantize_inter_rvv_i32: 0.7
h263dsp.dct_unquant
---
tests/checkasm/h263dsp.c | 47 +++-
1 file changed, 46 insertions(+), 1 deletion(-)
diff --git a/tests/checkasm/h263dsp.c b/tests/checkasm/h263dsp.c
index 2d0957a90b..b21854d061 100644
--- a/tests/checkasm/h263dsp.c
+++ b/tests/checkasm/h263dsp.c
@@ -18,13
---
libavcodec/mpegvideo.c | 44 ++
1 file changed, 10 insertions(+), 34 deletions(-)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 7af823b8bd..9be0fecc8d 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -201,13 +201,
Note that optimised implementations of these functions will be taken
into actual use only if MpegEncContext.dct_unquantize_h263_{inter,intra}
are *not* overloaded by existing optimisations.
---
Compared to version 2, this separates inter and intra functions to
ease writing aligned-dependent optimi
Video devices categorized by AVFoundation as
'AVCaptureDeviceTypeExternal(Unknown)' (like USB video streams) were not
recognized by libavdevice.
Signed-off-by: Theo Fabi
---
libavdevice/avfoundation.m | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavdevice/avfoundation.m b/libavdevice/a
Le sunnuntaina 9. kesäkuuta 2024, 18.36.35 EEST James Almer a écrit :
> I obviously don't have that kind of information. You'd need to look at
> things like Steam's, Firefox's or Chrome's hardware surveys.
As discussed on IRC yesterday, Steam claims that 106.85% of processors support
SSE2 (and as
On Sun, Jun 9, 2024 at 6:41 AM James Almer wrote:
>
> On 6/9/2024 2:56 AM, Pierre-Anthony Lemieux wrote:
> > On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote:
> >>
> >> On 6/8/2024 9:59 PM, p...@sandflow.com wrote:
> >>> From: Pierre-Anthony Lemieux
> >>>
> >>> If `--toolchain=valgrind-memcheck
Fixes: CID1197065 Resource leak
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavfilter/af_aderivative.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavfilter/af_aderivative.c b/libavfilter/af_aderivative.c
index eeaa23ff88d..4883972dcf1 100644
--- a/libavf
This is unlikely to make a difference
Fixes: CID1591896 Unintentional integer overflow
Fixes: CID1591901 Unintentional integer overflow
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libswscale/swscale.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
Fixes: CID1591930 Wrong sizeof argument
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavutil/wchar_filename.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h
index 868a30b5325..23cc92aa2d7 1
Fixes: CID1591944 Wrong sizeof argument
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavutil/hwcontext_dxva2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/hwcontext_dxva2.c b/libavutil/hwcontext_dxva2.c
index 03cb739a7f2..0b76966ebf
Fixes: CID1598558 Resource leak
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavutil/hwcontext_d3d11va.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c
index c04ab01a282..9b3c5f389fa 100644
--- a/lib
Fixes: CID1591909 Wrong sizeof argument
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavutil/hwcontext_d3d11va.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c
index 8963c9fc85b..c04a
Le sunnuntaina 9. kesäkuuta 2024, 12.27.06 EEST Rémi Denis-Courmont a écrit :
> To preserve the alignment promise of the block base address, we pass
> the start offset separately (it is either 0 or 1).
>
> Note that optimised implementations of this function will be taken into
> actual use if Mpeg
On 6/8/2024 12:55 PM, Andreas Rheinhardt wrote:
James Almer:
On 6/6/2024 11:48 AM, Andreas Rheinhardt wrote:
James Almer:
And remove shuffle_bytes_2103_mmxext.
shuffle_bytes_0321_c: 28.1
shuffle_bytes_0321_sse2: 13.6
shuffle_bytes_0321_ssse3: 9.6
shuffle_bytes_0321_avx2: 7.1
shuffle_bytes_123
From: Niklas Haas
This is used by future versions of the spec to implement metadata
compression. Given that we don't yet implement that spec, validate that
this is equal to 0 for now.
---
libavcodec/dovi_rpudec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavcodec/d
From: Niklas Haas
In the spec, dm_metadata_present also toggles all extension blocks, so
we need to move them inside the branch.
---
libavcodec/dovi_rpudec.c | 25 +
libavcodec/dovi_rpuenc.c | 21 -
2 files changed, 25 insertions(+), 21 deletions(-)
d
From: Niklas Haas
Only flush state when we started parsing data, otherwise just error out.
Remove the 'fail' label to make this a bit less confusing to read.
---
libavcodec/dovi_rpudec.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/libavcodec/dovi
From: Niklas Haas
Despite the suggestive size limits, this metadata ID has nothing to do
with the VDR metadata ID used for the data mappings. Actually, the
specification leaves them wholly unexplained, other than acknowleding
their existence. Must be some secret dolby sauce. They're not even
invo
From: Niklas Haas
When this is 0, the metadata is explicitly inferred to stated default
values from the spec, rather than inferred from the previous frame's
values.
Likewise, when encoding, instead of checking if the value changed since
the last frame, we need to check if it differs from the def
From: Niklas Haas
According to the spec, missing previous VDR RPU IDs do not constitute an
error, but we should instead fallback first to VDR RPU with ID 0, and
failing that, synthesize "neutral" metadata.
That's nontrivial though as the resulting metadata will be dependent on
other properties o
From: Niklas Haas
Storing the color metadata alongside the data mapping is no longer
needed, so we can simplify this array's type.
---
libavcodec/dovi_rpu.h| 7 +--
libavcodec/dovi_rpudec.c | 6 +++---
libavcodec/dovi_rpuenc.c | 10 +-
3 files changed, 9 insertions(+), 14 delet
From: Niklas Haas
Move `vdr` into local scope and point only to the field we actually care
about.
---
libavcodec/dovi_rpudec.c | 35 ---
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/libavcodec/dovi_rpudec.c b/libavcodec/dovi_rpudec.c
index 3e154
On 6/9/2024 2:56 AM, Pierre-Anthony Lemieux wrote:
On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote:
On 6/8/2024 9:59 PM, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
If `--toolchain=valgrind-memcheck` is selected, fate-lavf-asf fails on a false
positive.
I can't reproduce this
On Sat, Jun 8, 2024 at 9:58 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Vittorio Giovara:
> > On Sat, Jun 8, 2024 at 9:45 PM Andreas Rheinhardt <
> > andreas.rheinha...@outlook.com> wrote:
> >
> >> Andreas Rheinhardt:
> >>> Signed-off-by: Andreas Rheinhardt
> >>> ---
> >>> l
On Sun, Jun 9, 2024 at 12:50 AM Timo Rothenpieler
wrote:
> On 08.06.2024 21:49, Vittorio Giovara wrote:
> > On Sat, Jun 8, 2024 at 6:02 PM Michael Niedermayer <
> mich...@niedermayer.cc>
> > wrote:
> >
> >> On Tue, May 14, 2024 at 01:38:16AM +0200, Michael Niedermayer wrote:
> >>> Hi all
> >>>
>
This seems to have been omitted in
880e2aa23645ed9871c66ee1cbd00f93c72d2d73.
---
configure | 5 -
1 file changed, 5 deletions(-)
diff --git a/configure b/configure
index e69ed55837..4e27e6fd2b 100755
--- a/configure
+++ b/configure
@@ -2130,7 +2130,6 @@ ARCH_LIST="
aarch64
alpha
The vendor has long since switched to Arm, wit the last product reaching
their official end-of-life over 11 years ago. Linux support for the ISA
was dropped 7 years ago. More importantly, this architecture was never
supported by upstream GCC, and the vendor fork is stuck at version 4.2,
which FFmpe
On the top of p. 112 in VVC (09/2023):
It is a requirement of bitstream conformance that the values of
qpInVal[ i ][ j ] and qpOutVal[ i ][ j ] shall be in the range
of −QpBdOffset to 63, inclusive for i in the range of 0 to
numQpTables − 1, inclusive, and j in the range of 0 to
sps_num_points_in_
I would have reordered the code to avoid forward declarations, but LGTM.
--
雷米‧德尼-库尔蒙
http://www.remlab.net/
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or ema
Always false since 49331f7ba3e3214738864af96d22fb1e6b5463b7.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/dnxhdenc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c
index 028604a6e5..8b67becbe2 100644
--- a/libavcodec/dnxhdenc.c
+++ b/libav
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo_enc.c | 4 +---
libavcodec/mpegvideoenc.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index b7c1f08b0f..46ef693abe 100644
--- a/libavcodec/mpegvideo_enc.c
It has been added in 3a87ac948f0cd95218e62d5a98b8b8d5e4c11366,
but there was never an implementation different from the ordinary
dct_quantize of it.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/me_cmp.c| 6 +++---
libavcodec/mpegvideo.h | 1 -
libavcodec/mpegvideo_enc.c | 1 -
3
Use the common approach whereby the _c versions are set first
and then (potentially) overwritten by the arch-specific ones
instead of calling the arch-specific code first, followed by
setting the function pointers that have not already been set.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/m
The C version is set in ff_dct_encode_init(), yet the MIPS version
is set in dct_init() (in ff_mpv_common_init() and therefore also
for decoders). This commit fixes this inconsistency.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mips/Makefile | 4 +-
libavcodec/mips/mpegvid
Signed-off-by: Andreas Rheinhardt
---
libavcodec/ituh263enc.c| 4
libavcodec/mpegvideo_enc.c | 2 --
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c
index 97abfb3f45..72c2288ebe 100644
--- a/libavcodec/ituh263enc.c
+++ b/li
Only used here.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/mpegvideo_enc.c | 13 -
libavcodec/mpegvideoenc.h | 1 -
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index 82bab43e14..45b6fdd3f0 100644
--- a
Rémi Denis-Courmont:
> Le sunnuntaina 9. kesäkuuta 2024, 12.26.50 EEST Andreas Rheinhardt a écrit :
>> The two refers to the functions that are set by ff_dct_encode_init():
>> dct_quantize and denoise_dct (the other one). It does not involve
>> dct_unquantize at all.
>
> I don't think that the pat
Le sunnuntaina 9. kesäkuuta 2024, 12.26.50 EEST Andreas Rheinhardt a écrit :
> The two refers to the functions that are set by ff_dct_encode_init():
> dct_quantize and denoise_dct (the other one). It does not involve
> dct_unquantize at all.
I don't think that the patchset implies any involvement
T-Head C908:
h263dsp.dct_unquantize_inter_c: 5.7
h263dsp.dct_unquantize_inter_rvv_i32: 2.7
h263dsp.dct_unquantize_intra_c: 5.7
h263dsp.dct_unquantize_intra_rvv_i32: 3.0
SpacemiT X60:
h263dsp.dct_unquantize_inter_c: 5.0
h263dsp.dct_unquantize_inter_rvv_i32: 1.2
h263dsp.dct_unquant
---
tests/checkasm/h263dsp.c | 46 +++-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/tests/checkasm/h263dsp.c b/tests/checkasm/h263dsp.c
index 2d0957a90b..546204cb28 100644
--- a/tests/checkasm/h263dsp.c
+++ b/tests/checkasm/h263dsp.c
@@ -18,13
---
libavcodec/mpegvideo.c | 30 +-
1 file changed, 5 insertions(+), 25 deletions(-)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 7af823b8bd..fa25d14970 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -201,7 +201,7 @@ static vo
To preserve the alignment promise of the block base address, we pass
the start offset separately (it is either 0 or 1).
Note that optimised implementations of this function will be taken into
actual use if MpegEncContext.dct_unquantize_h263_{inter,intra} are *not*
overloaded by existing optimisati
Rémi Denis-Courmont:
> Le sunnuntaina 9. kesäkuuta 2024, 11.39.55 EEST Andreas Rheinhardt a écrit :
>> Andreas Rheinhardt:
>>> Rémi Denis-Courmont:
On entry the function pointer is always NULL. We just need to set the
pointer before probing x86 CPU optimisations.
>>>
>>> Incorrect:
>>> ht
Le sunnuntaina 9. kesäkuuta 2024, 11.39.55 EEST Andreas Rheinhardt a écrit :
> Andreas Rheinhardt:
> > Rémi Denis-Courmont:
> >> On entry the function pointer is always NULL. We just need to set the
> >> pointer before probing x86 CPU optimisations.
> >
> > Incorrect:
> > https://github.com/mkver/
Andreas Rheinhardt:
> Rémi Denis-Courmont:
>> On entry the function pointer is always NULL. We just need to set the
>> pointer before probing x86 CPU optimisations.
>>
>
> Incorrect:
> https://github.com/mkver/FFmpeg/commit/d22d4ee8419788f9bb239a21e276cebce0891737
> (see also
> https://github.com/
Rémi Denis-Courmont:
> On entry the function pointer is always NULL. We just need to set the
> pointer before probing x86 CPU optimisations.
>
Incorrect:
https://github.com/mkver/FFmpeg/commit/d22d4ee8419788f9bb239a21e276cebce0891737
(see also
https://github.com/mkver/FFmpeg/commits/mpegvideo_poo
On entry the function pointer is always NULL. We just need to set the
pointer before probing x86 CPU optimisations.
Note that there is a third code path setting this function pointer, but
it does so *after* calling this function: the DNxHD encoder.
---
libavcodec/mpegvideo_enc.c | 3 +--
1 file c
---
libavcodec/mpegvideo_enc.c | 9 -
libavcodec/mpegvideoenc.h | 1 -
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index dd92f0a3af..af04db70d8 100644
--- a/libavcodec/mpegvideo_enc.c
+++ b/libavcodec/mpegvideo_enc
No functional changes.
---
libavcodec/mpegvideo_enc.c | 166 ++---
1 file changed, 83 insertions(+), 83 deletions(-)
diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
index 82bab43e14..dd92f0a3af 100644
--- a/libavcodec/mpegvideo_enc.c
+++ b/liba
dct_quantize cannot be NULL here. The call to ff_dct_encode_init() would
initialized it to a non-NULL value already.
---
libavcodec/dnxhdenc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c
index 0cb25d7714..681fb738c0 100644
--- a/libavcodec/dn
Meh. This breaks FATE... on platforms that don't have an optimise function
already.
--
レミ・デニ-クールモン
http://www.remlab.net/
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link
64 matches
Mail list logo