[FFmpeg-devel] [PATCH] avcodec/riscv: add h264 dc idct rvv

2024-06-09 Thread J. Dekker
checkasm: bench runs 131072 (1 << 17) h264_idct4_add_dc_8bpp_c: 1.5 h264_idct4_add_dc_8bpp_rvv_i64: 0.7 h264_idct4_add_dc_9bpp_c: 1.5 h264_idct4_add_dc_9bpp_rvv_i64: 0.7 h264_idct4_add_dc_10bpp_c: 1.5 h264_idct4_add_dc_10bpp_rvv_i64: 0.7 h264_idct4_add_dc_12bpp_c: 1.2 h264_idct4_add_dc_12bpp_rvv_i6

[FFmpeg-devel] [PATCH] avcodec/vvc/inter: Don't return void

2024-06-09 Thread Andreas Rheinhardt
Returning a void is not allowed by the spec. Just return instead. Signed-off-by: Andreas Rheinhardt --- libavcodec/vvc/inter.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 98cb43322f..aaf3230c1e 100644 --- a/li

Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer

2024-06-09 Thread Lynne via ffmpeg-devel
On 07/06/2024 18:48, Lynne wrote: On 07/06/2024 17:22, Wu, Tong1 wrote: From: ffmpeg-devel On Behalf Of Lynne via ffmpeg-devel Sent: Friday, June 7, 2024 11:10 PM To: ffmpeg-devel@ffmpeg.org Cc: Lynne Subject: Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from V

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_lpd: remove unused local variables

2024-06-09 Thread Michael Niedermayer
On Sat, Jun 08, 2024 at 08:17:54PM -0400, Leo Izen wrote: > int idx, and int first_tcx_flag are set but not used, so this commit > removes their declarations and assignments. > > Signed-off-by: Leo Izen > --- > libavcodec/aac/aacdec_lpd.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(

Re: [FFmpeg-devel] [WIP] False positives on Coverity

2024-06-09 Thread Michael Niedermayer
On Sun, Jun 09, 2024 at 03:10:09PM +0200, Vittorio Giovara wrote: > On Sun, Jun 9, 2024 at 12:50 AM Timo Rothenpieler > wrote: > > > On 08.06.2024 21:49, Vittorio Giovara wrote: > > > On Sat, Jun 8, 2024 at 6:02 PM Michael Niedermayer < > > mich...@niedermayer.cc> > > > wrote: > > > > > >> On Tue

Re: [FFmpeg-devel] [WIP] False positives on Coverity

2024-06-09 Thread Michael Niedermayer
On Sun, Jun 09, 2024 at 12:49:57AM +0200, Timo Rothenpieler wrote: > On 08.06.2024 21:49, Vittorio Giovara wrote: > > On Sat, Jun 8, 2024 at 6:02 PM Michael Niedermayer > > wrote: > > > > > On Tue, May 14, 2024 at 01:38:16AM +0200, Michael Niedermayer wrote: > > > > Hi all > > > > > > > > To kee

[FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-09 Thread Sean McGovern
Hi, Attached is a patch to do proper removal of support for the DEC Alpha. I hope it is not mangled. Side note: it seems GMail now prevents sending patches directly with git send-email -- I really wish we could move to a CI platform like GitLab or Gitea. -- Sean McGovern From 68d2bc76dfd8d153de5

[FFmpeg-devel] [PATCH v2] avdevice/avfoundation: add external video devices

2024-06-09 Thread Theo Fabi
Video devices categorized by AVFoundation as 'AVCaptureDeviceTypeExternal(Unknown)' (like USB video streams) were not recognized by libavdevice. Signed-off-by: Theo Fabi --- libavdevice/avfoundation.m | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice

[FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: Add check for av_packet_new_side_data()

2024-06-09 Thread Jiasheng Jiang
Add check for av_packet_new_side_data() to avoid null pointer dereference if allocation fails. Fixes: bdc1220eeb ("h263enc: Add an option for outputting info about MBs as side data") Signed-off-by: Jiasheng Jiang --- libavcodec/mpegvideo_enc.c | 2 ++ 1 file changed, 2 insertions(+) diff --gi

[FFmpeg-devel] [PATCH] fate/vvc: add vvc-conformance-RPR_A_Alibaba_4

2024-06-09 Thread Frank Plowman
BeforeAfter - make fate-vvc CPU Time (No ASM) 131.52s 134.83s libavcodec/vvc/* Line Coverage 95.3%96.9% inter_template.c Line Coverage 74.3%88.2% inter.c Line Coverage 85.3%99.2%

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-09 Thread Rémi Denis-Courmont
Le sunnuntaina 9. kesäkuuta 2024, 19.13.54 EEST Andreas Rheinhardt a écrit : > Rémi Denis-Courmont: > > --- > > > > libavcodec/mpegvideo.c | 30 +- > > 1 file changed, 5 insertions(+), 25 deletions(-) > > > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.

Re: [FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-09 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > --- > libavcodec/mpegvideo.c | 30 +- > 1 file changed, 5 insertions(+), 25 deletions(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index 7af823b8bd..fa25d14970 100644 > --- a/libavcodec/mpegvideo.c > +++ b/libavcodec/mpeg

[FFmpeg-devel] [PATCH 4/4] lavc/h263dsp: R-V V dct_unquantize_{intra, inter}

2024-06-09 Thread Rémi Denis-Courmont
T-Head C908: h263dsp.dct_unquantize_inter_c: 3.7 h263dsp.dct_unquantize_inter_rvv_i32: 1.7 h263dsp.dct_unquantize_intra_c: 4.0 h263dsp.dct_unquantize_intra_rvv_i32: 2.0 SpacemiT X60: h263dsp.dct_unquantize_inter_c: 3.5 h263dsp.dct_unquantize_inter_rvv_i32: 0.7 h263dsp.dct_unquant

[FFmpeg-devel] [PATCH 3/4] checkasm/h263dsp: test dct_unquantize_{intra, inter}

2024-06-09 Thread Rémi Denis-Courmont
--- tests/checkasm/h263dsp.c | 47 +++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/h263dsp.c b/tests/checkasm/h263dsp.c index 2d0957a90b..b21854d061 100644 --- a/tests/checkasm/h263dsp.c +++ b/tests/checkasm/h263dsp.c @@ -18,13

[FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-09 Thread Rémi Denis-Courmont
--- libavcodec/mpegvideo.c | 44 ++ 1 file changed, 10 insertions(+), 34 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 7af823b8bd..9be0fecc8d 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -201,13 +201,

[FFmpeg-devel] [PATCHv3 1/4] lavc/h263dsp: add DCT dequantisation functions

2024-06-09 Thread Rémi Denis-Courmont
Note that optimised implementations of these functions will be taken into actual use only if MpegEncContext.dct_unquantize_h263_{inter,intra} are *not* overloaded by existing optimisations. --- Compared to version 2, this separates inter and intra functions to ease writing aligned-dependent optimi

[FFmpeg-devel] [PATCH] avdevice/avfoundation: add external video devices

2024-06-09 Thread Theo Fabi
Video devices categorized by AVFoundation as 'AVCaptureDeviceTypeExternal(Unknown)' (like USB video streams) were not recognized by libavdevice. Signed-off-by: Theo Fabi --- libavdevice/avfoundation.m | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice/a

Re: [FFmpeg-devel] [PATCH] swscale/x86/rgb2rgb: add SSE2 shuffle_bytes functions

2024-06-09 Thread Rémi Denis-Courmont
Le sunnuntaina 9. kesäkuuta 2024, 18.36.35 EEST James Almer a écrit : > I obviously don't have that kind of information. You'd need to look at > things like Steam's, Firefox's or Chrome's hardware surveys. As discussed on IRC yesterday, Steam claims that 106.85% of processors support SSE2 (and as

Re: [FFmpeg-devel] [PATCH] configure: remove false positives with valgrind-memcheck

2024-06-09 Thread Pierre-Anthony Lemieux
On Sun, Jun 9, 2024 at 6:41 AM James Almer wrote: > > On 6/9/2024 2:56 AM, Pierre-Anthony Lemieux wrote: > > On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote: > >> > >> On 6/8/2024 9:59 PM, p...@sandflow.com wrote: > >>> From: Pierre-Anthony Lemieux > >>> > >>> If `--toolchain=valgrind-memcheck

[FFmpeg-devel] [PATCH 6/6] avfilter/af_aderivative: Free out on error

2024-06-09 Thread Michael Niedermayer
Fixes: CID1197065 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavfilter/af_aderivative.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/af_aderivative.c b/libavfilter/af_aderivative.c index eeaa23ff88d..4883972dcf1 100644 --- a/libavf

[FFmpeg-devel] [PATCH 5/6] swscale/swscale: Use ptrdiff_t for linesize computations

2024-06-09 Thread Michael Niedermayer
This is unlikely to make a difference Fixes: CID1591896 Unintentional integer overflow Fixes: CID1591901 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libswscale/swscale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[FFmpeg-devel] [PATCH 4/6] avutil/wchar_filename: Correct sizeof

2024-06-09 Thread Michael Niedermayer
Fixes: CID1591930 Wrong sizeof argument Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/wchar_filename.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/wchar_filename.h b/libavutil/wchar_filename.h index 868a30b5325..23cc92aa2d7 1

[FFmpeg-devel] [PATCH 3/6] avutil/hwcontext_d3d11va: correct sizeof IDirect3DSurface9

2024-06-09 Thread Michael Niedermayer
Fixes: CID1591944 Wrong sizeof argument Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/hwcontext_dxva2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hwcontext_dxva2.c b/libavutil/hwcontext_dxva2.c index 03cb739a7f2..0b76966ebf

[FFmpeg-devel] [PATCH 2/6] avutil/hwcontext_d3d11va: Free AVD3D11FrameDescriptor on error

2024-06-09 Thread Michael Niedermayer
Fixes: CID1598558 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/hwcontext_d3d11va.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c index c04ab01a282..9b3c5f389fa 100644 --- a/lib

[FFmpeg-devel] [PATCH 1/6] avutil/hwcontext_d3d11va: correct sizeof AVD3D11FrameDescriptor

2024-06-09 Thread Michael Niedermayer
Fixes: CID1591909 Wrong sizeof argument Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/hwcontext_d3d11va.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c index 8963c9fc85b..c04a

Re: [FFmpeg-devel] [PATCHv2 1/4] lavc/h263dsp: add DCT dequantisation function

2024-06-09 Thread Rémi Denis-Courmont
Le sunnuntaina 9. kesäkuuta 2024, 12.27.06 EEST Rémi Denis-Courmont a écrit : > To preserve the alignment promise of the block base address, we pass > the start offset separately (it is either 0 or 1). > > Note that optimised implementations of this function will be taken into > actual use if Mpeg

Re: [FFmpeg-devel] [PATCH] swscale/x86/rgb2rgb: add SSE2 shuffle_bytes functions

2024-06-09 Thread James Almer
On 6/8/2024 12:55 PM, Andreas Rheinhardt wrote: James Almer: On 6/6/2024 11:48 AM, Andreas Rheinhardt wrote: James Almer: And remove shuffle_bytes_2103_mmxext. shuffle_bytes_0321_c: 28.1 shuffle_bytes_0321_sse2: 13.6 shuffle_bytes_0321_ssse3: 9.6 shuffle_bytes_0321_avx2: 7.1 shuffle_bytes_123

[FFmpeg-devel] [PATCH 7/8] avcodec/dovi_rpudec: reject reserved_zero_3bits != 0

2024-06-09 Thread Niklas Haas
From: Niklas Haas This is used by future versions of the spec to implement metadata compression. Given that we don't yet implement that spec, validate that this is equal to 0 for now. --- libavcodec/dovi_rpudec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/d

[FFmpeg-devel] [PATCH 6/8] avcodec/dovi_rpu: guard ext blocks by dm_metadata_present

2024-06-09 Thread Niklas Haas
From: Niklas Haas In the spec, dm_metadata_present also toggles all extension blocks, so we need to move them inside the branch. --- libavcodec/dovi_rpudec.c | 25 + libavcodec/dovi_rpuenc.c | 21 - 2 files changed, 25 insertions(+), 21 deletions(-) d

[FFmpeg-devel] [PATCH 8/8] avcodec/dovi_rpudec: handle errors consistently

2024-06-09 Thread Niklas Haas
From: Niklas Haas Only flush state when we started parsing data, otherwise just error out. Remove the 'fail' label to make this a bit less confusing to read. --- libavcodec/dovi_rpudec.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/libavcodec/dovi

[FFmpeg-devel] [PATCH 3/8] avcodec/dovi_rpu: fix dm_metadata_id handling

2024-06-09 Thread Niklas Haas
From: Niklas Haas Despite the suggestive size limits, this metadata ID has nothing to do with the VDR metadata ID used for the data mappings. Actually, the specification leaves them wholly unexplained, other than acknowleding their existence. Must be some secret dolby sauce. They're not even invo

[FFmpeg-devel] [PATCH 2/8] avcodec/dovi_rpu: properly handle vdr_dm_metadata_present

2024-06-09 Thread Niklas Haas
From: Niklas Haas When this is 0, the metadata is explicitly inferred to stated default values from the spec, rather than inferred from the previous frame's values. Likewise, when encoding, instead of checking if the value changed since the last frame, we need to check if it differs from the def

[FFmpeg-devel] [PATCH 1/8] avdovi/dovi_rpudec: handle prev_vdr_rpu_id failures

2024-06-09 Thread Niklas Haas
From: Niklas Haas According to the spec, missing previous VDR RPU IDs do not constitute an error, but we should instead fallback first to VDR RPU with ID 0, and failing that, synthesize "neutral" metadata. That's nontrivial though as the resulting metadata will be dependent on other properties o

[FFmpeg-devel] [PATCH 5/8] avcodec/dovi_rpu: simplify vdr type

2024-06-09 Thread Niklas Haas
From: Niklas Haas Storing the color metadata alongside the data mapping is no longer needed, so we can simplify this array's type. --- libavcodec/dovi_rpu.h| 7 +-- libavcodec/dovi_rpudec.c | 6 +++--- libavcodec/dovi_rpuenc.c | 10 +- 3 files changed, 9 insertions(+), 14 delet

[FFmpeg-devel] [PATCH 4/8] avcodec/dovi_rpudec: simplify vdr handling (cosmetic)

2024-06-09 Thread Niklas Haas
From: Niklas Haas Move `vdr` into local scope and point only to the field we actually care about. --- libavcodec/dovi_rpudec.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/libavcodec/dovi_rpudec.c b/libavcodec/dovi_rpudec.c index 3e154

Re: [FFmpeg-devel] [PATCH] configure: remove false positives with valgrind-memcheck

2024-06-09 Thread James Almer
On 6/9/2024 2:56 AM, Pierre-Anthony Lemieux wrote: On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote: On 6/8/2024 9:59 PM, p...@sandflow.com wrote: From: Pierre-Anthony Lemieux If `--toolchain=valgrind-memcheck` is selected, fate-lavf-asf fails on a false positive. I can't reproduce this

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dnxhdenc: Move PutBitContext from ctx to stack

2024-06-09 Thread Vittorio Giovara
On Sat, Jun 8, 2024 at 9:58 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Vittorio Giovara: > > On Sat, Jun 8, 2024 at 9:45 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Andreas Rheinhardt: > >>> Signed-off-by: Andreas Rheinhardt > >>> --- > >>> l

Re: [FFmpeg-devel] [WIP] False positives on Coverity

2024-06-09 Thread Vittorio Giovara
On Sun, Jun 9, 2024 at 12:50 AM Timo Rothenpieler wrote: > On 08.06.2024 21:49, Vittorio Giovara wrote: > > On Sat, Jun 8, 2024 at 6:02 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > >> On Tue, May 14, 2024 at 01:38:16AM +0200, Michael Niedermayer wrote: > >>> Hi all > >>> >

[FFmpeg-devel] [PATCH] configure: remove stray bfin architecture

2024-06-09 Thread Rémi Denis-Courmont
This seems to have been omitted in 880e2aa23645ed9871c66ee1cbd00f93c72d2d73. --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b/configure index e69ed55837..4e27e6fd2b 100755 --- a/configure +++ b/configure @@ -2130,7 +2130,6 @@ ARCH_LIST=" aarch64 alpha

[FFmpeg-devel] [PATCH] avr32: remove explicit support

2024-06-09 Thread Rémi Denis-Courmont
The vendor has long since switched to Arm, wit the last product reaching their official end-of-life over 11 years ago. Linux support for the ISA was dropped 7 years ago. More importantly, this architecture was never supported by upstream GCC, and the vendor fork is stuck at version 4.2, which FFmpe

[FFmpeg-devel] [PATCH v4] lavc/vvc: Prevent overflow in chroma QP derivation

2024-06-09 Thread Frank Plowman
On the top of p. 112 in VVC (09/2023): It is a requirement of bitstream conformance that the values of qpInVal[ i ][ j ] and qpOutVal[ i ][ j ] shall be in the range of −QpBdOffset to 63, inclusive for i in the range of 0 to numQpTables − 1, inclusive, and j in the range of 0 to sps_num_points_in_

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/mpegvideo_enc: Don't pretend ff_dct_encode_init() can fail

2024-06-09 Thread Rémi Denis-Courmont
I would have reordered the code to avoid forward declarations, but LGTM. -- 雷米‧德尼-库尔蒙 http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or ema

[FFmpeg-devel] [PATCH 1/7] avcodec/dnxhdenc: Remove always-false check

2024-06-09 Thread Andreas Rheinhardt
Always false since 49331f7ba3e3214738864af96d22fb1e6b5463b7. Signed-off-by: Andreas Rheinhardt --- libavcodec/dnxhdenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index 028604a6e5..8b67becbe2 100644 --- a/libavcodec/dnxhdenc.c +++ b/libav

[FFmpeg-devel] [PATCH 7/7] avcodec/mpegvideo_enc: Don't pretend ff_dct_encode_init() can fail

2024-06-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 4 +--- libavcodec/mpegvideoenc.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index b7c1f08b0f..46ef693abe 100644 --- a/libavcodec/mpegvideo_enc.c

[FFmpeg-devel] [PATCH 6/7] avcodec/mpegvideo: Remove fast_dct_quantize

2024-06-09 Thread Andreas Rheinhardt
It has been added in 3a87ac948f0cd95218e62d5a98b8b8d5e4c11366, but there was never an implementation different from the ordinary dct_quantize of it. Signed-off-by: Andreas Rheinhardt --- libavcodec/me_cmp.c| 6 +++--- libavcodec/mpegvideo.h | 1 - libavcodec/mpegvideo_enc.c | 1 - 3

[FFmpeg-devel] [PATCH 5/7] avcodec/mpegvideo_enc: Always set c funcs in ff_dct_encode_init()

2024-06-09 Thread Andreas Rheinhardt
Use the common approach whereby the _c versions are set first and then (potentially) overwritten by the arch-specific ones instead of calling the arch-specific code first, followed by setting the function pointers that have not already been set. Signed-off-by: Andreas Rheinhardt --- libavcodec/m

[FFmpeg-devel] [PATCH 4/7] avcodec/mips/mpegvideo: Set denoise_dct only for encoder

2024-06-09 Thread Andreas Rheinhardt
The C version is set in ff_dct_encode_init(), yet the MIPS version is set in dct_init() (in ff_mpv_common_init() and therefore also for decoders). This commit fixes this inconsistency. Signed-off-by: Andreas Rheinhardt --- libavcodec/mips/Makefile | 4 +- libavcodec/mips/mpegvid

[FFmpeg-devel] [PATCH 3/7] avcodec/mpegvideo_enc: Move initializing H263DSP to ituh263enc.c

2024-06-09 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263enc.c| 4 libavcodec/mpegvideo_enc.c | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c index 97abfb3f45..72c2288ebe 100644 --- a/libavcodec/ituh263enc.c +++ b/li

[FFmpeg-devel] [PATCH 2/7] avcodec/mpegvideo_enc: Make ff_dct_quantize_c() static

2024-06-09 Thread Andreas Rheinhardt
Only used here. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_enc.c | 13 - libavcodec/mpegvideoenc.h | 1 - 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 82bab43e14..45b6fdd3f0 100644 --- a

Re: [FFmpeg-devel] [PATCH 4/4] lavc/mpv_enc: rationalize dct_quantize init

2024-06-09 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Le sunnuntaina 9. kesäkuuta 2024, 12.26.50 EEST Andreas Rheinhardt a écrit : >> The two refers to the functions that are set by ff_dct_encode_init(): >> dct_quantize and denoise_dct (the other one). It does not involve >> dct_unquantize at all. > > I don't think that the pat

Re: [FFmpeg-devel] [PATCH 4/4] lavc/mpv_enc: rationalize dct_quantize init

2024-06-09 Thread Rémi Denis-Courmont
Le sunnuntaina 9. kesäkuuta 2024, 12.26.50 EEST Andreas Rheinhardt a écrit : > The two refers to the functions that are set by ff_dct_encode_init(): > dct_quantize and denoise_dct (the other one). It does not involve > dct_unquantize at all. I don't think that the patchset implies any involvement

[FFmpeg-devel] [PATCH 4/4] lavc/h263dsp: R-V V dct_unquantize

2024-06-09 Thread Rémi Denis-Courmont
T-Head C908: h263dsp.dct_unquantize_inter_c: 5.7 h263dsp.dct_unquantize_inter_rvv_i32: 2.7 h263dsp.dct_unquantize_intra_c: 5.7 h263dsp.dct_unquantize_intra_rvv_i32: 3.0 SpacemiT X60: h263dsp.dct_unquantize_inter_c: 5.0 h263dsp.dct_unquantize_inter_rvv_i32: 1.2 h263dsp.dct_unquant

[FFmpeg-devel] [PATCHv2 3/4] checkasm/h263dsp: test dct_unquantize

2024-06-09 Thread Rémi Denis-Courmont
--- tests/checkasm/h263dsp.c | 46 +++- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/h263dsp.c b/tests/checkasm/h263dsp.c index 2d0957a90b..546204cb28 100644 --- a/tests/checkasm/h263dsp.c +++ b/tests/checkasm/h263dsp.c @@ -18,13

[FFmpeg-devel] [PATCH 2/4] lavc/mpegvideo: use H263DSP dequant function

2024-06-09 Thread Rémi Denis-Courmont
--- libavcodec/mpegvideo.c | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 7af823b8bd..fa25d14970 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -201,7 +201,7 @@ static vo

[FFmpeg-devel] [PATCHv2 1/4] lavc/h263dsp: add DCT dequantisation function

2024-06-09 Thread Rémi Denis-Courmont
To preserve the alignment promise of the block base address, we pass the start offset separately (it is either 0 or 1). Note that optimised implementations of this function will be taken into actual use if MpegEncContext.dct_unquantize_h263_{inter,intra} are *not* overloaded by existing optimisati

Re: [FFmpeg-devel] [PATCH 4/4] lavc/mpv_enc: rationalize dct_quantize init

2024-06-09 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > Le sunnuntaina 9. kesäkuuta 2024, 11.39.55 EEST Andreas Rheinhardt a écrit : >> Andreas Rheinhardt: >>> Rémi Denis-Courmont: On entry the function pointer is always NULL. We just need to set the pointer before probing x86 CPU optimisations. >>> >>> Incorrect: >>> ht

Re: [FFmpeg-devel] [PATCH 4/4] lavc/mpv_enc: rationalize dct_quantize init

2024-06-09 Thread Rémi Denis-Courmont
Le sunnuntaina 9. kesäkuuta 2024, 11.39.55 EEST Andreas Rheinhardt a écrit : > Andreas Rheinhardt: > > Rémi Denis-Courmont: > >> On entry the function pointer is always NULL. We just need to set the > >> pointer before probing x86 CPU optimisations. > > > > Incorrect: > > https://github.com/mkver/

Re: [FFmpeg-devel] [PATCH 4/4] lavc/mpv_enc: rationalize dct_quantize init

2024-06-09 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Rémi Denis-Courmont: >> On entry the function pointer is always NULL. We just need to set the >> pointer before probing x86 CPU optimisations. >> > > Incorrect: > https://github.com/mkver/FFmpeg/commit/d22d4ee8419788f9bb239a21e276cebce0891737 > (see also > https://github.com/

Re: [FFmpeg-devel] [PATCH 4/4] lavc/mpv_enc: rationalize dct_quantize init

2024-06-09 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > On entry the function pointer is always NULL. We just need to set the > pointer before probing x86 CPU optimisations. > Incorrect: https://github.com/mkver/FFmpeg/commit/d22d4ee8419788f9bb239a21e276cebce0891737 (see also https://github.com/mkver/FFmpeg/commits/mpegvideo_poo

[FFmpeg-devel] [PATCH 4/4] lavc/mpv_enc: rationalize dct_quantize init

2024-06-09 Thread Rémi Denis-Courmont
On entry the function pointer is always NULL. We just need to set the pointer before probing x86 CPU optimisations. Note that there is a third code path setting this function pointer, but it does so *after* calling this function: the DNxHD encoder. --- libavcodec/mpegvideo_enc.c | 3 +-- 1 file c

[FFmpeg-devel] [PATCH 3/4] lavc/mpv_enc: privatize ff_dct_quantize_c

2024-06-09 Thread Rémi Denis-Courmont
--- libavcodec/mpegvideo_enc.c | 9 - libavcodec/mpegvideoenc.h | 1 - 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index dd92f0a3af..af04db70d8 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc

[FFmpeg-devel] [PATCH 2/4] lavc/mpvenc: reorder code

2024-06-09 Thread Rémi Denis-Courmont
No functional changes. --- libavcodec/mpegvideo_enc.c | 166 ++--- 1 file changed, 83 insertions(+), 83 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 82bab43e14..dd92f0a3af 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/liba

[FFmpeg-devel] [PATCH 1/4] lavc/dnxhdenc: eliminate dead code

2024-06-09 Thread Rémi Denis-Courmont
dct_quantize cannot be NULL here. The call to ff_dct_encode_init() would initialized it to a non-NULL value already. --- libavcodec/dnxhdenc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index 0cb25d7714..681fb738c0 100644 --- a/libavcodec/dn

Re: [FFmpeg-devel] [PATCH 1/2] lavc/mpegvideo: use H263DSP dequant function

2024-06-09 Thread Rémi Denis-Courmont
Meh. This breaks FATE... on platforms that don't have an optimise function already. -- レミ・デニ-クールモン http://www.remlab.net/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link