---
libavcodec/h263dsp.c | 17 +
libavcodec/h263dsp.h | 2 ++
2 files changed, 19 insertions(+)
diff --git a/libavcodec/h263dsp.c b/libavcodec/h263dsp.c
index 6a13353499..eb990f27bd 100644
--- a/libavcodec/h263dsp.c
+++ b/libavcodec/h263dsp.c
@@ -23,6 +23,22 @@
#include "config.
On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote:
>
> On 6/8/2024 9:59 PM, p...@sandflow.com wrote:
> > From: Pierre-Anthony Lemieux
> >
> > If `--toolchain=valgrind-memcheck` is selected, fate-lavf-asf fails on a
> > false positive.
>
> I can't reproduce this. Tried with both --disable-optimiz
Signed-off-by: Andreas Rheinhardt
---
tests/api/api-band-test.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/api/api-band-test.c b/tests/api/api-band-test.c
index e088d0854a..c3612bedb9 100644
--- a/tests/api/api-band-test.c
+++ b/tests/api/api-band-test.c
@@ -1
Signed-off-by: Andreas Rheinhardt
---
tests/api/api-band-test.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/api/api-band-test.c b/tests/api/api-band-test.c
index d40e31b850..e088d0854a 100644
--- a/tests/api/api-band-test.c
+++ b/tests/api/api-band-test.c
Besides being write only it had the wrong type:
An uint8_t is definitely not enough to store the size
of these buffers.
Signed-off-by: Andreas Rheinhardt
---
tests/api/api-band-test.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/api/api-band-test.c b/tests/api/api-band-test.c
index
The H.264 decoder does not support draw_horiz_band (it does not have
the AV_CODEC_CAP_DRAW_HORIZ_BAND), making ff_h264_draw_horiz_band()
legally dead. The function here always calls draw_horiz_band
in coded order, although the default case is display order.
Signed-off-by: Andreas Rheinhardt
---
On 6/8/2024 9:59 PM, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
If `--toolchain=valgrind-memcheck` is selected, fate-lavf-asf fails on a false
positive.
I can't reproduce this. Tried with both --disable-optimizations and
without it, on Ubuntu 22.04 x86_64.
How are you getting t
From: Pierre-Anthony Lemieux
If `--toolchain=valgrind-memcheck` is selected, fate-lavf-asf fails on a false
positive.
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 6c5b8aab9a..c708f2e38c 100755
--- a/configure
+++ b/configure
@@ -
On Sun, Jun 9, 2024 at 5:14 AM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Nuo Mi:
> > On Wed, Jun 5, 2024 at 7:41 PM Andreas Rheinhardt <
> > andreas.rheinha...@outlook.com> wrote:
> >
> >> This is the VVC version of 8b5d15530127fea54e934043a64653859de07353.
> >>
> >> (Hint: Thi
int idx, and int first_tcx_flag are set but not used, so this commit
removes their declarations and assignments.
Signed-off-by: Leo Izen
---
libavcodec/aac/aacdec_lpd.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd
Fixes: CID1551685 Uninitialized scalar variable
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/usmdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/usmdec.c b/libavformat/usmdec.c
index 9a21cc30413..6de2a73edf0 100644
---
Fixes: CID1551679 Data race condition
Fixes: CID1551687 Data race condition
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/udp.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/libavformat/udp.c b/libavformat/udp.c
index c
Fixes: CID1591881 Uninitialized scalar variable
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/tls_schannel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c
index 214a47a218b..55a67
This may help CID1452449 Uninitialized scalar variable
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/subfile.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/subfile.c b/libavformat/subfile.c
index eedac1524e1..be48ef72ef2 100644
--- a/l
Found while reviewing CID1452449 Uninitialized scalar variable
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/subfile.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/subfile.c b/libavformat/subfile.c
index 633a9e3c62c..e
Fixes: CID1473554 Uninitialized scalar variable
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/rtsp.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index c6fca89d83f..19b93df8394 100644
--- a/libavformat/rtsp
It seems reply1 is initialized by ff_rtsp_send_cmd() in most cases but there
are code paths like "continue" which look like they could skip it but even if
not
writing this so a complex loop after several layers of calls initialized a local
variable through a pointer is just bad design.
This patch
Found while reviewing CID1473532 Uninitialized scalar variable
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/rtsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index db78735c7ae..28c858077ad 10
Fixes: CID1452585 Untrusted loop bound
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer
---
libavformat/rtpenc_vc2hq.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/libavformat/rtpenc_vc2hq.c b/libavformat/rtpenc_vc2hq.c
index 085204fa64
On 08.06.2024 21:49, Vittorio Giovara wrote:
On Sat, Jun 8, 2024 at 6:02 PM Michael Niedermayer
wrote:
On Tue, May 14, 2024 at 01:38:16AM +0200, Michael Niedermayer wrote:
Hi all
To keep people updated (and as this is not vissible on the ML)
heres my current list of issues marked as false po
Andreas Rheinhardt:
> If any of these files (say A) would be changed in such a way
> that A acquires a new dependency on another file B, building B
> would need to be added to all the rules that lead to A being built.
> Yet currently the rules for several files are spread over
> the lavc Makefile a
Nuo Mi:
> On Wed, Jun 5, 2024 at 7:41 PM Andreas Rheinhardt <
> andreas.rheinha...@outlook.com> wrote:
>
>> This is the VVC version of 8b5d15530127fea54e934043a64653859de07353.
>>
>> (Hint: This ensures that the order of NALU arrays is OPI-VPS-SPS-PPS-
>> Prefix-SEI-Suffix-SEI, regardless of the o
Signed-off-by: Andreas Rheinhardt
---
libavformat/vvc.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/libavformat/vvc.c b/libavformat/vvc.c
index 595492cd1e..3a686c9910 100644
--- a/libavformat/vvc.c
+++ b/libavformat/vvc.c
@@ -567,7 +567,6 @@ static void vvcc_
Signed-off-by: Andreas Rheinhardt
---
libavformat/vvc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/vvc.c b/libavformat/vvc.c
index 3821de7812..595492cd1e 100644
--- a/libavformat/vvc.c
+++ b/libavformat/vvc.c
@@ -675,7 +675,7 @@ static int vvcc_write(AVIOConte
Rémi Denis-Courmont:
> ---
> libavcodec/mpegvideo.c | 29 -
> 1 file changed, 4 insertions(+), 25 deletions(-)
>
> diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
> index 7af823b8bd..0eb4a1a865 100644
> --- a/libavcodec/mpegvideo.c
> +++ b/libavcodec/mpegv
---
tests/checkasm/h263dsp.c | 28
1 file changed, 28 insertions(+)
diff --git a/tests/checkasm/h263dsp.c b/tests/checkasm/h263dsp.c
index 2d0957a90b..fea5923f2e 100644
--- a/tests/checkasm/h263dsp.c
+++ b/tests/checkasm/h263dsp.c
@@ -18,6 +18,7 @@
* 51 Franklin Str
---
libavcodec/mpegvideo.c | 29 -
1 file changed, 4 insertions(+), 25 deletions(-)
diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
index 7af823b8bd..0eb4a1a865 100644
--- a/libavcodec/mpegvideo.c
+++ b/libavcodec/mpegvideo.c
@@ -201,7 +201,7 @@ static voi
Vittorio Giovara:
> On Sat, Jun 8, 2024 at 9:45 PM Andreas Rheinhardt <
> andreas.rheinha...@outlook.com> wrote:
>
>> Andreas Rheinhardt:
>>> Signed-off-by: Andreas Rheinhardt
>>> ---
>>> libavcodec/dnxhdenc.c | 33 +
>>> 1 file changed, 17 insertions(+), 16 delet
On Sat, Jun 8, 2024 at 9:45 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Andreas Rheinhardt:
> > Signed-off-by: Andreas Rheinhardt
> > ---
> > libavcodec/dnxhdenc.c | 33 +
> > 1 file changed, 17 insertions(+), 16 deletions(-)
> >
> > diff --gi
On Sat, Jun 8, 2024 at 6:02 PM Michael Niedermayer
wrote:
> On Tue, May 14, 2024 at 01:38:16AM +0200, Michael Niedermayer wrote:
> > Hi all
> >
> > To keep people updated (and as this is not vissible on the ML)
> > heres my current list of issues marked as false positives / intentional
> in Mai &
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/dnxhdenc.c | 33 +
> 1 file changed, 17 insertions(+), 16 deletions(-)
>
> diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c
> index 0cb25d7714..4760a2932c 100644
> --- a/libavcode
Andreas Rheinhardt:
> The MMXEXT versions of the rgb2rgb functions tested here
> always emit emms on their own. Therefore one can use
> a stricter test to ensure that it stays that way.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> tests/checkasm/sw_rgb.c | 12 ++--
> 1 file changed, 6 i
Andreas Rheinhardt:
> The ff_nv12ToUV_* functions don't use non-temporal stores
> at all.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libswscale/x86/rgb2rgb_template.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/libswscale/x86/rgb2rgb_template.c
> b/libswscale/x86/rgb2rgb_tem
Le lauantaina 8. kesäkuuta 2024, 21.01.08 EEST Lynne via ffmpeg-devel a écrit :
> > #if HAVE_RV && !defined(__riscv_zbb)
>
> Could you add a ./configure flag or a check for enabling non-dynamic Zbb?
That's defined by the compiler target architecture and/or CPU. Adding a
configure flag wouldn't
On 08/06/2024 13:37, Rémi Denis-Courmont wrote:
Zbb staticZbb dynamic I baseline
clz 0.668032642 1.336072283 19.552376803
clzl 0.668092643 1.336181786 26.110855571
ctz 1.336208533 3.340209702 26.054869008
ctzl 1.336247784 3.340362457 26.055266
Le lauantaina 8. kesäkuuta 2024, 18.55.53 EEST Andreas Rheinhardt a écrit :
> I think we should not optimize for CPUs that do not even have x86-64 v2.
> So I would not add these SSE2 versions.
We certainly should consider ditching SSE2 where SSSE3 is available now or in
the near future. But in th
On Tue, May 14, 2024 at 01:38:16AM +0200, Michael Niedermayer wrote:
> Hi all
>
> To keep people updated (and as this is not vissible on the ML)
> heres my current list of issues marked as false positives / intentional in
> Mai & April 2024
> (in case anyone wants to review, i presume noone wants
James Almer:
> On 6/6/2024 11:48 AM, Andreas Rheinhardt wrote:
>> James Almer:
>>> And remove shuffle_bytes_2103_mmxext.
>>>
>>> shuffle_bytes_0321_c: 28.1
>>> shuffle_bytes_0321_sse2: 13.6
>>> shuffle_bytes_0321_ssse3: 9.6
>>> shuffle_bytes_0321_avx2: 7.1
>>> shuffle_bytes_1230_c: 52.6
>>> shuffle
Le lauantaina 8. kesäkuuta 2024, 16.41.13 EEST Andreas Rheinhardt a écrit :
> > My preference would be to use builtin_bswap (as riscv/ does) on all
> > architectures on GCC and Clang, and keep the bespoke C for other compilers
> > and external header inclusion.
>
> Why would you not want to use th
This way said function sets everything (except for the actual
contents of the frame's data). Also rename it to prepare_picture()
given its new role.
Signed-off-by: Andreas Rheinhardt
---
Now calling av_frame_copy_props() after setting the frame's dimensions
to the actually valid (i.e. unpadded) d
Peter Ross:
> ---
> palette decoding now conforms to description at
> https://wiki.multimedia.cx/index.php/IBM_PhotoMotion
>
> libavcodec/mmvideo.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c
> index 3038d9ea92.
Rémi Denis-Courmont:
> Le lauantaina 8. kesäkuuta 2024, 9.23.48 EEST Andreas Rheinhardt a écrit :
>> Rémi Denis-Courmont:
>>> Le lauantaina 8. kesäkuuta 2024, 0.26.21 EEST Andreas Rheinhardt a écrit :
(Also: IIRC Clang actually parses inline assembler and optimize it;
>>>
>>> That sounds sketc
Quoting Christophe Gisquet (2024-06-08 09:08:01)
> Le ven. 7 juin 2024, 15:05, Anton Khirnov a écrit :
>
> > They are useless duplicates of corresponding AVCodecContext fields.
> >
>
> FYI, the intent of one field was to be a bit field to simultaneously
> indicate/use frame threading and one of
Quoting Christophe Gisquet (2024-06-08 09:02:04)
> Le ven. 7 juin 2024, 15:07, Anton Khirnov a écrit :
>
> > if (pps->tiles_enabled_flag &&
> > pps->tile_id[ctb_addr_ts] != pps->tile_id[ctb_addr_ts - 1]) {
> > int ret;
> > -if (s->threads_number == 1
On Fri, Jun 7, 2024 at 3:19 PM Anton Khirnov wrote:
> ---
> libavcodec/hevc/hevcdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c
> index 5fc55d5de9..88f2bcecad 100644
> --- a/libavcodec/hevc/hevcdec.c
> +++ b/lib
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> wenbin.chen-at-intel@ffmpeg.org
> Sent: Monday, June 3, 2024 1:10 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH] libavfi/dnn: enable LibTorch xpu device option
> support
>
> From: Wenbin Chen
>
> Add xpu
We need to round toward zero here.
---
libavcodec/riscv/aacencdsp_rvv.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/riscv/aacencdsp_rvv.S b/libavcodec/riscv/aacencdsp_rvv.S
index ddb4155398..21e66a77ae 100644
--- a/libavcodec/riscv/aacencdsp_rvv.S
+++ b/libavcode
This adds runtime support to use Zbb REV8 for 32- and 64-bit byte-wise
swaps. The result is about five times slower than if targetting Zbb
statically, but still a lot faster than the default bespoke C code or a
call to GCC run-time functions.
For 16-bit swap, this is however unsurprisingly a lot w
Zbb staticZbb dynamic I baseline
popcount 1.336129286 3.469067758 20.146362909
popcountl 1.336322291 3.340292968 20.224829821
(seconds for 1 billion iterations on a SiFive-U74 core)
---
libavutil/riscv/intmath.h | 73 ---
1 file changed,
Zbb staticZbb dynamic I baseline
clz 0.668032642 1.336072283 19.552376803
clzl 0.668092643 1.336181786 26.110855571
ctz 1.336208533 3.340209702 26.054869008
ctzl 1.336247784 3.340362457 26.055266290
(seconds for 1 billion iterations on a SiFive-U
Due to hysterical raisins, most RISC-V Linux distributions target a
RV64GC baseline excluding the Bit-manipulation ISA extensions, most
notably:
- Zba: address generation extension and
- Zbb: basic bit manipulation extension.
Most CPUs that would make sense to run FFmpeg on support Zba and Zbb
(inc
On Tue, Jun 4, 2024 at 8:04 PM Nuo Mi wrote:
> A 360 video specific tool
> see https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9503377
>
> passed files:
> DMVR_A_Huawei_3.bit
> WRAP_D_InterDigital_4.bit
> WRAP_A_InterDigital_4.bit
> WRAP_B_InterDigital_4.bit
> WRAP_C_Inte
---
libavcodec/mmvideo.c | 11 +++
libavformat/mm.c | 9 +++--
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c
index 3b6b9ed580..2d006d58ba 100644
--- a/libavcodec/mmvideo.c
+++ b/libavcodec/mmvideo.c
@@ -39,6 +39,7 @@
---
libavcodec/mmvideo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c
index b5b6ffd25b..3b6b9ed580 100644
--- a/libavcodec/mmvideo.c
+++ b/libavcodec/mmvideo.c
@@ -162,7 +162,7 @@ static int mm_decode_inter(MmContext * s, int half_
---
palette decoding now conforms to description at
https://wiki.multimedia.cx/index.php/IBM_PhotoMotion
libavcodec/mmvideo.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c
index 3038d9ea92..b5b6ffd25b 100644
--- a/libav
---
libavformat/mm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/mm.c b/libavformat/mm.c
index 23c025d852..a40b5c44bb 100644
--- a/libavformat/mm.c
+++ b/libavformat/mm.c
@@ -180,7 +180,8 @@ static int read_packet(AVFormatContext *s,
if ((ret = av
Le ven. 7 juin 2024, 15:05, Anton Khirnov a écrit :
> They are useless duplicates of corresponding AVCodecContext fields.
>
FYI, the intent of one field was to be a bit field to simultaneously
indicate/use frame threading and one of tile, WPP or slice threading, as
that was also supported in the
Le ven. 7 juin 2024, 15:07, Anton Khirnov a écrit :
> if (pps->tiles_enabled_flag &&
> pps->tile_id[ctb_addr_ts] != pps->tile_id[ctb_addr_ts - 1]) {
> int ret;
> -if (s->threads_number == 1)
> +if (!is_wpp)
> ret = cabac_
58 matches
Mail list logo