Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/vaapi_encode_h265: Set general_*_constriaint flags with profile

2024-03-31 Thread Wang, Fei W
On Wed, 2024-03-20 at 16:44 +0800, Fei Wang wrote: > On Mon, 2024-03-18 at 21:22 +, Mark Thompson wrote: > > On 18/03/2024 04:21, fei.w.wang-at-intel@ffmpeg.org wrote: > > > From: Fei Wang > > > > > > According to Table A.2 in spec. > > > > > > Signed-off-by: Fei Wang > > > --- > > >

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_hevc: Add support for Main Intra & Main 10 Intra

2024-03-31 Thread Xiang, Haihao
On Do, 2024-03-28 at 10:07 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Both Main Intra and Main 10 Intra are Rext, we may use Main and Main 10 > instead for decoding. This patch fixes the error below: > > [hevc @ 0x55a771b80a00] No support for codec hevc profile 4. > [hevc @ 0x55a771b80

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: convert from lambda to qp

2024-03-31 Thread Xiang, Haihao
On Do, 2024-03-28 at 14:55 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > When AV_CODEC_FLAG_QSCALE is set, the value of avctx->global_quality is > lambda. > > Signed-off-by: Haihao Xiang > --- >  libavcodec/vaapi_encode.c | 5 - >  1 file changed, 4 insertions(+), 1 deletion(-) > > d

Re: [FFmpeg-devel] [PATCH v1] lavc/vaapi_encode: Add VAAPI version check for BLBRC

2024-03-31 Thread Xiang, Haihao
On Vr, 2024-03-29 at 09:10 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > Fix build fail when VAAPI version less than 0.39.2. > > Signed-off-by: Fei Wang > --- >  libavcodec/vaapi_encode.c | 20 +--- >  1 file changed, 17 insertions(+), 3 deletions(-) > >

[FFmpeg-devel] [PATCH 3/3] avcodec/hevcdec: Fix null dereference in hevc_frame_end()

2024-03-31 Thread Michael Niedermayer
Fixes: member access within null pointer of type 'const AVFilmGrainParams' (aka 'const struct AVFilmGrainParams') Fixes: 67701/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-6595117570916352 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/proje

[FFmpeg-devel] [PATCH 2/3] avcodec/exr: Dont use 64bits to hold 6bits

2024-03-31 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index 09f2fca109c..8bd39f78a45 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -335,7 +335,7 @@ static int huf_unpack_enc_table(G

[FFmpeg-devel] [PATCH 1/3] avcodec/exr: Check for remaining bits in huf_unpack_enc_table()

2024-03-31 Thread Michael Niedermayer
Fixes: Timeout Fixes: 67645/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EXR_fuzzer-6308760977997824 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 5 - 1 file changed, 4 ins

Re: [FFmpeg-devel] [PATCH 4/4] avformat/iamf: Check language_label

2024-03-31 Thread Michael Niedermayer
On Thu, Mar 21, 2024 at 04:55:46AM +0100, Michael Niedermayer wrote: > On Wed, Mar 20, 2024 at 11:17:09PM -0300, James Almer wrote: > > On 3/20/2024 10:15 PM, Michael Niedermayer wrote: > > > Fixes: null pointer dereference > > > Fixes: > > > 67023/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fu

[FFmpeg-devel] [PATCH] avformat/hlsenc: use a slash separator even in win32

2024-03-31 Thread Marton Balint
We don't know if the protocol used is referring to a local file or a remote resource, so it is better to simply use slash as separator which works all the time. (well, except in very special cases when the user specified a \\?\ path) Fixes ticket #9780. Signed-off-by: Marton Balint --- libavfor

[FFmpeg-devel] [PATCH] avfilter/buffersrc: never override channel count in av_buffersrc_add_frame_flags

2024-03-31 Thread Marton Balint
Overriding unknown layouts with the negotiated layout is OK, but the number of channels should match with what was negotiated. Signed-off-by: Marton Balint --- libavfilter/buffersrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffer

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/hls.c: support in-stream ID3 metadata update.

2024-03-31 Thread Romain Beauxis
On Sun, Mar 31, 2024, 05:52 Liu Steven wrote: > > > > On Mar 29, 2024, at 06:51, Romain Beauxis wrote: > > > > On Mon, Mar 25, 2024, 19:58 Romain Beauxis wrote: > > > >> This patch adds support for updating HLS metadata passed as ID3 frames. > >> > >> This seems like a pretty straight-forward i

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Check that cts fits in 32bit

2024-03-31 Thread James Almer
On 3/31/2024 8:40 AM, Michael Niedermayer wrote: Fixes: Assertion av_rescale_rnd(start_dts, mov->movie_timescale, track->timescale, AV_ROUND_DOWN) <= 0 failed at libavformat/movenc.c:3694 Fixes: poc2 Found-by: Wang Dawei and Zhou Geng, from Zhongguancun Laboratory Signed-off-by: Michael Niederm

Re: [FFmpeg-devel] [PATCH v10 2/5] avformat/rcwtdec: add RCWT Closed Captions demuxer

2024-03-31 Thread Michael Niedermayer
On Sat, Mar 30, 2024 at 03:55:13PM +0100, Stefano Sabatini wrote: > On date Saturday 2024-03-30 01:23:53 +0100, Michael Niedermayer wrote: > > On Thu, Mar 28, 2024 at 03:11:29PM -0500, Marth64 wrote: > > [...] > > > > > +static int rcwt_probe(const AVProbeData *p) > > > +{ > > > +return p->buf

Re: [FFmpeg-devel] Fixes #10509

2024-03-31 Thread Marton Balint
On Fri, 29 Mar 2024, Poorva wrote: On Tue, Mar 26, 2024 at 2:36 AM Poorva <2003gaikarpoo...@gmail.com> wrote: Thank you for your feedback on the Git patch I submitted for review. I have rectified the problem by adding the necessary changes . The updated patch file is attached for your

Re: [FFmpeg-devel] FFmpeg at NAB 2024

2024-03-31 Thread Derek Buitenhuis
On 11/1/2023 9:25 PM, Derek Buitenhuis wrote: > This is certainly interesting considering we just had a giant thread about > not using > or using SPI, with multiple people accused of having corporate interests. Adding to the list of wtf NAB things: https://twitter.com/JanetGrecoBP/status/1773342

[FFmpeg-devel] [PATCH] avformat/movenc: Check that cts fits in 32bit

2024-03-31 Thread Michael Niedermayer
Fixes: Assertion av_rescale_rnd(start_dts, mov->movie_timescale, track->timescale, AV_ROUND_DOWN) <= 0 failed at libavformat/movenc.c:3694 Fixes: poc2 Found-by: Wang Dawei and Zhou Geng, from Zhongguancun Laboratory Signed-off-by: Michael Niedermayer --- libavformat/movenc.c | 6 ++ 1 file

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/hls.c: support in-stream ID3 metadata update.

2024-03-31 Thread Liu Steven
> On Mar 29, 2024, at 06:51, Romain Beauxis wrote: > > On Mon, Mar 25, 2024, 19:58 Romain Beauxis wrote: > >> This patch adds support for updating HLS metadata passed as ID3 frames. >> >> This seems like a pretty straight-forward improvement. Updating the >> metadaata of the first stream se

Re: [FFmpeg-devel] [PATCH] avformat/rtmpproto: Don't free AVOpt-strings manually, fix crash

2024-03-31 Thread Steven Liu
Liu Steven 于2024年3月31日周日 10:16写道: > > > > > On Mar 30, 2024, at 12:21, Andreas Rheinhardt > > wrote: > > > > Andreas Rheinhardt: > Hi Andreas, > > >> Besides being redundant, freeing manually is actually harmful here, > >> as rtmp_close() may call gen_fcunpublish_stream() which dereferences > >>