Re: [FFmpeg-devel] [PATCH 1/2] lavf/mpenenc: extend options definition

2024-01-20 Thread Anton Khirnov
>Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavf/mpenenc: extend options definition ^ typo -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] [PATCH 1/2] lavf/dvenc: improve error messaging

2024-01-20 Thread Anton Khirnov
Quoting Stefano Sabatini (2024-01-20 16:24:07) > if ((c->sys->time_base.den != 25 && c->sys->time_base.den != 50) || > c->sys->time_base.num != 1) { > -if (c->ast[0] && c->ast[0]->codecpar->sample_rate != 48000) > -goto bail_out; > -if (c->ast[1] && c->ast[1]->code

Re: [FFmpeg-devel] [PATCH 1/2 v2] avutil: add a Tile Grid API

2024-01-20 Thread Anton Khirnov
Quoting James Almer (2024-01-20 23:04:06) > This includes a struct and helpers. It will be used to support container level > cropping and tiled image formats, but should be generic enough for general > usage. > > Signed-off-by: James Almer > --- > Extended to include fields used for cropping. Sho

[FFmpeg-devel] [PATCH 2/2 v2] avformat: add a Tile Grid stream group type

2024-01-20 Thread James Almer
This will be used to support tiled image formats like HEIF. Signed-off-by: James Almer --- libavformat/avformat.c | 5 + libavformat/avformat.h | 3 +++ libavformat/dump.c | 46 ++ libavformat/options.c | 9 + 4 files changed, 63 insert

[FFmpeg-devel] [PATCH 1/2 v2] avutil: add a Tile Grid API

2024-01-20 Thread James Almer
This includes a struct and helpers. It will be used to support container level cropping and tiled image formats, but should be generic enough for general usage. Signed-off-by: James Almer --- Extended to include fields used for cropping. Should make the struct reusable even for non tiled images,

Re: [FFmpeg-devel] [PATCH] avformat/dump: only print streams within a group in verbose levels

2024-01-20 Thread James Almer
On 1/17/2024 5:40 PM, James Almer wrote: Signed-off-by: James Almer --- libavformat/dump.c | 278 +++-- 1 file changed, 143 insertions(+), 135 deletions(-) Will apply. ___ ffmpeg-devel mailing list ffmpeg-de

[FFmpeg-devel] [PATCH 2/2] doc/muxers: add MPEG-1/2 muxers section

2024-01-20 Thread Stefano Sabatini
--- doc/muxers.texi | 66 + 1 file changed, 66 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index a8bc642c00..c7951e1c33 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -578,6 +578,72 @@ ffmpeg -re @var{} -movflags isml+frag_k

[FFmpeg-devel] [PATCH 1/2] lavf/mpenenc: extend options definition

2024-01-20 Thread Stefano Sabatini
--- libavformat/mpegenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c index 12d9fb33ec..14caf9e162 100644 --- a/libavformat/mpegenc.c +++ b/libavformat/mpegenc.c @@ -1291,8 +1291,8 @@ static void mpeg_mux_deinit(AVFormatCont

Re: [FFmpeg-devel] FFmpeg's HLS muxer's deprecation of the hls_wrap option

2024-01-20 Thread Dennis Mungai
On Sat, 20 Jan 2024 at 18:42, Steven Liu wrote: > Dennis Mungai 于2024年1月20日 周六23:15写道: > > > On Sat, 20 Jan 2024, 6:09 pm Steven Liu, > wrote: > > > > > Dennis Mungai 于2024年1月20日 周六21:02写道: > > > > > > > Hello, > > > > > > > > Is there a valid technical reason as to why FFmpeg's HLS muxer > drop

Re: [FFmpeg-devel] FFmpeg's HLS muxer's deprecation of the hls_wrap option

2024-01-20 Thread Steven Liu
Dennis Mungai 于2024年1月20日 周六23:15写道: > On Sat, 20 Jan 2024, 6:09 pm Steven Liu, wrote: > > > Dennis Mungai 于2024年1月20日 周六21:02写道: > > > > > Hello, > > > > > > Is there a valid technical reason as to why FFmpeg's HLS muxer dropped > > the > > > hls_wrap option? > > > > > > eg. three player playing

[FFmpeg-devel] [PATCH 2/2] doc/muxers: add dv

2024-01-20 Thread Stefano Sabatini
--- doc/muxers.texi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 24ed1b3369..a8bc642c00 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1339,6 +1339,20 @@ of each audio packet, with a size computed according to the formula: Th

[FFmpeg-devel] [PATCH 1/2] lavf/dvenc: improve error messaging

2024-01-20 Thread Stefano Sabatini
Provide useful information about the failure in the error message, do not let the user guess. --- libavformat/dvenc.c | 119 +++- 1 file changed, 85 insertions(+), 34 deletions(-) diff --git a/libavformat/dvenc.c b/libavformat/dvenc.c index 29d2dc47ac..9a8

[FFmpeg-devel] [PATCH v2 1/1] avfilter/vf_vpp_qsv: apply 3D LUT from file.

2024-01-20 Thread Chen Yufei
Usage: "vpp_qsv=lut3d_file=" Requires oneVPL, using system memory 3D LUT surface. Signed-off-by: Chen Yufei --- libavfilter/Makefile | 8 +- libavfilter/lut3d.c | 669 +++ libavfilter/lut3d.h | 13 + libavfilter/vf_lut3d.c | 590 +--

[FFmpeg-devel] [PATCH v2 0/1] avfilter/vf_vpp_qsv: apply 3D LUT from file

2024-01-20 Thread Chen Yufei
This patch adds support for applying 3D LUT from file using oneVPL VPP. PATCH v1 uses VA-API to create LUT surface. Because oneVPL can't work with VA-API on Windows, this version now creates LUT in system memory (MFX_RESOURCE_SYSTEM_SURFACE) and let oneVPL copy LUT to video memory. Note: requir

Re: [FFmpeg-devel] FFmpeg's HLS muxer's deprecation of the hls_wrap option

2024-01-20 Thread Dennis Mungai
On Sat, 20 Jan 2024, 6:09 pm Steven Liu, wrote: > Dennis Mungai 于2024年1月20日 周六21:02写道: > > > Hello, > > > > Is there a valid technical reason as to why FFmpeg's HLS muxer dropped > the > > hls_wrap option? > > > eg. three player playing the list and every fragment less or equal 1 second > , > 1.

Re: [FFmpeg-devel] FFmpeg's HLS muxer's deprecation of the hls_wrap option

2024-01-20 Thread Steven Liu
Dennis Mungai 于2024年1月20日 周六21:02写道: > Hello, > > Is there a valid technical reason as to why FFmpeg's HLS muxer dropped the > hls_wrap option? eg. three player playing the list and every fragment less or equal 1 second , 1. Player 1 from fragment1, fragment2 2. Now Player 2 from fragment 1, fra

[FFmpeg-devel] [PATCH] lavc/vvc: Remove left shifts of negative values

2024-01-20 Thread post
From: Frank Plowman VVC specifies << as arithmetic left shift, i.e. x << y is equivalent to x * pow2(y). C's << on the other hand has UB if x is negative. This patch removes all UB resulting from this, mostly by replacing x << y with x * (1 << y), but there are also a couple places where the OO

[FFmpeg-devel] [PATCH 2/2] doc/muxers: add daud

2024-01-20 Thread Stefano Sabatini
--- doc/muxers.texi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index a49853daf2..a9f2f6fe17 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1312,6 +1312,32 @@ ffmpeg -re -i -map 0 -map 0 -c:a libfdk_aac -c:v libx264 \

[FFmpeg-devel] [PATCH 1/2] lavf/daudenc: clarify error messages

2024-01-20 Thread Stefano Sabatini
--- libavformat/daudenc.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/libavformat/daudenc.c b/libavformat/daudenc.c index 2d84b16650..8e8bce8be3 100644 --- a/libavformat/daudenc.c +++ b/libavformat/daudenc.c @@ -25,8 +25,21 @@ static int daud_init(struc

[FFmpeg-devel] FFmpeg's HLS muxer's deprecation of the hls_wrap option

2024-01-20 Thread Dennis Mungai
Hello, Is there a valid technical reason as to why FFmpeg's HLS muxer dropped the hls_wrap option? There are many cases where the hls_wrap option remains critical so as to preserve the set of output file names without increments. This deprecation breaks that. For now, this behavior can be worked

[FFmpeg-devel] [PATCH 1/2] lavf/dascenc: sort options by name

2024-01-20 Thread Stefano Sabatini
--- libavformat/dashenc.c | 68 +-- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 2f5394c308..4a92863f22 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -2362,50 +2362,50

[FFmpeg-devel] [PATCH 2/2] doc/muxers/dash: review documentation

2024-01-20 Thread Stefano Sabatini
Sort options by name, review formatting, apply consistency fixes and fill the gaps (e.g. missing value for constants or flags), and review and extend content. --- doc/muxers.texi | 418 +--- 1 file changed, 293 insertions(+), 125 deletions(-) diff --git

[FFmpeg-devel] [PATCH 2/2] fate: add raw IAMF tests

2024-01-20 Thread James Almer
Covers muxing from raw pcm audio input into FLAC, using several scalable layouts, and demuxing the result. Signed-off-by: James Almer --- tests/Makefile | 7 +- tests/fate/iamf.mak| 31 ++ tests/filtergraphs/iamf_5_1|

[FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_mux_init: remove whitespaces from input arguments when parsing stream groups

2024-01-20 Thread James Almer
If the arguments are read from a file, things like line breaks could be present Signed-off-by: James Almer --- fftools/ffmpeg_mux_init.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index b527e1f118..15200c5

Re: [FFmpeg-devel] [PATCH v3 2/2] doc/ffmpeg: update the documentation about vaapi device creation

2024-01-20 Thread Stefano Sabatini
On date Tuesday 2024-01-16 13:23:11 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Signed-off-by: Haihao Xiang > --- > doc/ffmpeg.texi | 23 +++ > 1 file changed, 23 insertions(+) Will apply both, thanks! ___ ffmpeg-devel ma

Re: [FFmpeg-devel] [PATCH] fftools/opt_common: show if muxer is device

2024-01-20 Thread Stefano Sabatini
On date Tuesday 2024-01-16 00:58:02 +0100, Stefano Sabatini wrote: > --- > fftools/opt_common.c | 28 +--- > 1 file changed, 21 insertions(+), 7 deletions(-) > > diff --git a/fftools/opt_common.c b/fftools/opt_common.c > index f5b73c9f2f..e263a5297e 100644 > --- a/fftools/

Re: [FFmpeg-devel] [PATCH 3/3] doc/muxers/chromaprint: review and extend

2024-01-20 Thread Stefano Sabatini
On date Tuesday 2024-01-16 00:57:32 +0100, Stefano Sabatini wrote: > In particular, apply formatting and consistency fixes and sort options > by name. > --- > doc/muxers.texi | 45 - > 1 file changed, 24 insertions(+), 21 deletions(-) Will apply this an

Re: [FFmpeg-devel] [PATCH 7/8] fftools/ffmpeg_demux: implement -bsf for input

2024-01-20 Thread Stefano Sabatini
On date Wednesday 2024-01-17 10:02:31 +0100, Anton Khirnov wrote: > Quoting Stefano Sabatini (2024-01-06 13:12:19) > > > > This looks spurious, since this suggests the example is about the > > listing, and it's applying a weird order of example/explanation > > (rather than the opposite). Use the