[FFmpeg-devel] [PATCH] configure: correct lensfun header function check

2023-12-30 Thread Gyan Doshi
The function lf_db_new was deprecated in lensfun 09dcd3e7ad in 2017 in favour of lf_db_create. The AVfilter was adjusted in 8b78eb312d but the configure check wasn't changed. lensfun removed lf_db_new declaration in lf 35c0017593 so configure fails to find lensfun. --- configure | 2 +- 1 file ch

[FFmpeg-devel] [PATCH] configure: remove Bitrig OS

2023-12-30 Thread Brad Smith
configure: remove Bitrig OS Bitrig has been defunct for 7 years. Signed-off-by: Brad Smith --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 42786719e9..d96b47ebe5 100755 --- a/configure +++ b/configure @@ -5625,7 +5625,7 @@ case $targ

[FFmpeg-devel] [PATCH] configure: update copyright year

2023-12-30 Thread Lynne
If anyone else wants to do this, it's fine by me. I did promise to let Paul do it this year, but can't get in touch with him. >From 4b85c208eb97f0a72d8286fd07f973d322ece6b5 Mon Sep 17 00:00:00 2001 From: Lynne Date: Mon, 1 Jan 2024 00:00:00 + Subject: [PATCH] configure: update copyright year

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc.c: Populate OTI using AAC profile in write_codec_attr.

2023-12-30 Thread David Johansen
On Sat, Dec 30, 2023 at 8:23 AM Romain Beauxis wrote: > Le jeu. 28 déc. 2023 à 17:26, David Johansen a > écrit : > >> > >> I love this change, but it appears that st->codecpar->profile is always > AV_PROFILE_UNKNOWN when using libfdk_aac as the encoder. Any indications > where I should look for

[FFmpeg-devel] [PATCH v2 6/7] lavf/codec2: Silence warnings when either muxer/demuxer is disabled

2023-12-30 Thread Tomas Härdin
From f64b4a90ea22421db494d87f5904ae8c7294c871 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Wed, 27 Dec 2023 22:52:25 +0100 Subject: [PATCH 6/7] lavf/codec2: Silence warnings when either muxer/demuxer is disabled --- libavformat/codec2.c | 76 +---

[FFmpeg-devel] [PATCH v2 5/7] lavf/codec2: Multiple of block_align -> not corrupt

2023-12-30 Thread Tomas Härdin
From 74302cd9f6f213b81e3bbc8a3547b518db41 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Wed, 27 Dec 2023 22:50:18 +0100 Subject: [PATCH 5/7] lavf/codec2: Multiple of block_align -> not corrupt --- libavformat/codec2.c | 5 + 1 file changed, 5 insertions(+) diff -

[FFmpeg-devel] [PATCH v2 4/7] lavf/codec2: Allow versions between 0.8 and 1.X

2023-12-30 Thread Tomas Härdin
From 5a660d91c2f34c4e464212bf3694cdb7bca80f1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Wed, 27 Dec 2023 17:33:18 +0100 Subject: [PATCH 4/7] lavf/codec2: Allow versions between 0.8 and 1.X --- libavformat/codec2.c | 36 ++-- 1 file chan

[FFmpeg-devel] [PATCH v2 3/7] lavf/codec2: Compute duration from filesize

2023-12-30 Thread Tomas Härdin
Previous version accidentally used CODEC2_EXTRADATA_SIZE not CODEC2_HEADER_SIZE /Tomas From 6fda817b2bc237081e6bf6daeff9087b6543647b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Wed, 27 Dec 2023 16:32:49 +0100 Subject: [PATCH 3/7] lavf/codec2: Compute duration from filesiz

[FFmpeg-devel] [PATCH v2 2/7] lavc/libcodec2: Report actual bitrate used both when decoding and encoding

2023-12-30 Thread Tomas Härdin
Without this it looks like the encoder runs at 128 kbit/s /Tomas From 5c913a3eaf5cf8c21edc119870b7fdc8251bd900 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Fri, 29 Dec 2023 14:09:51 +0100 Subject: [PATCH 2/7] lavc/libcodec2: Report actual bitrate used both when decoding a

[FFmpeg-devel] [PATCH v2 1/7] lavc/codec2utils: Use actual libcodec2 version

2023-12-30 Thread Tomas Härdin
Should compile without libcodec2 installed now /Tomas From 098a3b7e78dc0b1bbdfce051de21526f0a886b4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Wed, 27 Dec 2023 17:32:21 +0100 Subject: [PATCH 1/7] lavc/codec2utils: Use actual libcodec2 version --- libavcodec/codec2utils

[FFmpeg-devel] [PATCH v2 6/6] Add myself as APC maintainer

2023-12-30 Thread Tomas Härdin
From 65f4215a519e457d6a3d6c943d14ebd739083eed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 26 Dec 2023 16:45:33 +0100 Subject: [PATCH 6/6] Add myself as APC maintainer --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS inde

[FFmpeg-devel] [PATCH v2 5/6] lavc: Add ADPCM IMA CRYO APC encoder

2023-12-30 Thread Tomas Härdin
From 701eec2a7e742fa0fcc375a6c3784ac012100d0a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 26 Dec 2023 14:32:20 +0100 Subject: [PATCH 5/6] lavc: Add ADPCM IMA CRYO APC encoder No trellis quantization yet --- Changelog | 1 + doc/general_content

[FFmpeg-devel] [PATCH v2 4/6] lavf: Add CRYO APC muxer

2023-12-30 Thread Tomas Härdin
From 1fab30dea9528478ccbe78dc68a3933acb8115b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 26 Dec 2023 14:32:10 +0100 Subject: [PATCH 4/6] lavf: Add CRYO APC muxer --- Changelog | 1 + doc/general_contents.texi | 2 +- libavformat/Makefile |

[FFmpeg-devel] [PATCH v2 3/6] Un-mark IMA APC as intra-only, only mark first packet as keyframe

2023-12-30 Thread Tomas Härdin
From f652daf2e9bad345c0e98ab058a5e07c3d45d13e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 26 Dec 2023 16:30:35 +0100 Subject: [PATCH 3/6] Un-mark IMA APC as intra-only, only mark first packet as keyframe Packets must be decoded in order. There is no way to seek and

[FFmpeg-devel] [PATCH v2 2/6] lavf/apc: Read duration from file

2023-12-30 Thread Tomas Härdin
From 2ef5c89c3e3173b26690bad0279fd484a30a6268 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 26 Dec 2023 14:31:59 +0100 Subject: [PATCH 2/6] lavf/apc: Read duration from file --- libavformat/apc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/

[FFmpeg-devel] [PATCH v2 1/6] doc/general_contents.texi: Add missing ADPCM IMA APC entry

2023-12-30 Thread Tomas Härdin
Addressed some comments and reordered some patches /Tomas From 90954f54d82bd0ceda0400ceb0e92e1affecf3db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= Date: Tue, 26 Dec 2023 15:03:51 +0100 Subject: [PATCH 1/6] doc/general_contents.texi: Add missing ADPCM IMA APC entry --- doc/g

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/avf_showwaves: Check history_nb_samples

2023-12-30 Thread Michael Niedermayer
On Sat, Dec 30, 2023 at 03:49:02AM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: tickets/10756/poc18ffmpeg > > Discovered by Zeng Yunxiang > Signed-off-by: Michael Niedermayer > --- > libavfilter/avf_showwaves.c | 2 ++ > 1 file changed, 2 insertions(+) will apply patc

Re: [FFmpeg-devel] [PATCH 3/6] Add CRYO APC muxer

2023-12-30 Thread Tomas Härdin
fre 2023-12-29 klockan 18:33 +0100 skrev Michael Niedermayer: > On Thu, Dec 28, 2023 at 11:31:05AM +0100, Tomas Härdin wrote: > > tis 2023-12-26 klockan 23:30 +0100 skrev Michael Niedermayer: > > > Hi > > > > > > On Tue, Dec 26, 2023 at 04:52:47PM +0100, Tomas Härdin wrote: > > > > > > > > > > [

Re: [FFmpeg-devel] [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16

2023-12-30 Thread flow gg
I mistook it, seeing the vector length as the length of the vector register .. I have modified it in this reply. Rémi Denis-Courmont 于2023年12月30日周六 20:15写道: > > > Le 29 décembre 2023 12:57:20 GMT+01:00, flow gg a > écrit : > >C908 > >ssd_int8_vs_int16_c: 207.7 > >ssd_int8_vs_int16_rvv_i32: 28

Re: [FFmpeg-devel] [PATCH 1/6] lavc/codec2utils: Use actual libcodec2 version

2023-12-30 Thread Tomas Härdin
fre 2023-12-29 klockan 00:30 +0100 skrev Michael Niedermayer: > On Thu, Dec 28, 2023 at 10:21:23PM +0100, Tomas Härdin wrote: > > tor 2023-12-28 klockan 21:29 +0100 skrev Michael Niedermayer: > > > On Thu, Dec 28, 2023 at 07:43:09PM +0100, Tomas Härdin wrote: > > > > libcodec2 has reached 1.X so it

Re: [FFmpeg-devel] [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16

2023-12-30 Thread Rémi Denis-Courmont
Le 30 décembre 2023 15:00:53 GMT+01:00, flow gg a écrit : >> At a quick glance, it won't work if the input length is not a multiple of >the vector length. > >Why? You're not handling tails as far as I see. > I tried 1024, 32*3, 32*7 and all passed the test. They're all multiples of the vector

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc.c: Populate OTI using AAC profile in write_codec_attr.

2023-12-30 Thread Romain Beauxis
Le jeu. 28 déc. 2023 à 17:26, David Johansen a écrit : >> >> I love this change, but it appears that st->codecpar->profile is always >> AV_PROFILE_UNKNOWN when using libfdk_aac as the encoder. Any indications >> where I should look for fix that so this can be used with that encoder? > > > It app

Re: [FFmpeg-devel] [PATCH] fftool/ffplay: avoid same name in local variable

2023-12-30 Thread Zhao Zhili
> -Original Message- > From: ffmpeg-devel On Behalf Of xufuji456 > via ffmpeg-devel > Sent: 2023年12月30日 16:41 > To: ffmpeg-devel@ffmpeg.org > Cc: xufuji456 <839789...@qq.com> > Subject: [FFmpeg-devel] [PATCH] fftool/ffplay: avoid same name in local > variable > > There is a warning in X

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-30 Thread flow gg
Thank you, I learned this and updated it in this reply. James Almer 于2023年12月30日周六 22:46写道: > On 12/30/2023 10:59 AM, flow gg wrote: > > Okay, it has been modified in this reply. > > > From d62f363e3aad534c7ead5f3015029b3e7cbbff46 Mon Sep 17 00:00:00 2001 > > From: sunyuechi > > Date: Fri, 29 D

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-30 Thread James Almer
On 12/30/2023 10:59 AM, flow gg wrote: Okay, it has been modified in this reply. From d62f363e3aad534c7ead5f3015029b3e7cbbff46 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Fri, 29 Dec 2023 13:09:21 +0800 Subject: [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test --- tests/checkasm/M

Re: [FFmpeg-devel] [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16

2023-12-30 Thread flow gg
flow gg 于2023年12月30日周六 22:00写道: > > At a quick glance, it won't work if the input length is not a multiple > of the vector length. > > Why? I tried 1024, 32*3, 32*7 and all passed the test. > > > Also do you really need to extend accumulators to 32 bits? > > It won't overflow after the test is ch

Re: [FFmpeg-devel] [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16

2023-12-30 Thread flow gg
> At a quick glance, it won't work if the input length is not a multiple of the vector length. Why? I tried 1024, 32*3, 32*7 and all passed the test. > Also do you really need to extend accumulators to 32 bits? It won't overflow after the test is changed, so it's not needed anymore. I have modif

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-30 Thread flow gg
Okay, it has been modified in this reply. Martin Storsjö 于2023年12月29日周五 22:35写道: > On Fri, 29 Dec 2023, James Almer wrote: > > > On 12/29/2023 9:16 AM, Martin Storsjö wrote: > >> On Fri, 29 Dec 2023, flow gg wrote: > >> > >>> Tests on x86 might fail, possibly due to a 16-bit sub overflow > >> >

Re: [FFmpeg-devel] [PATCH 3/3] lavc/svq1enc: R-V V ssd_int8_vs_int16

2023-12-30 Thread Rémi Denis-Courmont
Le 29 décembre 2023 12:57:20 GMT+01:00, flow gg a écrit : >C908 >ssd_int8_vs_int16_c: 207.7 >ssd_int8_vs_int16_rvv_i32: 28.0 At a quick glance, it won't work if the input length is not a multiple of the vector length. Also do you really need to extend accumulators to 32 bits?

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/svqenc: add ssd_int8_vs_int16 test

2023-12-30 Thread Rémi Denis-Courmont
Le 29 décembre 2023 12:57:01 GMT+01:00, flow gg a écrit : >Tests on x86 might fail, possibly due to a 16-bit sub overflow I don't know anything about the SVQ encoder. Still, especially for an encoder, overflows are probably not expected. So then it is as Martin wrote. _

[FFmpeg-devel] [PATCH] fftool/ffplay: avoid same name in local variable

2023-12-30 Thread xufuji456 via ffmpeg-devel
There is a warning in XCode:"Declaration shadows a local variable" Signed-off-by: xufuji456 <839789...@qq.com> --- fftools/ffplay.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index ea5ff31393..17861e60be 100644 --- a/fftools/