[FFmpeg-devel] [PATCH] avformat/riffenc: don't force WAVEFORMATEXTENSIBLE for flt/dbl LPCM

2023-12-20 Thread Gyan Doshi
2c2a167ca7 forced WAVEFORMATEXTENSIBLE for all LPCM streams with greater than 16 bits per sample. However, WAVEFORMATEX allows IEEE Float samples or any depth where raw depth == coded depth, see Remarks section at https://learn.microsoft.com/en-us/windows/win32/api/mmreg/ns-mmreg-waveformatex and s

[FFmpeg-devel] Backporting Clang 14 fix to the 4.4 branch

2023-12-20 Thread Brad Smith
https://github.com/FFmpeg/FFmpeg/commit/ab792634197e364ca1bb194f9abe36836e42f12d But the function is in libavformat/utils.c for 4.4 instead of libavformat/seek.c. Could the Clang 14 fix please be backported to the 4.4 branch? OpenBSD ran into this issue recently when upgrading from Clang 13

Re: [FFmpeg-devel] [PATCH] avfilter/vf_showinfo: add udu_sei_as_ascii option

2023-12-20 Thread Zhao Zhili
> On Dec 13, 2023, at 11:46, Zhao Zhili wrote: > > From: Zhao Zhili > > Some encoders (e.g., libx264) dump encoder configuration as user > data unregistered SEI message. This option try to print it as > ascii character when possible. > --- > doc/filters.texi | 4 > libavfilter/

[FFmpeg-devel] Temporary delays in patch reviewing and testing by me

2023-12-20 Thread Michael Niedermayer
Hi all My main development machiene died today, so expect increased delays about things that involve me/it until thats fixed Rest of the mail is just about the issue, and you can skip reading that Timeline: box suddenly stopped, no reaction to any input or pings power off and on did not bring it

Re: [FFmpeg-devel] [PATCH v1] avcodec/av1dec: Add tile list OBU to decompose list

2023-12-20 Thread Wang, Fei W
On Wed, 2023-12-20 at 17:11 +0100, Andreas Rheinhardt wrote: > fei.w.wang-at-intel@ffmpeg.org: > > From: Fei Wang > > > > Show the unsupported message and return unsupported for clips > > contain > > tile list OBU since it hasn't been implemented. Otherwise, decoding > > maybe successful but

Re: [FFmpeg-devel] [PATCH] Add new vf_tiltandshift filter

2023-12-20 Thread Vittorio Giovara
On Wed, Dec 20, 2023 at 2:50 PM Nicolas George wrote: > Vittorio Giovara (12023-12-20): > > If there are no more comments, I'll push this today or tomorrow. > > I think the change you made after the last request might go too far, but > I have not had time to look at the code carefully enough to b

Re: [FFmpeg-devel] [PATCH] Add new vf_tiltandshift filter

2023-12-20 Thread Nicolas George
Vittorio Giovara (12023-12-20): > If there are no more comments, I'll push this today or tomorrow. I think the change you made after the last request might go too far, but I have not had time to look at the code carefully enough to be sure. If a filter can produce several output frames from one i

Re: [FFmpeg-devel] [PATCH] Add new vf_tiltandshift filter

2023-12-20 Thread Vittorio Giovara
On Fri, Dec 15, 2023 at 3:12 PM Vittorio Giovara wrote: > > > On Fri, Dec 15, 2023 at 12:34 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> > +static int list_add_frame(FrameList **list, size_t *size, AVFrame >> > *frame) >> > +{ >> > +FrameList *element = av_mallocz(siz

Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-20 Thread Michael Niedermayer
On Wed, Dec 20, 2023 at 05:57:40PM +0100, Tomas Härdin wrote: > tis 2023-12-19 klockan 15:02 +0100 skrev Nicolas George: [...] > [...] , but every line of code > carries with it a non-zero maintenance burden Assuming you mean with "non-zero" a "larger than zero" maintenance burden then we can pro

Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-20 Thread Nicolas George
Tomas Härdin (12023-12-20): > I'm not even sure what this is trying to say, but every line of code > carries with it a non-zero maintenance burden Sure, if you want. But for some parts of FFmpeg, like the one we are discussing, the maintenance burden is so small that we wasted ten time as much ene

Re: [FFmpeg-devel] [PATCH] [MXF] - Add jpeg2000 subdescriptor in MXF file (V2).

2023-12-20 Thread Cédric Le Barz
Le 19/12/2023 à 14:36, Tomas Härdin a écrit : +for ( comp = 0; comp < component_count; comp++ ) { +avio_write(pb, &sc->j2k_info.j2k_comp_desc[3*comp] , 3); +} Looks like this could be simplified to just avio_write(pb, sc->j2k_info.j2k_comp_desc, 3*component_count); +if

Re: [FFmpeg-devel] [PATCH] lavc: remove the QOA decoder

2023-12-20 Thread Tomas Härdin
tis 2023-12-19 klockan 15:02 +0100 skrev Nicolas George: > Tomas Härdin (12023-12-19): > > Technical debt concerns everyone > > There is no technical debt. There is never a technical debt from > something that can be removed at an instant notice and that some are > considering removing now I'm no

Re: [FFmpeg-devel] [PATCH v1] avcodec/av1dec: Add tile list OBU to decompose list

2023-12-20 Thread Andreas Rheinhardt
fei.w.wang-at-intel@ffmpeg.org: > From: Fei Wang > > Show the unsupported message and return unsupported for clips contain > tile list OBU since it hasn't been implemented. Otherwise, decoding > maybe successful but result is incorrect. > > Signed-off-by: Fei Wang > --- > libavcodec/av1dec

[FFmpeg-devel] [PATCH] configure: Disable inline assembly with nonlocal labels with LTO on Clang on Windows

2023-12-20 Thread Martin Storsjö
The file libavcodec/x86/mlpdsp_init.c uses inline assembly with nonlocal labels that are referenced outside of the assembly in C. This fails to link with LTO when built with Clang when targeting Windows. The root cause has been reported upstream at https://github.com/llvm/llvm-project/issues/76046

[FFmpeg-devel] [PATCH] libavcodec: fix -Wint-conversion in vulkan

2023-12-20 Thread Sam James
FIx warnings (soon to be errors in GCC 14, already so in Clang 15): ``` src/libavcodec/vulkan_av1.c: In function ‘vk_av1_create_params’: src/libavcodec/vulkan_av1.c:183:43: error: initialization of ‘long long unsigned int’ from ‘void *’ makes integer from pointer without a cast [-Wint-conversion]

Re: [FFmpeg-devel] [PATCH v2] fftools/ffplay: split filters & show modes cycling into separate keys

2023-12-20 Thread Ondřej Fiala
On Tue Dec 19, 2023 at 9:12 PM CET, Ondřej Fiala wrote: > ... > > diff --git a/fftools/ffplay.c b/fftools/ffplay.c > index 873ee8cc74..05182d9f49 100644 > --- a/fftools/ffplay.c > +++ b/fftools/ffplay.c > @@ -3370,14 +3370,11 @@ static void event_loop(VideoState *cur_stream) > case SDL

Re: [FFmpeg-devel] Subject: [PATCH 3/3] lavc/dnxhdenc: R-V V get_pixels_8x4_sym

2023-12-20 Thread flow gg
Because the format of [PATCH 1/3] was modified, this patch needs to be changed, and it has been modified in this reply. flow gg 于2023年12月20日周三 16:41写道: > C908: > get_pixels_8x4_sym_c: 297.2 > get_pixels_8x4_sym_rvv_i64: 52.7 > ___ > ffmpeg-devel mailin

Re: [FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init

2023-12-20 Thread flow gg
> typo in 'lavc' fixed. > Brace should be on its own line fixed > Shouldn't it actually replace the existing ff_dnxhdenc_init_x86() call in dnxhdenc.c? Sorry, I missed this part, it's fixed in this reply Anton Khirnov 于2023年12月20日周三 17:51写道: > Quoting flow gg (2023-12-20 09:39:57) > > > > >

Re: [FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init

2023-12-20 Thread Anton Khirnov
Quoting flow gg (2023-12-20 09:39:57) > > > From 3f8adabeac408ada6048a1e2ac472534f970364e Mon Sep 17 00:00:00 2001 > From: sunyuechi > Date: Wed, 20 Dec 2023 16:17:32 +0800 > Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init typo in 'lavc' > > This is for clarity and use in testing, co

Re: [FFmpeg-devel] [PATCH v3 1/3] fftools/ffmpeg_filter: fix NULL pointer dereference

2023-12-20 Thread Anton Khirnov
Quoting Zhao Zhili (2023-12-20 11:26:22) > From: Zhao Zhili > > In close_output(), a dummy frame is created with format NONE passed > to enc_open(), which isn't prepared for it. The NULL pointer > dereference happened at > av_pix_fmt_desc_get(enc_ctx->pix_fmt)->comp[0].depth. > > When fgt.graph

Re: [FFmpeg-devel] [PATCH] configure: Add a --disable-version-tracking option

2023-12-20 Thread Anton Khirnov
Quoting Martin Storsjö (2023-12-20 09:12:21) > On Fri, 15 Dec 2023, Martin Storsjö wrote: > > > This disables regenerating ffversion.h whenever the checked out > > git commit changes, speeding up development rebuilds. > > > > Whenever this option is set, force the version to be printed as > > "unk

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: remove myself from FFmpeg

2023-12-20 Thread Nicolas George
Vittorio Giovara (12023-12-19): > I am not too sure that bringing up a topic from 12 days ago with arguments > from 12 years ago is bringing any value to the conversation. Those who do not learn from history are bound to repeat it. > J

Re: [FFmpeg-devel] Subject: [PATCH 3/3] lavc/dnxhdenc: R-V V get_pixels_8x4_sym

2023-12-20 Thread flow gg
There are only three emails in my Sent Items, but there are six at ffmpeg-devel.. I'm not quite sure why, please ignore the three duplicates. flow gg 于2023年12月20日周三 16:41写道: > C908: > get_pixels_8x4_sym_c: 297.2 > get_pixels_8x4_sym_rvv_i64: 52.7 > ___

[FFmpeg-devel] [PATCH v1] avcodec/av1dec: Add tile list OBU to decompose list

2023-12-20 Thread fei . w . wang-at-intel . com
From: Fei Wang Show the unsupported message and return unsupported for clips contain tile list OBU since it hasn't been implemented. Otherwise, decoding maybe successful but result is incorrect. Signed-off-by: Fei Wang --- libavcodec/av1dec.c | 5 + 1 file changed, 5 insertions(+) diff --

[FFmpeg-devel] Subject: [PATCH 3/3] lavc/dnxhdenc: R-V V get_pixels_8x4_sym

2023-12-20 Thread flow gg
C908: get_pixels_8x4_sym_c: 297.2 get_pixels_8x4_sym_rvv_i64: 52.7 From 6fe4dbe9af39af50a1bf2069e91dfa542d83fee3 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Wed, 20 Dec 2023 16:28:33 +0800 Subject: [PATCH 3/3] lavc/dnxhdenc: R-V V get_pixels_8x4_sym C908: get_pixels_8x4_sym_c: 297.2 get_pixels

[FFmpeg-devel] Subject: [PATCH 2/3] checkasm/dnxhdenc: add get_pixels_8x4_sym test

2023-12-20 Thread flow gg
From 2f17a594805615a93f3f475246d61d61cc0aa43b Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Wed, 20 Dec 2023 16:21:38 +0800 Subject: [PATCH 2/3] checkasm/dnxhdenc: add get_pixels_8x4_sym test --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h |

[FFmpeg-devel] Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init

2023-12-20 Thread flow gg
From 3f8adabeac408ada6048a1e2ac472534f970364e Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Wed, 20 Dec 2023 16:17:32 +0800 Subject: [PATCH 1/3] lvac/dnxhdenc: add ff_dnxhdenc_init This is for clarity and use in testing, consistent with other parts of the code. --- libavcodec/dnxhdenc.c | 6 ++

Re: [FFmpeg-devel] [PATCH] configure: Add a --disable-version-tracking option

2023-12-20 Thread Martin Storsjö
On Fri, 15 Dec 2023, Martin Storsjö wrote: This disables regenerating ffversion.h whenever the checked out git commit changes, speeding up development rebuilds. Whenever this option is set, force the version to be printed as "unknown" rather than showing potentially stale information. --- Makef

Re: [FFmpeg-devel] [PATCH] checkasm: Remove unnecessary const on scalar parameters

2023-12-20 Thread Martin Storsjö
On Mon, 18 Dec 2023, Martin Storsjö wrote: The ffmpeg coding style doesn't usually use const on scalar parameters (or on the pointer values - as opposed to the type that is pointed to, where it has a semantic meaning), contrary to the dav1d coding style (where this was imported from). This avoi