I modified the temporary test and sent it in "[FFmpeg-devel] [PATCH]
checkasm/ac3dsp: add float_to_fixed24 test".
So the test time results have changed, and I updated them in the patch.
c910
float_to_fixed24_c: 2207.2
float_to_fixed24_rvv_f32: 696.2
flow gg 于2023年11月22日周三 20:00写道：
> c910
>
From 02dd534bd602ba3ec79e51070934949a98f780e2 Mon Sep 17 00:00:00 2001
From: sunyuechi
Date: Wed, 22 Nov 2023 14:57:29 +0800
Subject: [PATCH] checkasm/ac3dsp: add float_to_fixed24 test
---
tests/checkasm/Makefile | 1 +
tests/checkasm/ac3dsp.c | 71 +++
On Wed, 22 Nov 2023, 19:49 James Almer, wrote:
> Signed-off-by: James Almer
> ---
> libavcodec/ac3dsp.h | 4 ++--
> libavcodec/ac3enc_template.c | 2 +-
> libavcodec/x86/ac3dsp.asm| 28 ++--
> libavcodec/x86/ac3dsp_init.c | 4
> 4 files changed, 33 i
Hello, I saw the new commit "avcodec/ac3dsp: make len a size_t in
float_to_fixed24."
So I removed the part #if (__riscv_xlen == 64) and restored the patch.
From 3e790fdccd780257f464aa8f8a56a37321ddd429 Mon Sep 17 00:00:00 2001
From: sunyuechi
Date: Wed, 22 Nov 2023 14:57:29 +0800
Subject: [PATCH]
LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Fixes https://crbug.com/1499669:
runtime error: signed integer overflow: 9223372036853334272 + 1375731456
cannot be represented in type 'int64_t' (aka 'long')
Signed-off-by: Dale Curtis
---
libavformat/mov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/mov.c b/
Signed-off-by: James Almer
---
libavfilter/asrc_anullsrc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavfilter/asrc_anullsrc.c b/libavfilter/asrc_anullsrc.c
index a8887da62d..a48728eaf0 100644
--- a/libavfilter/asrc_anullsrc.c
+++ b/libavfilter/asrc_anullsrc.c
@@ -
Le keskiviikkona 22. marraskuuta 2023, 21.49.13 EET James Almer a écrit :
> Should simplify asm implementations, and prevent UB on at least win64.
>
> Signed-off-by: James Almer
This one looks good to me, but I am utterly incompetent for the previous two.
--
雷米‧德尼-库尔蒙
http://www.remlab.net/
Should simplify asm implementations, and prevent UB on at least win64.
Signed-off-by: James Almer
---
libavcodec/ac3dsp.c | 2 +-
libavcodec/ac3dsp.h | 2 +-
libavcodec/arm/ac3dsp_init_arm.c | 2 +-
libavcodec/mips/ac3dsp_mips.c| 2 +-
libavcodec/x86/ac3dsp_init.c
Signed-off-by: James Almer
---
libavcodec/ac3dsp.h | 4 ++--
libavcodec/ac3enc_template.c | 2 +-
libavcodec/x86/ac3dsp.asm| 28 ++--
libavcodec/x86/ac3dsp_init.c | 4
4 files changed, 33 insertions(+), 5 deletions(-)
diff --git a/libavcodec/ac3dsp.h
Signed-off-by: James Almer
---
libavcodec/x86/ac3dsp.asm | 46 +++
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/libavcodec/x86/ac3dsp.asm b/libavcodec/x86/ac3dsp.asm
index a95d359d95..42c8310462 100644
--- a/libavcodec/x86/ac3dsp.asm
+++ b/li
Am 22.11.23 um 03:54 schrieb Cosmin Stejerean via ffmpeg-devel:
On Nov 20, 2023, at 5:14 PM, James Almer wrote:
On 11/20/2023 4:22 PM, Thilo Borgmann via ffmpeg-devel wrote:
+ if (*got_frame) {
+ if (!(s->vp8x_flags & VP8X_FLAG_ANIMATION)) {
+ // no animation, output the de
Wow, thank you for reviewing this. I just wanted to see if the function was
working properly. There are so many bugs in the test code ...
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscrib
On 11/22/2023 11:30 AM, flow gg wrote:
How did you test it?
I wrote a test, but it was a bit rough, so I want to modify it before
submitting. I've added it to this reply.
From 08a012d86db51275fd2cda8dd7ad47cc1f1481ce Mon Sep 17 00:00:00 2001
From: sunyuechi
Date: Wed, 22 Nov 2023 14:57:29
On 11/22/2023 1:37 PM, flow gg wrote:
Thank you for your guidance, I finally understand.. How about choosing
manual zero-extension for rv64? I modified the patch.
#if (__riscv_xlen == 64)
slli a2, a2, 32
srli a2, a2, 32
#endif
Please, don't top post.
I think it will be bett
Thank you for your guidance, I finally understand.. How about choosing
manual zero-extension for rv64? I modified the patch.
#if (__riscv_xlen == 64)
slli a2, a2, 32
srli a2, a2, 32
#endif
Rémi Denis-Courmont 于2023年11月22日周三 22:51写道：
>
>
> Le 22 novembre 2023 16:30:44 GMT+02:00,
Le 22 novembre 2023 16:30:44 GMT+02:00, flow gg a écrit :
>> How did you test it?
>
>I wrote a test, but it was a bit rough, so I want to modify it before
>submitting. I've added it to this reply.
>
>> This does not seem according to the C ABI. AFAIK `unsigned` is
>sign-extended.
>
>I'm a bit co
qemu-riscv64 -cpu rv64,v=true,g=true,c=true,zba=true,vlen=128 checkasm
--test=ac3dsp
flow gg 于2023年11月22日周三 22:30写道：
> > How did you test it?
>
> I wrote a test, but it was a bit rough, so I want to modify it before
> submitting. I've added it to this reply.
>
> > This does not seem according to
> How did you test it?
I wrote a test, but it was a bit rough, so I want to modify it before
submitting. I've added it to this reply.
> This does not seem according to the C ABI. AFAIK `unsigned` is
sign-extended.
I'm a bit confused... because this passed in the tests I wrote in qemu.
Maybe ther
Hi,
How did you test it? As per
http://ffmpeg.org/pipermail/ffmpeg-devel/2023-June/310720.html we still don't
have a FATE instance set up with the RISC-V Vector extension. The only testing
consists of my manual runs of checkasm on a K230 board. (We *do* have Zba and
Zbb now though, hence the e
Hi
On Wed, Nov 22, 2023 at 01:45:05PM +0100, Niklas Haas wrote:
> On Tue, 14 Nov 2023 23:52:50 +0100 Michael Niedermayer
> wrote:
> > would this result in overall cleaner code or do you see some problems
> > with this ?
> >
> > Given the messi-ness that the always setting results in i would may
On Tue, 14 Nov 2023 23:52:50 +0100 Michael Niedermayer
wrote:
> would this result in overall cleaner code or do you see some problems
> with this ?
>
> Given the messi-ness that the always setting results in i would maybe
> suggest to explore this and see if this is cleaner.
>
> Its conceptuall
On Wed, 22 Nov 2023, Logan.Lyu wrote:
I can't reproduce the error you mentioned...
I can apply patches to the ffmpeg master branch normally using 'git
apply xxx.patch/.eml' or 'git am xxx.patch/.eml'.
I guess you have emails that haven't been through the complete delivery
chain, while some
Hi Michael,
Thank you for reply.
I can't reproduce the error you mentioned...
I can apply patches to the ffmpeg master branch normally using 'git
apply xxx.patch/.eml' or 'git am xxx.patch/.eml'.
By the way, I create these patches by /'git format-patch -s -o "../"
--add-header "X-Unsent: 1"
c910
float_to_fixed24_c: 208.2
float_to_fixed24_rvv_f32: 71.5
From 69da974fd0febaa74db4dd551b05172caeefb846 Mon Sep 17 00:00:00 2001
From: sunyuechi
Date: Wed, 22 Nov 2023 14:57:29 +0800
Subject: [PATCH] lavc/ac3dsp: R-V V float_to_fixed24
c910
float_to_fixed24_c: 208.2
float_to_f
On Wed, 22 Nov 2023, Zhao Zhili wrote:
I have taken code from ftp.c as reference:
```
if (s->rw_timeout != -1) {
av_dict_set_int(&opts, "timeout", s->rw_timeout, 0);
} /* if option is not given, don't pass it and let tcp use its own
default */
```
Ah, I see!
Now it’s
> On Nov 22, 2023, at 17:40, Zhao Zhili wrote:
>
>
>
>> On Nov 22, 2023, at 17:33, Martin Storsjö wrote:
>>
>> On Wed, 22 Nov 2023, Zhao Zhili wrote:
>>
>>>
>>>
On Nov 15, 2023, at 21:24, Zhao Zhili wrote:
From: Zhao Zhili
Signed-off-by: Zhao Zhili
---
> On Nov 22, 2023, at 17:33, Martin Storsjö wrote:
>
> On Wed, 22 Nov 2023, Zhao Zhili wrote:
>
>>
>>
>>> On Nov 15, 2023, at 21:24, Zhao Zhili wrote:
>>>
>>> From: Zhao Zhili
>>>
>>> Signed-off-by: Zhao Zhili
>>> ---
>>> libavformat/rtmpproto.c | 3 +++
>>> 1 file changed, 3 insertions(
On Wed, 22 Nov 2023, Zhao Zhili wrote:
On Nov 15, 2023, at 21:24, Zhao Zhili wrote:
From: Zhao Zhili
Signed-off-by: Zhao Zhili
---
libavformat/rtmpproto.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index 98718bc6da..a0c6195eb2
Michael Niedermayer writes:
> Signed-off-by: Michael Niedermayer
> ---
> doc/git-howto.texi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Most people probably use git@ already, seems to be more common practice
in general. Both users map to the same id on the server so would make
s
> On Nov 15, 2023, at 21:24, Zhao Zhili wrote:
>
> From: Zhao Zhili
>
> Signed-off-by: Zhao Zhili
> ---
> libavformat/rtmpproto.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
> index 98718bc6da..a0c6195eb2 100644
> --- a/libav
31 matches
Mail list logo
