Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c

2023-11-16 Thread Kyle Swanson
Hi, On Wed, Nov 15, 2023 at 12:39 PM Paul B Mahol wrote: > > Attached. Only had a few minutes to look at this. Seems like more than just merging two filters, I see a bunch of new filter options for example. Can you explain? Thanks, Kyle ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] cherrypick ab7926341 into 4.2

2023-11-16 Thread Martin Storsjö
On Thu, 16 Nov 2023, Michael Niedermayer wrote: On Thu, Nov 16, 2023 at 02:35:58PM -0800, Reed Weichler wrote: pretty self-explanatory. i guess they forgot to cherrypick it when it was first committed. here is my code to repro: https://pastebin.com/raw/yQr3WWvX it needs a FLAC file as input. it

Re: [FFmpeg-devel] [PATCH v3 1/8] swscale: fix sws_setColorspaceDetails after sws_init_context

2023-11-16 Thread Michael Niedermayer
On Tue, Nov 07, 2023 at 02:08:35PM +0100, Niklas Haas wrote: > Will apply soon. It seems this causes an assertion failue: libswscale/tests/swscale grayf32be -> grayf32be grayf32be 96x96 -> grayf32be 64x 64 flags= 1 CRC=d85005d7 SSD=0, 958, 667,0 grayf32be 96x96 -> grayf32be 64x 96

Re: [FFmpeg-devel] [PATCH] cherrypick ab7926341 into 4.2

2023-11-16 Thread Michael Niedermayer
On Thu, Nov 16, 2023 at 02:35:58PM -0800, Reed Weichler wrote: > pretty self-explanatory. > i guess they forgot to cherrypick it when it was first committed. > here is my code to repro: https://pastebin.com/raw/yQr3WWvX > it needs a FLAC file as input. > it hit an EXC_BAD_ACCESS here: > https://git

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/qsv: add sps pps header when frame->key_frame is true

2023-11-16 Thread Michael Niedermayer
On Thu, Nov 16, 2023 at 12:06:56PM +0800, Zhongwei Wang via ffmpeg-devel wrote: > The key_frame currently doesn't set extra header into frames when using qsv > encoders. > > Signed-off-by: reito > --- > libavcodec/qsvenc.c | 31 +++ > 1 file changed, 31 insertions(+)

[FFmpeg-devel] [PATCH] cherrypick ab7926341 into 4.2

2023-11-16 Thread Reed Weichler
pretty self-explanatory. i guess they forgot to cherrypick it when it was first committed. here is my code to repro: https://pastebin.com/raw/yQr3WWvX it needs a FLAC file as input. it hit an EXC_BAD_ACCESS here: https://github.com/FFmpeg/FFmpeg/blob/c6c36aa97a/libavformat/utils.c#L2227 index was e

Re: [FFmpeg-devel] [PATCH] cherrypick ab7926341 into 4.2

2023-11-16 Thread Reed Weichler
Oops, sorry. I forgot to turn off HTML. Let me retry On Thu, Nov 16, 2023 at 2:28 PM Reed Weichler wrote: > pretty self-explanatory. > i guess they forgot to cherrypick it when it was first committed. > here is my code to repro: https://pastebin.com/raw/yQr3WWvX > it needs a FLAC file as input.

[FFmpeg-devel] [PATCH] cherrypick ab7926341 into 4.2

2023-11-16 Thread Reed Weichler
pretty self-explanatory. i guess they forgot to cherrypick it when it was first committed. here is my code to repro: https://pastebin.com/raw/yQr3WWvX it needs a FLAC file as input. it hit an EXC_BAD_ACCESS here: https://github.com/FFmpeg/FFmpeg/blob/c6c36aa97a/libavformat/utils.c#L2227 index was e

[FFmpeg-devel] [PATCH] riscv: set fast half-precision conversion

2023-11-16 Thread Rémi Denis-Courmont
This is only supported at compilation time. If Zfhmin is supported, then conversions are fast, which is what the flag is used for. At this time, run-tiem detection is not possible, as in not supported by Linux. But even if it were, the current FFmpeg approach seems unable to deal with it (same prob

Re: [FFmpeg-devel] [PATCH] checkasm/riscv: use t0 as alternative link register

2023-11-16 Thread Rémi Denis-Courmont
Le torstaina 16. marraskuuta 2023, 18.04.51 EET Rémi Denis-Courmont a écrit : > The unprivileged ISA specification says that either RA or T0 should be > used for this purpose. Other registers may confuse the return address > prediction stack. Need more sleep. This is true for the link register (th

[FFmpeg-devel] [PATCH 2/2] checkasm/riscv: report an error upon SIGILL

2023-11-16 Thread Rémi Denis-Courmont
Terminating the whole checkasm process is not very helpful. This will report if an illegal instruction occurs while executing a tested function. This is a common occurrence whilst developping RISC-V assembler, due to the compatibility between vector configuration and instruction done at run-time. -

[FFmpeg-devel] [PATCH 1/2] checkasm: add helper to report a fatal signal

2023-11-16 Thread Rémi Denis-Courmont
--- tests/checkasm/checkasm.c | 15 +++ tests/checkasm/checkasm.h | 1 + 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 708119e7c6..c67cf58922 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/check

[FFmpeg-devel] [PATCH] checkasm/riscv: use t0 as alternative link register

2023-11-16 Thread Rémi Denis-Courmont
The unprivileged ISA specification says that either RA or T0 should be used for this purpose. Other registers may confuse the return address prediction stack. --- tests/checkasm/riscv/checkasm.S | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/riscv/checka

Re: [FFmpeg-devel] [PATCH v6] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-16 Thread James Almer
On 11/15/2023 3:47 PM, Ronald S. Bultje wrote: Hi, On Sun, Nov 12, 2023 at 8:53 PM Dai, Jianhui J < jianhui.j.dai-at-intel@ffmpeg.org> wrote: TESTS: ffmpeg -i fate-suite/vp8/frame_size_change.webm -vcodec copy -bsf:v trace_headers -f null - (I've merged this already.) I don't think a f

Re: [FFmpeg-devel] [PATCH v6] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-11-16 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of > Ronald S. Bultje > Sent: Thursday, November 16, 2023 2:47 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v6] avcodec/cbs_vp8: Add support for > VP8 codec bitstream > > H