[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix OOB read regression

2023-10-12 Thread Leo Izen
In f7ac3512f5b5cb8eb149f37300b43461d8e93af3 the size of the dynamically allocated buffer was shrunk, but it was made too small for very small alphabet sizes. This patch sets a minimum size to prevent an OOB read. Reported-by: Cole Dilorenzo Signed-off-by: Leo Izen --- libavcodec/jpegxl_parser.c

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/evc_ps: Check chroma_format_idc

2023-10-12 Thread Kieran Kunhya
On Fri, 13 Oct 2023 at 00:28, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 62678/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4858264984354816 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by >

[FFmpeg-devel] [PATCH 3/3] avcodec/evc_parse: Check tid

2023-10-12 Thread Michael Niedermayer
The check is based on not infinite looping. It is likely a more strict check can be done Fixes: Infinite loop Fixes: 62473/clusterfuzz-testcase-minimized-ffmpeg_BSF_EVC_FRAME_MERGE_fuzzer-5719883750703104 Fixes: 62765/clusterfuzz-testcase-minimized-ffmpeg_dem_EVC_fuzzer-6448531252314112 Found-b

[FFmpeg-devel] [PATCH 2/3] avcodec/evc_parse: remove pow() and log2()

2023-10-12 Thread Michael Niedermayer
The use of float based functions is both unneeded and wrong due to unpredictable rounding Signed-off-by: Michael Niedermayer --- libavcodec/evc_parse.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/evc_parse.c b/libavcodec/evc_parse.c index bd3a4416f2

[FFmpeg-devel] [PATCH 1/3] avcodec/evc_ps: Check chroma_format_idc

2023-10-12 Thread Michael Niedermayer
Fixes: out of array access Fixes: 62678/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4858264984354816 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/evc_ps.c | 4 1 file changed,

Re: [FFmpeg-devel] [PATCH 3/3] doc: add spi.txt

2023-10-12 Thread Stefano Sabatini
On date Wednesday 2023-10-11 20:10:15 +0200, Michael Niedermayer wrote: > This explains how to request refunds and what can be funded by SPI > --- > doc/spi.txt | 50 ++ > 1 file changed, 50 insertions(+) > create mode 100644 doc/spi.txt > > diff -

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264idct_template: Don't include h264dec.h

2023-10-12 Thread Andreas Rheinhardt
Andreas Rheinhardt: > It is only needed for scan8 which is in h264_parse.h. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/h264idct_template.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/h264idct_template.c b/libavcodec/h264idct_template.c > ind

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/error_resilience: Constify ThreadFrame*

2023-10-12 Thread Michael Niedermayer
On Tue, Oct 10, 2023 at 03:27:19AM +0200, Andreas Rheinhardt wrote: > Forgotten in 0eb399ac3953da16f880a1e455bb009a45f76d49. > While just at it, also use a forward declaration. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/error_resilience.h | 3 +-- > libavcodec/h264dec.h |

Re: [FFmpeg-devel] [PATCH] avfilter/libvmaf: update pix_fmts

2023-10-12 Thread Kyle Swanson
Hi, On Tue, Oct 10, 2023 at 1:02 PM Kyle Swanson wrote: > This patch adds 12/16-bit support to the libvmaf filter. Unless there > are questions/reviews, I'll push tomorrow. Patch attached. Merged. Thanks, Kyle ___ ffmpeg-devel mailing list ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 3/3] doc: add spi.txt

2023-10-12 Thread Lynne
Oct 12, 2023, 19:37 by mich...@niedermayer.cc: > On Thu, Oct 12, 2023 at 10:03:20AM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: >> > This explains how to request refunds and what can be funded by SPI >> > --- >> > doc/spi.txt | 50 ++

Re: [FFmpeg-devel] [PATCH 3/3] doc: add spi.txt

2023-10-12 Thread Michael Niedermayer
On Thu, Oct 12, 2023 at 10:03:20AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > This explains how to request refunds and what can be funded by SPI > > --- > > doc/spi.txt | 50 ++ > > 1 file changed, 50 insertions(+) > > create mode 1

Re: [FFmpeg-devel] [PATCH 24/42] avcodec/refstruct: Allow to share pools

2023-10-12 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2023-10-12 15:51:18) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2023-09-19 21:57:16) To do this, make FFRefStructPool itself refcounted according to the RefStruct API. Signed-off-by: Andreas Rheinhardt --- libavcode

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: add hw_configs

2023-10-12 Thread Zhao Zhili
> From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: 2023年10月12日 22:56 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: add > hw_configs > > Zhao Zhili: > > > >> From: ffmpeg-devel On Behalf Of Andreas > >> Rheinhardt > >> Sent: 2023年

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: add hw_configs

2023-10-12 Thread Andreas Rheinhardt
Zhao Zhili: > >> From: ffmpeg-devel On Behalf Of Andreas >> Rheinhardt >> Sent: 2023年10月12日 22:01 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: add >> hw_configs >> >> Zhao Zhili: >>> From: Zhao Zhili >>> >>> Will be used in the following pa

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: add hw_configs

2023-10-12 Thread Zhao Zhili
> From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: 2023年10月12日 22:01 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: add > hw_configs > > Zhao Zhili: > > From: Zhao Zhili > > > > Will be used in the following patches. > > It doesn'

Re: [FFmpeg-devel] [PATCH 24/42] avcodec/refstruct: Allow to share pools

2023-10-12 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2023-10-12 15:51:18) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2023-09-19 21:57:16) To do this, make FFRefStructPool itself refcounted according to the RefStruct API. Signed-off-by: Andreas Rheinhardt --- libavcode

Re: [FFmpeg-devel] [PATCH 24/42] avcodec/refstruct: Allow to share pools

2023-10-12 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-10-12 15:51:18) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2023-09-19 21:57:16) > >> To do this, make FFRefStructPool itself refcounted according > >> to the RefStruct API. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcodec/refstruct.c | 29

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: add hw_configs

2023-10-12 Thread Andreas Rheinhardt
Zhao Zhili: > From: Zhao Zhili > > Will be used in the following patches. It doesn't seem to be used for 2/2, so it should be applied with the patches that actually need it. > --- > libavcodec/videotoolboxenc.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/libavcodec/video

Re: [FFmpeg-devel] [PATCH 21/42] avcodec/refstruct: Allow to always return zeroed pool entries

2023-10-12 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-10-12 15:25:14) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2023-09-19 21:57:13) > >> diff --git a/libavcodec/refstruct.h b/libavcodec/refstruct.h > >> Furthermore, it also makes the pool behave as if the > >> FF_REFSTRUCT_POOL_FLAG_NO_ZEROING flag had been pro

Re: [FFmpeg-devel] [PATCH 24/42] avcodec/refstruct: Allow to share pools

2023-10-12 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2023-09-19 21:57:16) >> To do this, make FFRefStructPool itself refcounted according >> to the RefStruct API. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/refstruct.c | 29 - >> libavcodec/refstruct.h | 5 ++

Re: [FFmpeg-devel] [PATCH 21/42] avcodec/refstruct: Allow to always return zeroed pool entries

2023-10-12 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2023-09-19 21:57:13) >> diff --git a/libavcodec/refstruct.h b/libavcodec/refstruct.h >> Furthermore, it also makes the pool behave as if the >> FF_REFSTRUCT_POOL_FLAG_NO_ZEROING flag had been provided. > > What does this imply for the caller? > It mea

Re: [FFmpeg-devel] [PATCH 24/42] avcodec/refstruct: Allow to share pools

2023-10-12 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-09-19 21:57:16) > To do this, make FFRefStructPool itself refcounted according > to the RefStruct API. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/refstruct.c | 29 - > libavcodec/refstruct.h | 5 - > 2 files changed,

[FFmpeg-devel] [PATCH 2/2] avcodec/videotoolboxenc: Check and set hevc profile

2023-10-12 Thread Zhao Zhili
From: Zhao Zhili 1. If user don't specify the profile, set it to main10 when pixel format is 10 bits. Before the patch, videotoolbox output main profile bitstream with 10 bit input, which can be confusing. 2. Warning when user set profile to main explicitly with 10 bit input. It works, b

[FFmpeg-devel] [PATCH 1/2] avcodec/videotoolboxenc: add hw_configs

2023-10-12 Thread Zhao Zhili
From: Zhao Zhili Will be used in the following patches. --- libavcodec/videotoolboxenc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 1d1595329a..b685bf4cc4 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcode

Re: [FFmpeg-devel] [PATCH 21/42] avcodec/refstruct: Allow to always return zeroed pool entries

2023-10-12 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2023-09-19 21:57:13) > diff --git a/libavcodec/refstruct.h b/libavcodec/refstruct.h > Furthermore, it also makes the pool behave as if the > FF_REFSTRUCT_POOL_FLAG_NO_ZEROING flag had been provided. What does this imply for the caller? -- Anton Khirnov ___

Re: [FFmpeg-devel] [PATCH 3/3] doc: add spi.txt

2023-10-12 Thread Andreas Rheinhardt
Michael Niedermayer: > This explains how to request refunds and what can be funded by SPI > --- > doc/spi.txt | 50 ++ > 1 file changed, 50 insertions(+) > create mode 100644 doc/spi.txt > > diff --git a/doc/spi.txt b/doc/spi.txt > new file mode 10