Re: [FFmpeg-devel] [RFC] Release 6.1

2023-10-08 Thread Lynne
Jul 6, 2023, 18:04 by d...@lynne.ee: > It's been a while since we've had a release, and we've had > a lot of new features in. > We did say we would make releases more often, and I think > it's about time we have a new release. > > Anything anyone wants to have merged or should we branch > off 6.1

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec, mov: Fix declaration-after-statement warnings

2023-10-08 Thread Michael Niedermayer
On Mon, Oct 09, 2023 at 12:16:35AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskadec.c | 5 ++--- > libavformat/mov.c | 2 +- > 2 files changed, 3 insertions(+), 4 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B

[FFmpeg-devel] [PATCH] avformat/matroskadec, mov: Fix declaration-after-statement warnings

2023-10-08 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 5 ++--- libavformat/mov.c | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index af0e5d7c0b..8f000f86be 100644 --- a/libavformat/matroskadec.c +++

Re: [FFmpeg-devel] [PATCH 01/15] avformat/concatdec: Check in/outpoint for overflow

2023-10-08 Thread Michael Niedermayer
On Sun, Oct 01, 2023 at 12:30:32AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 9154241445400 - -915424149454600 > cannot be represented in type 'long' > Fixes: > 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_CONCAT_fuzzer-4739147999084544 > > Found-by: continuou

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Output palette as stream side data

2023-10-08 Thread Andreas Rheinhardt
Michael Niedermayer: > On Thu, Oct 05, 2023 at 02:36:52PM +0200, Andreas Rheinhardt wrote: >> This is simpler implementation-wise (it avoids an almost-always-false >> check in read_packet and decreases sizeof(MatroskaTrack) by about 2/3) >> and makes the side-data available directly after read_head

Re: [FFmpeg-devel] [PATCH 05/13] avcodec/mpegvideo_enc: Don't reget known values

2023-10-08 Thread Michael Niedermayer
On Fri, Oct 06, 2023 at 04:46:28AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideo_enc.c | 15 --- > 1 file changed, 4 insertions(+), 11 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787

Re: [FFmpeg-devel] [PATCH 12/13] avcodec/mpeg(picture|video_dec): Move comment to more appropriate place

2023-10-08 Thread Michael Niedermayer
On Fri, Oct 06, 2023 at 04:46:35AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegpicture.c | 2 -- > libavcodec/mpegvideo_dec.c | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(-) ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/wmv2dec: Parse extradata during init

2023-10-08 Thread Michael Niedermayer
On Sat, Oct 07, 2023 at 02:37:39AM +0200, Andreas Rheinhardt wrote: > And stop setting picture_number which was only done to not parse > extradata multiple times. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/wmv2dec.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) sh

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/h261dec: Remove pointless goto

2023-10-08 Thread Michael Niedermayer
On Sat, Oct 07, 2023 at 02:40:28AM +0200, Andreas Rheinhardt wrote: > There is no need to parse the header twice; doing so does nothing. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/h261dec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavcodec/h261dec.c b/libavcodec

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Output palette as stream side data

2023-10-08 Thread Michael Niedermayer
On Thu, Oct 05, 2023 at 02:36:52PM +0200, Andreas Rheinhardt wrote: > This is simpler implementation-wise (it avoids an almost-always-false > check in read_packet and decreases sizeof(MatroskaTrack) by about 2/3) > and makes the side-data available directly after read_header. > > It also fixes the

Re: [FFmpeg-devel] [PATCH] avcodec/refstruct: Inline ff_refstruct_allocz()

2023-10-08 Thread James Almer
On 10/8/2023 7:21 AM, Andreas Rheinhardt wrote: Suggested by James Almer. Signed-off-by: Andreas Rheinhardt --- libavcodec/refstruct.c | 5 - libavcodec/refstruct.h | 6 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/refstruct.c b/libavcodec/refstruct.c

Re: [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1

2023-10-08 Thread Zhao Zhili
> On Oct 8, 2023, at 21:17, Zhao Zhili wrote: > > From: Zhao Zhili > > The last frame is corrupted. It has different results on different > platform. > --- > tests/fate/screen.mak| 3 ++- > tests/ref/fate/zmbv-8bit | 1 - > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/

[FFmpeg-devel] [PATCH] avcodec/zmbv: handle corrupted packet

2023-10-08 Thread Zhao Zhili
From: Zhao Zhili Mark the frame as corrupt when AV_CODEC_FLAG_OUTPUT_CORRUPT is set, drop the frame otherwise. --- libavcodec/zmbv.c| 26 -- tests/ref/fate/zmbv-8bit | 1 - 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/libavcodec/zmbv.c b/libavc

[FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1

2023-10-08 Thread Zhao Zhili
From: Zhao Zhili The last frame is corrupted. It has different results on different platform. --- tests/fate/screen.mak| 3 ++- tests/ref/fate/zmbv-8bit | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fate/screen.mak b/tests/fate/screen.mak index bd6d228544..1c929

Re: [FFmpeg-devel] [PATCH v1] avcodec/libaomdec: don't set aspect ratio when it's not yet known

2023-10-08 Thread James Almer
On 10/8/2023 9:45 AM, Steven Liu wrote: James Almer 于2023年10月8日 周日20:08写道: On 10/8/2023 8:57 AM, Steven Liu wrote: Makes the output of the libaom av1 decoder consistent with external decoders like libdav1d. reference commit: 1652f2492f88434010053289d946dab6a57e4d58 But it is known at this

Re: [FFmpeg-devel] [PATCH v1] avcodec/libaomdec: don't set aspect ratio when it's not yet known

2023-10-08 Thread Steven Liu
James Almer 于2023年10月8日 周日20:08写道: > On 10/8/2023 8:57 AM, Steven Liu wrote: > > Makes the output of the libaom av1 decoder consistent with external > decoders like > > libdav1d. > > > > reference commit: 1652f2492f88434010053289d946dab6a57e4d58 > > But it is known at this point. picture->sample_a

Re: [FFmpeg-devel] [PATCH v1] avcodec/libaomdec: don't set aspect ratio when it's not yet known

2023-10-08 Thread James Almer
On 10/8/2023 8:57 AM, Steven Liu wrote: Makes the output of the libaom av1 decoder consistent with external decoders like libdav1d. reference commit: 1652f2492f88434010053289d946dab6a57e4d58 But it is known at this point. picture->sample_aspect_ratio is set directly above. What needs to be

[FFmpeg-devel] [PATCH v1] avcodec/libaomdec: don't set aspect ratio when it's not yet known

2023-10-08 Thread Steven Liu
Makes the output of the libaom av1 decoder consistent with external decoders like libdav1d. reference commit: 1652f2492f88434010053289d946dab6a57e4d58 Signed-off-by: Steven Liu --- libavcodec/libaomdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/libaomdec.c b/libavcodec/lib

[FFmpeg-devel] [PATCH] avcodec/refstruct: Inline ff_refstruct_allocz()

2023-10-08 Thread Andreas Rheinhardt
Suggested by James Almer. Signed-off-by: Andreas Rheinhardt --- libavcodec/refstruct.c | 5 - libavcodec/refstruct.h | 6 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/refstruct.c b/libavcodec/refstruct.c index 9a6575f987..2e055d539e 100644 --- a/libavcodec