Re: [FFmpeg-devel] [PATCH] cbs_av1: Make fake OBU size length field a write option

2023-09-25 Thread Wang, Fei W
On Mon, 2023-09-25 at 14:53 +0100, Mark Thompson wrote: > This is an option to modify the behaviour of the writer, not a syntax > field. > --- > Tested by hacking av1_metadata. For example, adding: > > av_opt_set_int(ctx->common.output->priv_data, > "fixed_obu_size_length", 7, 0); > > gets you O

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/codec_par: Move enum AVFieldOrder to defs.h

2023-09-25 Thread James Almer
On 9/25/2023 8:55 PM, Andreas Rheinhardt wrote: It is also used by AVCodecContext. Signed-off-by: Andreas Rheinhardt --- doc/APIchanges | 3 +++ libavcodec/codec_par.h | 10 +- libavcodec/defs.h | 8 3 files changed, 12 insertions(+), 9 deletions(-) diff --

[FFmpeg-devel] [PATCH 3/3] avcodec/avcodec: Avoid codec_desc.h, codec_par.h inclusions

2023-09-25 Thread Andreas Rheinhardt
Instead, use forward declarations; and in order not to affect any user include these headers for them, but not internally. This has the advantage of removing implicit inclusions of these headers from almost all files providing codecs. Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.c

[FFmpeg-devel] [PATCH 2/3] avcodec/codec_par: Move enum AVFieldOrder to defs.h

2023-09-25 Thread Andreas Rheinhardt
It is also used by AVCodecContext. Signed-off-by: Andreas Rheinhardt --- doc/APIchanges | 3 +++ libavcodec/codec_par.h | 10 +- libavcodec/defs.h | 8 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index ca7ffbb97e

[FFmpeg-devel] [PATCH v2 1/3] avformat/avformat: Deprecate AVFMT_ALLOW_FLUSH

2023-09-25 Thread Andreas Rheinhardt
It is of no value to the user, because every muxer can always be flushed with a NULL packet. As its documentation shows ("If not set, the muxer will not receive a NULL packet in the write_packet function") it is actually an internal flag that has been publically exposed because there was no interna

Re: [FFmpeg-devel] [PATCH] avformat/avformat: Deprecate AVFMT_ALLOW_FLUSH

2023-09-25 Thread James Almer
On 9/25/2023 7:45 PM, Andreas Rheinhardt wrote: It is of no value to the user, because every muxer can always be flushed with a NULL packet. As its documentation shows ("If not set, the muxer will not receive a NULL packet in the write_packet function") it is actually an internal flag that has be

[FFmpeg-devel] [PATCH] avformat/avformat: Deprecate AVFMT_ALLOW_FLUSH

2023-09-25 Thread Andreas Rheinhardt
It is of no value to the user, because every muxer can always be flushed with a NULL packet. As its documentation shows ("If not set, the muxer will not receive a NULL packet in the write_packet function") it is actually an internal flag that has been publically exposed because there were no intern

[FFmpeg-devel] [PATCH] avdevice/fbdev_common: Make declaration proper prototype

2023-09-25 Thread Andreas Rheinhardt
Fixes a -Wstrict-prototypes warning from Clang 15. Signed-off-by: Andreas Rheinhardt --- libavdevice/fbdev_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/fbdev_common.c b/libavdevice/fbdev_common.c index 47e7edde5c..2c70abb1f0 100644 --- a/libavdevice/fb

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: Remove unused function

2023-09-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/jpegxl_parser.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c index 6656ed35c5..d25a1b6e1d 100644 --- a/libavcodec/jpegxl_parser.c +++ b/libavcodec/jpegxl_parser.c @@ -223,11 +223,6

[FFmpeg-devel] [PATCH] avcodec/error_resilience: Remove set-but-not-used variable

2023-09-25 Thread Andreas Rheinhardt
Fixes a -Wunused-but-set-variable from Clang 15. Signed-off-by: Andreas Rheinhardt --- libavcodec/error_resilience.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/error_resilience.c b/libavcodec/error_resilience.c index 880aea6f30..9d03e53237 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH 00/10 v4][RFC] AVCodecContext and AVCodecParameters side data

2023-09-25 Thread James Almer
On 9/25/2023 5:02 PM, Paul B Mahol wrote: On 9/25/23, James Almer wrote: On 9/14/2023 1:40 PM, James Almer wrote: On 9/14/2023 12:43 PM, Anton Khirnov wrote: Quoting James Almer (2023-09-06 19:44:20) Changes since the previous version: - Removed the AVPacketSideDataSet from AVCodecContext, u

Re: [FFmpeg-devel] [PATCH 00/10 v4][RFC] AVCodecContext and AVCodecParameters side data

2023-09-25 Thread Paul B Mahol
On 9/25/23, James Almer wrote: > On 9/14/2023 1:40 PM, James Almer wrote: >> On 9/14/2023 12:43 PM, Anton Khirnov wrote: >>> Quoting James Almer (2023-09-06 19:44:20) Changes since the previous version: - Removed the AVPacketSideDataSet from AVCodecContext, using instead the exis

Re: [FFmpeg-devel] [PATCH 01/42] tests/fate-run: Ensure that THREADS=random is actually random

2023-09-25 Thread Andreas Rheinhardt
Andreas Rheinhardt: > From the documentation of GNU awk [1]: > "In most awk implementations, including gawk, rand() starts generating > numbers from the same starting number, or seed, each time you run awk.45 > Thus, a program generates the same results each time you run it. The > numbers are rando

Re: [FFmpeg-devel] [PATCH 00/10 v4][RFC] AVCodecContext and AVCodecParameters side data

2023-09-25 Thread James Almer
On 9/14/2023 1:40 PM, James Almer wrote: On 9/14/2023 12:43 PM, Anton Khirnov wrote: Quoting James Almer (2023-09-06 19:44:20) Changes since the previous version: - Removed the AVPacketSideDataSet from AVCodecContext, using instead the    existing coded_side_data field, at Anton's request. I s

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vmixdec: Fix signed integer overflow in dc

2023-09-25 Thread Michael Niedermayer
On Tue, Sep 05, 2023 at 04:03:57AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483181 + 1024 cannot be represented in > type 'int' > Fixes: > 61117/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VMIX_fuzzer-5387692433866752 > > Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Adjust threshold for VMIX

2023-09-25 Thread Michael Niedermayer
Fixes: Timeout Fixes: 62286/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VMIX_fuzzer-5155237134204928 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed,

Re: [FFmpeg-devel] [PATCH v3] GSoC 2023: Add Audio Overlay Filter

2023-09-25 Thread Paul B Mahol
On 9/11/23, Harshit Karwal wrote: > 1. Replaced ring buffer ADT with AVAudioFifo from libavutil/audio_fifo.h > 2. Fixed potential freeing of uninitialised pointers in uninit > 3. Minor changes like removing unused headers Will apply with more fixes soon. __

[FFmpeg-devel] [PATCH 6/9] avcodec/snow: Split ff_snow_get_buffer()

2023-09-25 Thread Andreas Rheinhardt
The part of said function that is common to both encoder and decoder is negligible since c954cf1e1b766a0d1992d5be0a8be0055a8e1a6a and more than offset by the costs of "Am I an encoder?" checks. So move allocating the frames to the encoder and decoder directly. Also rename ff_snow_frame_start() to

[FFmpeg-devel] [PATCH 9/9] avcodec/tests/.gitignore: Add bitstream test tools

2023-09-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/tests/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/tests/.gitignore b/libavcodec/tests/.gitignore index 5e0ccc5838..8e8878a881 100644 --- a/libavcodec/tests/.gitignore +++ b/libavcodec/tests/.gitignore @@ -2,6 +2,8 @@

[FFmpeg-devel] [PATCH 8/9] avcodec/aacsbrdata: Move ff_sbr_noise_table to sbrdsp_template.c

2023-09-25 Thread Andreas Rheinhardt
ff_sbr_noise_table is only used by SBR DSP code and sbrdsp.h is the header providing its declaration. Furthermore, this ensures that checkasm does not pull the whole AAC SBR and PS code in. Signed-off-by: Andreas Rheinhardt --- libavcodec/aacsbrdata.h | 266

[FFmpeg-devel] [PATCH 7/9] avcodec/snow: Move decoder parts out of ff_snow_common_init_after_header

2023-09-25 Thread Andreas Rheinhardt
They are not common. Furthermore, this file is pulled in when linking checkasm and up until now, the calls to ff_get_buffer() and av_codec_is_decoder() caused all of libavcodec to be pulled in as well. Besides being bad size-wise this also has the downside that it pulls in avpriv_(cga|vga16)_font

[FFmpeg-devel] [PATCH 5/9] checkasm/motion: Don't allocate AVCodecContext

2023-09-25 Thread Andreas Rheinhardt
Instead use one on the stack to avoid pulling in all of libavcodec. Signed-off-by: Andreas Rheinhardt --- ff_me_cmp_init() reads only codec_id (checks whether it is Snow) as well as the bitexact flag. The first check has been added in cfe675269bf44c49590e9076b5d2cd2503804f98 due to alignment; I d

[FFmpeg-devel] [PATCH 4/9] avfilter/bwdifdsp: Avoid including ff_bwdif_filter_line3_c()

2023-09-25 Thread Andreas Rheinhardt
This function is used by the AARCH64 code to filter a few remaining lines in case the dimensions are not suitably aligned; it is furthermore also used by checkasm to actually test the AARCH64 code against. But it is normally not used and this patch therefore moves it in bwdifdsp.h as a static inlin

[FFmpeg-devel] [PATCH 3/9] avfilter/bwdifdsp: Constify

2023-09-25 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 12 ++--- libavfilter/bwdifdsp.c | 60 ++--- libavfilter/bwdifdsp.h | 12 ++--- libavfilter/x86/vf_bwdif_init.c | 12 ++--- 4 files changed, 48

[FFmpeg-devel] [PATCH 2/9] avfilter/vf_bwdif: Move DSP code to a new file

2023-09-25 Thread Andreas Rheinhardt
Otherwise checkasm/vf_bwdif.c pulls in vf_bwdif.c and then all of libavfilter. Besides being bad size-wise this also has the downside that it pulls in avpriv_(cga|vga16)_font from libavutil which are marked as being imported from another library when building libavfilter as a DLL and this breaks ch

[FFmpeg-devel] [PATCH 1/9] avfilter/bwdif: Add proper BWDIFDSPContext

2023-09-25 Thread Andreas Rheinhardt
This already avoids unnecessary indirectly included headers in the arch-specific vf_bwdif_init.c files; it is also in preparation for splitting the actual functions out of vf_bwdif.c. Signed-off-by: Andreas Rheinhardt --- libavfilter/aarch64/vf_bwdif_init_aarch64.c | 4 ++-- libavfilter/{bwdif.

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-25 Thread Timo Rothenpieler
On 25.09.2023 14:18, Kyle Swanson wrote: Hi, On Sat, Sep 23, 2023 at 12:02 PM Timo Rothenpieler wrote: On 23.09.2023 11:50, Kyle Swanson wrote: Hi, On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler < t...@rothenpieler.org> wrote: Or it needs to be a sub-feature of libvmaf, where if libv

Re: [FFmpeg-devel] [PATCH] avcodec/extract_extradata: filter what Metadata OBUs are included in AV1 extradata

2023-09-25 Thread Derek Buitenhuis
On 9/18/2023 6:18 PM, James Almer wrote: > Only those that are relevant for the entire coded stream should be included. > > Signed-off-by: James Almer > --- > libavcodec/extract_extradata_bsf.c | 27 +++ > 1 file changed, 27 insertions(+) +1'd on IRC, but doing so here,

[FFmpeg-devel] [PATCH] cbs_av1: Make fake OBU size length field a write option

2023-09-25 Thread Mark Thompson
This is an option to modify the behaviour of the writer, not a syntax field. --- Tested by hacking av1_metadata. For example, adding: av_opt_set_int(ctx->common.output->priv_data, "fixed_obu_size_length", 7, 0); gets you OBU headers that look like: [trace_headers @ 0x55706fcb2880] OBU header [

[FFmpeg-devel] [REFUND-REQUEST] VDD23 Travel

2023-09-25 Thread Derek Buitenhuis
Hello, Nice to see you all again after so long. My request is for my flights to/from Dublin, which cost 90.58 GBP. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit lin

Re: [FFmpeg-devel] VDD 2023, FFmpeg meeting notes, (23-11-2023, 4pm, Dublin)

2023-09-25 Thread Cosmin Stejerean via ffmpeg-devel
> On Sep 24, 2023, at 5:45 PM, Michael Niedermayer > wrote: > > On Sun, Sep 24, 2023 at 04:10:00PM +0100, Ronald S. Bultje wrote: >> >> >> I believe the GA should have sole control and ownership over the domain and >> trademark. I suggested to kindly ask Fabrice to transfer ownership and/or

Re: [FFmpeg-devel] [PATCH] avfilter: add libvmaf_cuda

2023-09-25 Thread Kyle Swanson
Hi, On Sat, Sep 23, 2023 at 12:02 PM Timo Rothenpieler wrote: > On 23.09.2023 11:50, Kyle Swanson wrote: > > Hi, > > > > On Wed, Sep 20, 2023 at 11:55 PM Timo Rothenpieler < > t...@rothenpieler.org> > > wrote: > >> Or it needs to be a sub-feature of libvmaf, where if libvmaf is enabled, > >> sup

[FFmpeg-devel] [PATCH] libavdevice/decklink: extend available actions on signal loss

2023-09-25 Thread Michael Riedl
Deprecate the option 'draw_bars' in favor of the new option 'signal_loss_action', which controls the behavior when the input signal is not available (including the behavior previously available through draw_bars). The default behavior remains unchanged to be backwards compatible. The new option is

[FFmpeg-devel] [PATCH] libavformat/svs.c Fixed, now it is in the right place.

2023-09-25 Thread mezhuevtp
From: headshog --- libavformat/svs.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/svs.c b/libavformat/svs.c index b91d29f5a6..bdfb856184 100644 --- a/libavformat/svs.c +++ b/libavformat/svs.c @@ -42,6 +42,7 @@ static int svs_read_header(AVFormatContext *s

[FFmpeg-devel] [PATCH] libavformat\svs.c: Fixed, not it is in the right place

2023-09-25 Thread mezhuevtp
From: headshog --- 0001-Fixed-not-it-is-in-the-right-place.patch | 89 +++ 0001-Numeric-truncation-in-svs.c-57.patch | 41 + libavformat/svs.c | 7 +- 3 files changed, 136 insertions(+), 1 deletion(-) create mode 100644 0001-Fixed-not-it-

Re: [FFmpeg-devel] [PATCH] Numeric truncation in svs.c:57

2023-09-25 Thread Andreas Rheinhardt
mezhue...@ispras.ru: > From: headshog > > Hi! We've been fuzzing `ffmpeg` with > [sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz) security predicates and > we found numeric truncation error in `svs.c:57`. > In function `svs_read_header` on line 57 field `st->codecpar->sample_rate` > has ty

[FFmpeg-devel] [PATCH] Numeric truncation in svs.c:57

2023-09-25 Thread mezhuevtp
From: headshog Hi! We've been fuzzing `ffmpeg` with [sydr-fuzz](https://github.com/ispras/oss-sydr-fuzz) security predicates and we found numeric truncation error in `svs.c:57`. In function `svs_read_header` on line 57 field `st->codecpar->sample_rate` has type `int`, the type of return value

Re: [FFmpeg-devel] libavdevice (was: FFmpeg release 6.1 (SDR Plans))

2023-09-25 Thread Paul B Mahol
On Sun, Sep 24, 2023 at 8:09 PM Nicolas George wrote: > Paul B Mahol (12023-09-24): > > libavdevice is using libavformat API that is unacceptable maintenance > burden. > > This is a lie. You would not even know if libavdevice is a maintenance > burden, you never touch it. > [computer@archlinux f

[FFmpeg-devel] [REFUND-REQUEST]] VDD'23 Travel

2023-09-25 Thread Niklas Haas
Hi, was a great VDD! Here are my travel costs: 316,00 EUR Flight STR <-> DUB 101,00 EUR Parking at STR 8,00 EUR Airport Shuttlebus in DUB I had planned to use the cheaper (~60 EUR) parking, but it was already closed by the time I had arrived, so I went to the next cheapest.. Thanks, Niklas __

Re: [FFmpeg-devel] [RFC/PATCH] ffmpeg CLI multithreading

2023-09-25 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-09-20 16:49:42) > Hi > > On Tue, Sep 19, 2023 at 09:10:27PM +0200, Anton Khirnov wrote: > [...] > > You can fetch the code from the 'ffmpeg_threading' branch in > > git://git.khirnov.net/libav. I will also present a short talk about this > > work at VDD. Comments,

[FFmpeg-devel] [PATCH v2 2/2] libavformat/whip: add WebRTC-HTTP ingestion protocol (WHIP)

2023-09-25 Thread Michael Riedl
This is based on the library libdatachannel, which is much more lightweight than other libraries like libwebrtc. At the same time, using this library avoids reimplementing parts of WebRTC in FFmpeg. Signed-off-by: Michael Riedl --- configure| 5 + libavformat/Makefile |

[FFmpeg-devel] [PATCH v2 1/2] libavformat/http: expose actual Location header value

2023-09-25 Thread Michael Riedl
This is needed for muxers which need to access the Location header as transmitted when no redirection happen. Signed-off-by: Michael Riedl --- libavformat/http.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/http.c b/libavformat/http.c index c0fe7c36d91..27f9c8e3000 100644 ---

Re: [FFmpeg-devel] FFmpeg release 6.1 (SDR Plans)

2023-09-25 Thread Kieran Kunhya
On Sun, 24 Sept 2023, 18:34 Paul B Mahol, wrote: > On 9/24/23, Nicolas George wrote: > > Paul B Mahol (12023-09-24): > >> libavdevice is abusing libavformat. > >> > >> It should have own API or be removed. > > > > libavdevice works. > > Define 'works'. > > It is clearly sub-optimal. > Why shoul