Re: [FFmpeg-devel] [PATCH 1/2] doc/developer: Reviews must be constructive

2023-08-24 Thread Nicolas George
Vittorio Giovara (12023-08-25): > NAK > we shouldn't put extra burden on reviewers, nor guilt trap them into > suggesting an alternative approach It is hilarious, in a very sad way, that you prefer put extra burden on people who do things than on people who block them. -- Nicolas George __

Re: [FFmpeg-devel] [PATCH v1 2/2] avformat/rtmpproto: support enhanced rtmp

2023-08-24 Thread Steven Liu
Marton Balint 于2023年8月25日周五 05:48写道: Hi Marton, > > > > On Thu, 24 Aug 2023, Tristan Matthews wrote: > > > Hi, > > > > On Thu, Aug 24, 2023 at 1:32 AM Steven Liu wrote: > >> > >> add option named rtmp_enhanced_codec, > >> it would support hvc1,av01,vp09 now, > >> the fourcc is using Array of str

Re: [FFmpeg-devel] [PATCH v1 2/2] avformat/rtmpproto: support enhanced rtmp

2023-08-24 Thread Steven Liu
Tristan Matthews 于2023年8月25日周五 04:11写道: > > Hi, Hi Tristan, > > On Thu, Aug 24, 2023 at 1:32 AM Steven Liu wrote: > > > > add option named rtmp_enhanced_codec, > > it would support hvc1,av01,vp09 now, > > the fourcc is using Array of strings. > > > > Signed-off-by: Steven Liu > > --- > > doc/p

[FFmpeg-devel] [PATCH v2 2/2] avformat/rtmpproto: support enhanced rtmp

2023-08-24 Thread Steven Liu
Add option named rtmp_enhanced_codec, it would support hvc1,av01,vp09 now, the fourcc is using Array of strings. Signed-off-by: Steven Liu --- doc/protocols.texi | 6 ++ libavformat/rtmpproto.c | 35 +++ 2 files changed, 41 insertions(+) diff --git a/do

[FFmpeg-devel] [PATCH v2 1/2] avformat/rtmppkt: add ff_amf_write_array for write array strings

2023-08-24 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/rtmppkt.c | 6 ++ libavformat/rtmppkt.h | 8 2 files changed, 14 insertions(+) diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c index 4b97c0833f..a602bf6a96 100644 --- a/libavformat/rtmppkt.c +++ b/libavformat/rtmppkt.c @@ -40,6 +4

Re: [FFmpeg-devel] [PATCH v4] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-08-24 Thread Dai, Jianhui J
> -Original Message- > From: ffmpeg-devel On Behalf Of Dai, > Jianhui J > Sent: Friday, August 25, 2023 10:40 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v4] avcodec/cbs_vp8: Add support for VP8 > codec bitstream > > This commit adds support for VP8 bitstream read

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/vulkan_decode: print also codec header name

2023-08-24 Thread Lynne
Aug 23, 2023, 22:06 by kaspe...@gmail.com: > Signed-off-by: Kacper Michajłow > --- > libavcodec/vulkan_decode.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/vulkan_decode.c b/libavcodec/vulkan_decode.c > index 7607edf52e..0d561b7450 100644 > --- a/libavcodec/vulkan_deco

Re: [FFmpeg-devel] [PATCH v3 5/5] lavfi/vf_xfade_vulkan: add wipes

2023-08-24 Thread Lynne
Aug 21, 2023, 22:46 by epira...@gmail.com: > Add the wipetl, wipetr, wipebl, wipebr effects. > --- > libavfilter/vf_xfade_vulkan.c | 60 +++ > 1 file changed, 60 insertions(+) > Patchset pushed, Thanks ___ ffmpeg-devel m

[FFmpeg-devel] [PATCH v4] avcodec/cbs_vp8: Add support for VP8 codec bitstream

2023-08-24 Thread Dai, Jianhui J
This commit adds support for VP8 bitstream read methods to the cbs codec. This enables the trace_headers bitstream filter to support VP8, in addition to AV1, H.264, H.265, and VP9. This can be useful for debugging VP8 stream issues. The CBS VP8 implements a simple VP8 boolean decoder with bounds c

Re: [FFmpeg-devel] [PATCH 1/2] doc/developer: Reviews must be constructive

2023-08-24 Thread Vittorio Giovara
On Thu, Aug 24, 2023 at 9:56 PM Michael Niedermayer wrote: > Suggested text is from Anton > > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 0c2f2cd7d1..383120daaa 100644 >

Re: [FFmpeg-devel] [PATCH v2] lavfi/dnn: Add OpenVINO API 2.0 support

2023-08-24 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > wenbin.chen-at-intel@ffmpeg.org > Sent: Tuesday, August 15, 2023 4:27 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v2] lavfi/dnn: Add OpenVINO API 2.0 > support > > From: Wenbin Chen > > OpenVINO API 2.

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/apedec: fix decoding 24bit insane files with recent versions"

2023-08-24 Thread Michael Niedermayer
On Fri, Aug 25, 2023 at 01:37:27AM +0200, Paul B Mahol wrote: > NAK > > Breaks decoding of another sample. please provide the sample if noone provides a sample, i will disregard this objection. Also as a sidenote, iam in contact with Matt Ashland and he also doesnt know what your commit was tryi

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/apedec: fix decoding 24bit insane files with recent versions"

2023-08-24 Thread Paul B Mahol
NAK Breaks decoding of another sample. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] avcodec/apedec: Fix CRC for 24bps and bigendian

2023-08-24 Thread Michael Niedermayer
Fixes CRC for vlc.ape and APE_48K_24bit_2CH_02_01.ape Signed-off-by: Michael Niedermayer --- libavcodec/apedec.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index cc0d7e2749..d48d3a676d 100644 --- a/libavcodec/a

[FFmpeg-devel] [PATCH 1/2] Revert "avcodec/apedec: fix decoding 24bit insane files with recent versions"

2023-08-24 Thread Michael Niedermayer
Fixes: Ticket9816 This reverts commit ed0001482a74b60f3d5bc5cd7e304c9d65b2fcd5. --- libavcodec/apedec.c | 59 ++--- 1 file changed, 13 insertions(+), 46 deletions(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 613c76df0b..cc0d7e2749 100644

Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-24 Thread Paul B Mahol
On Thu, Aug 24, 2023 at 11:51 PM James Almer wrote: > On 8/24/2023 6:11 PM, Paul B Mahol wrote: > > On Thu, Aug 24, 2023 at 11:00 PM James Almer wrote: > > > >> On 8/24/2023 6:52 AM, Paul B Mahol wrote: > >>> +static int osq_receive_frame(AVCodecContext *avctx, AVFrame *frame) > >>> +{ > >>> +

Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-24 Thread James Almer
On 8/24/2023 6:11 PM, Paul B Mahol wrote: On Thu, Aug 24, 2023 at 11:00 PM James Almer wrote: On 8/24/2023 6:52 AM, Paul B Mahol wrote: +static int osq_receive_frame(AVCodecContext *avctx, AVFrame *frame) +{ +OSQContext *s = avctx->priv_data; +GetBitContext *gb = &s->gb; +int ret,

Re: [FFmpeg-devel] [PATCH v1 2/2] avformat/rtmpproto: support enhanced rtmp

2023-08-24 Thread Marton Balint
On Thu, 24 Aug 2023, Tristan Matthews wrote: Hi, On Thu, Aug 24, 2023 at 1:32 AM Steven Liu wrote: add option named rtmp_enhanced_codec, it would support hvc1,av01,vp09 now, the fourcc is using Array of strings. Signed-off-by: Steven Liu --- doc/protocols.texi | 6 ++ libavfor

Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-24 Thread Paul B Mahol
On Thu, Aug 24, 2023 at 11:00 PM James Almer wrote: > On 8/24/2023 6:52 AM, Paul B Mahol wrote: > > +static int osq_receive_frame(AVCodecContext *avctx, AVFrame *frame) > > +{ > > +OSQContext *s = avctx->priv_data; > > +GetBitContext *gb = &s->gb; > > +int ret, n; > > + > > +while

Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-24 Thread James Almer
On 8/24/2023 6:52 AM, Paul B Mahol wrote: +static int osq_receive_frame(AVCodecContext *avctx, AVFrame *frame) +{ +OSQContext *s = avctx->priv_data; +GetBitContext *gb = &s->gb; +int ret, n; + +while (s->bitstream_size < s->max_framesize) { +int size; + +if (!s->pk

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/rtmppkt: add ff_amf_write_array for write array strings

2023-08-24 Thread Marton Balint
On Thu, 24 Aug 2023, Steven Liu wrote: Signed-off-by: Steven Liu --- libavformat/rtmppkt.c | 6 ++ libavformat/rtmppkt.h | 8 2 files changed, 14 insertions(+) diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c index 4b97c0833f..cd0c68ec8a 100644 --- a/libavformat/rtmppkt

Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-24 Thread Paul B Mahol
On Thu, Aug 24, 2023 at 9:54 PM James Almer wrote: > On 8/24/2023 6:52 AM, Paul B Mahol wrote: > > Patches attached. > > > > Stereo decoding have some issues with some predictors so not yet > bitexact. > > > > Please comment. > > > +static av_cold int osq_close(AVCodecContext *avctx) > > +{ > > +

Re: [FFmpeg-devel] [PATCH 2/2] doc/developer: Code pushed without patches on ffmpeg-devel must be announced on the ML

2023-08-24 Thread Andreas Rheinhardt
James Almer: > On 8/24/2023 4:56 PM, Michael Niedermayer wrote: >> Signed-off-by: Michael Niedermayer >> --- >>   doc/developer.texi | 9 + >>   1 file changed, 9 insertions(+) >> >> diff --git a/doc/developer.texi b/doc/developer.texi >> index 383120daaa..1c0091fc74 100644 >> --- a/doc/dev

Re: [FFmpeg-devel] [PATCH v1 2/2] avformat/rtmpproto: support enhanced rtmp

2023-08-24 Thread Tristan Matthews
Hi, On Thu, Aug 24, 2023 at 1:32 AM Steven Liu wrote: > > add option named rtmp_enhanced_codec, > it would support hvc1,av01,vp09 now, > the fourcc is using Array of strings. > > Signed-off-by: Steven Liu > --- > doc/protocols.texi | 6 ++ > libavformat/rtmpproto.c | 38 ++

Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-24 Thread Andreas Rheinhardt
James Almer: > On 8/24/2023 6:52 AM, Paul B Mahol wrote: >> Patches attached. >> >> Stereo decoding have some issues with some predictors so not yet >> bitexact. >> >> Please comment. > >> +static av_cold int osq_close(AVCodecContext *avctx) >> +{ >> +    OSQContext *s = avctx->priv_data; >> + >>

Re: [FFmpeg-devel] [PATCH 2/2] doc/developer: Code pushed without patches on ffmpeg-devel must be announced on the ML

2023-08-24 Thread James Almer
On 8/24/2023 4:56 PM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- doc/developer.texi | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index 383120daaa..1c0091fc74 100644 --- a/doc/developer.texi +++ b/doc/developer.texi

Re: [FFmpeg-devel] [PATCH 2/2] doc/developer: Code pushed without patches on ffmpeg-devel must be announced on the ML

2023-08-24 Thread Andreas Rheinhardt
Michael Niedermayer: > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 383120daaa..1c0091fc74 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -856,6 +

[FFmpeg-devel] [PATCH 2/2] doc/developer: Code pushed without patches on ffmpeg-devel must be announced on the ML

2023-08-24 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/developer.texi | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index 383120daaa..1c0091fc74 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -856,6 +856,15 @@ way to get everyone's patches r

[FFmpeg-devel] [PATCH 1/2] doc/developer: Reviews must be constructive

2023-08-24 Thread Michael Niedermayer
Suggested text is from Anton Signed-off-by: Michael Niedermayer --- doc/developer.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index 0c2f2cd7d1..383120daaa 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -853,6 +853,9 @@ Everyone

[FFmpeg-devel] [PATCH 0/2] [RFC] doc/developer patch review improvements

2023-08-24 Thread Michael Niedermayer
This set contains 2 additions to the patch review and commit policy/guidlines ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.

Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-24 Thread James Almer
On 8/24/2023 6:52 AM, Paul B Mahol wrote: Patches attached. Stereo decoding have some issues with some predictors so not yet bitexact. Please comment. +static av_cold int osq_close(AVCodecContext *avctx) +{ +OSQContext *s = avctx->priv_data; + +av_freep(&s->bitstream); +s->bitstr

Re: [FFmpeg-devel] [PATCH] adpcm fixes and improvements

2023-08-24 Thread Paul B Mahol
On Thu, Aug 24, 2023 at 7:39 PM Michael Niedermayer wrote: > On Thu, Aug 24, 2023 at 06:26:36PM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > On Thu, Aug 24, 2023 at 12:51:28AM +0200, Paul B Mahol wrote: > > >> On Thu, Aug 24, 2023 at 12:36 AM Michael Niedermayer < > mich...@nie

Re: [FFmpeg-devel] [PATCH v7 0/5] JPEG XL Parser (and bug fixes)

2023-08-24 Thread Leo Izen
On 8/2/23 16:33, Leo Izen wrote: Changes from v6: - Added dummy stub libavformat/jpegxl_parse.c to fix shared builds Changes from v5: - Attached an extra commit to fix existing bug with libjxldec - Made various changes based on comments by Andreas Reinhardt -- removed jpegxl_parse.c from avforma

Re: [FFmpeg-devel] [PATCH] checkasm: hevc_sao: Fix a regression in hevc_sao_edge

2023-08-24 Thread Martin Storsjö via ffmpeg-devel
On Thu, 24 Aug 2023, Matthias Dressel wrote: From: Matthias Dressel check_func() might return NULL, in which case the function is not to be benched. Introduced in cc679054c715acda9438e566b8de3a9eba421ac3. Signed-off-by: Matthias Dressel --- tests/checkasm/hevc_sao.c | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-24 Thread Paul B Mahol
On Thu, Aug 24, 2023 at 8:06 PM Michael Niedermayer wrote: > On Thu, Aug 24, 2023 at 11:52:45AM +0200, Paul B Mahol wrote: > > Patches attached. > > > > Stereo decoding have some issues with some predictors so not yet > bitexact. > > > > Please comment. > > > [...] > > diff --git a/libavformat/os

Re: [FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-24 Thread Michael Niedermayer
On Thu, Aug 24, 2023 at 11:52:45AM +0200, Paul B Mahol wrote: > Patches attached. > > Stereo decoding have some issues with some predictors so not yet bitexact. > > Please comment. [...] > diff --git a/libavformat/osq.c b/libavformat/osq.c > new file mode 100644 > index 00..36ce25313f >

Re: [FFmpeg-devel] [PATCH] adpcm fixes and improvements

2023-08-24 Thread Michael Niedermayer
On Thu, Aug 24, 2023 at 06:26:36PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Thu, Aug 24, 2023 at 12:51:28AM +0200, Paul B Mahol wrote: > >> On Thu, Aug 24, 2023 at 12:36 AM Michael Niedermayer > >> > >> wrote: > >> > >>> On Wed, Aug 23, 2023 at 09:04:35PM +0200, Paul B Mahol

Re: [FFmpeg-devel] [PATCH] adpcm fixes and improvements

2023-08-24 Thread Andreas Rheinhardt
Michael Niedermayer: > On Thu, Aug 24, 2023 at 12:51:28AM +0200, Paul B Mahol wrote: >> On Thu, Aug 24, 2023 at 12:36 AM Michael Niedermayer >> wrote: >> >>> On Wed, Aug 23, 2023 at 09:04:35PM +0200, Paul B Mahol wrote: On Wed, Aug 23, 2023 at 9:02 PM Michael Niedermayer < >>> mich...@niederm

Re: [FFmpeg-devel] [PATCH] adpcm fixes and improvements

2023-08-24 Thread Michael Niedermayer
On Thu, Aug 24, 2023 at 12:51:28AM +0200, Paul B Mahol wrote: > On Thu, Aug 24, 2023 at 12:36 AM Michael Niedermayer > wrote: > > > On Wed, Aug 23, 2023 at 09:04:35PM +0200, Paul B Mahol wrote: > > > On Wed, Aug 23, 2023 at 9:02 PM Michael Niedermayer < > > mich...@niedermayer.cc> > > > wrote: >

[FFmpeg-devel] [PATCH] checkasm: hevc_sao: Fix a regression in hevc_sao_edge

2023-08-24 Thread Matthias Dressel
From: Matthias Dressel check_func() might return NULL, in which case the function is not to be benched. Introduced in cc679054c715acda9438e566b8de3a9eba421ac3. Signed-off-by: Matthias Dressel --- tests/checkasm/hevc_sao.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test

[FFmpeg-devel] [PATCH] OSQ lossless audio format support

2023-08-24 Thread Paul B Mahol
Patches attached. Stereo decoding have some issues with some predictors so not yet bitexact. Please comment. From a90b4fbd4178d4ef434e1255ed20dddebde0ddb8 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Tue, 27 Jun 2023 19:51:54 +0200 Subject: [PATCH 2/2] avformat: add OSQ demuxer Signed-off-