Re: [FFmpeg-devel] [PATCH v3 11/12] avcodec/libx264: add support for writing out CLL and MDCV

2023-08-19 Thread Andreas Rheinhardt
Jan Ekström: > Both of these two structures were first available with X264_BUILD > 163, so make relevant functionality conditional on the version > being at least such. > > Keep handle_side_data available in all cases as this way X264_init > does not require additional version based conditions wit

Re: [FFmpeg-devel] [PATCH v3 11/12] avcodec/libx264: add support for writing out CLL and MDCV

2023-08-19 Thread Andreas Rheinhardt
Jan Ekström: > On Sat, Aug 19, 2023 at 7:53 PM Michael Niedermayer > wrote: >> >> On Fri, Aug 18, 2023 at 12:48:49AM +0300, Jan Ekström wrote: >>> Both of these two structures were first available with X264_BUILD >>> 163, so make relevant functionality conditional on the version >>> being at least

[FFmpeg-devel] [PATCH v1] avformat/rtmpproto: support fourCcList property in enhanced rtmp

2023-08-19 Thread Steven Liu
As the enhanced rtmp Extending NetConnection connect Command section said, the rtmp should add a property named fourCcLive, but there should only one codec can be set for the video stream in rtmp+flv, so user can use the option rtmp_enhanced_flags to set the enhanced rtmp with av1, hevc or vp9. Si

Re: [FFmpeg-devel] [PATCH v3 11/12] avcodec/libx264: add support for writing out CLL and MDCV

2023-08-19 Thread Jan Ekström
On Sat, Aug 19, 2023 at 7:53 PM Michael Niedermayer wrote: > > On Fri, Aug 18, 2023 at 12:48:49AM +0300, Jan Ekström wrote: > > Both of these two structures were first available with X264_BUILD > > 163, so make relevant functionality conditional on the version > > being at least such. > > > > Keep

[FFmpeg-devel] [PATCH] configure: Include objbase.h when checking for CoTaskMemFree

2023-08-19 Thread Martin Storsjö
ddc1cd5cdd2570bf3d6ab807ee0ecfacdf09431d defined WIN32_LEAN_AND_MEAN globally, which makes for much fewer transitive includes from windows.h. With that define, CoTaskMemFree no longer gets implicitly declared by just including windows.h, but one has to include the right header objbase.h too. That

Re: [FFmpeg-devel] [PATCH v4 1/1] configure: Set WIN32_LEAN_AND_MEAN at configure time

2023-08-19 Thread Martin Storsjö
On Sat, 19 Aug 2023, Gyan Doshi wrote: ddc1cd5cdd breaks the checks for ole32 and thus prevents detection of DXVA2. @ https://github.com/FFmpeg/FFmpeg/commit/ddc1cd5cdd2570bf3d6ab807ee0ecfacdf09431d Thanks for noticing this, and sorry for the breakage. It seems like this is fixable by adju

Re: [FFmpeg-devel] [PATCH v3 11/12] avcodec/libx264: add support for writing out CLL and MDCV

2023-08-19 Thread Michael Niedermayer
On Fri, Aug 18, 2023 at 12:48:49AM +0300, Jan Ekström wrote: > Both of these two structures were first available with X264_BUILD > 163, so make relevant functionality conditional on the version > being at least such. > > Keep handle_side_data available in all cases as this way X264_init > does not

Re: [FFmpeg-devel] [PATCH v4 1/1] configure: Set WIN32_LEAN_AND_MEAN at configure time

2023-08-19 Thread Gyan Doshi
ddc1cd5cdd breaks the checks for ole32 and thus prevents detection of DXVA2. @ https://github.com/FFmpeg/FFmpeg/commit/ddc1cd5cdd2570bf3d6ab807ee0ecfacdf09431d Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/

Re: [FFmpeg-devel] [PATCH v4] vvcdec: add thread executor

2023-08-19 Thread James Almer
On 8/18/2023 1:17 PM, James Almer wrote: On 8/15/2023 11:50 AM, Nuo Mi wrote: The executor design pattern was inroduced by java it also adapted by python

Re: [FFmpeg-devel] [PATCH v3] avutil/thread: add wrappers for pthread_cond_t and pthread_t functions

2023-08-19 Thread James Almer
On 8/19/2023 8:55 AM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavutil/thread.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/libavutil/thread.h b/libavutil/thread.h index 2f5e7e1cb5..f67b0cdc44 100644 --- a/libavutil/threa

Re: [FFmpeg-devel] [PATCH v3] avutil/thread: add wrappers for pthread_cond_t and pthread_t functions

2023-08-19 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavutil/thread.h | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/libavutil/thread.h b/libavutil/thread.h > index 2f5e7e1cb5..f67b0cdc44 100644 > --- a/libavutil/thread.h > +++ b/libavutil/thread.h > @@ -

Re: [FFmpeg-devel] [PATCH] avformat/hls: reset the playlist init segment on seek

2023-08-19 Thread Timo Rothenpieler
On 15.08.2023 22:53, Timo Rothenpieler wrote: The mp4 demuxer gets very upset when it gets flushed and not re-fed this data. --- libavformat/hls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index 2a2fe28a54..c625e30291 100644 --- a/libavformat/