[FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h266: store RowHeightVal in the context

2023-06-30 Thread James Almer
Stop overwriting values from the bitstream array pps_tile_row_height_minus1. Signed-off-by: James Almer --- libavcodec/cbs_h266_syntax_template.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h266: store SubpicIdVal in the context

2023-06-30 Thread James Almer
And use it to derive CurrSubpicIdx Signed-off-by: James Almer --- libavcodec/cbs_h266.h | 2 ++ libavcodec/cbs_h266_syntax_template.c | 34 +-- 2 files changed, 19 insertions(+), 17 deletions(-) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h

Re: [FFmpeg-devel] [PATCH v2 6/7] v210enc: Pass through bar data

2023-06-30 Thread Devin Heitmueller
Hi Kieran, On Fri, Jun 30, 2023 at 6:41 PM Kieran Kunhya wrote: > > On Fri, 30 Jun 2023 at 21:42, Devin Heitmueller > wrote: >> >> When encoding to V210, make sure the bar side data makes it through >> in the resulting AVPacket. This is needed so the decklink output >> module can put out bar d

Re: [FFmpeg-devel] [PATCH v2 6/7] v210enc: Pass through bar data

2023-06-30 Thread Kieran Kunhya
On Fri, 30 Jun 2023 at 21:42, Devin Heitmueller < devin.heitmuel...@ltnglobal.com> wrote: > When encoding to V210, make sure the bar side data makes it through > in the resulting AVPacket. This is needed so the decklink output > module can put out bar data as VANC when in 10-bit mode. > ff_decod

[FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h266_syntax_template: Avoid shadowing

2023-06-30 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_h266_syntax_template.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c index a329b7f9ed..646cd94413 100644 --- a/libavcodec/cbs_h266_syntax

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-06-30 Thread Tomas Härdin
fre 2023-06-30 klockan 16:08 +0200 skrev Michael Niedermayer: > Also as said previously, If there is at least a 2nd developer working > on this then we could & should move this to a seperate libraray > (libavradio) Just start a separate project or contribute to GNU Radio or osmocom or whatever. Ho

Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

2023-06-30 Thread Tomas Härdin
tor 2023-06-29 klockan 09:14 +0200 skrev Nicolas George: > Tomas Härdin (12023-06-29): > > >   The reason why XML parsing shouldn't be > > implemented in FFmpeg isn't just because it is difficult but > > because: > > > > * it is out of scope > > It is necessary. Factuall

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-06-30 Thread Martin Storsjö
On Fri, 30 Jun 2023, Michael Niedermayer wrote: On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote: If you apply this I will apply my pending libswresample commits and also remove sonic decoder from libavcodec. ok, if you plan to fix the bugs in the libswresample patches ill wait a

[FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h266_syntax_template: Remove set-but-unused variable

2023-06-30 Thread Andreas Rheinhardt
Reported by Clang. Signed-off-by: Andreas Rheinhardt --- Maybe this was meant to be used? libavcodec/cbs_h266_syntax_template.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c index 56e1205337..

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h266_syntax_template: Don't use uninitialized value

2023-06-30 Thread Andreas Rheinhardt
Probably a typo. Fixes a warning from Clang. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_h266_syntax_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c index 863fecdefa..56e1205337

[FFmpeg-devel] [PATCH v2 7/7] avdevice/decklink_enc: Add support for output of bar data as VANC

2023-06-30 Thread Devin Heitmueller
SMPTE ST2016-3 supports both AFD and bar data within the VANC message. Extend the existing support to pass through both. Example usage: ffmpeg -i input.ts -vf setafd=afd=1:code=0x00:bardata=1:top=100:bottom=120 -f decklink -vcodec v210 'DeckLink Duo (4)' Signed-off-by: Devin Heitmueller --- l

[FFmpeg-devel] [PATCH v2 6/7] v210enc: Pass through bar data

2023-06-30 Thread Devin Heitmueller
When encoding to V210, make sure the bar side data makes it through in the resulting AVPacket. This is needed so the decklink output module can put out bar data as VANC when in 10-bit mode. Signed-off-by: Devin Heitmueller --- libavcodec/v210enc.c | 8 1 file changed, 8 insertions(+)

[FFmpeg-devel] [PATCH v2 5/7] libavutil: Provide a side data description for newly introduced bar data

2023-06-30 Thread Devin Heitmueller
Add a new description for bar data, so that the presence of bar data can be seen through ffprobe. Signed-off-by: Devin Heitmueller --- libavutil/frame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index b6cee2d..03d1b31 100644 --- a/libavutil/frame.c

[FFmpeg-devel] [PATCH v2 4/7] libavfilter: Add filter to insert AFD/bar data

2023-06-30 Thread Devin Heitmueller
Introduce a new filter which allows the user to manually set the AFD or bar data side data on AVFrames. Signed-off-by: Devin Heitmueller --- doc/filters.texi | 52 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_afd.c | 133 +

[FFmpeg-devel] [PATCH v2 3/7] avcodec/avframe: add new side data types for Bar Data

2023-06-30 Thread Devin Heitmueller
Add new side data types for both AVPacket and AVFrame to support "bar data" as defined in SMPTE 2016-1, ATSC A/53, and SCTE 128-1. Signed-off-by: Devin Heitmueller --- libavcodec/decode.c | 1 + libavcodec/defs.h | 12 libavcodec/packet.h | 6 ++ libavutil/frame.h | 6 +++

[FFmpeg-devel] [PATCH v2 2/7] vf_drawtext: Add ability to show AFD value

2023-06-30 Thread Devin Heitmueller
Add an "afd" variable which shows the current AFD side data for the given frame. This is to assist in debugging as it allows us to burn the current AFD right into the video. Example usage: ./ffmpeg -y -i afd.ts -vf drawtext=fontfile=/Library/Fonts/Verdana.ttf:text="AFD=%{afd}":fontsize=32:x=10:

[FFmpeg-devel] [PATCH v2 1/7] libavcodec: Preserve AFD side data when going from AVPacket to AVFrame

2023-06-30 Thread Devin Heitmueller
This is needed to ensure that AFD data continues to work when capturing V210 video with the Decklink libavdevice input. Signed-off-by: Devin Heitmueller --- libavcodec/decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index a7c1302..6ee2c85 10

[FFmpeg-devel] [PATCH v2 0/7] Misc AFD improvements and support for Bar Data

2023-06-30 Thread Devin Heitmueller
This patch series is essentially exactly the same as the one sent on June 7, but the vf_drawtext patch has been rebased against master to resolve a conflict, per Paul Mahol's request. Devin Heitmueller (7): libavcodec: Preserve AFD side data when going from AVPacket to AVFrame vf_drawtext: Add

[FFmpeg-devel] [PATCH v3 2/2] decklink_enc: add support for SMPTE 2038 VANC packet output

2023-06-30 Thread Devin Heitmueller
Support decoding and embedding VANC packets delivered via SMPTE 2038 into the SDI output. We leverage an intermediate queue because data packets are announced separately from video but we need to embed the data into the video frame when it is output. Note that this patch has some additional abstr

[FFmpeg-devel] [PATCH v3 1/2] decklink: move queue_size to an argument for ff_decklink_packet_queue_init

2023-06-30 Thread Devin Heitmueller
The existing queue initialization function would always sets it's maximum queue size to ctx->queue_size. But because we are introducing more queues we may want the sizes to differ between them. Move the specification of the queue size into an argument, which can be passed from the caller. This p

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-06-30 Thread Michael Niedermayer
On Fri, Jun 30, 2023 at 07:40:53PM +0200, Michael Niedermayer wrote: > On Fri, Jun 30, 2023 at 04:38:46PM +0200, Jean-Baptiste Kempf wrote: > > On Fri, 30 Jun 2023, at 16:08, Michael Niedermayer wrote: > > > Also as said previously, If there is at least a 2nd developer working > > > on this then we

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-06-30 Thread Paul B Mahol
On Fri, Jun 30, 2023 at 7:41 PM Michael Niedermayer wrote: > On Fri, Jun 30, 2023 at 04:38:46PM +0200, Jean-Baptiste Kempf wrote: > > On Fri, 30 Jun 2023, at 16:08, Michael Niedermayer wrote: > > > Also as said previously, If there is at least a 2nd developer working > > > on this then we could &

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: auto calculate depth

2023-06-30 Thread Paul B Mahol
On Fri, Jun 30, 2023 at 2:35 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Thu, Jun 29, 2023 at 9:20 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Paul B Mahol: > >>> On Wed, Jun 28, 2023 at 7:34 PM Andreas Rheinhardt < > >>> an

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-06-30 Thread Carotti, Elias
On Wed, 2023-06-28 at 14:55 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Quoting Carotti, Elias (2023-06-26 11:50:59) > > We can do

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-06-30 Thread Michael Niedermayer
On Fri, Jun 30, 2023 at 04:38:46PM +0200, Jean-Baptiste Kempf wrote: > On Fri, 30 Jun 2023, at 16:08, Michael Niedermayer wrote: > > Also as said previously, If there is at least a 2nd developer working > > on this then we could & should move this to a seperate libraray (libavradio) > > Why wait f

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-06-30 Thread Kieran Kunhya
On Fri, 30 Jun 2023 at 15:08, Michael Niedermayer wrote: > On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote: > > If you apply this I will apply my pending libswresample commits and also > > remove sonic decoder from libavcodec. > > ok, if you plan to fix the bugs in the libswresample

[FFmpeg-devel] [PATCH] fate/cbs: simplify the filter_unit discard tests

2023-06-30 Thread James Almer
No need to generate intermediate files and probe them. We only care to know that the output of the bsf excludes the frames in question, and a simple checksum is enough. Signed-off-by: James Almer --- tests/fate/cbs.mak | 30 +-- tests/ref/fate/cbs-h264-discard-bid

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-06-30 Thread Jean-Baptiste Kempf
On Fri, 30 Jun 2023, at 16:08, Michael Niedermayer wrote: > Also as said previously, If there is at least a 2nd developer working > on this then we could & should move this to a seperate libraray (libavradio) Why wait for a 2nd dev? -- Jean-Baptiste Kempf - President +33 672 704 734 ___

Re: [FFmpeg-devel] [PATCH v6 0/1] avformat: add Software Defined Radio support

2023-06-30 Thread Michael Niedermayer
On Thu, Jun 29, 2023 at 05:43:53PM +0200, Paul B Mahol wrote: > If you apply this I will apply my pending libswresample commits and also > remove sonic decoder from libavcodec. ok, if you plan to fix the bugs in the libswresample patches ill wait a bit, so others can object and if no objections w

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: auto calculate depth

2023-06-30 Thread Andreas Rheinhardt
Paul B Mahol: > On Thu, Jun 29, 2023 at 9:20 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Paul B Mahol: >>> On Wed, Jun 28, 2023 at 7:34 PM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> Paul B Mahol: > On Wed, Jun 28, 2023 at 11:57 AM Paul B

[FFmpeg-devel] [PATCH] lavfi/tonemap_vaapi: remove HDR metadata

2023-06-30 Thread Xiang, Haihao
From: Haihao Xiang The HDR metadata should be removed after HDR to SDR conversion, otherwise the output frame still has HDR side data. Signed-off-by: Haihao Xiang --- libavfilter/vf_tonemap_vaapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/vf_tonemap_vaapi.c b/libavfil

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: auto calculate depth

2023-06-30 Thread Paul B Mahol
On Thu, Jun 29, 2023 at 9:20 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Paul B Mahol: > > On Wed, Jun 28, 2023 at 7:34 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Paul B Mahol: > >>> On Wed, Jun 28, 2023 at 11:57 AM Paul B Mahol > wrote: > >>>

[FFmpeg-devel] [PATCH] avcodec/tests/avcodec: Remove unnecessary internal.h inclusion

2023-06-30 Thread Andreas Rheinhardt
Forgotten in a688f3c13ce55c2ba51dbbb344564649f1bb52fe. Signed-off-by: Andreas Rheinhardt --- Will apply this soon. libavcodec/tests/avcodec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/tests/avcodec.c b/libavcodec/tests/avcodec.c index d78447d0fc..bbf5289af2 100644 --- a/liba

[FFmpeg-devel] [PATCH v2] avcodec/v4l2_m2m_dec: resolve resolution change

2023-06-30 Thread Hsia-Jun Li
From: "Hsia-Jun(Randy) Li" It shouldn't allocate buffer nor get the capture fmt before the resolution change event appeared in decoder setup. And it should not apply to new resolution before the buffer from the previous sequence is dequeued. Changelog: v2 1. Decoder won't get or set format befo