Re: [FFmpeg-devel] [PATCH 1/5] avutil/frame: add new interlaced and top_field_first flags

2023-05-04 Thread James Almer
On 4/29/2023 9:19 PM, James Almer wrote: On 4/12/2023 4:49 PM, James Almer wrote: Signed-off-by: James Almer --- Missing version bump and APIChanges entry.   libavutil/frame.h | 9 +   1 file changed, 9 insertions(+) diff --git a/libavutil/frame.h b/libavutil/frame.h index 5b58c14ac3..

[FFmpeg-devel] [PATCH 2/2] doc/examples/transcode_aac: use av_calloc to allocate the array of input samples buffer pointers

2023-05-04 Thread James Almer
Signed-off-by: James Almer --- doc/examples/transcode_aac.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index 7f4ca382b1..eddb3b203d 100644 --- a/doc/examples/transcode_aac.c +++ b/doc/examples/transcode_

[FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: free the converted input samples buffer with av_free

2023-05-04 Thread James Almer
Fixes -Wuse-after-free warnings. Signed-off-by: James Almer --- doc/examples/transcode_aac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index bb5681a7c0..7f4ca382b1 100644 --- a/doc/examples/transcode_aac.c

[FFmpeg-devel] [PATCH v5 6/6] decklink_enc: add support for playout of 608 captions in MOV files

2023-05-04 Thread Devin Heitmueller
Unlike other cases where the closed captions are embedded in the video stream as MPEG-2 userdata or H.264 SEI data, with MOV files the captions are often found on a separate "e608" subtitle track. Add support for playout of such files, leveraging the new ccfifo mechanism to ensure that they are em

[FFmpeg-devel] [PATCH v5 5/6] vf_ccrepack: Add new filter to repack CEA-708 side data

2023-05-04 Thread Devin Heitmueller
THis filter can correct certain issues seen from upstream sources where the cc_count is not properly set or the CEA-608 tuples are not at the start of the payload as expected. Make use of the ccfifo to extract and immediately repack the CEA-708 side data, thereby removing any extra padding and ens

[FFmpeg-devel] [PATCH v5 4/6] tinterlace: Properly preserve CEA-708 closed captions

2023-05-04 Thread Devin Heitmueller
Because the interlacing filter halves the effective framerate, we need to ensure that no CEA-708 data is lost as frames are merged. Make use of the new ccfifo mechanism to ensure that caption data is properly preserved as frames pass through the filter. Thanks to Thomas Mundt for review and notic

[FFmpeg-devel] [PATCH v5 3/6] yadif: Properly preserve CEA-708 closed captions

2023-05-04 Thread Devin Heitmueller
Various deinterlacing modes have the effect of doubling the framerate, and we need to ensure that the caption data isn't duplicated (or else you get double captions on-screen). Use the new ccfifo mechanism for yadif (and yadif_cuda and bwdif since they use the same yadif core) so that CEA-708 data

[FFmpeg-devel] [PATCH v5 2/6] vf_fps: properly preserve CEA-708 captions

2023-05-04 Thread Devin Heitmueller
The existing implementation made an attempt to remove duplicate captions if increasing the framerate, but made no attempt to handle reducing the framerate, nor did it rewrite the caption payloads to have the appropriate cc_count (e.g. the cc_count needs to change from 20 to 10 when going from 1080i

[FFmpeg-devel] [PATCH v5 1/6] ccfifo: Properly handle CEA-708 captions through framerate conversion

2023-05-04 Thread Devin Heitmueller
When transcoding video that contains 708 closed captions, the caption data is tied to the frames as side data. Simply dropping or adding frames to change the framerate will result in loss of data, so the caption data needs to be preserved and reformatted. For example, without this patch convertin

[FFmpeg-devel] [PATCH v5 0/6] Add support for Closed Caption FIFO

2023-05-04 Thread Devin Heitmueller
This latest update to the patch series includes several fixes from Lance Wang to the vf_ccrepack, as well as incorporating feedback from Anton Khirnov. The primary change across all the filters was to make the filter error out if the ff_ccfifo_alloc() call failed. This is reasonable because as a

Re: [FFmpeg-devel] [PATCH 1/2] lavc/tak: make ff_tak_parse_streaminfo static

2023-05-04 Thread Paul B Mahol
approved ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] lavc/tak: do not store invalid values in stream info

2023-05-04 Thread Paul B Mahol
approved ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add vanitous self to maintain RISC-V

2023-05-04 Thread James Almer
On 5/3/2023 1:10 PM, Rémi Denis-Courmont wrote: --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 854ccc3fa4..f95be01dc6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -543,6 +543,7 @@ LoongArch Shiyou Yin Mac OS

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: always use the same path for setting InputStream.[next_]dts

2023-05-04 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-05-04 14:12:58) > On Tue, May 02, 2023 at 09:31:35AM +, Anton Khirnov wrote: > > ffmpeg | branch: master | Anton Khirnov | Wed Apr 26 > > 10:51:38 2023 +0200| [129c7bf53fbe2be4f5483ecf6fc036ff9caf05cf] | > > committer: Anton Khirnov > > > > fftools/ffmpeg:

[FFmpeg-devel] [PATCH 1/2] lavc/tak: make ff_tak_parse_streaminfo static

2023-05-04 Thread Anton Khirnov
It is not used outside of tak.c --- libavcodec/tak.c | 6 +++--- libavcodec/tak.h | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/tak.c b/libavcodec/tak.c index f26574c968..d1604dc9d2 100644 --- a/libavcodec/tak.c +++ b/libavcodec/tak.c @@ -92,7 +92,7 @@ int ff_ta

[FFmpeg-devel] [PATCH 2/2] lavc/tak: do not store invalid values in stream info

2023-05-04 Thread Anton Khirnov
When tak_get_nb_samples() fails, it will currently write AVERROR_INVALIDDATA as TAKStreamInfo.frame_samples. The parser will then use this negative value as a frame duration, which leads to various breakage. Avoid this by returning the error code from tak_parse_streaminfo() directly and never stor

[FFmpeg-devel] [PATCH] libavformat: simplify ffurl_open_whitelist() by using parent contexts

2023-05-04 Thread Michael Niedermayer
This also simplifies passing more things from parent contexts in the future It also avoids bugs as the calls are simpler. In that sense this change adds a missing interrupt callback to icecast Signed-off-by: Michael Niedermayer --- libavformat/avio.c | 18 ++ libavf

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: optimize image copy efficiency

2023-05-04 Thread ??????
Thank you for your review, Martin. I try add some data, and submit again. -- Original -- From: "FFmpeg development discussions and patches"

[FFmpeg-devel] [PATCH] avfilter/dnn_backend_openvino: fix log message

2023-05-04 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index b67f288336..051aea8bb9 100644 --- a/libavfilter/dnn/dn

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: always use the same path for setting InputStream.[next_]dts

2023-05-04 Thread Michael Niedermayer
On Tue, May 02, 2023 at 09:31:35AM +, Anton Khirnov wrote: > ffmpeg | branch: master | Anton Khirnov | Wed Apr 26 > 10:51:38 2023 +0200| [129c7bf53fbe2be4f5483ecf6fc036ff9caf05cf] | committer: > Anton Khirnov > > fftools/ffmpeg: always use the same path for setting InputStream.[next_]dts >

Re: [FFmpeg-devel] av_mallocz_array

2023-05-04 Thread Hendrik Leppkes
On Thu, May 4, 2023 at 11:06 AM Christophe GARNIER wrote: > > Hello, > > To build makemkv version 1.17.3 (makemkv-oss), I retreived he sources of > ffmpeg from the git repository (git clone > https://git.ffmpeg.org/ffmpeg.git ffmpeg).It appeared that the function > av_mallocz_array is not present

Re: [FFmpeg-devel] av_mallocz_array

2023-05-04 Thread Paul B Mahol
This is invalid. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] av_mallocz_array

2023-05-04 Thread Christophe GARNIER
Hello, To build makemkv version 1.17.3 (makemkv-oss), I retreived he sources of ffmpeg from the git repository (git clone https://git.ffmpeg.org/ffmpeg.git ffmpeg).It appeared that the function av_mallocz_array is not present into libavutil/mem.c and libavutil/mem.h. I had the following code

[FFmpeg-devel] [PATCH v1 6/6] swscale/la: Add following builtin optimized functions

2023-05-04 Thread Hao Chen
From: Jin Bo yuv420_rgb24_lsx yuv420_bgr24_lsx yuv420_rgba32_lsx yuv420_argb32_lsx yuv420_bgra32_lsx yuv420_abgr32_lsx ./configure --disable-lasx ffmpeg -i ~/media/1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -pix_fmt rgb24 -y /dev/null -an before: 184fps after: 207fps --- libswscale/loongarch/Make

[FFmpeg-devel] [PATCH v1 3/6] avcodec/la: Add LSX optimization for h264 chroma and intrapred.

2023-05-04 Thread Hao Chen
From: Lu Wang ./configure --disable-lasx ffmpeg -i 1_h264_1080p_30fps_3Mbps.mp4 -f rawvideo -y /dev/null -an before: 199fps after: 214fps --- libavcodec/loongarch/Makefile |4 +- .../loongarch/h264_intrapred_init_loongarch.c | 18 +- libavcodec/loongarch/h264_intrapred_las

[FFmpeg-devel] Add LSX optimization in avcodec and swscale.

2023-05-04 Thread Hao Chen
v1: Add LSX optimization in avcodec and swscale, due to the 2K series CPUs only support lsx. [PATCH v1 1/6] avcodec/la: add LSX optimization for h264 idct. [PATCH v1 2/6] avcodec/la: Add LSX optimization for loop filter. [PATCH v1 3/6] avcodec/la: Add LSX optimization for h264 chroma and [PATCH v1

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: new optimization for 8-bit hevc_pel_uni_w_pixels, qpel_uni_w_h, qpel_uni_w_v, qpel_uni_w_hv and qpel_h

2023-05-04 Thread Martin Storsjö
On Wed, 3 May 2023, myais wrote: Hello, - I splited this patch, Do I need to resubmit or just attach them as attachments? (I attached those patches.  If I need to resummit, please let me know.) The attached form here is fine with me. I didn't review it in detail yet, but I think it roughly

[FFmpeg-devel] [PATCH v1 1/6] avcodec/la: add LSX optimization for h264 idct.

2023-05-04 Thread Hao Chen
From: Shiyou Yin loongson_asm.S is LoongArch asm optimization helper. ./configure --disable-lasx Add functions: ff_h264_idct_add_8_lsx ff_h264_idct8_add_8_lsx ff_h264_idct_dc_add_8_lsx ff_h264_idct8_dc_add_8_lsx ff_h264_luma_dc_dequant_idct_8_lsx Replaced function(LSX is enough for thes

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: optimize image copy efficiency

2023-05-04 Thread Martin Storsjö
On Thu, 4 May 2023, xufuji456 wrote: It makes sense when copying 4K/8K video, if linesize equals to aligned linesize. Signed-off-by: xufuji456 <839789...@qq.com> --- libavutil/imgutils.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavutil/imgutils.c b/l

[FFmpeg-devel] [PATCH] avutil/imgutils: optimize image copy efficiency

2023-05-04 Thread xufuji456
It makes sense when copying 4K/8K video, if linesize equals to aligned linesize. Signed-off-by: xufuji456 <839789...@qq.com> --- libavutil/imgutils.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c index 9ab5757cf6..

Re: [FFmpeg-devel] [Internet]Re: [PATCH] avcodec/options_table: reorder nokey after nointra

2023-05-04 Thread zhilizhao(赵志立)
> On Apr 26, 2023, at 15:41, Steven Liu wrote: > > Zhao Zhili 于2023年4月26日周三 10:49写道: >> >> From: Zhao Zhili >> >> So the values are in ascending order. >> >> Signed-off-by: Zhao Zhili >> --- >> libavcodec/options_table.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff -

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/avcodec: fix UB NULL+0

2023-05-04 Thread zhilizhao(赵志立)
> On Apr 26, 2023, at 20:49, zhilizhao(赵志立) wrote: > >> On Apr 12, 2023, at 01:49, Zhao Zhili wrote: >> >> From: Zhao Zhili >> >> --- >> libavcodec/avcodec.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c >> index