Re: [FFmpeg-devel] [PATCH v5] avformat/hls: Add option to retry failed segments for hls

2023-02-07 Thread Gyan Doshi
On 2022-10-21 02:49 pm, Steven Liu wrote: gnattu 于2022年10月20日周四 20:12写道: Current HLS implementation simply skip a failed segment to catch up the stream, but this is not optimal for some use cases like livestream recording. Add an option to retry a failed segment to ensure the output file is a

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/af_pan: fix regression introduced with switch to new channel layout API

2023-02-07 Thread Martin Storsjö
On Tue, 7 Feb 2023, Paul B Mahol wrote: ffmpeg | branch: master | Paul B Mahol | Sat Feb 4 21:46:15 2023 +0100| [93a9ee7afd7bf2e019490117f1bada30724a0200] | committer: Paul B Mahol avfilter/af_pan: fix regression introduced with switch to new channel layout API Fixes #10168 http://git.vid

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_metadata_bsf: remove AUDs at any position

2023-02-07 Thread Gyan Doshi
On 2023-02-04 03:36 pm, Gyan Doshi wrote: Some files, likely due to faulty packetization or muxing, can have AUDs at other positions besides the head unit of a packet. Remove these too. Plan to push in 24h if no more comments. --- libavcodec/h264_metadata_bsf.c | 13 +++-- 1 file

[FFmpeg-devel] [PATCH 2/2] lavc/qsvenc_{h264, hevc}: import user data unregistered SEIs if available

2023-02-07 Thread Xiang, Haihao
From: Haihao Xiang option udu_sei is added, user should set udu_sei to true|on|1 if user data unregistered SEI is expected. Verify user data unregistered SEI with commands below: $ ffmpeg -y -f lavfi -i testsrc -vf "format=nv12" -c:v libx264 -frames:v 1 a.h264 $ ffmpeg -y -init_hw_device qsv -i

[FFmpeg-devel] [PATCH 1/2] lavc/qsvenc: enlarge the maximum number of mfxPayload on mfxEncodeCtrl

2023-02-07 Thread Xiang, Haihao
From: Haihao Xiang The next commit and other commits in future may support more mfxPayload for encoding Signed-off-by: Haihao Xiang --- libavcodec/qsv_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsv_internal.h b/libavcodec/qsv_internal.h index 5119

[FFmpeg-devel] [PATCH] add skip_loop_filter flag to decide whether loop-filter

2023-02-07 Thread xufuji456
--- libavcodec/vp9.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 7c0a246446..ebb89a413c 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -1371,7 +1371,7 @@ static int decode_tiles(AVCodecContext *avctx, }

Re: [FFmpeg-devel] Hardware purchase request Apple M2

2023-02-07 Thread Martin Storsjö
Hi Devin, Thilo, On Tue, 7 Feb 2023, Thilo Borgmann wrote: Am 07.02.23 um 21:19 schrieb Devin Heitmueller: On Mon, Feb 6, 2023 at 6:24 AM Thilo Borgmann wrote: Martin pointed out we don't need an M2 for FATE as the instruction sets are equal on both machines. It may be worth noting that wh

[FFmpeg-devel] [PATCH] avformat/movenc: allow writing out channel count in MP4 and 3GP

2023-02-07 Thread Jan Ekström
ISOBMFF (14496-12) made this field ('channelcount') in the AudioSampleEntry structure non-template¹ somewhere before the release of the 2022 edition. As for ETSI TS 126 244 AKA 3GPP file format (V16.1.0, 2020-10), it does not seem contain any references limiting the channelcount entry in AudioSampl

Re: [FFmpeg-devel] Hardware purchase request Apple M2

2023-02-07 Thread Thilo Borgmann
Am 07.02.23 um 21:19 schrieb Devin Heitmueller: On Mon, Feb 6, 2023 at 6:24 AM Thilo Borgmann wrote: Martin pointed out we don't need an M2 for FATE as the instruction sets are equal on both machines. It may be worth noting that while the M1 and M2 have the same instruction set, there is no

Re: [FFmpeg-devel] Hardware purchase request Apple M2

2023-02-07 Thread Devin Heitmueller
On Mon, Feb 6, 2023 at 6:24 AM Thilo Borgmann wrote: > Martin pointed out we don't need an M2 for FATE as the instruction sets are > equal on both machines. It may be worth noting that while the M1 and M2 have the same instruction set, there is no guarantee the video processing blocks are identi

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec/pngenc: avoid writing cICP when inappropriate

2023-02-07 Thread Leo Izen
On 2/2/23 10:09, Leo Izen wrote: We parse the fallback cHRM on decode and correctly determine that we have BT.709 primaries, but unknown TRC. This causes us to write cICP where we shouldn't. Primaries without transfer can be handled entirely by cHRM, so we should only write cICP if we actually kn

Re: [FFmpeg-devel] [PATCH] avfilter: use ff_inlink_make_frame_writable()

2023-02-07 Thread Paul B Mahol
On 2/6/23, Paul B Mahol wrote: > Patch attached. > Better patch attached. From 15f004ccb196e39c6c429e2c93041444c1a1e419 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Mon, 6 Feb 2023 14:57:50 +0100 Subject: [PATCH] avfilter: use ff_inlink_make_frame_writable() Signed-off-by: Paul B Mahol --

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: add an option for writing pre-muxing stats

2023-02-07 Thread Tim Harris
> > Am 07.02.23 um 10:41 schrieb Anton Khirnov: > > Also, I'm wondering if we shouldn't rename the options to > > -stats_{mux,enc_pre,enc_post}[_fmt] for consistency. > > They were added just recently, so it should be fine if done before the > > release. > > > > Opinions? > > I'd like that. Can't

Re: [FFmpeg-devel] [PATCH] avfilter: fix af_pan regression

2023-02-07 Thread Paul B Mahol
On 2/5/23, Paul B Mahol wrote: > On 2/5/23, Michael Niedermayer wrote: >> On Sat, Feb 04, 2023 at 09:48:38PM +0100, Paul B Mahol wrote: >>> Patch attached. >> >>> af_pan.c |3 +++ >>> 1 file changed, 3 insertions(+) >>> bf878b3bd193e6462d1babf5e6e45a056a3a0f65 >>> 0001-avfilter-af_pan-fix-re

[FFmpeg-devel] [PATCH 4/4] avformat/tee: relay programs to child muxers

2023-02-07 Thread Gyan Doshi
--- libavformat/tee.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/tee.c b/libavformat/tee.c index dd408dd096..fd1b17ce7c 100644 --- a/libavformat/tee.c +++ b/libavformat/tee.c @@ -291,6 +291,12 @@ static int open_slave(AVFormatContext *avf, char *slave, TeeSlave *tee_sla

[FFmpeg-devel] [PATCH 3/4] avformat/segment: relay programs to child muxers

2023-02-07 Thread Gyan Doshi
--- libavformat/segment.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 80e4bf851c..a5acc28dfd 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -182,6 +182,12 @@ static int segment_mux_init(AVFormatContext *s)

[FFmpeg-devel] [PATCH 2/4] avformat/hls: relay programs to child muxers

2023-02-07 Thread Gyan Doshi
--- libavformat/hlsenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 39df9becc7..bfad1eef90 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -907,6 +907,12 @@ static int hls_mux_init(AVFormatContext *s, VariantStream *

[FFmpeg-devel] [PATCH 1/4] avformat: add av_program_copy()

2023-02-07 Thread Gyan Doshi
Needed to transfer programs in parent muxing contexts to child muxers, like in hls, segment, tee muxers. --- doc/APIchanges | 3 +++ libavformat/avformat.c | 52 ++ libavformat/avformat.h | 2 ++ libavformat/version.h | 2 +- 4 files changed, 58

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: add an option for writing pre-muxing stats

2023-02-07 Thread Thilo Borgmann
Am 07.02.23 um 10:41 schrieb Anton Khirnov: Also, I'm wondering if we shouldn't rename the options to -stats_{mux,enc_pre,enc_post}[_fmt] for consistency. They were added just recently, so it should be fine if done before the release. Opinions? I'd like that. Can't comment on the code itself

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: add an option for writing pre-muxing stats

2023-02-07 Thread Anton Khirnov
Also, I'm wondering if we shouldn't rename the options to -stats_{mux,enc_pre,enc_post}[_fmt] for consistency. They were added just recently, so it should be fine if done before the release. Opinions? -- Anton Khirnov ___ ffmpeg-devel mailing list ffm

[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg: add an option for writing pre-muxing stats

2023-02-07 Thread Anton Khirnov
Analogous to -enc_stats*, but happens right before muxing. Useful because bitstream filters and the sync queue can modify packets after encoding and before muxing. Also has access to the muxing timebase. --- Changelog | 3 ++- doc/ffmpeg.texi | 13 + fftools/

[FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: store output packet timebases in the packet

2023-02-07 Thread Anton Khirnov
Useful to keep track of what timebase the packet's timestamps are in. --- fftools/ffmpeg.c | 33 - fftools/ffmpeg_mux.c | 7 --- 2 files changed, 24 insertions(+), 16 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 743bc0c6b6..32e0c3feb

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/flvenc: add option to read metadata from file

2023-02-07 Thread Gyan Doshi
On 2023-02-05 04:35 pm, Gyan Doshi wrote: On 2023-02-05 04:07 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-02-04 11:11:12) On 2023-02-03 09:04 pm, Andreas Rheinhardt wrote: What does this achieve that can't be achieved by other means (namely by an API-user updating the relevant meta

Re: [FFmpeg-devel] [PATCH] ffmpeg_mux: terminate stream thread queue only on sq_send EOF

2023-02-07 Thread Gyan Doshi
On 2023-02-07 02:03 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-02-07 09:18:22) On 2023-02-07 01:39 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-02-04 11:01:21) Prior to 2d924b3a630, ffmpeg would exit if any packet write failed. After the switch to threaded mode for muxing, ffmp

Re: [FFmpeg-devel] [PATCH] ffmpeg_mux: terminate stream thread queue only on sq_send EOF

2023-02-07 Thread Anton Khirnov
Quoting Gyan Doshi (2023-02-07 09:18:22) > > > On 2023-02-07 01:39 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2023-02-04 11:01:21) > >> Prior to 2d924b3a630, ffmpeg would exit if any packet write failed. > >> After the switch to threaded mode for muxing, ffmpeg only closes that > >> OutputS

Re: [FFmpeg-devel] [PATCH] ffmpeg_mux: terminate stream thread queue only on sq_send EOF

2023-02-07 Thread Gyan Doshi
On 2023-02-07 01:39 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-02-04 11:01:21) Prior to 2d924b3a630, ffmpeg would exit if any packet write failed. After the switch to threaded mode for muxing, ffmpeg only closes that OutputStream instead of closng the file. This happens because EOF ret

Re: [FFmpeg-devel] [PATCH] ffmpeg_mux: terminate stream thread queue only on sq_send EOF

2023-02-07 Thread Anton Khirnov
Quoting Gyan Doshi (2023-02-04 11:01:21) > Prior to 2d924b3a630, ffmpeg would exit if any packet write failed. > After the switch to threaded mode for muxing, ffmpeg only closes that > OutputStream instead of closng the file. This happens because EOF > returned by write_packet isn't distinguished f

[FFmpeg-devel] [PATCH] configure: make flite depend on threads

2023-02-07 Thread Anton Khirnov
The filter calls pthreads functions unconditionally. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index d67855c729..12184c7f26 100755 --- a/configure +++ b/configure @@ -3667,7 +3667,7 @@ eq_filter_deps="gpl" erosion_opencl_filter_deps="o