Re: [FFmpeg-devel] [PATCH 2/2] lavfi/dnn: Remove DNN native backend

2023-01-01 Thread Michael Niedermayer
On Fri, Dec 30, 2022 at 04:42:56PM +0800, Ting Fu wrote: > According to discussion in > https://etherpad.mit.edu/p/FF_dev_meeting_20221202. > The DNN native backend should be removed at first step. > All the DNN native backend related code is deleted. > > Signed-off-by: Ting Fu This patch seems

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/dnn: Remove DNN native backend

2023-01-01 Thread Jean-Baptiste Kempf
On Fri, 30 Dec 2022, at 09:42, Ting Fu wrote: > According to discussion in > https://etherpad.mit.edu/p/FF_dev_meeting_20221202. > The DNN native backend should be removed at first step. > All the DNN native backend related code is deleted. > > Signed-off-by: Ting Fu LGTM. -- Jean-Baptiste Kemp

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/dnn: Modify error message for incorrect backend_type

2023-01-01 Thread Jean-Baptiste Kempf
LGTM. On Fri, 30 Dec 2022, at 09:42, Ting Fu wrote: > Signed-off-by: Ting Fu > --- > libavfilter/dnn/dnn_interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/dnn/dnn_interface.c > b/libavfilter/dnn/dnn_interface.c > index 554a36b0dc..fa484c0905 100644

Re: [FFmpeg-devel] [PATCH] avformat: Add support for embedding cover art in Ogg files

2023-01-01 Thread Jean-Baptiste Kempf
On Thu, 29 Dec 2022, at 22:05, Zsolt Vadász wrote: > It's done similarly to how the flac muxer does it, so I reused most of > the code and adapted it. Would a common function make sense here? -- Jean-Baptiste Kempf - President +33 672 704 734 ___ ffm