Re: [FFmpeg-devel] [PATCH] avformat/segment: add option min_seg_duration

Plan to push tomorrow. On 2022-12-25 11:54 pm, Gyan Doshi wrote: On 2022-12-21 09:08 pm, Gyan Doshi wrote: New option can be used to avoid creating very short segments with inputs whose GOP size is variable or unharmonic with segment_time. Only effective with segment_time. Comments? ---  

[FFmpeg-devel] 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

>ffmpeg -h >segfaults with this patch My environment test is OK. Details are as follows: SZV1000266228:/usr1/wujian/build # ffmpeg -h ffmpeg version N-109445-gcc46f5b Copyright (c) 2000-2022 the FFmpeg developers built with gcc 7 (GCC) configuration: --samples=/usr1/wujian/ffmpeg_master/fate-s

[FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: check number of index table entires more strictly

Let's ignore the index table if the number of index entries does not match the index duration (or the special AVID index entry counts). Fixes: OOM Fixes: 50551/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-6607795234930688 Found-by: continuous fuzzing process https://github.com/google/os

[FFmpeg-devel] [PATCH 2/3] avformat/mxfdec: support Avid files with an extra index entry

Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index ad4ee15570..2e61e77d67 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1991,11 +1991,11 @@ static int

[FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: check index entry array size

Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e6118e141d..ad4ee15570 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1198,11 +1198,15 @@ static int m

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

On Tue, 27 Dec 2022, Marton Balint wrote: On Tue, 27 Dec 2022, Michael Niedermayer wrote: On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote: On Mon, 26 Dec 2022, Michael Niedermayer wrote: On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote: lör 2022-12-24 kl

Re: [FFmpeg-devel] Rework color quantization in palette{gen,use}

On Tue, Nov 08, 2022 at 10:37:59PM +, Soft Works wrote: [...] > For completeness, I'm also including the recent comparison, but it > seems you're already on track in this regard. If you remove the alpha from the input image you'll see that it performs pretty much as good. You can check with t

Re: [FFmpeg-devel] [PATCH 12/15] avfilter/palettegen: base split decision on a perceptual model

On Sat, Nov 05, 2022 at 08:07:42PM +0100, Andreas Rheinhardt wrote: [...] > You are adding floating point to places where there was no floating > point before (some other patches of this patchset do the same). Is this > still bitexact across all supported arches? It should be good with the last it

[FFmpeg-devel] [PATCH v2 08/32] avfilter/paletteuse: remove redundant alpha condition

This is redundant with a != 0xff below. --- libavfilter/vf_paletteuse.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index 8954a02524..0861a70a0b 100644 --- a/libavfilter/vf_paletteuse.c +++ b/libavfilter/vf_pal

[FFmpeg-devel] [PATCH v2 32/32] avfilter/palette{gen, use}: misc for-loop cosmetics

--- libavfilter/vf_palettegen.c | 19 +-- libavfilter/vf_paletteuse.c | 22 +- 2 files changed, 18 insertions(+), 23 deletions(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index 97e12f7274..4b69d3c63b 100644 --- a/libavfilter/vf_pal

[FFmpeg-devel] [PATCH v2 31/32] avfilter/paletteuse: move r, g, b computation in a more local scope

--- libavfilter/vf_paletteuse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index 33b8e70293..e3462b4abb 100644 --- a/libavfilter/vf_paletteuse.c +++ b/libavfilter/vf_paletteuse.c @@ -262,9 +262,6 @@ static av_

[FFmpeg-devel] [PATCH v2 07/32] avfilter/paletteuse: remove unused alpha split dimension

The equalities in the w{r,g,b} range checks make sure longest is never 0. Even if the alpha ended up being selected in get_next_color() it would cause underread memory accesses in its caller (colormap_insert). --- libavfilter/vf_paletteuse.c | 33 - 1 file changed,

[FFmpeg-devel] [PATCH v2 30/32] avfilter/paletteuse: remove mean error tool

This belongs in another filter. --- libavfilter/vf_paletteuse.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index 690422a842..33b8e70293 100644 --- a/libavfilter/vf_paletteuse.c +++ b/libavfilter/vf_p

[FFmpeg-devel] [PATCH v2 06/32] avfilter/paletteuse: name target color arg consistently in colormap functions

--- libavfilter/vf_paletteuse.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index fb4016b11c..f43f077454 100644 --- a/libavfilter/vf_paletteuse.c +++ b/libavfilter/vf_paletteuse.c @@ -180,7 +180,7 @@ static a

[FFmpeg-devel] [PATCH v2 29/32] avfilter/paletteuse: remove alternative search methods

This is a maintenance pain more than anything. It appears to make the code slightly faster as a side effect. --- libavfilter/vf_paletteuse.c | 220 +--- 1 file changed, 31 insertions(+), 189 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_pal

[FFmpeg-devel] [PATCH v2 28/32] avfilter/paletteuse: switch to recursive method

It appears faster than the iterative method on my machine (1.06x faster), so I'm guessing compilers improved over time (the iterative version was slightly faster in the past). --- libavfilter/vf_paletteuse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_palette

[FFmpeg-devel] [PATCH v2 27/32] avfilter/paletteuse: use lowbias32 for color hashing

Impact is more negligible than previous commit but still faster (1.02x). --- libavfilter/vf_paletteuse.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index c32b73ab9a..c2d6333662 100644 --- a/libavfilter/vf_pa

[FFmpeg-devel] [PATCH v2 26/32] avfilter/palettegen: use lowbias32 for color hashing

1.12x faster overall in palettegen on my machine. --- libavfilter/vf_palettegen.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index 6301cf6358..97e12f7274 100644 --- a/libavfilter/vf_palettegen.c

[FFmpeg-devel] [PATCH v2 25/32] avfilter/palette: add lowbias32 hashing

--- libavfilter/palette.c | 10 ++ libavfilter/palette.h | 5 + 2 files changed, 15 insertions(+) diff --git a/libavfilter/palette.c b/libavfilter/palette.c index 03e48fc71e..e21ab6ff4d 100644 --- a/libavfilter/palette.c +++ b/libavfilter/palette.c @@ -208,3 +208,13 @@ uint32_t ff_ok

[FFmpeg-devel] [PATCH v2 24/32] avfilter/palette{gen, use}: update Copyright after recent changes

--- libavfilter/vf_palettegen.c | 1 + libavfilter/vf_paletteuse.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index 507690fa82..6301cf6358 100644 --- a/libavfilter/vf_palettegen.c +++ b/libavfilter/vf_palettegen.c @@ -1,5 +1,6 @@

[FFmpeg-devel] [PATCH v2 23/32] avfilter/palettegen: use libc qsort

Now that the sort function is deterministic, we can rely on the libc sorting function. --- libavfilter/vf_palettegen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index 784e81b875..507690fa82 100644 --- a/libavfilt

[FFmpeg-devel] [PATCH v2 22/32] avfilter/palettegen: make refs order deterministic

Currently, in case of equality on the first color channel, the order of the ref colors is defined by the hashing function. This commit makes the sorting deterministic and improve the hierarchical ordering. --- libavfilter/vf_palettegen.c| 61 ++ tests/ref/fate/f

[FFmpeg-devel] [PATCH v2 21/32] avfilter/palettegen: add a warning about supporting only sRGB

--- libavfilter/vf_palettegen.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index 3178c43ab9..ba81739d27 100644 --- a/libavfilter/vf_palettegen.c +++ b/libavfilter/vf_palettegen.c @@ -451,9 +451,13 @@ static

[FFmpeg-devel] [PATCH v2 20/32] avfilter/palettegen: base box split decision on a perceptual model

Similar to the change in paletteuse, we rely on a perceptual model to decide how and where to split the box. --- libavfilter/Makefile | 2 +- libavfilter/vf_palettegen.c| 48 -- tests/ref/fate/filter-palettegen-1 | 2 +- tests/ref/fate/filter-pal

[FFmpeg-devel] [PATCH v2 19/32] avfilter/palettegen: switch to signed arithmetic

This prevents mixed sign arithmetic (typically because we have signed color channel differences), which has nasty side effects in C. --- libavfilter/vf_palettegen.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c

[FFmpeg-devel] [PATCH v2 18/32] avfilter/palettegen: rename local variable box_weight to weight

This variable is used only for the running weight (used to reach the target median). The places where we actually need the box weight are changed to use box->weight. --- libavfilter/vf_palettegen.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_

[FFmpeg-devel] [PATCH v2 17/32] avfilter/palettegen: misc cosmetics

--- libavfilter/vf_palettegen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index 36f0a976d9..ad21882df3 100644 --- a/libavfilter/vf_palettegen.c +++ b/libavfilter/vf_palettegen.c @@ -132,7 +132,7 @@ static int c

[FFmpeg-devel] [PATCH v2 16/32] avfilter/palettegen: compute average color within compute_box_stats()

--- libavfilter/vf_palettegen.c | 30 +- 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index 00b5f88c49..36f0a976d9 100644 --- a/libavfilter/vf_palettegen.c +++ b/libavfilter/vf_palettegen.c @@ -1

[FFmpeg-devel] [PATCH v2 15/32] avfilter/palettegen: change cut score from ∑e² to max e²

This is following the results from personal research¹. ¹: https://github.com/ubitux/research/tree/main/color-quantization#results --- libavfilter/vf_palettegen.c| 3 ++- tests/ref/fate/filter-palettegen-1 | 2 +- tests/ref/fate/filter-palettegen-2 | 2 +- 3 files changed, 4 insertions(+),

[FFmpeg-devel] [PATCH v2 14/32] avfilter/palettegen: rename variance to cut_score

"Variance" wasn't exactly the correct word; "cut score" is more agnostic, which will be useful when changing the algorithm in the next commit. --- libavfilter/vf_palettegen.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/

[FFmpeg-devel] [PATCH v2 13/32] avfilter/palettegen: always compute the box variance

The variance computation is simple enough now (since we can use the axis squared errors) that it doesn't need to have a complex lazy computation logic. --- libavfilter/vf_palettegen.c | 42 - 1 file changed, 9 insertions(+), 33 deletions(-) diff --git a/libavfi

[FFmpeg-devel] [PATCH v2 12/32] avfilter/palettegen: use box->major_axis without intermediate variable

--- libavfilter/vf_palettegen.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index ed1448755c..aa0c8fdc5b 100644 --- a/libavfilter/vf_palettegen.c +++ b/libavfilter/vf_palettegen.c @@ -363,22 +363,21 @@

[FFmpeg-devel] [PATCH v2 11/32] avfilter/palettegen: define the best axis to cut using the squared error

This is following the results from personal research¹. ¹: https://github.com/ubitux/research/tree/main/color-quantization#results --- libavfilter/vf_palettegen.c| 42 ++ tests/ref/fate/filter-palettegen-1 | 2 +- tests/ref/fate/filter-palettegen-2 | 2 +- 3 f

[FFmpeg-devel] [PATCH v2 10/32] avfilter/palettegen: move box stats computation to a dedicated function

--- libavfilter/vf_palettegen.c | 64 ++--- 1 file changed, 38 insertions(+), 26 deletions(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index bea3292796..a047c75599 100644 --- a/libavfilter/vf_palettegen.c +++ b/libavfilter/vf_palettege

[FFmpeg-devel] [PATCH v2 09/32] avfilter/paletteuse: switch to a perceptual model

Now the selection of the color is based on a distance built around human perception of color instead of the unreliable sRGB triplet one. --- libavfilter/Makefile| 2 +- libavfilter/vf_paletteuse.c | 181 ++-- tests/ref/fate/filter-paletteus

[FFmpeg-devel] [PATCH v2 05/32] avfilter/paletteuse: switch from u8[4] to u32 for color code

This change simplifies the code quite a bit and make it consistent with how it's done in palettegen. --- libavfilter/vf_paletteuse.c | 98 - 1 file changed, 41 insertions(+), 57 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c

[FFmpeg-devel] [PATCH v2 04/32] avfilter/palette{gen, use}: add palette utils

These color management helpers will be shared by palettegen and paletteuse in the following commits. Note that it probably makes sense to share at least the sRGB/linear functions with other filters at some point. More information on OkLab can be found here: https://bottosson.github.io/posts/okla

[FFmpeg-devel] [PATCH v2 03/32] avfilter/palette{gen, use}: simplify a few alpha masks

--- libavfilter/vf_paletteuse.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index cb18329bb7..f9d8a1cdfc 100644 --- a/libavfilter/vf_paletteuse.c +++ b/libavfilter/vf_paletteuse.c @@ -156,7 +156,7 @@ s

[FFmpeg-devel] [PATCH v2 02/32] avfilter/palette{gen, use}: revert support palettes with alpha

This reverts commit dea673d0d548c864ec85f9260d8900d944ef7a2a. This change cannot work for several reasons, the most obvious ones are: - the alpha is being part of the scoring of the color difference, even though we can not interpret the alpha as part of the perception of the color (we don't e

[FFmpeg-devel] [PATCH v2 01/32] avfilter/palettegen: allow a minimum of 2 colors

--- libavfilter/vf_palettegen.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index 27f74fd147..c03f62b942 100644 --- a/libavfilter/vf_palettegen.c +++ b/libavfilter/vf_palettegen.c @@ -82,7 +82,7 @@ typedef stru

[FFmpeg-devel] New iteration for the color quantization in palette{gen, use}

Here is a new version of the palette filters patchset. A lot changed since last iteration. Here are a few highlights: - The previous version had a terrible typo in the transfer function, this is now fixed - There is now a warning when the frames are not using sRGB transfer function (I'm assumi

[FFmpeg-devel] [PATCH 3/3] avcodec/flacenc: Don't reload bits_per_raw_sample

This has the advantage of allowing the compiler to check bits_per_raw_sample only once on little-endian hardware. Signed-off-by: Andreas Rheinhardt --- libavcodec/flacenc.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c

[FFmpeg-devel] [PATCH 2/3] avcodec/flacenc: Don't copy buffer if avoidable

It is avoidable for 32-bit FLAC on little endian hardware. Signed-off-by: Andreas Rheinhardt --- libavcodec/flacenc.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/libavcodec/flacenc.c b/libavcodec/flacenc.c index bf5d12facb..adaaa77b79 100644 --- a/li

Re: [FFmpeg-devel] Would a crypto file be acceptable?

On Tue, Dec 27, 2022 at 10:40 PM Michael Niedermayer wrote: > On Wed, Dec 21, 2022 at 04:44:59PM +0100, Mark Gaiser wrote: > > Hi, > > > > The ffmpeg crypto protocol handler [1] allows one to play encrypted > media. > > > > The great thing here is that it allows playback of any media format that

[FFmpeg-devel] [PATCH 1/3] avcodec/bswapdsp: Don't presume src to be naturally aligned

src typically comes from AVPackets and AVPacket.data has no alignment requirement. This means that the casts to uint32_t* might be undefined behaviour (they are if the pointer is no suitably aligned) and that the C versions of the conversion functions presume too much alignment; I don't know whethe

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

tis 2022-12-27 klockan 22:49 +0100 skrev Michael Niedermayer: > On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote: > > > > > > On Mon, 26 Dec 2022, Michael Niedermayer wrote: > > > > > On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote: > > > > lör 2022-12-24 klockan 23:50

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

On Tue, 27 Dec 2022, Michael Niedermayer wrote: On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote: On Mon, 26 Dec 2022, Michael Niedermayer wrote: On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote: lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer:    

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

On Tue, Dec 27, 2022 at 07:05:44PM +0100, Marton Balint wrote: > > > On Mon, 26 Dec 2022, Michael Niedermayer wrote: > > > On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote: > > > lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer: > > > > > > > > index_table->nb_p

[FFmpeg-devel] [PATCH] avformat/segment: Add strftime list prefix formatting

In the segment muxer, when `strftime` is enabled, apply formatting to the `segment_list_entry_prefix` string if it's set. ``` ffmpeg -i in.mkv -codec copy -map 0 -f segment \ -segment_list out.csv -segment_list_entry_prefix %Y/ \ -strftime 1 "/var/www/html/%Y/%Y%m%d%H%M%S.ts" ``` Will pro

Re: [FFmpeg-devel] Would a crypto file be acceptable?

On Wed, Dec 21, 2022 at 04:44:59PM +0100, Mark Gaiser wrote: > Hi, > > The ffmpeg crypto protocol handler [1] allows one to play encrypted media. > > The great thing here is that it allows playback of any media format that > ffmpeg supports! > Have a container format like mkv as an encrypted blob

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

On Mon, Dec 26, 2022 at 01:07:51PM +, Wujian(Chin) wrote: > The issue has been modified. Please review again, thank you! > > Signed-off-by: wujian_nanjing > --- > doc/fftools-common-opts.texi | 11 +++ > fftools/cmdutils.c | 77 > ++-- >

Re: [FFmpeg-devel] Would a crypto file be acceptable?

On Mon, Dec 26, 2022 at 12:18 PM Tomas Härdin wrote: > mån 2022-12-26 klockan 12:00 +0100 skrev Nicolas George: > > Tomas Härdin (12022-12-26): > > > That we want to avoid having keys in the command line is not > > > unreasonable. A -keyfile argument for crypto: might be appropriate. > > > > You

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Check index_duration

On Mon, 26 Dec 2022, Michael Niedermayer wrote: On Mon, Dec 26, 2022 at 11:32:48AM +0100, Tomas Härdin wrote: lör 2022-12-24 klockan 23:50 +0100 skrev Michael Niedermayer: index_table->nb_ptses += s->index_duration; +    // If index_duration is substantially larger than nb_inde

Re: [FFmpeg-devel] [PATCH v2] avformat/segment: add -strftime_mkdir option

I have been using this patch and it has been working great. Surprised that this functionality isn't already in the muxer. Steven Viola ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegbdec: return the amount of bytes consumed when discarding frames

On 12/26/2022 8:33 AM, James Almer wrote: EAGAIN is not correct in this scenario. FFCodec.cb.decode() callback decoders always return the amount of bytes consumed from the input packet (if any), and report if a frame was generated by setting got_frame. Signed-off-by: James Almer --- libavcode

Re: [FFmpeg-devel] [PATCH] avcodec/pnm: avoid mirroring PFM images vertically

On 12/27/2022 10:38 AM, Leo Izen wrote: On 12/14/22 15:13, Leo Izen wrote: On 11/29/22 06:14, Anton Khirnov wrote: Quoting Leo Izen (2022-11-16 12:43:06) PFM (aka Portable FloatMap) encodes its scanlines from bottom-to-top, not from top-to-bottom, unlike other NetPBM formats. Without this patc

Re: [FFmpeg-devel] [PATCH] avcodec/pnm: avoid mirroring PFM images vertically

On 12/14/22 15:13, Leo Izen wrote: On 11/29/22 06:14, Anton Khirnov wrote: Quoting Leo Izen (2022-11-16 12:43:06) PFM (aka Portable FloatMap) encodes its scanlines from bottom-to-top, not from top-to-bottom, unlike other NetPBM formats. Without this patch, FFmpeg ignores this exception and deco

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

You could just call ff_filter_process_command() instead of hardcoding supported commands here. It will ignore any option without the AV_OPT_FLAG_RUNTIME_PARAM flag. This is going to generate memleaks, and needlessly reallocate unrelated buffers. You should instead av_realloc all four s->bb

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

Resend whithout line wrap. Signed-off-by: Ashyni --- doc/filters.texi | 13 + libavfilter/vf_cropdetect.c| 42 +-- tests/ref/fate/filter-metadata-cropdetect | 60 +++--- tests/ref/fate/filter-metadata-cropdetect1 | 14 ++

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

On 12/27/2022 8:46 AM, Jeffrey CHAPUIS wrote: Hello, first attempt to contribute. Related to https://trac.ffmpeg.org/ticket/9851. Tested with ffmpeg and mpv, amazing results. Signed-off-by: Ashyni ---  doc/filters.texi   | 13 +  libavfilter/vf_cropdetect.c   

[FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

Hello, first attempt to contribute. Related to https://trac.ffmpeg.org/ticket/9851. Tested with ffmpeg and mpv, amazing results. Signed-off-by: Ashyni --- doc/filters.texi | 13 + libavfilter/vf_cropdetect.c| 42 +-- tests/ref/fate/fil

Re: [FFmpeg-devel] [PATCH v1] fate/jpeg2000: add JPEG 2000 tests using ITU/ISO conformance materials

mån 2022-12-26 klockan 12:22 -0800 skrev p...@sandflow.com: > From: Pierre-Anthony Lemieux > > Adds JPEG 2000 decoder tests using materials from the conformance > suite specified in > Rec. ITU-T T.803 | ISO/IEC 15444-4. The jpeg2000dec-ds0_ht_01_b11 > test assumes that > patchset > https://patch